| 03:04.00 | *** join/#asterisk-bugs lmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 03:04.00 | *** mode/#asterisk-bugs [+o lmadsen] by ChanServ |
| 05:29.38 | *** part/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 05:49.07 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 08:23.20 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 09:52.54 | *** join/#asterisk-bugs fmueller (n=user@p548F7C20.dip.t-dialin.net) |
| 11:52.28 | *** join/#asterisk-bugs caio1982 (i=caio1982@CAcert-br/caio1982) |
| 11:52.44 | *** part/#asterisk-bugs jmls_home (n=jmls_hom@mail.tessera.co.uk) |
| 12:00.28 | *** join/#asterisk-bugs jmls_home (n=jmls_hom@mail.tessera.co.uk) |
| 12:09.02 | *** part/#asterisk-bugs jmls_home (n=jmls_hom@mail.tessera.co.uk) |
| 12:17.35 | *** join/#asterisk-bugs jmls_home (n=jmls_hom@mail.tessera.co.uk) |
| 13:03.23 | *** join/#asterisk-bugs Victor_Yure (n=Victor_Y@unaffiliated/victoryure/x-837844) |
| 13:17.58 | *** join/#asterisk-bugs agx (n=AGX@host63-216-static.34-88-b.business.telecomitalia.it) |
| 13:26.43 | *** part/#asterisk-bugs agx (n=AGX@host63-216-static.34-88-b.business.telecomitalia.it) |
| 14:03.18 | *** join/#asterisk-bugs lmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 14:03.18 | *** mode/#asterisk-bugs [+o lmadsen] by ChanServ |
| 15:10.37 | *** join/#asterisk-bugs seanbright (i=seanbrig@65.207.74.18) |
| 15:11.13 | *** join/#asterisk-bugs russellb (n=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 15:11.13 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 15:21.33 | file | M12491 |
| 15:21.35 | MuffinMan | [closed] [Asterisk] Channels/chan_sip/Interoperability 0012491: "502 Bad Gateway" is translated as "NO ANSWER" instead of "FAILED", why? reported by ibc http://bugs.digium.com/view.php?id=12491 |
| 15:21.37 | file | pokes codefreeze-lap / codefreeze |
| 15:21.44 | file | M12494 |
| 15:21.45 | MuffinMan | [feedback] [Asterisk] Channels/chan_sip/General 0012494: asterisk locks after p2p sip channel bridge reported by pj http://bugs.digium.com/view.php?id=12494 |
| 15:22.31 | file | they did attach some core show locks |
| 15:22.55 | file | I believe they are using TCP with or without TLS though |
| 15:23.19 | codefreeze-lap | rubs the spot where file poked him.... |
| 15:23.42 | seanbright | ... |
| 15:24.18 | seanbright | too... easy... must... resist... |
| 16:08.11 | *** join/#asterisk-bugs elguero (n=elguero@h-68-167-124-171.cmbrmaor.covad.net) |
| 16:54.07 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 17:59.18 | *** join/#asterisk-bugs Victor_Yure (n=Victor_Y@unaffiliated/victoryure/x-837844) |
| 18:18.51 | *** join/#asterisk-bugs seanbright (i=seanbrig@65.207.74.18) |
| 18:54.17 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 19:10.13 | jsmith | There... I've uploaded a patch to bug number 12498 for review |
| 19:11.20 | Qwell | jsmith: scary |
| 19:11.47 | jsmith | Qwell: Yes, *very* scary... |
| 19:16.16 | Qwell | jsmith: yeah, I don't know why it would be doing that |
| 19:16.36 | Qwell | oh, yes I do |
| 19:16.40 | jsmith | Oh? |
| 19:16.45 | jsmith | I thought I did, but I was wrong |
| 19:16.46 | Qwell | see -c114226 |
| 19:16.51 | jsmith | Please enlighten me |
| 19:16.55 | Qwell | svn diff -c114226 |
| 19:17.04 | Qwell | and log -r114226 also |
| 19:17.10 | Qwell | scope funkiness |
| 19:18.03 | jsmith | OK, am I doing something stupid? |
| 19:18.14 | jsmith | I type "svn diff -c114226 apps/app_chanspy.c" |
| 19:18.19 | jsmith | Shouldn't that work? |
| 19:18.25 | Qwell | svn 1.4? |
| 19:18.31 | jsmith | Trunk... |
| 19:18.32 | Qwell | (literally svn, not the repo) |
| 19:18.38 | jsmith | Oh... |
| 19:18.40 | jsmith | Hold on. |
| 19:18.47 | Qwell | -c is a 1.4 feature |
| 19:18.52 | jsmith | svn, version 1.4.6 (r28521) |
| 19:19.09 | Qwell | trunk rev is probably +1. that was 1.4 |
| 19:19.52 | jsmith | Removed the line that says "struct ast_channel *peer;" |
| 19:19.56 | jsmith | Oh, gotcha... |
| 19:20.24 | Qwell | it was scoped incorrectly, and I suspect that these peer = NULL; lines (there are two, you'll notice) were there to cleanup |
| 19:20.33 | Qwell | trying to find the rev where it was added |
| 19:21.00 | jsmith | 38374 by kpfleming |
| 19:21.12 | jsmith | (that's the second one) |
| 19:21.52 | Qwell | hmm, what about the first? |
| 19:22.13 | jsmith | 104107 by russell |
| 19:22.33 | Qwell | it was correctly scoped in 38374 |
| 19:23.14 | Qwell | yep, that's where the scope changed |
| 19:23.18 | jsmith | Exactly |
| 19:23.26 | russellb | hides |
| 19:23.59 | Qwell | so, just removing that line may not be correct. peer could have disappeared |
| 19:24.17 | jsmith | From the commit log "this patch uses some channel datastore magic on the spied upon channel to be able to detect if and when the channel goes away" |
| 19:24.19 | jsmith | Right... |
| 19:24.34 | Qwell | probably prev = peer_chanspy_ds instead of prev = peer |
| 19:24.37 | Qwell | in the for loop |
| 19:24.38 | jsmith | russellb: You don't have to hide... according to the commit log, it was kpfleming that gave you the idea, and file that reviewed the code |
| 19:24.46 | Qwell | russellb: thoughts? :D |
| 19:25.11 | Qwell | jsmith: and as far as the waitms thing, if it's not hurting anything, I would say leave it |
| 19:26.20 | jsmith | Qwell: Well, having that line in there causes a 5-second wait if you reach the end of the channel list and have to start going through the list again |
| 19:26.34 | jsmith | Qwell: What I was saying is that removing doesn't seem to hurt anything |
| 19:29.34 | jsmith | Qwell: I seem to be hearing crickets... I realize app_chanspy is everyone's favorite code (besides chan_agent) |
| 19:29.42 | russellb | i'm eating cake. |
| 19:29.48 | russellb | but soon i will open chanspy. |
| 19:30.07 | russellb | cake > chanspy |
| 19:31.07 | jsmith | russellb: On that note, I'll go have another piece of cake too |
| 19:32.17 | lmadsen | wants cake now |
| 19:32.22 | lmadsen | goes for dinner with a friend |
| 19:33.18 | russellb | lmadsen: it's too early for dinner, get back to work |
| 19:33.49 | lmadsen | I routinely see people go for lunch at like 10:30am, so your logic will not work on me :) |
| 19:34.01 | lmadsen | and it's an hour later here and it is there |
| 19:34.06 | lmadsen | and I haven't even had lunch :) |
| 19:34.10 | file | if anyone should be going to dinner it's me |
| 19:34.14 | lmadsen | so actually I'm going for a late lunch |
| 19:34.16 | lmadsen | does that help? |
| 19:34.51 | russellb | um, NO! |
| 19:34.58 | russellb | there is a patch you really need to test |
| 19:34.59 | russellb | NOW |
| 19:35.57 | lmadsen | my friend will not be happy if I don't show up... :) |
| 19:36.04 | lmadsen | she is leaving for the summer |
| 19:36.07 | file | lmadsen: friends are useless |
| 19:36.14 | lmadsen | file: that's why we keep you around? |
| 19:36.18 | file | Asterisk can be your friend!!! |
| 19:36.19 | russellb | M10540 |
| 19:36.19 | file | long time. |
| 19:36.20 | russellb | fine, go |
| 19:36.21 | MuffinMan | [ready for testing] [Asterisk] Functions/func_timeout 0010540: timeout value should accept floating point numbers reported by spendergrass http://bugs.digium.com/view.php?id=10540 |
| 19:36.26 | russellb | but once you return, you should test that :) |
| 19:36.28 | lmadsen | russellb: is there another change to that? |
| 19:36.32 | lmadsen | I tested, and it crashed |
| 19:36.36 | lmadsen | uploaded a backtrace too |
| 19:36.39 | russellb | oh. |
| 19:36.41 | lmadsen | :D |
| 19:36.44 | russellb | then it should be assigned back to tilghman |
| 19:36.50 | russellb | go eat, then, good sir! |
| 19:36.56 | lmadsen | thx! my work here is done :) |
| 19:37.07 | file | lame sir. |
| 19:37.16 | lmadsen | at least you called me sir, and I'll take that. |
| 19:37.32 | lmadsen | good bye good sirs! I'll be back later to work on that documentation bug I suppose |
| 19:38.50 | russellb | ok, chanspy ... |
| 19:38.54 | russellb | we're looking at 1.4, right? |
| 19:38.59 | Qwell | either |
| 19:39.09 | Qwell | all the revisions above were 1.4 |
| 19:39.25 | Qwell | specifically 114226 |
| 19:39.41 | Qwell | and 104106 |
| 19:41.28 | Juggie | according to jsmith, 1.4 and trunk both dont work with * to jump channels |
| 19:41.31 | Qwell | the problem before was that prev was also null, due to the scope of peer. now, prev is null sometimes |
| 19:41.33 | Juggie | though i have no idea how this has gone unnoticed |
| 19:41.39 | Qwell | s/also/always/ |
| 19:42.03 | Qwell | sometimes = on success |
| 19:42.49 | jsmith | I'm thoroughly convinced that people that use ChanSpy aren't keeping up with the latest releases, and this may be one reason why ;-) |
| 19:44.35 | Juggie | perhaps, perhaps :) |
| 19:45.09 | russellb | Qwell: what was the reason you said removing that line is bad? |
| 19:45.34 | Qwell | the comment right above it |
| 19:45.40 | Qwell | peer can go away, right? |
| 19:47.28 | Qwell | it's not actually used after that, but.. |
| 19:48.35 | jsmith | Qwell: I couldn't find a way to make peer go away in such a way that would cause problems, but I'm just a n00b |
| 19:49.43 | Juggie | shoudnt ast_channel_walk_locked be, ast_walk_channel_locked |
| 19:49.50 | Juggie | to go with the rest of the nameing convention |
| 19:49.57 | Juggie | the other functions are all ast_walk_* |
| 19:52.27 | jsmith | Juggie: Don't go changing the API, or you'll get called a dinosaur... or an ostrich... or something worse. |
| 19:52.39 | Juggie | i've been called worse many times :) |
| 19:52.47 | Juggie | anyway with this patch |
| 19:52.48 | Juggie | and my patch |
| 19:52.54 | Juggie | were you able to jump around? |
| 19:53.19 | jsmith | Juggie: Absitively Posolutely! |
| 19:53.25 | Juggie | fantastic |
| 19:53.27 | jsmith | But I'll test it again, just to make sure... |
| 19:53.38 | Juggie | do you want me to post that patcharonie? |
| 19:53.49 | jsmith | I already did :-p |
| 19:53.57 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 19:54.06 | Juggie | did you fix my code i had a { on a new line |
| 19:54.07 | Juggie | by accident |
| 19:54.16 | jsmith | Nope. |
| 19:54.21 | jsmith | I'll remove the patch, and let you upload it |
| 19:54.26 | Juggie | i can do it |
| 19:54.37 | jsmith | Done |
| 19:55.23 | Juggie | i'm going to upload the code |
| 19:55.30 | Juggie | but i need you to upload new documentation |
| 19:55.38 | Juggie | in a seperate patch |
| 19:55.39 | jsmith | Gimme two seconds to test, and then I'll write new documentation |
| 19:55.42 | jsmith | Right... |
| 19:55.50 | Juggie | you can just post the whole patch if you want |
| 19:55.55 | jsmith | Unless you want the docs in the same patch |
| 19:56.01 | Juggie | just move the lone { up a line |
| 19:56.40 | Juggie | nm do this |
| 19:56.46 | jsmith | Already taken care of, my friend... already taken care of |
| 19:56.47 | Juggie | just make the documentation patch and put it in pastebin |
| 19:56.52 | Juggie | well ok whatever :) |
| 19:56.59 | Juggie | i dont care how it gets there :) |
| 19:57.23 | Juggie | i can just commit it too :) hahaha |
| 19:57.27 | Juggie | thats a scary thought. |
| 19:57.38 | jsmith | Juggie: What's even scarier... so can I ;-) |
| 19:57.47 | Juggie | hah |
| 19:59.03 | Juggie | well you just go ahead and upload the full thing |
| 19:59.05 | Juggie | with documentation |
| 19:59.53 | jsmith | Your patch still works ;-) |
| 20:00.34 | Juggie | good good ok well fix the ChanSPy and Externspy docs |
| 20:00.39 | Juggie | to say : works with both and post it |
| 20:00.42 | Juggie | and call it a day :) |
| 20:30.29 | jsmith | Juggie: Documentation written, patch being uploaded as I type |
| 20:37.04 | jsmith | Juggie: http://bugs.digium.com/file_download.php?file_id=18646&type=bug |
| 20:48.40 | seanbright | "dup_mygroup" is fun to say out loud |
| 20:54.21 | jsmith | seanbright: Can you imagine an doo-op acapella group singing.... dup dup dup... dup_mygroup group group... dup_mygroup group group.... |
| 20:54.33 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 20:55.06 | seanbright | jsmith: it was more something like yosemite sam saying "Well, dup ma' group!" |
| 20:55.35 | jsmith | seanbright: That works ;-) |
| 21:10.35 | *** join/#asterisk-bugs fakhir (n=fakhir@unaffiliated/fakhir) |