| 00:27.04 | *** join/#asterisk-bugs fakhir_ (n=fakhir@unaffiliated/fakhir) |
| 02:08.38 | *** join/#asterisk-bugs bkruse (n=bkruse@76.73.154.120) |
| 02:15.40 | *** join/#asterisk-bugs Juggie (i=Juggie@CPE001601df17fb-CM001a6682d7b6.cpe.net.cable.rogers.com) |
| 02:15.41 | *** mode/#asterisk-bugs [+o Juggie] by ChanServ |
| 02:25.59 | *** join/#asterisk-bugs ChanServ (ChanServ@services.) |
| 02:25.59 | *** mode/#asterisk-bugs [+o ChanServ] by irc.freenode.net |
| 03:23.36 | *** join/#asterisk-bugs bkruse (n=bkruse@76.73.154.120) [NETSPLIT VICTIM] |
| 04:35.16 | *** join/#asterisk-bugs fakhir_ (n=fakhir@unaffiliated/fakhir) |
| 07:06.59 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 08:53.32 | *** join/#asterisk-bugs mbranca (n=matteo@81.208.92.210) |
| 12:10.11 | *** join/#asterisk-bugs russellb (n=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 12:10.11 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 12:25.07 | *** join/#asterisk-bugs jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 12:36.10 | *** join/#asterisk-bugs caio1982 (i=caio1982@CAcert-br/caio1982) |
| 13:17.18 | *** join/#asterisk-bugs lmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:17.18 | *** mode/#asterisk-bugs [+o lmadsen] by ChanServ |
| 13:26.17 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 13:58.08 | *** join/#asterisk-bugs putnopvut (n=putnopvu@216.207.245.1) |
| 13:58.08 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 14:44.45 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 14:57.04 | *** join/#asterisk-bugs Deeewayne (n=Deeewayn@216.207.245.1) |
| 14:57.04 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 15:10.48 | *** join/#asterisk-bugs russellb (n=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 15:10.49 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 15:12.18 | *** join/#asterisk-bugs jpeeler (n=jpeeler@216.207.245.1) |
| 15:12.59 | *** join/#asterisk-bugs bbryant (n=brett@216.207.245.1) |
| 15:12.59 | *** mode/#asterisk-bugs [+o bbryant] by ChanServ |
| 15:13.23 | *** join/#asterisk-bugs fakhir (n=fakhir@unaffiliated/fakhir) |
| 16:06.39 | *** join/#asterisk-bugs Deeewayne (n=Deeewayn@216.207.245.1) |
| 16:06.39 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 16:36.18 | putnopvut | Hey folks, I'd like some feedback on a patch I'm about to propose. First, here's the issue: |
| 16:36.27 | putnopvut | M12771 |
| 16:36.28 | MuffinMan | [new] [Asterisk] Applications/app_queue 0012771: Bogus <member> is still 'Not in Use' warnings for AgentLogin'ed agents. reported by davidw (Karma: neutral) http://bugs.digium.com/view.php?id=12771 |
| 16:36.38 | jsmith | cranks the volume to 11 and listens to the feedback |
| 16:36.59 | putnopvut | Pretty much there's a minor race condition between the caller's thread in app_queue and the device state thread that reports member device state. |
| 16:37.45 | putnopvut | My proposed fix is to build in a delay (100 usec) between when the member answers the call and the call is bridged ONLY if there are no other options set for the queue which will already cause a small delay. |
| 16:37.57 | putnopvut | Here's the patch (hold on while I pastebin it): |
| 16:39.01 | putnopvut | http://pastebin.ca/1043046 |
| 16:39.12 | *** join/#asterisk-bugs fakhir_ (n=fakhir@unaffiliated/fakhir) |
| 16:40.42 | jsmith | Is hardcoding a delay really the best way to avoid the race condition? |
| 16:40.51 | jsmith | I mean, at least in theory, the agent would be in a "ringing" state, right? |
| 16:40.53 | jsmith | And if it's already ringing, another call shouldn't be distributed to that agent, right? |
| 16:40.59 | jsmith | Now, obviously, in the case of AgentLogin, that "ringing" time would pretty much just be the duration of the beep that the agent hears, and possibly the duration of the queue announcement (if one is set) |
| 16:41.23 | jsmith | This is all theoretical, not having looked at the code in several years |
| 16:41.54 | putnopvut | The problem is that Local channels don't report a ringing state (and by extension neither do callback agents). |
| 16:42.25 | putnopvut | I think I see where this leads the next question though. |
| 16:42.36 | putnopvut | Why don't Local channels report a ringing state? |
| 16:42.51 | jsmith | putnopvut: My point exactly... |
| 16:43.03 | jsmith | putnopvut: Local channels *should* report a ringing state, just like any other channel type |
| 16:43.45 | putnopvut | Ah, Local channels only report "invalid" and "unknown" state apparently. Lovely. |
| 16:43.59 | russellb | they do in trunk |
| 16:44.02 | russellb | i think? |
| 16:44.07 | putnopvut | Hmmm, I'll check. |
| 16:44.09 | russellb | no, they report INUSE |
| 16:44.37 | russellb | or something |
| 16:44.37 | putnopvut | Do they report in use when they are ringing? |
| 16:44.37 | putnopvut | That would be enough. |
| 16:44.37 | russellb | yeah |
| 16:44.38 | jsmith | Yeah... that would work |
| 16:44.41 | putnopvut | I'll double check just to be safe. |
| 16:49.01 | jsmith | can't wait until putnopvut rewrites chan_agent and app_queue from scratch |
| 16:50.00 | putnopvut | I would love to rewrite chan_agent from scratch if for no other purpose than to be able to actually understand what the heck is going on in that code. |
| 16:50.01 | jsmith | putnopvut: You could do chan_agent2, and then compare the two side-by-side |
| 16:50.03 | jsmith | AGENT2/blah, etc. |
| 16:53.31 | putnopvut | Great. My test with local channels in trunk is not going so hot. I can't get the local channel to report anything other than "invalid" to the queue. |
| 16:54.26 | putnopvut | Ah... |
| 16:54.41 | putnopvut | I bet it's the same thing that mvanbaak is seeing where ast_exists_extension is always returning 0. |
| 16:56.44 | jsmith | putnopvut: Did you load chan_local before app_queue? |
| 16:56.57 | jsmith | putnopvut: I know there are some funky module-loading order issues there |
| 16:57.01 | putnopvut | Yes. I even reloaded app_queue to be on the safe side. |
| 16:57.05 | jsmith | Ugh... |
| 16:57.18 | putnopvut | But I'm fairly certain it's the same thing that mvanbaak was seeing in his branch. |
| 16:57.49 | putnopvut | chan_local calls ast_exists_extension to get the device state, but that function is always returning 0 for some reason. |
| 16:58.01 | putnopvut | As a result, the device state remains invalid. |
| 16:58.44 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 17:08.38 | lmadsen | putnopvut: I had to make a change to chan_local to make Unknown act the same as Ringing |
| 17:08.53 | putnopvut | lmadsen: in trunk or 1.4? |
| 17:08.55 | lmadsen | since I never saw Unknown except when the other end was Ringing |
| 17:09.03 | lmadsen | putnopvut: ummm... 1.4 (ABE) |
| 17:09.40 | lmadsen | because when it went to Unknown, it treated the end point as Not In Use, and thus, the phone would get multiple calls distributed to it |
| 17:10.22 | putnopvut | lmadsen: okay, cool. I'll keep that in mind. If trunk turns out to have better device state reporting and I can't backport it to 1.4, I'll make a concession for Unknown with regards to local channels in queues. |
| 17:10.35 | lmadsen | putnopvut: ok, let me know -- I have the patch, and its pretty simple |
| 17:18.42 | putnopvut | lmadsen: it appears as though local channels in trunk will always show up as 'Not in use' even when ringing. Would you mind posting the patch you wrote to the bugtracker? |
| 17:18.57 | lmadsen | putnopvut: I didn't write it, but I can post it :) |
| 17:19.09 | lmadsen | you should now better than that |
| 17:19.11 | lmadsen | know* |
| 17:19.20 | putnopvut | lmadsen: hmm, well, regarding licensing issues, is it something we can accept? |
| 17:19.29 | lmadsen | yes, it was written inside digium |
| 17:19.34 | putnopvut | Okay, cool. |
| 17:19.38 | lmadsen | against O.S. |
| 17:25.45 | jmls | putnopvut: mvanbaak's problem was in his dialplan, not the code. He had an extension of "foo" instead of foo ;) |
| 17:26.17 | jmls | he spent the weekend looking at his "c" code when there was nothing wrong with it 8-) |
| 17:26.40 | jmls | (he also told me to laugh long and hard at him) |
| 17:26.47 | jmls | is an evil bugger |
| 17:27.13 | lmadsen | putnopvut: there you go |
| 17:27.32 | lmadsen | jmls: and that's why we like you |
| 17:30.00 | jmls | cackles |
| 17:30.13 | jmls | dammit. got to get ready for football. |
| 17:30.44 | jmls | it's a sad sight seeing 22 old'n'bald guys lumping a piece of leather around all in the name of "sport" |
| 17:33.39 | putnopvut | lmadsen: thanks for the bug report. |
| 17:37.19 | putnopvut | lmadsen: are you sure you submitted the right patch? That seems to be something that adds a '/b' option for local channels. |
| 17:37.34 | lmadsen | yes, that is true |
| 17:37.44 | lmadsen | you need to add the /b to make them act like that |
| 17:37.48 | file | O.o |
| 17:37.53 | putnopvut | oh |
| 17:37.54 | lmadsen | I'm pretty sure that is the right patch... |
| 17:37.55 | file | the /b was for changing transfer logic |
| 17:38.03 | lmadsen | oh right... which I *just* realized |
| 17:38.06 | lmadsen | which I don't use anymore |
| 17:38.09 | lmadsen | that is a bad patch :) |
| 17:38.14 | lmadsen | let me find the real one |
| 17:38.17 | lmadsen | (I was testing you) |
| 17:38.29 | putnopvut | lmadsen: phew, I thought I was crazy for a second. |
| 17:38.35 | lmadsen | you still are |
| 17:38.37 | putnopvut | And yes, I know I just set myself up with that. |
| 17:38.40 | lmadsen | :D |
| 17:38.44 | Juggie | putnopvut! |
| 17:38.51 | putnopvut | Juggie: what's happenin'? |
| 17:39.27 | Juggie | meh, not much. |
| 17:39.30 | Juggie | you? |
| 17:40.41 | putnopvut | Just working. |
| 17:46.56 | Juggie | sounds exciting! |
| 17:47.41 | lmadsen | putnopvut: ok, Matt Nicholson wrote the patch, but its part of another patch... so he is trying to isolate it now |
| 17:47.46 | lmadsen | I asked him to attach when complete |
| 17:48.13 | putnopvut | lmadsen: great. much appreciated. |
| 17:48.18 | lmadsen | np |
| 18:45.18 | lmadsen | M12110 |
| 18:45.20 | MuffinMan | [feedback] [Asterisk] Channels/chan_sip/Interoperability 0012110: CCM sends multiple INVITEs which causes MusicOnHold to execute on a channel reported by blitzrage (Karma: +31.50) http://bugs.digium.com/view.php?id=12110 |
| 18:45.21 | lmadsen | can I just close this? |
| 18:45.28 | lmadsen | I'm thinking so |
| 18:46.48 | *** join/#asterisk-bugs bkruse (n=bkruse@76.73.154.120) |
| 18:48.45 | putnopvut | lmadsen: as the reporter, you can always feel free to close an issue, I say. |
| 18:49.10 | lmadsen | I agree |
| 18:49.12 | lmadsen | closed! |
| 18:49.25 | lmadsen | I opened it, but it wasn't for me |
| 18:58.54 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 19:30.09 | *** part/#asterisk-bugs Deeewayne (n=Deeewayn@216.207.245.1) |
| 19:56.37 | *** join/#asterisk-bugs tuxd00d (n=tuxd00d@128.187.132.25) |
| 19:58.34 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 20:06.43 | *** join/#asterisk-bugs putnopvut (n=putnopvu@216.207.245.1) |
| 20:06.43 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 20:07.16 | *** join/#asterisk-bugs bbryant (n=brett@216.207.245.1) |
| 20:07.17 | *** mode/#asterisk-bugs [+o bbryant] by ChanServ |
| 20:08.40 | *** join/#asterisk-bugs jpeeler (n=jpeeler@216.207.245.1) |
| 20:12.42 | *** join/#asterisk-bugs Deeewayne (n=Deeewayn@216.207.245.1) |
| 20:12.42 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 20:14.22 | *** join/#asterisk-bugs russellb (n=russell@asterisk/developer-and-stable-maintainer/drumkilla) |
| 20:14.22 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 20:59.09 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 21:04.07 | *** join/#asterisk-bugs fakhir (n=fakhir@unaffiliated/fakhir) |
| 21:51.58 | *** join/#asterisk-bugs oej (n=olle@114.62-97-206.bkkb.no) |
| 21:59.11 | *** join/#asterisk-bugs fakhir_ (n=fakhir@unaffiliated/fakhir) |
| 22:25.31 | *** join/#asterisk-bugs Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 22:25.31 | *** mode/#asterisk-bugs [+o Qwell] by ChanServ |
| 22:52.55 | *** join/#asterisk-bugs bbryant (n=brett@216.207.245.1) |
| 22:52.55 | *** mode/#asterisk-bugs [+o bbryant] by ChanServ |
| 23:04.54 | *** join/#asterisk-bugs bbryant (n=brett@216.207.245.1) |
| 23:04.54 | *** mode/#asterisk-bugs [+o bbryant] by ChanServ |
| 23:09.11 | *** part/#asterisk-bugs Deeewayne (n=Deeewayn@216.207.245.1) |
| 23:17.31 | *** join/#asterisk-bugs ZX81 (n=matt@202.49.106.158) |
| 23:23.49 | *** join/#asterisk-bugs mvanbaak_ (n=michiel@vanbaak.xs4all.nl) |