| 00:11.23 | *** join/#asterisk-bugs russellb_ (n=russellb@asterisk/developer-and-stable-maintainer/drumkilla) |
| 00:11.23 | *** mode/#asterisk-bugs [+o russellb_] by ChanServ |
| 00:18.15 | *** join/#asterisk-bugs russellb (n=russellb@asterisk/developer-and-stable-maintainer/drumkilla) |
| 00:18.15 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 00:44.25 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) |
| 00:44.25 | *** mode/#asterisk-bugs [+o implicit] by ChanServ |
| 01:32.32 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 01:32.45 | *** part/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 02:10.26 | *** join/#asterisk-bugs fakhir (n=fakhir@unaffiliated/fakhir) |
| 02:34.13 | *** join/#asterisk-bugs implicit- (n=bayan@unaffiliated/implicit) |
| 02:34.13 | *** mode/#asterisk-bugs [+o implicit-] by ChanServ |
| 03:29.03 | *** join/#asterisk-bugs ZX81_ (n=matt@202.49.106.158) |
| 03:50.17 | *** join/#asterisk-bugs ZX81 (n=matt@202.49.106.158) |
| 04:51.10 | *** join/#asterisk-bugs ZX81_ (n=matt@202.49.106.158) |
| 10:21.38 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 11:17.48 | *** join/#asterisk-bugs DagMoller (n=aguirre@unaffiliated/dagmoller) |
| 12:14.13 | *** join/#asterisk-bugs russellb (n=russellb@asterisk/developer-and-stable-maintainer/drumkilla) |
| 12:14.13 | *** mode/#asterisk-bugs [+o russellb] by ChanServ |
| 13:34.20 | *** join/#asterisk-bugs d1mas (n=chatzill@host-99.dataart.net) |
| 13:35.30 | d1mas | Corydon76: hello. I would like to clarify something regarding your fix for 12875 ( change - http://svn.digium.com/view/asterisk/branches/1.4/channels/chan_iax2.c?r1=130889&r2=130888&pathrev=130889 ) |
| 13:35.48 | *** join/#asterisk-bugs shido6 (n=shido6@209.114.208.192) |
| 13:37.06 | d1mas | Corydon76: basically I do not understand your fix :) My understanding was that user->cid* fields are these which came from the config files )or realtime in my case). So what I wanted is to make sure these fields are used regardless if channel already has callerid or not. |
| 13:38.51 | d1mas | Corydon76: original code was kind of using them but only in the case the call has IAX_HASCALLERID flag AND user->cid* fields are non-empty. Your fix basically removed check for user->cid* non-emptiness but the call is still required to have IAX_HASCALLERID... |
| 14:08.19 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 14:22.26 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 14:26.15 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 14:55.01 | *** join/#asterisk-bugs jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) |
| 15:15.11 | *** join/#asterisk-bugs putnopvut (n=putnopvu@conference/asterisk/x-9c25c68ca4978296) |
| 15:15.11 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 15:19.21 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 15:20.50 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) |
| 15:20.50 | *** mode/#asterisk-bugs [+o implicit] by ChanServ |
| 16:07.12 | *** join/#asterisk-bugs Juggie (i=Juggie@CPE001601df17fb-CM001a6682d7b6.cpe.net.cable.rogers.com) [NETSPLIT VICTIM] |
| 16:07.12 | *** mode/#asterisk-bugs [+o Juggie] by irc.freenode.net |
| 16:07.19 | *** join/#asterisk-bugs russellb (n=russellb@asterisk/developer-and-stable-maintainer/drumkilla) [NETSPLIT VICTIM] |
| 16:07.19 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) [NETSPLIT VICTIM] |
| 16:07.19 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) [NETSPLIT VICTIM] |
| 16:07.19 | *** join/#asterisk-bugs d1mas (n=chatzill@host-99.dataart.net) [NETSPLIT VICTIM] |
| 16:07.19 | *** join/#asterisk-bugs bkruse (n=bkruse@conference/asterisk/x-7e360e17277046c0) [NETSPLIT VICTIM] |
| 16:07.20 | *** join/#asterisk-bugs Qwell (i=north@pdpc/sponsor/digium/Qwell) [NETSPLIT VICTIM] |
| 16:07.20 | *** join/#asterisk-bugs jsmith-away (n=jsmith@72.21.36.138) |
| 16:07.20 | *** mode/#asterisk-bugs [+ooo russellb Qwell jsmith-away] by irc.freenode.net |
| 16:08.16 | *** join/#asterisk-bugs shido6 (n=shido6@209.114.208.192) |
| 16:08.16 | *** join/#asterisk-bugs d3wayne (n=dwayne@76.29.245.9) |
| 16:08.16 | *** join/#asterisk-bugs angler (n=angler@pdpc/sponsor/digium/angler) |
| 16:08.21 | *** join/#asterisk-bugs putnopvut (n=putnopvu@conference/asterisk/x-9c25c68ca4978296) [NETSPLIT VICTIM] |
| 16:08.21 | *** join/#asterisk-bugs jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) [NETSPLIT VICTIM] |
| 16:08.21 | *** join/#asterisk-bugs file (n=file@asterisk/developer-and-muffin-lover/file) |
| 16:08.21 | *** mode/#asterisk-bugs [+oo putnopvut file] by irc.freenode.net |
| 16:08.23 | *** join/#asterisk-bugs Corydon76-dig (i=silver@pdpc/supporter/bronze/Corydon76-home) [NETSPLIT VICTIM] |
| 16:08.23 | *** join/#asterisk-bugs citats (n=james@mrplow.gnuinternet.com) [NETSPLIT VICTIM] |
| 16:08.23 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) [NETSPLIT VICTIM] |
| 16:08.23 | *** join/#asterisk-bugs mvanbaak (n=michiel@vanbaak.xs4all.nl) [NETSPLIT VICTIM] |
| 16:08.23 | *** mode/#asterisk-bugs [+ooo Corydon76-dig citats implicit] by irc.freenode.net |
| 16:09.16 | *** join/#asterisk-bugs ChanServ (ChanServ@services.) |
| 16:09.16 | *** join/#asterisk-bugs MuffinMan (n=muffinma@asterisk/issue-tracker-bot/muffinman) [NETSPLIT VICTIM] |
| 16:09.16 | *** join/#asterisk-bugs seanbright (n=sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 16:09.16 | *** join/#asterisk-bugs elguero (n=elguero@ns1.nashuacs.com) [NETSPLIT VICTIM] |
| 16:09.16 | *** mode/#asterisk-bugs [+o ChanServ] by irc.freenode.net |
| 16:11.47 | *** join/#asterisk-bugs fakhir (n=fakhir@unaffiliated/fakhir) |
| 16:19.40 | *** part/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 16:20.05 | *** join/#asterisk-bugs codefreeze-lap (n=murf@216.166.159.235) |
| 16:25.50 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 17:02.34 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 17:10.24 | *** part/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 17:11.29 | *** join/#asterisk-bugs lmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 17:11.29 | *** mode/#asterisk-bugs [+o lmadsen] by ChanServ |
| 19:01.44 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 19:14.53 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) |
| 19:14.53 | *** mode/#asterisk-bugs [+o implicit] by ChanServ |
| 20:01.24 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 20:12.01 | d1mas | Corydon76: are you there? |
| 21:01.59 | *** join/#asterisk-bugs atis_work (n=atis_wor@193.238.212.171) |
| 21:04.58 | Corydon76-dig | d1mas: yes, I'm here |
| 21:05.16 | d1mas | Corydon76: I guess you missed my question right? |
| 21:06.41 | Corydon76-dig | I did before, yes |
| 21:06.58 | Corydon76-dig | The answer is, you need to go look at where IAX_HASCALLERID is set |
| 21:07.07 | Corydon76-dig | And then you will be enlightened |
| 21:07.34 | d1mas | will do |
| 21:08.07 | Corydon76-dig | specifically, if somebody does this: "callerid=" |
| 21:08.13 | d1mas | Corydon76: however if it is set - I would not opend the bug at first... |
| 21:08.26 | Corydon76-dig | That's nonzero, and the normal checks would fail, if they checked for non-zero length |
| 21:08.40 | d1mas | Corydon76: because in my case user->cid* are initialized while flag is not set |
| 21:08.53 | Corydon76-dig | d1mas: that's not possible |
| 21:09.11 | d1mas | will re-check |
| 21:09.23 | Corydon76-dig | The flag is ALWAYS set when callerid is set, EVEN IF SET TO BLANK |
| 21:09.41 | Corydon76-dig | That's why it's a flag, not a check for nonzero length |
| 21:12.17 | d1mas | Corydon76: hm... btw, looking at the code I would say if callerid is empty string, the flag will be reset... (chan_iax2.c, build_peer) |
| 21:12.49 | Corydon76-dig | Okay, empty string, yes |
| 21:13.21 | Corydon76-dig | but you still cannot have a case where you set the value and that flag is clear |
| 21:13.39 | d1mas | (not my case anyway, it was just about your words that "even if set to blank") |
| 21:13.56 | d1mas | true |
| 21:14.24 | Corydon76-dig | When that was switched to "!ast_strlen_zero()" that was probably introducing a bug |
| 21:15.05 | Corydon76-dig | I may fix that, because I believe that is broken. You should be able to set callerid to blank and override callerid that way |
| 21:19.15 | d1mas | Corydon76: looks like you are right. Shame on me - when I was looking at the patch, I thought the check you removed was not on iaxs[callno]->cid_num but on user->cid_num. |
| 21:58.10 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) |
| 21:58.10 | *** mode/#asterisk-bugs [+o implicit] by ChanServ |
| 22:27.37 | *** join/#asterisk-bugs ChanServ (ChanServ@services.) |
| 22:27.37 | *** mode/#asterisk-bugs [+o ChanServ] by irc.freenode.net |
| 22:37.29 | putnopvut | M11259 |
| 22:37.32 | MuffinMan | [assigned] [Asterisk] Core/Jitterbuffer 0011259: Jitterbuffer does not work well with injected sound reported by plack (Karma: +3.00) http://bugs.digium.com/view.php?id=11259 |
| 22:38.15 | putnopvut | So the original plan was to queue AST_CONTROL_SRCUPDATE frames whenever the source of audio would change in order to not make jitter buffers go crazy. |
| 22:38.15 | *** join/#asterisk-bugs ChanServ (ChanServ@services.) |
| 22:38.15 | *** mode/#asterisk-bugs [+o ChanServ] by irc.freenode.net |
| 22:38.59 | putnopvut | It turns out that most of the time that the audio source changes, it means that ast_generic_bridge returns in order to inject new audio into the channel. |
| 22:39.42 | putnopvut | So really, the only places where the AST_CONTROL_SRCUPDATE frames need to be queued are where the source of audio will change, but which will not cause a return from ast_generic_bridge. |
| 22:39.59 | putnopvut | Besides, say, an RTP SSRC change, what else could cause such behavior? |
| 22:44.31 | putnopvut | Would a masquerade be a potential scenario for this? |
| 22:45.09 | putnopvut | I don't know of a time where a masquerade happens to a bridged channel in a separate thread from the bridge. |
| 22:56.42 | *** join/#asterisk-bugs ZX81 (n=matt@202.49.106.158) |