| 00:04.37 | *** join/#asterisk-bugs dwayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 01:30.32 | *** join/#asterisk-bugs Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 01:30.32 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 02:20.44 | *** join/#asterisk-bugs JunK-Y (n=junky@modemcable206.69-20-96.mc.videotron.ca) |
| 02:20.44 | *** mode/#asterisk-bugs [+o JunK-Y] by ChanServ |
| 04:28.55 | *** join/#asterisk-bugs lmsteffan (n=laurent@195.221.84.4) |
| 04:34.15 | *** join/#asterisk-bugs leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 04:34.15 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 05:57.17 | *** join/#asterisk-bugs |Cybex| (n=John@atwork-26.r-212.178.82.atwork.nl) |
| 06:00.17 | *** join/#asterisk-bugs lmsteffan (n=laurent@reef.ac-noumea.nc) |
| 06:38.19 | *** join/#asterisk-bugs oej (n=olle@1x-193-157-197-57.uio.no) |
| 07:11.37 | *** join/#asterisk-bugs oej (n=olle@156.116.14.30) |
| 07:21.36 | *** join/#asterisk-bugs oej_ (n=olle@1x-193-157-197-57.uio.no) |
| 09:14.25 | *** join/#asterisk-bugs Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 09:14.25 | *** join/#asterisk-bugs oej (n=olle@1x-193-157-197-57.uio.no) |
| 09:14.25 | *** join/#asterisk-bugs russellb (n=russellb@asterisk/digium-open-source-team-lead/russellb) |
| 09:14.25 | *** join/#asterisk-bugs The_Boy_Wonder (n=davidvos@asterisk/batman-developer/dvossel) |
| 09:14.25 | *** join/#asterisk-bugs file (n=file@asterisk/developer-and-muffin-lover/file) |
| 09:14.25 | *** join/#asterisk-bugs jsmith-away (n=jsmith@asterisk/training-and-documentation-guru/jsmith) |
| 09:14.25 | *** mode/#asterisk-bugs [+oooo Qwell russellb file jsmith-away] by irc.freenode.net |
| 09:14.25 | *** join/#asterisk-bugs mnicholson (n=mnichols@nat/digium/x-bnbwwkrzpnjhwcxt) |
| 09:14.26 | *** join/#asterisk-bugs angler (n=angler@pdpc/sponsor/digium/angler) |
| 13:41.47 | *** join/#asterisk-bugs davidbrillert (n=aragon12@h216-235-8-130.host.egate.net) |
| 13:43.02 | *** join/#asterisk-bugs leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:43.02 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 14:12.19 | *** join/#asterisk-bugs Victor_Yure (n=victor@unaffiliated/victoryure/x-837844) |
| 14:13.04 | *** join/#asterisk-bugs Victor_Yure_ (n=victor@unaffiliated/victoryure/x-837844) |
| 14:25.49 | *** part/#asterisk-bugs |Cybex| (n=John@atwork-26.r-212.178.82.atwork.nl) |
| 14:31.22 | *** join/#asterisk-bugs xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 14:41.24 | *** join/#asterisk-bugs jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) |
| 14:48.45 | *** join/#asterisk-bugs putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 14:48.45 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 15:00.07 | *** join/#asterisk-bugs Deeewayne (n=dwayne@75.76.254.162) |
| 15:00.07 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 15:14.58 | *** join/#asterisk-bugs ebroad (n=EB@72.11.213.195) |
| 15:15.33 | *** join/#asterisk-bugs Corydon76-dig (i=red@pdpc/supporter/bronze/Corydon76-home) [NETSPLIT VICTIM] |
| 15:15.33 | *** mode/#asterisk-bugs [+o Corydon76-dig] by ChanServ |
| 15:18.17 | *** join/#asterisk-bugs xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 15:23.57 | *** join/#asterisk-bugs xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 15:24.16 | *** join/#asterisk-bugs |Cybex| (n=John@80.100.126.176) |
| 15:50.43 | Qwell | leifmadsen: damnit.. me too. Jean asked me a similar question, and I know it was familiar, but still can't figure out why |
| 15:50.47 | Qwell | leifmadsen: (re: -dev email) |
| 15:51.16 | leifmadsen | Qwell: ya, I hate when it happens.... just so much information, but you can't put your finger on it. Just a gut instinct. |
| 16:00.58 | leifmadsen | russellb: ping? |
| 16:06.15 | ebroad | can a marshal please delete externtXXport.patch on 15880 |
| 16:06.47 | leifmadsen | yes |
| 16:06.49 | leifmadsen | M15880 |
| 16:06.52 | MuffinMan | [confirmed] [Asterisk] Channels/chan_sip/TCP-TLS 0015880: [patch] Contact header port ignores transport when using externip reported by ebroad (Karma: +2.00) https://issues.asterisk.org/view.php?id=15880 |
| 16:07.13 | ebroad | thanks! |
| 16:07.16 | leifmadsen | done |
| 16:07.22 | ebroad | awesome |
| 16:07.31 | leifmadsen | really wish mantis was smart enough that once I logged in, it would take me BACK to the page I was just at |
| 16:37.45 | putnopvut | oh that is frustrating as hell |
| 16:37.55 | putnopvut | ...he said 30 minutes later :) |
| 16:48.18 | Qwell | M14797 |
| 16:48.21 | MuffinMan | [ready for review] [Asterisk] Core/BuildSystem 0014797: [patch] Make. Parallel build on multi CPU host reported by arkadia (Karma: +21.75) https://issues.asterisk.org/view.php?id=14797 |
| 16:48.21 | Qwell | seanbright: isn't that fixed? |
| 16:50.31 | seanbright | it should be, yes. |
| 16:50.42 | seanbright | i didn't realize there was an issue in mantis for it. |
| 16:51.30 | seanbright | i fixed it by adding '+'s where appropriate. he did it by always including $(MAKE) in the action... not sure which is more elegant |
| 16:51.33 | seanbright | (or correct) |
| 16:52.58 | Qwell | I'll close it |
| 16:53.06 | seanbright | wfm |
| 16:53.28 | Micc | Why am I getting these filling up my logs? [2009-10-06 09:50:19] WARNING[10591] channel.c: Exception flag set on 'SIP/ann2-09f123c8', but no exception handler |
| 16:59.12 | Corydon76-dig | Micc: #asterisk |
| 17:23.14 | ebroad | MSet(~~EXTEN~~=savedexten) after a macro call, good idea or bad idea? |
| 17:27.59 | Corydon76-dig | ebroad: #asterisk |
| 17:29.52 | ebroad | Corydon76-dig, right. my real question is a macro call within an extension block supposed to leave exten=s or should it set it back after it returns, i.e. is this by design or a bug? |
| 17:30.36 | Corydon76-dig | Again, #asterisk. This channel is for coordination between bug marshals on existing filed issues, not general Asterisk help |
| 17:30.54 | *** join/#asterisk-bugs Victor_Yure (n=victor@unaffiliated/victoryure/x-837844) |
| 17:30.59 | ebroad | ok |
| 17:31.32 | Corydon76-dig | Seriously, if you aren't a bug marshal, and you don't have a filed issue that you're wanting to discuss, then the discussion belongs in #asterisk |
| 17:38.28 | leifmadsen | M16026 |
| 17:38.31 | MuffinMan | [new] [Asterisk] CDR/General 0016026: cdr blind transfer problem reported by foxfire (Karma: neutral) https://issues.asterisk.org/view.php?id=16026 |
| 17:38.56 | leifmadsen | can anyone tell if this is really a bug, or if this is just the inability for the userfield being set to be inherited to the called channels CDR? |
| 17:45.36 | leifmadsen | M1602 |
| 17:45.38 | leifmadsen | oops |
| 17:45.39 | MuffinMan | [closed] [Asterisk] Applications/app_voicemail 0001602: [patch] MIME boundary text can trigger delays in email from voicemail reported by stevegaarder (Karma: neutral) https://issues.asterisk.org/view.php?id=1602 |
| 17:45.41 | leifmadsen | M16021 |
| 17:45.44 | MuffinMan | [new] [Asterisk] Resources/res_realtime 0016021: sippeers loaded with realtime are treated as type=friends, no matter what type is in the db reported by Guggemand (Karma: neutral) https://issues.asterisk.org/view.php?id=16021 |
| 17:46.01 | leifmadsen | did the 'kill-the-user' stuff happen in 1.6.1 or 1.6.2? |
| 17:47.43 | seanbright | it was revision 128242 |
| 17:49.23 | russellb | 1.6.1 |
| 17:49.25 | seanbright | looks like 1.6.2 |
| 17:49.34 | seanbright | err |
| 17:49.37 | seanbright | yes, that. |
| 17:49.39 | seanbright | heh |
| 17:51.03 | leifmadsen | russellb: ok, so that bug is bogus as that is the expected behaviour, no? |
| 17:51.18 | leifmadsen | and I should point them to UPGRADE.txt I presume |
| 17:51.48 | russellb | no, that does not sound correct |
| 17:51.58 | russellb | the code was not supposed to change any behavior |
| 17:51.59 | leifmadsen | hmmm |
| 17:51.59 | seanbright | that guy was in in #-dev yesterday |
| 17:52.03 | leifmadsen | I see |
| 17:52.29 | leifmadsen | interesting, then I will have to acknowledge this issue |
| 17:52.36 | leifmadsen | he points to part of the code that does the matching |
| 17:52.55 | seanbright | http://pastebin.ca/1598944 |
| 17:55.05 | leifmadsen | seanbright: thanks for the reference! |
| 17:55.16 | seanbright | it is my pleasure to serve you |
| 17:55.23 | leifmadsen | o.O |
| 17:55.36 | seanbright | don't make something dirty out of it. |
| 17:56.10 | leifmadsen | I didn't |
| 17:56.12 | leifmadsen | but now I am |
| 17:56.17 | seanbright | heh |
| 17:56.27 | seanbright | so then i made something dirty out of it |
| 17:56.30 | seanbright | damn. |
| 17:56.49 | leifmadsen | true! |
| 17:59.18 | ebroad | The_Boy_Wonder, ping |
| 18:03.24 | russellb | well, we have passed mantis ID 16000 |
| 18:03.40 | russellb | i'm not sure what that means, but I thought it was interesting |
| 18:03.56 | seanbright | that means we're that much closer to 20000 |
| 18:04.00 | russellb | true. |
| 18:04.15 | russellb | I read in a book about OSS that a very active issue tracker is a sign of a healthy open source project |
| 18:04.19 | russellb | so, yay? |
| 18:04.25 | seanbright | heh |
| 18:04.36 | seanbright | you want to see active bug tracker... look at firefox |
| 18:04.38 | seanbright | heh |
| 18:04.49 | seanbright | they get like hundreds per day |
| 18:05.15 | russellb | they have also had like 23423 billion downloads :-) |
| 18:05.28 | seanbright | true |
| 18:05.32 | russellb | successful, mass market open source software ... |
| 18:05.35 | seanbright | i wasn't saying we weren't healthy |
| 18:05.37 | russellb | i can't imagine dealing with that issue tracker |
| 18:05.39 | russellb | right |
| 18:05.51 | russellb | their user to developer ratio has got to be ridiculous |
| 18:05.59 | seanbright | uh, yeah. |
| 18:06.12 | seanbright | ours hovers around 1 |
| 18:06.16 | seanbright | :) |
| 18:06.25 | russellb | 1 to 1? HA |
| 18:06.33 | seanbright | 1000 to 1? |
| 18:07.12 | russellb | no idea, i would still guess higher, though |
| 18:07.56 | seanbright | i have no idea how popular asterisk is |
| 18:08.03 | seanbright | like how many installs of it there are out there |
| 18:08.08 | russellb | 1.5 million downloads that we could count in 2008 (I think that's what we reported), and that's not including distribution that we can't track, like distro packages |
| 18:08.25 | ebroad | or svn checkouts |
| 18:08.28 | russellb | and from what I hear, 2009 is much higher |
| 18:08.29 | russellb | ebroad: right. |
| 18:08.41 | russellb | so, a lot, is about the best i can do, heh |
| 18:08.46 | seanbright | well i have a script that downloads asterisk tarballs 24/7 |
| 18:09.02 | russellb | seanbright: lol. We had some silly DoS attempts from china that did that :-p |
| 18:09.11 | seanbright | that was me |
| 18:09.12 | seanbright | my bad. |
| 18:09.13 | russellb | figures |
| 18:24.30 | Micc | no one seems to know anything about my error WARNING[10591] channel.c: Exception flag set on 'SIP/dandd4-0f56bf00', but no exception handler |
| 18:25.01 | russellb | looks like a warning, not an error |
| 18:25.02 | russellb | :-p |
| 18:27.14 | The_Boy_Wonder | ebroad, hey I'm back |
| 18:27.27 | ebroad | The_Boy_Wonder, hey |
| 18:27.34 | ebroad | i commented on r392 |
| 18:27.39 | Corydon76-dig | ebroad: see patch on #asterisk |
| 18:27.51 | ebroad | Corydon76-dig, its building now |
| 18:27.58 | Corydon76-dig | k |
| 18:27.59 | ebroad | thanks for taking the time, much appreciated |
| 18:28.11 | Micc | @russellb, yeah its a warning, but the error is that it fills the logs. |
| 18:28.30 | Corydon76-dig | Patch may not be the best possible, but it should work. If codefreeze were around, I'd ask him |
| 18:28.42 | Micc | I'm not sure what makes it stop, but one time it filled over a gig in my logs. This morning it only went for a few thousand lines. |
| 18:28.58 | Micc | and at the time the cpu spikes way up. |
| 18:29.21 | ebroad | Corydon76-dig, its a start, which is important |
| 18:30.21 | The_Boy_Wonder | ebroad, hey, i can't find your comment?! |
| 18:30.35 | ebroad | The_Boy_Wonder, arrg, had to publish |
| 18:30.38 | The_Boy_Wonder | ha |
| 18:30.53 | ebroad | btw, the patch will never override the port when using UDP |
| 18:30.57 | ebroad | only tcp and tls |
| 18:31.12 | ebroad | which are set to their RFC defaults if no config is set |
| 18:31.33 | ebroad | i would assume that this would be the correct behavior |
| 18:33.48 | The_Boy_Wonder | ebroad, here's where i'm confused. *us = externip; <--- that sets the address and port to whatever the externip option was set too.. the switch statement had a default option which would set it to STANDARD_SIP_PORT which would overrided any port set by the externip |
| 18:34.12 | ebroad | right, but we should never hit default |
| 18:34.28 | The_Boy_Wonder | we will everytime TRANSPORT = udp |
| 18:34.46 | ebroad | woops |
| 18:34.50 | The_Boy_Wonder | hehe |
| 18:34.59 | ebroad | for forgot the break under the udp case |
| 18:36.15 | The_Boy_Wonder | and here's the other thing, what if someone expects the port they set in externip to be used for all transports... meaning they left externiptcpport and externiptlsport blank... then we override the port they had set with the tcp and tls defaults |
| 18:37.01 | ebroad | you can't do that with PAT/port redirection, its not possible |
| 18:37.34 | ebroad | tcp and tls have to run on different ports |
| 18:37.42 | The_Boy_Wonder | oh |
| 18:37.49 | ebroad | you cant map an external port on any firewall to multiple internal ports |
| 18:37.51 | ebroad | its one to one |
| 18:38.22 | ebroad | you can have udp/5060 and tcp/5060 but tls would have to run on something else |
| 18:38.57 | ebroad | since its underlying transport is TCP |
| 18:39.09 | file | usually 5061 |
| 18:39.26 | ebroad | right, which is what we should be defaulting to |
| 18:40.14 | ebroad | the only thing i could think of is defualting to the localaddress ports instead of the rfc ports |
| 18:40.41 | ebroad | right now the logic is a little backwards |
| 18:40.41 | The_Boy_Wonder | right, this makes sense to always default for tls, but i'm not sure about tcp if the externtcpport isn't set. because that could be the same as the port set in the externip address |
| 18:40.48 | ebroad | true |
| 18:40.58 | The_Boy_Wonder | what was previous behavior |
| 18:40.59 | *** join/#asterisk-bugs xpot (n=james@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 18:41.16 | The_Boy_Wonder | we just used the global config for everything, even though that was incorrect for tls |
| 18:41.21 | ebroad | but pairing it down to externtlsport only gives us less flexibility |
| 18:41.28 | The_Boy_Wonder | right |
| 18:41.29 | ebroad | yup |
| 18:41.43 | ebroad | if no port was set on externip we used 5060 for everything |
| 18:42.49 | *** part/#asterisk-bugs |Cybex| (n=John@80.100.126.176) |
| 18:43.27 | ebroad | lets resolve this like this: externtlsport defaults to rfc, externtcport defaults to externip port if set to maintain consistency |
| 18:43.40 | ebroad | externtcpport |
| 18:43.52 | The_Boy_Wonder | perfect |
| 18:44.00 | *** join/#asterisk-bugs xpot (n=james@70.91.210.233) |
| 18:44.15 | The_Boy_Wonder | also, it might be worth noting that in the sample.conf file |
| 18:44.45 | ebroad | good point |
| 18:45.00 | ebroad | Corydon76-dig, you are the man, works great |
| 18:45.23 | The_Boy_Wonder | alrighty, i'll be watching for a review update, let me know if you need anything |
| 18:45.46 | ebroad | will do, i gotta run and beat some stubborn servers, ill post an updated diff later on today |
| 18:49.42 | *** join/#asterisk-bugs |Cybex| (n=John@80.100.126.176) |
| 18:58.42 | *** part/#asterisk-bugs |Cybex| (n=John@80.100.126.176) |
| 19:02.40 | *** join/#asterisk-bugs |Cybex| (n=John@80.100.126.176) |
| 19:53.58 | *** join/#asterisk-bugs ebroad (n=EB@72.11.213.195) |
| 19:54.02 | ebroad | The_Boy_Wonder, ping |
| 19:55.10 | The_Boy_Wonder | ebroad, hey |
| 19:55.30 | ebroad | The_Boy_Wonder, updated diff posted |
| 19:56.28 | The_Boy_Wonder | ebroad, nice, i'll take a look at it in a bit |
| 19:56.39 | ebroad | The_Boy_Wonder, sure thing |
| 20:03.22 | *** join/#asterisk-bugs Entomologist (n=nobody@76.164.171.226) |
| 20:03.37 | seanbright | Entomologist: wb! |
| 20:04.01 | leifmadsen | oh snap |
| 21:00.50 | *** join/#asterisk-bugs ebroad (n=EB@72.11.213.195) |
| 21:08.32 | jpeeler | umm, can somebody make sure i'm not crazy and see if the patch for 15944 is against an unpatched version of asterisk? |
| 21:11.38 | seanbright | M15944 |
| 21:11.40 | MuffinMan | [ready for review] [Asterisk] Channels/chan_dahdi 0015944: [patch] if caller ID name is not set dahdi crashes reported by nmav (Karma: neutral) https://issues.asterisk.org/view.php?id=15944 |
| 21:12.56 | seanbright | doesn't apply cleanly to the version the reportor mentions |
| 21:13.01 | seanbright | (1.4.26.1) |
| 21:13.09 | putnopvut | jpeeler: heh, a grep for strncpy in chan_dahdi in 1.4.26 yields nothing |
| 21:13.18 | putnopvut | He may have reported against the wrong version. |
| 21:13.28 | jpeeler | there's no dahdi_callerid struct, no DAHDI_SET_CALLERID ioctl... |
| 21:13.43 | jpeeler | checked in trunk, searched google heh |
| 21:14.02 | putnopvut | jpeeler: nice :) |
| 21:14.06 | seanbright | heh |
| 21:14.07 | putnopvut | Yeah, question him about it. |
| 21:14.30 | jpeeler | just wanted to make sure, today seems to be an off day for me |
| 21:15.00 | seanbright | wow, yeah |
| 21:15.07 | seanbright | that patch is all kindsa fucked |
| 21:26.44 | seanbright | "Was the version of Asterisk reported accurate and originally unmodified? " |
| 21:26.47 | seanbright | jpeeler: no |
| 21:26.56 | seanbright | :) |
| 21:27.11 | jpeeler | heh, i'm trying to be nice |
| 21:28.11 | jpeeler | but attaching a patch for a patched copy seems strange, most of the time a patch isn't attached or the whole file is |
| 21:34.34 | Qwell | that's freaking bizarre |
| 22:01.25 | *** join/#asterisk-bugs ebroad (n=EB@72.11.213.195) |
| 22:01.32 | ebroad | The_Boy_Wonder, ping |
| 22:01.44 | The_Boy_Wonder | ebroad, hey |
| 22:01.56 | ebroad | The_Boy_Wonder, i think your suggestion makes the most sense |
| 22:02.00 | ebroad | i updated the diff |
| 22:02.07 | The_Boy_Wonder | nice, i'll look now |
| 22:09.17 | The_Boy_Wonder | ebroad, what happens if you set both externhost and externip? |
| 22:10.23 | ebroad | which ever one is parsed first |
| 22:10.39 | ebroad | but that would be true for the address parts as well |
| 22:10.45 | mvanbaak | I prefer 'last matching one' |
| 22:10.56 | ebroad | i believe externhost ultimately set externip |
| 22:11.16 | The_Boy_Wonder | yep you're right |
| 22:11.36 | mvanbaak | externhost isn't using dnsmanager ? |
| 22:11.52 | ebroad | i think it does for lookups |
| 22:12.05 | mvanbaak | yes, it does |
| 22:12.16 | mvanbaak | and indeed uses the resolved ip for externip |
| 22:13.10 | ebroad | which makes sense, it leaves you with a single variable to use/check |
| 22:13.55 | mvanbaak | yuppers |
| 22:14.16 | mvanbaak | if you have: |
| 22:14.29 | mvanbaak | externhost = iax.mvanbaak.info |
| 22:14.39 | mvanbaak | externip = 1.2.3.4 |
| 22:14.52 | mvanbaak | I would say, it will use externip = 1.2.3.4 |
| 22:15.03 | ebroad | that would be correct |
| 22:15.06 | ebroad | i believe |
| 22:15.15 | mvanbaak | because it's later in the config file and will overwrite what has been defired before |
| 22:15.34 | mvanbaak | ok, that contradicts your previous statement |
| 22:15.41 | mvanbaak | 00:10 < ebroad> which ever one is parsed first |
| 22:15.46 | ebroad | woops |
| 22:15.51 | The_Boy_Wonder | so, externhost's port isn't dynamic, just the ip right |
| 22:15.51 | ebroad | that should have been parsed last |
| 22:16.14 | mvanbaak | The_Boy_Wonder: indeed |
| 22:16.19 | ebroad | yes, we only get dynamic ports with stun |
| 22:16.26 | mvanbaak | (as far as I can see looking at the code) |
| 22:20.21 | mvanbaak | time for me to leave |
| 22:20.24 | mvanbaak | later all |
| 22:20.26 | ebroad | later |
| 22:20.37 | ebroad | i have to head out in a few as well |
| 22:24.05 | The_Boy_Wonder | ebroad, do you feel good about this getting committed? |
| 22:24.32 | ebroad | The_Boy_Wonder, yes, I have been running various iterations of this patch on my * box |
| 22:25.15 | ebroad | i think the final diff is the least intrusive |
| 22:25.38 | The_Boy_Wonder | nice, well i'm giving it a ship it. I'll go ahead and commit it and close the issue. Excellent work! :) |
| 22:25.56 | ebroad | it shouldn't break tcp or udp, and it will fix TLS |
| 22:26.00 | ebroad | thanx |
| 22:26.03 | The_Boy_Wonder | oh, one minor thing |
| 22:26.07 | ebroad | sure |
| 22:27.15 | Entomologist | *** CLOSED (15998) [Channels/chan_dahdi] [patch] Reset entire span request can result in a crash |
| 22:27.16 | Entomologist | Reported by: tsearle Karma: 14.5 |
| 22:27.16 | Entomologist | https://issues.asterisk.org/view.php?id=15998 |
| 22:27.17 | Entomologist | ********************************************************* |
| 22:27.21 | The_Boy_Wonder | i just didn't feel like putting this in the review because its not important. case statements arn't supposed to be indented according to the coding guidelines, the only reason i know this is because people called me out on it |
| 22:28.04 | The_Boy_Wonder | i'm going to make that minor change and get it into trunk |
| 22:29.16 | ebroad | thanx, habit i guess, when i do code, its in .net and the ide indents case/switch blocks |
| 22:29.29 | russellb | you can tell the IDE not to :-p |
| 22:29.58 | ebroad | i got used to it, so for me its easier to read |
| 22:30.11 | ebroad | though all of my * patches were done in nano |
| 22:30.12 | The_Boy_Wonder | i tend to agree |
| 22:31.08 | ebroad | very cool, i hope this patch helps others aside from myself |
| 22:31.15 | The_Boy_Wonder | :) |
| 22:32.05 | ebroad | because if you can wrap your sip traffic in unsolvable math equations...why not ;) |
| 22:33.24 | ebroad | Corydon76-dig, ping |
| 22:37.17 | ebroad | The_Boy_Wonder, thanx for all your time and help |
| 22:37.30 | ebroad | much appreciated |
| 22:39.58 | Entomologist | *** CLOSED (15880) [Channels/chan_sip/TCP-TLS] [patch] Contact header port ignores transport when using externip |
| 22:39.59 | Entomologist | Assigned to: dvossel |
| 22:39.59 | Entomologist | Reported by: ebroad Karma: 2 |
| 22:40.00 | Entomologist | https://issues.asterisk.org/view.php?id=15880 |
| 22:40.00 | Entomologist | ********************************************************* |
| 22:40.06 | Qwell | OHSNAP |
| 22:40.12 | The_Boy_Wonder | :o |
| 22:40.46 | The_Boy_Wonder | umm i think i need to update the CHANGES for the new sip options |
| 23:00.29 | *** join/#asterisk-bugs putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 23:00.29 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 23:51.21 | Entomologist | *** CLOSED (15683) [Channels/chan_dahdi] [patch] dahdi_read unbalanced ast_mutex_lock and ast_mutex_unlock |
| 23:51.21 | Entomologist | Reported by: alecdavis Karma: 64.5 |
| 23:51.21 | Entomologist | https://issues.asterisk.org/view.php?id=15683 |
| 23:51.22 | Entomologist | ********************************************************* |