| 00:22.36 | *** join/#asterisk-bugs Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 00:22.36 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 01:20.41 | *** join/#asterisk-bugs DavidR2008 (n=chatzill@71.0.16.133) |
| 03:34.54 | *** join/#asterisk-bugs ChanServ (ChanServ@services.) |
| 03:34.55 | *** join/#asterisk-bugs Pagautas (n=bigman@ns.voip.ktu.lt) |
| 03:34.55 | *** join/#asterisk-bugs mvanbaak (n=michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 03:34.55 | *** join/#asterisk-bugs MuffinMan (n=muffinma@asterisk/issue-tracker-bot/muffinman) |
| 03:34.55 | *** join/#asterisk-bugs mnicholson (n=mnichols@nat/digium/x-cnlzsmtkkbqkukvd) |
| 03:34.55 | *** join/#asterisk-bugs Guest10003 (n=Administ@76.73.154.120) |
| 03:34.55 | *** join/#asterisk-bugs ccesario (n=ccesario@189.19.6.236) |
| 03:34.55 | *** join/#asterisk-bugs implicit (n=bayan@unaffiliated/implicit) |
| 03:34.55 | *** join/#asterisk-bugs metallurg (n=mbrick@95.78.194.115) |
| 03:34.55 | *** join/#asterisk-bugs leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 03:34.55 | *** join/#asterisk-bugs ajohnson (n=ajohnson@65-122-4-130.dia.static.qwest.net) |
| 03:34.55 | *** join/#asterisk-bugs Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 03:34.55 | *** mode/#asterisk-bugs [+oooo ChanServ implicit leifmadsen Deeewayne] by irc.freenode.net |
| 03:34.55 | *** join/#asterisk-bugs TheDavidFactor (n=chatzill@fw1.safedataisp.net) |
| 03:34.55 | *** join/#asterisk-bugs The_Boy_Wonder (n=davidvos@asterisk/batman-developer/dvossel) |
| 03:34.55 | *** join/#asterisk-bugs Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 03:34.55 | *** join/#asterisk-bugs russellb (n=russellb@asterisk/digium-open-source-team-lead/russellb) |
| 03:34.55 | *** join/#asterisk-bugs file (n=file@asterisk/developer-and-muffin-lover/file) |
| 03:34.56 | *** join/#asterisk-bugs seanbright (n=sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 03:34.56 | *** mode/#asterisk-bugs [+oooo Qwell russellb file seanbright] by irc.freenode.net |
| 03:34.56 | *** join/#asterisk-bugs Entomologist (n=nobody@76.164.171.226) [NETSPLIT VICTIM] |
| 03:34.56 | *** join/#asterisk-bugs angler (n=angler@pdpc/sponsor/digium/angler) |
| 03:34.56 | *** join/#asterisk-bugs Corydon76-dig (i=yellow@pdpc/supporter/bronze/Corydon76-home) |
| 03:34.56 | *** join/#asterisk-bugs jsmith-away (n=jsmith@asterisk/training-and-documentation-guru/jsmith) |
| 03:34.56 | *** join/#asterisk-bugs _charly_ (i=kroseneg@83.246.112.40) [NETSPLIT VICTIM] |
| 03:34.56 | *** join/#asterisk-bugs Marquis42 (n=bfhbmw0@65-127-126-34.dia.static.qwest.net) [NETSPLIT VICTIM] |
| 03:34.56 | *** mode/#asterisk-bugs [+oo Corydon76-dig jsmith-away] by irc.freenode.net |
| 03:44.56 | *** join/#asterisk-bugs xpot (n=xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 04:00.33 | *** join/#asterisk-bugs Micc (n=Micc@c-71-231-123-28.hsd1.wa.comcast.net) |
| 05:03.10 | *** join/#asterisk-bugs Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) [NETSPLIT VICTIM] |
| 05:03.10 | *** join/#asterisk-bugs leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 05:03.10 | *** join/#asterisk-bugs metallurg (n=mbrick@95.78.194.115) [NETSPLIT VICTIM] |
| 05:03.10 | *** mode/#asterisk-bugs [+oo Deeewayne leifmadsen] by irc.freenode.net |
| 06:17.00 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 08:19.24 | *** join/#asterisk-bugs Hatrix (n=Hatrix@213.201.24.127.static.user.ono.com) |
| 08:46.27 | *** join/#asterisk-bugs oej (n=olle@static-213-115-251-100.sme.bredbandsbolaget.se) |
| 11:09.39 | *** join/#asterisk-bugs caio1982 (i=caio1982@CAcert-br/caio1982) |
| 13:22.49 | *** join/#asterisk-bugs davidbrillert (n=aragon12@h216-235-8-130.host.egate.net) |
| 13:23.37 | *** join/#asterisk-bugs ebroad (n=EB@72.11.213.195) |
| 13:30.32 | Entomologist | *** CLOSED (13028) [Channels/chan_sip/NewFeature] [patch] Add support to handle incoming out-of-dialog SIP NOTIFY requests for "message-summary" event package |
| 13:30.32 | Entomologist | Assigned to: file |
| 13:30.33 | Entomologist | Reported by: AsteriskRocks Karma: 6 |
| 13:30.33 | Entomologist | https://issues.asterisk.org/view.php?id=13028 |
| 13:30.34 | Entomologist | ********************************************************* |
| 13:45.55 | *** join/#asterisk-bugs Whtsup (n=sssi@WimaxUser3715-154.wateen.net) |
| 13:46.02 | Whtsup | hello |
| 13:49.06 | ebroad | ajohnson, ping |
| 13:54.31 | ajohnson | ebroad: pong |
| 13:55.39 | ebroad | i was talking to kpfleming yesterday about your issue with sip and rt |
| 13:56.42 | ebroad | he thinks that there maybe a left over reference when the peer is unregistered and that is why it still exists in the ao2 container |
| 13:57.04 | ebroad | so short circuiting find_peer() which is what my patch did may not be the way to go |
| 13:57.15 | ebroad | let me ask you, do you have rtautoclear set? |
| 14:03.52 | *** join/#asterisk-bugs Deeewayne (n=dwayne@75.76.254.162) |
| 14:03.52 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 14:08.11 | ebroad | ajohnson, when you get a minute ^^^^^^^^^^^^^^^^^^ |
| 14:08.36 | ajohnson | ebroad: sorry |
| 14:08.46 | ebroad | thats ok |
| 14:09.01 | ajohnson | let me check |
| 14:09.31 | ajohnson | though sip prune realtime all did not clear out the peer |
| 14:10.24 | ajohnson | ebroad: looks like the default is yes? |
| 14:10.32 | ajohnson | I don't specifically set it |
| 14:10.35 | ebroad | ok |
| 14:10.48 | ebroad | the default i believe will use the peers expiry then |
| 14:11.10 | ebroad | so when the reg expires, the peer will be cleared |
| 14:11.23 | ajohnson | That's to clear the peer on expire for register |
| 14:11.34 | ajohnson | right, but that's not how realtime works |
| 14:11.58 | ajohnson | it should get the latest data every time, not just every 300 seconds |
| 14:12.53 | ebroad | if you look at the blurb at the to of find peer, it looks like the devs were trying to avoid too many db lookups |
| 14:13.05 | ebroad | *top of find_peer |
| 14:13.35 | ebroad | afaik, rt peer registrations are still cached in memory |
| 14:14.07 | ebroad | so any lookups will still return the peers stale data |
| 14:14.15 | ajohnson | then something needs to be provided to force a refresh |
| 14:14.28 | ajohnson | sip realtime prune all would seem logical |
| 14:14.32 | ajohnson | except it doesn't work |
| 14:14.51 | ebroad | well, when we expire, or when re unregister we should be as well |
| 14:15.12 | ajohnson | except they never expire, they just keep re-registering |
| 14:15.18 | ajohnson | and the peer is never rebuilt |
| 14:15.44 | ebroad | we should be rebuilding when we reregister |
| 14:15.45 | ajohnson | plus I really really need a way to force a reload of a peer |
| 14:15.51 | ajohnson | ok, it isn't |
| 14:16.11 | ebroad | i think i may have found the extra ref |
| 14:16.15 | ajohnson | but that isn't fast enough. If I edit a peer in a database, I need to be able to send Asterisk a command to reload that peer. |
| 14:16.41 | ebroad | im gonna setup a realtime environment to check it out |
| 14:17.31 | ebroad | right, and ill bet, if you setup peer, never register it, prune realtime, and do sip show peer foo, you will see those changes in the cli |
| 14:18.00 | ebroad | that would be change the peers config and then prune realtime |
| 14:18.21 | ebroad | i think we have an errant reference in the code that handles regs |
| 14:19.05 | ajohnson | sip show peer doesn't work with realtime peers |
| 14:19.26 | ebroad | doh, shows you how much i know about rt :) |
| 14:19.33 | ebroad | is there any way to display the peer? |
| 14:19.35 | ajohnson | heh np :) |
| 14:19.38 | file | if you specify 'load' at the end it does |
| 14:19.57 | ebroad | that means its going to the db though, correct? |
| 14:20.04 | ajohnson | so it does |
| 14:20.10 | file | loads forces it to do a realtime lookup |
| 14:20.13 | file | erm load |
| 14:20.46 | ebroad | does show use find_peer? |
| 14:20.50 | file | sure does. |
| 14:20.54 | ebroad | hmm |
| 14:21.02 | ebroad | so that would be a good way toy test |
| 14:21.16 | file | if I remember correctly if you have caching enabled and do sip show peer <blah> load it'll persist afterwards |
| 14:21.22 | ajohnson | ebroad: And the intention of reducing database queries did not appear to work, because Asterisk was still querying for the peer every time. |
| 14:21.29 | ebroad | while i got your attention file :p |
| 14:21.45 | ebroad | ajohnson, yeah, and my patch made it worse ;) |
| 14:22.05 | ebroad | file, do you have a sec to take a look at something |
| 14:22.10 | ajohnson | ebroad: That's my point. Your patch didn't make it worse. Asterisk was still doing the queries anyway |
| 14:22.16 | file | ummm, what is it? |
| 14:23.07 | ajohnson | I take my comment back... maybe it is worse now on the # of queries |
| 14:23.09 | ebroad | opinion on code in chan_sip :) |
| 14:23.28 | file | I'll answer specific well thought out questions ^_^ |
| 14:24.12 | ebroad | i haven't had my coffee yet, so i don't think well |
| 14:24.16 | ebroad | but i have a hunch |
| 14:24.45 | ebroad | svn trunk, line 12778(parse_register_result()) |
| 14:25.12 | file | k |
| 14:25.23 | ebroad | shouldnt there be an unref_peer() there? |
| 14:26.21 | file | I wouldn't think so |
| 14:26.54 | ebroad | ok |
| 14:26.59 | ebroad | scratch that |
| 14:27.03 | file | why do you think so? |
| 14:27.23 | ebroad | well, that little if() block in the else statement |
| 14:27.41 | ebroad | if else() is true, peer->expire will never be -1 |
| 14:27.50 | ebroad | oh wait |
| 14:27.58 | ebroad | the scheduler could set that |
| 14:28.20 | file | dun dun dunnnnnnnnn |
| 14:29.03 | ebroad | arrgh, short circuiting find_peer() is easier than finding errant refs |
| 14:29.40 | file | that's a bad road to go down :P |
| 14:29.43 | ebroad | file, 15967 if you are curious |
| 14:29.53 | ebroad | woops |
| 14:30.05 | ebroad | that should be 1612 |
| 14:30.14 | ebroad | s/1612/16112/ |
| 14:30.25 | file | nods |
| 14:35.31 | Entomologist | *** CLOSED (16027) [Channels/chan_sip/General] [patch] Crash on Pickup or Transfer |
| 14:35.31 | Entomologist | Assigned to: dvossel |
| 14:35.32 | Entomologist | Reported by: ciscofreak Karma: 0 |
| 14:35.32 | Entomologist | https://issues.asterisk.org/view.php?id=16027 |
| 14:35.33 | Entomologist | ********************************************************* |
| 16:27.09 | ebroad | file, ping |
| 16:27.21 | file | pong? |
| 16:28.08 | ebroad | file, that same piece of code i pointed out earlier, shouldn't we schedule expiration for realtime peers as well |
| 16:28.09 | ebroad | ? |
| 16:28.17 | ebroad | currently it looks like we don't |
| 16:28.49 | file | define realtime peer, do you mean a cached or non-cached realtime peer? |
| 16:30.10 | ebroad | non cached, rtcachefriends=no |
| 16:30.24 | file | then no. |
| 16:30.34 | ebroad | why not? |
| 16:30.42 | ebroad | (forgive my ignorance) |
| 16:30.46 | file | because that requires the peer to exist in memory |
| 16:32.06 | ajohnson | file: It must exist in memory, otherwise how does Asterisk keep interracting with the peer while ignoring what's in the database? |
| 16:32.32 | ajohnson | Or a bug was keeping it in memory when it shouldn't have been |
| 16:32.46 | ebroad | thats correct, otherwise i wouldnt need to short circuit find_peer |
| 16:32.48 | file | if rtcachefriends is set to no it should not persist in memory |
| 16:33.05 | ajohnson | ok, so a bug was keeping it in memory... |
| 16:33.08 | file | the peer should be loaded long enough to use the configured values, and then destroyed |
| 16:33.20 | ajohnson | ebroad: So that means the change you made might be appropriate? |
| 16:33.40 | ebroad | if rtcachefriends=no, so a realtime peer should never be found in an ao2 container |
| 16:33.41 | ajohnson | I haven't tested your change with realtime caching turned on though |
| 16:33.59 | ebroad | it'll probably break caching |
| 16:34.01 | ajohnson | or maybe the peer is getting added to the container when it shouldn't |
| 16:34.11 | ebroad | im updating unconditionally |
| 16:34.17 | ajohnson | ok |
| 16:34.21 | ebroad | though i could check for rtcachefriends |
| 16:34.56 | ajohnson | That would work, though it would probably be best to keep the peer from being stored in memory in the first place, or at least removed immediately after use |
| 16:34.56 | file | that change is a hack, it's not the right solution |
| 16:35.07 | ebroad | right |
| 16:35.23 | ebroad | me thinks i need to look at build_peer() |
| 16:58.06 | ebroad | ajohnson, ping |
| 17:04.36 | ajohnson | ebroad: pong |
| 17:04.51 | ebroad | do you mind testing something |
| 17:06.45 | leifmadsen | russellb: ping |
| 17:07.11 | leifmadsen | I just got thinking; for a while there 1.6.2 I don't think could compile chan_h323 -- is that still the case? |
| 17:09.46 | *** part/#asterisk-bugs Hatrix (n=Hatrix@213.201.24.127.static.user.ono.com) |
| 17:10.10 | ajohnson | ebroad: no |
| 17:10.31 | ajohnson | just let me know what to do or if I need to download a patch online |
| 17:11.11 | ebroad | do you have a test instance without my previous patch? |
| 17:18.18 | ebroad | ajohnson, in your prod instance, if you do a show database in the CLI, do your realtime peers show up under the sip registry tree? |
| 17:18.58 | ajohnson | will try it out |
| 17:19.03 | ebroad | thanks |
| 17:19.36 | ebroad | sorry for bugging you, i havent had a chance to setup realtime on my test instance |
| 17:19.37 | ajohnson | Isn't database the asterisk database? |
| 17:19.41 | ebroad | yup |
| 17:19.47 | ebroad | just a hunch |
| 17:19.51 | ajohnson | Only the items in the asterisk database show up |
| 17:19.55 | ajohnson | no peers |
| 17:20.11 | ebroad | is there a sip/registry key/family? |
| 17:20.18 | ajohnson | no |
| 17:20.38 | ebroad | ok |
| 17:20.41 | ebroad | scratch that |
| 17:21.16 | ajohnson | It appears that is not in 1.6.2 |
| 17:21.20 | ajohnson | it shows up in 1.4 |
| 17:21.39 | ebroad | are all your peers realtime? |
| 17:21.51 | jsmith | leifmadsen: Who would be the right person to look at 16139? |
| 17:23.00 | leifmadsen | M16139 |
| 17:23.02 | MuffinMan | [new] [Asterisk] Core/HTTP 0016139: CVE-2008-7220: static-http/prototype.js is vulnerable to "cross-site ajax requests" reported by jcollie (Karma: +91.75) https://issues.asterisk.org/view.php?id=16139 |
| 17:23.23 | leifmadsen | Corydon76-dig: you? |
| 17:23.33 | Corydon76-dig | Me? |
| 17:23.44 | leifmadsen | the issue above, is that in your realm? |
| 17:23.57 | Corydon76-dig | Not really |
| 17:24.03 | leifmadsen | oh wait, that would be Ryan I think |
| 17:24.25 | ajohnson | ebroad: Not all of my peers are realtime |
| 17:24.44 | ajohnson | 6 are not realtime |
| 17:24.45 | leifmadsen | jsmith: I ping'd awk_r about it in #asterisk-gui |
| 17:24.57 | ebroad | are they host=dynamic? |
| 17:25.41 | ajohnson | on |
| 17:25.42 | ajohnson | no |
| 17:25.52 | ajohnson | the realtime peers are, the static ones are not |
| 17:26.02 | ebroad | ok |
| 17:26.05 | ebroad | that makes sense then |
| 17:47.45 | *** join/#asterisk-bugs jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) |
| 18:00.33 | ebroad | ajohnson, rt works as it should for me using the latest svn trunk |
| 18:01.46 | ebroad | ill have to test with 1.6.2 |
| 18:13.25 | *** join/#asterisk-bugs putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 18:13.26 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 18:33.20 | leifmadsen | putnopvut: !!! |
| 18:35.10 | putnopvut | leifmadsen: hello |
| 19:17.54 | *** join/#asterisk-bugs davidbrillert (n=aragon12@h216-235-8-130.host.egate.net) |
| 19:19.03 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 19:19.57 | ajohnson | ebroad: really |
| 19:20.20 | ebroad | ajohnson, yup, changing the context kicks in instantly |
| 19:20.45 | ebroad | ill test with 1.6.2 RCn in a bit |
| 19:22.06 | ajohnson | ok |
| 19:22.14 | ajohnson | your patch didn't get merged, did it? |
| 19:22.54 | ebroad | nope, as file and kpfleming stated, its the wrong way to go about it |
| 19:23.21 | ebroad | for some reason your rt peers are in an ao2 container when they shouldnt be |
| 19:25.42 | ebroad | if you have time to test svn trunk, let me know what happens |
| 19:26.08 | ajohnson | okie dokie |
| 19:26.14 | ajohnson | you changes didn't get merged, did they? |
| 19:26.35 | ebroad | nope, i checked chan_sip just to make sure |
| 19:27.11 | ebroad | and usually the svn bot would update the ticket if it had |
| 19:58.56 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 20:02.56 | ebroad | ajohnson, i am unable to reproduce this on 1.6.2.0-rc3 |
| 20:16.53 | Entomologist | *** CLOSED (15495) [Core/HTTP] [patch] Asterisk runs over end of buffer reading manager input over HTTP and segfaults |
| 20:16.53 | Entomologist | Assigned to: tilghman |
| 20:16.53 | Entomologist | Reported by: pdf Karma: 0 |
| 20:16.54 | Entomologist | https://issues.asterisk.org/view.php?id=15495 |
| 20:16.54 | Entomologist | ********************************************************* |
| 20:21.19 | *** join/#asterisk-bugs mvanbaak (n=michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 20:22.31 | ajohnson | ebroad: I can |
| 20:25.07 | *** join/#asterisk-bugs mvanbaak (n=michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 20:26.48 | *** join/#asterisk-bugs mvanbaak (n=michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 20:27.11 | ajohnson | ebroad: I was able to replicate the issue on SVN trunk on a fresh install on a new server |
| 20:28.12 | ebroad | can you pm or pastebin the realtime section of your sip.conf? |
| 20:29.12 | *** join/#asterisk-bugs mvanbaak (n=michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 20:30.54 | ajohnson | ebroad: ok |
| 20:31.53 | ajohnson | rtcachefriends=no |
| 20:31.59 | ajohnson | rtsavesysname=yes |
| 20:32.04 | ajohnson | that's it |
| 20:32.16 | ajohnson | I can give you all my configs but extensions.conf if you like |
| 20:32.49 | ebroad | can you set rtsavesysname=no |
| 20:32.57 | ajohnson | I can |
| 20:33.08 | ajohnson | but I can't operate that way in the long term |
| 20:34.51 | ebroad | clustering? |
| 20:34.55 | ajohnson | yes |
| 20:35.34 | ajohnson | ebroad: rtsavesysname does not affect it |
| 20:36.21 | ajohnson | ebroad: check out this feature |
| 20:36.21 | ajohnson | rtupdate=yes |
| 20:36.29 | ebroad | i have that explicitly enabled |
| 20:36.30 | ajohnson | I don't have it set, but it seems suspicious |
| 20:36.42 | ajohnson | ok, let me explicitly enable it |
| 20:37.47 | ajohnson | nope, still broken |
| 20:40.38 | ebroad | hmm, im having a hard time breaking it |
| 20:42.28 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 20:42.38 | ajohnson | I'm using Centos 5.3 and MySQL |
| 20:42.47 | ebroad | what version of mysql? |
| 20:43.13 | ajohnson | ODBC drivers or server? |
| 20:43.30 | ajohnson | Though I doubt that's the cause since 1.6.0 does not exibit the problem |
| 20:43.31 | ebroad | server |
| 20:44.12 | ebroad | and out of curiousity, how many realtime peers do you have? |
| 20:44.12 | ajohnson | 5.0 |
| 20:44.34 | ebroad | im testing on slackware 13(x86_64) with 5.1.39 |
| 20:51.34 | *** join/#asterisk-bugs |Cybex| (n=John@atwork-20.r-212.178.82.atwork.nl) |
| 21:17.50 | *** join/#asterisk-bugs oej (n=olle@ns.webway.se) |
| 21:29.01 | *** join/#asterisk-bugs Marquis42 (n=bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 22:37.00 | *** join/#asterisk-bugs albertoandrade (n=albertoa@189.101.111.35) |