| 19:36.45 | *** join/#asterisk-bugs infobot (ibot@rikers.org) |
| 19:36.45 | *** topic/#asterisk-bugs is Asterisk Bugs Discussion -=- http://issues.asterisk.org/ -=- http://asterisk.org/developers/bug-guidelines - Discussions not related to reported issues should be in #asterisk -=- Test bugs marked Ready For Testing! -=- http://xkcd.org/583/ |
| 20:01.58 | *** join/#asterisk-bugs goldenear (~goldenear@2a01:e35:2e58:8df0:21c:b3ff:fec6:943a) |
| 20:04.39 | goldenear | hi there |
| 20:04.57 | goldenear | I've got a question about asterisk and RFC 3581 |
| 20:05.20 | goldenear | it is related to : https://issues.asterisk.org/view.php?id=8855 |
| 20:06.05 | jsmith | ~ask |
| 20:06.06 | infobot | Questions in the channel should be specific, informative, complete, concise, and on-topic. Don't ask if you can ask a question first. Don't ask if a person is there; just ask what you intended to ask them. Better questions more frequently yield better answers. We are all here voluntarily or against our will. |
| 20:06.51 | goldenear | How about the patch ? |
| 20:07.19 | goldenear | Why doesn't it has been merged with branch 1.6 ? |
| 20:07.55 | seanbright | file: ^^^^ |
| 20:07.58 | seanbright | (teehee) |
| 20:10.18 | file | it was a substantial change to make it work properly and because it had behaved the other way for so long I was uncomfortable changing it in other branches |
| 20:11.20 | goldenear | this bug is very annoying and force me to use nat=yes at the moment... otherwise UA using stun but keeping their rfc1819 addr in the via (just adding an rport) won't work :/ |
| 20:17.48 | goldenear | the issue is that at this time support for RFC 3581 is broken :/ |
| 20:19.05 | goldenear | or we have to use nat=yes witch is more than simply replying to src ip/port |
| 20:19.17 | goldenear | any roadmap to change this ? |
| 20:19.39 | file | it has been fixed in trunk, but changing it in earlier versions is substantial and essentially changes the behaviour of chan_sip |
| 20:19.57 | file | from what it has been since it was created to something different, that has the potential to break stuff for other people |
| 20:21.13 | file | that's why I did not backport it |
| 20:28.23 | goldenear | I understand |
| 20:29.09 | goldenear | the patch have kept nat=never and route=route for backward compatility |
| 20:29.23 | goldenear | nat=yes does the same than before |
| 20:29.52 | goldenear | and nat=no would simply be fixed to respect RFC 3581 |
| 20:32.59 | seanbright | but "fixed" for you might be broken for someone else |
| 20:33.04 | seanbright | thus the dilemma |
| 20:40.51 | goldenear | so the RFC is the rule :) |
| 20:41.14 | goldenear | that's why the RFCs are made for :) |
| 20:45.33 | seanbright | well it works properly in trunk (will be 1.8) |
| 20:46.28 | jsmith | goldenear: I'm not sure I understand. Can you explain how the patch applied in bug 8855 doesn't respect RFC 3581? Do you have SIP traces/packet traces and a detailed explanation of what 8855 does wrong? |
| 20:46.52 | file | jsmith: the patch wasn't put into non-trunk branches |
| 20:47.56 | jsmith | file: I understand that. I'm making the assumption though that if we get more info on what he claims is broken, we'll be able to definitively say "Yes, the patch that went into trunk fixed that" or "Ooops, we didn't consider that corner case" |
| 20:49.43 | goldenear | the patch in 8855 fixe the issue about RFC 3581 but break the backward compatibility |
| 21:00.45 | *** join/#asterisk-bugs goldenear_ (~goldenear@2a01:e35:2e58:8df0:21c:b3ff:fec6:943a) |
| 21:22.32 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 21:22.32 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 23:05.19 | goldenear | file: I've juste made a patch for asterisk 1.6 |
| 23:05.20 | goldenear | http://pastebin.com/m42a65241 |
| 23:05.59 | goldenear | it's a simple modification that make work RFC3581 mode as it should |
| 23:07.07 | goldenear | this is conforme to rfc3581 and should not break anything for anybody :) |
| 23:08.39 | goldenear | it works for me : |
| 23:09.29 | goldenear | NAT=no (default) + no rport in via -> send to via address:port |
| 23:10.17 | goldenear | NAT=no (default) + rport in via (generated by ua) -> send to received address:port (conforme to rfc3581) |
| 23:10.30 | goldenear | NAT=route -> same as before |
| 23:10.50 | goldenear | NAT=never -> same as before |
| 23:33.58 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 23:33.58 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 23:54.38 | *** join/#asterisk-bugs goldenear (~goldenear@2a01:e35:2e58:8df0:21c:b3ff:fec6:943a) |