| 01:03.05 | Entomologist | *** CLOSED (16875) [Resources/res_musiconhold] [patch][regression] Cannot specify http:// URL in music-on-hold class directory statement |
| 01:03.06 | Entomologist | Reported by: raarts Karma: 5.25 |
| 01:03.06 | Entomologist | https://issues.asterisk.org/view.php?id=16875 |
| 01:03.07 | Entomologist | ********************************************************* |
| 02:27.50 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 03:14.30 | Entomologist | *** CLOSED (16858) [Core/General] asterisk command history loads as unusable garbage |
| 03:14.31 | Entomologist | Reported by: jw-asterisk |
| 03:14.31 | Entomologist | https://issues.asterisk.org/view.php?id=16858 |
| 03:14.32 | Entomologist | ********************************************************* |
| 03:14.42 | seanbright | there we go |
| 03:14.44 | seanbright | that's much easier |
| 04:37.38 | Entomologist | *** CLOSED (16953) [Applications/app_voicemail/ODBC] [patch] [regression] SQL Syntax Error - Missing Single Quote |
| 04:37.39 | Entomologist | Reported by: elguero Karma: 3.5 |
| 04:37.39 | Entomologist | https://issues.asterisk.org/view.php?id=16953 |
| 04:37.40 | Entomologist | ********************************************************* |
| 05:33.11 | *** join/#asterisk-bugs sip7 (~sip83@69.196.159.201) |
| 05:33.23 | sip7 | Is this a bug? in 1.6.2.5, the "core stop now" sometimes disappears from the "help" command list and it will also not be available for the user. I have to use "kill" |
| 10:22.10 | mvanbaak | that would be a bug indeed |
| 11:44.12 | *** join/#asterisk-bugs corretico (~laguilar@201.201.46.106) |
| 12:24.34 | *** join/#asterisk-bugs caio1982 (~caio1982@CAcert-br/caio1982) |
| 12:47.28 | *** join/#asterisk-bugs caio1982 (~caio1982@CAcert-br/caio1982) |
| 13:06.48 | *** join/#asterisk-bugs xpot (~xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 13:41.45 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:41.45 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 13:49.47 | leifmadsen | M16858 |
| 13:49.50 | MuffinMan | [new] [Asterisk] Core/General 0016858: asterisk command history loads as unusable garbage reported by jw-asterisk https://issues.asterisk.org/view.php?id=16858 |
| 13:49.54 | leifmadsen | reopened? |
| 13:50.56 | leifmadsen | Russell makes a comment, but I'm not sure if it means there is something wrong on F12, or if there is something we should change? He asks the question and the reporter replies, stating he is using some F12 RPM script, but I'm not sure which one, or what he is using it for. |
| 14:16.48 | *** join/#asterisk-bugs elguero (~miguel323@12.187.84.162) |
| 14:32.23 | sip7 | Is 1.6.2.5 production ready, or is it release candidate? |
| 14:35.07 | elguero | sip7: http://lists.digium.com/pipermail/asterisk-dev/2010-March/042827.html |
| 14:37.30 | sip7 | elguero: Ahhh.. thank you! |
| 14:38.20 | elguero | sip7: no problem |
| 14:43.10 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 14:43.10 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 14:43.47 | jsmith | leifmadsen: Ping? |
| 14:43.55 | leifmadsen | jsmith: Pong? |
| 14:44.33 | jsmith | leifmadsen: My opinion on 16858 (for what little it's worth) is while most users won't see that because they're compiling against an internal version of libedit, it's still poor handling on the part of Asterisk |
| 14:58.37 | leifmadsen | jsmith: ok cool -- I'll just let the developers determine how they want to handle it, because I'm not terribly interested in helping that guy too much |
| 14:59.12 | leifmadsen | jsmith: on another note, have you ever tried this? phone (dtmfmode=rfc2833) --SIP--> asterisk --SIP--> provider (dtmfmode=inband) |
| 15:00.03 | leifmadsen | do you know if asterisk accepts the rfc2833 and then sends DTMF via inband on the providers side? (i.e. it converts based on the setting) |
| 15:00.18 | leifmadsen | or does it just pass through as rfc2833 |
| 15:00.19 | jsmith | leifmadsen: I've tried that, but it has been a while. Should work, though |
| 15:00.25 | jsmith | leifmadsen: No, it should convert it |
| 15:00.51 | leifmadsen | huh... ya, having dtmf issues with someone on 1.6.2.2 so I wonder if that's a bug, or if there is a good way to check for that. I guess I'd have to record the audio to see if it is getting put into the audio stream |
| 15:01.02 | leifmadsen | I definitely see the rfc2833 as I can see the start and end frames via debug |
| 15:07.43 | *** join/#asterisk-bugs elguero (~miguel323@12.187.84.162) |
| 15:07.43 | *** join/#asterisk-bugs xpot (~xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 15:07.43 | *** join/#asterisk-bugs caio1982 (~caio1982@CAcert-br/caio1982) |
| 15:18.15 | seanbright | russellb: so how do we handle the libedit debacle? |
| 15:18.35 | seanbright | tell the reporter to report it to fedora? |
| 15:19.48 | jsmith | seanbright: In this case, I don't think it's that simple |
| 15:19.56 | seanbright | of course |
| 15:20.22 | seanbright | so the reporter gets rewarded for his behavior |
| 15:20.24 | seanbright | super. |
| 15:20.45 | leifmadsen | ya no kidding |
| 15:21.00 | seanbright | jsmith: actually, i think it is that simple |
| 15:21.05 | seanbright | asterisk - from source - works fine |
| 15:21.07 | seanbright | there is no bug |
| 15:27.00 | jsmith | seanbright: Well, whether or not you're using an internal or external version of libedit, we should be symmetrical in the way we save and read the history |
| 15:27.33 | jsmith | seanbright: Just because it doesn't exhibit the problem with the internal version of libedit doesn't mean the code isn't wrong :-/ |
| 15:28.04 | seanbright | asterisk - from source - is not capable of linking against an external version of libedit |
| 15:28.05 | jsmith | seanbright: I'm not saying we reward the reporter for his attitude... I'm looking at it *simply* from a technical standpoint |
| 15:28.13 | jsmith | doesn't care *who* is right... only *what* is right |
| 15:28.40 | seanbright | asterisk is only linking against an external libedit because it has been patched by a third party to do so |
| 15:29.07 | seanbright | i could change asterisk to link against an external berkeley db library |
| 15:29.42 | seanbright | does that mean you'd have the modify the internal db library to match the external library's behavior? |
| 15:34.18 | Marquis42 | Since I was trolled into that bug, too, I'm *personally* with seanbright on this one. But I do have to say that his version of the function works with both libedit variants, so there is kind of an "accept liberally" aspect to it. |
| 15:34.45 | jsmith | seanbright: I fully understand *why* he linked to an external version of libedit, due to Fedora's policy |
| 15:35.04 | jsmith | seanbright: But I'm still of the opinion of "be liberal in what you accept, and be strict in what you send" |
| 15:35.05 | seanbright | ok people need to *stop* using *asterisks* so *often* |
| 15:35.15 | seanbright | yes i'm *annoyed* but i am not *beligerant* |
| 15:35.19 | leifmadsen | I don't understand what needs to change? |
| 15:35.19 | seanbright | heh |
| 15:35.34 | leifmadsen | is the bug due to something he changed in Asterisk? |
| 15:35.39 | seanbright | leifmadsen: yes. |
| 15:35.49 | leifmadsen | why was it changed? |
| 15:35.50 | seanbright | not him personally, but the patches from fedora he applies |
| 15:35.54 | seanbright | applied* |
| 15:36.00 | jsmith | leifmadsen: The code in Asterisk that writes out the CLI history isn't perfect... Under normal conditions, you'll never notice it, because of the version of libedit that comes in Asterisk |
| 15:36.18 | jsmith | leifmadsen: Because he's using an external version of libedit, he's seeing the side-effect |
| 15:36.22 | leifmadsen | jsmith: in what circumstances though could it be noticed? |
| 15:36.29 | leifmadsen | jsmith: how is he using an external version of libedit? |
| 15:36.31 | jsmith | leifmadsen: If you're linking to an external version of libedit, rather than the internal one |
| 15:36.40 | seanbright | leifmadsen: via the fedora patch |
| 15:36.55 | leifmadsen | then I don't see how this is our problem -- he is using third party changes |
| 15:37.06 | jsmith | leifmadsen: Fedora has a policy that programs (like Asterisk) shouldn't include their own copies of libraries (like libedit), and should instead link to the system version |
| 15:37.17 | leifmadsen | jsmith: isn't that a fedora issue then? |
| 15:37.19 | jsmith | leifmadsen: Here, let me call you and explain over the phone |
| 15:37.23 | jsmith | leifmadsen: It'll be easier |
| 15:37.27 | leifmadsen | I understand what you're saying |
| 15:37.31 | seanbright | i'd prefer you discuss it here |
| 15:37.55 | leifmadsen | I think here is a better place for this, because I follow what you're saying, I just don't agree with your suggested resolution at this point |
| 15:38.08 | jsmith | leifmadsen: As I see it, it's an inconsistency in Asterisk that most users will never see, because of the version of libedit in use |
| 15:38.17 | elguero | Then you are going to limit Asterisk from being included in distributions if that is the distributions policy, right? |
| 15:38.27 | jsmith | leifmadsen: That being said, it's still an inconsistency in Asterisk, whether it manifests itself or not |
| 15:38.30 | seanbright | elguero: no |
| 15:38.42 | jsmith | elguero: No, they just patch the build system to use the system version of libedit |
| 15:38.46 | leifmadsen | I don't see the inconsistency in Asterisk if this never happens without third-party changes |
| 15:38.47 | seanbright | they just need to create ANOTHER patch to fix the bug in their version |
| 15:38.52 | elguero | I thought seanbright mentioned in the bug report that there was a bug in the internal library that was fixed upstream? Or did I misunderstand something? |
| 15:38.59 | seanbright | elguero: that is correct |
| 15:39.06 | elguero | oh okay |
| 15:39.23 | seanbright | elguero: there is a bug in the internal library, but it works when saving/loading history entries. |
| 15:39.25 | jsmith | would prefer to either update the version of libedit in Asterisk, have Asterisk allow for an external version, or be liberal in what we accept |
| 15:39.25 | leifmadsen | or, if they must create a patch to use an external library, and the bug is in that library, than there is no bug in Asterisk |
| 15:39.35 | seanbright | elguero: so there is a bug in the internal library, but not in asterisk itself. |
| 15:39.36 | jsmith | leifmadsen: The bug isn't in their patch |
| 15:39.43 | seanbright | jsmith: yes it is |
| 15:39.44 | leifmadsen | jsmith: I said in the library |
| 15:39.49 | jsmith | leifmadsen: The bug (if you want to call it that... I'm going to call it an inconsistency) |
| 15:40.02 | jsmith | seanbright: The bug is in the Asterisk code that calls the library, not the library itself |
| 15:40.03 | elguero | right, I get that... there is nothing wrong with asterisk... just the library that it is using and in asterisk it is working with the bug |
| 15:40.08 | seanbright | no it's not |
| 15:40.12 | jsmith | elguero: No, not quite |
| 15:40.21 | elguero | okay, sorry |
| 15:40.30 | seanbright | wow |
| 15:40.36 | seanbright | jsmith: you don't understand the problem |
| 15:40.45 | seanbright | elguero: what you just said was correct |
| 15:41.02 | leifmadsen | bug resides here --> libedit (external) --> patch to use external libraries --> asterisk |
| 15:41.08 | leifmadsen | as is my understanding |
| 15:41.13 | seanbright | let's back up |
| 15:41.17 | leifmadsen | please |
| 15:41.29 | seanbright | main/editline <- there is a bug there (internal libedit) |
| 15:41.40 | jsmith | seanbright: As I see it, it's an inconsistency between ast_el_read_history and ast_el_write_history |
| 15:41.58 | jsmith | seanbright: If there's an actual bug in main/editline, I'm not sure |
| 15:42.05 | seanbright | there is |
| 15:42.09 | seanbright | i am telling you there is |
| 15:42.13 | jsmith | seanbright: OK, I'll believe you |
| 15:42.17 | seanbright | that's good |
| 15:42.27 | jsmith | seanbright: That being said, ast_el_read_history and ast_el_write_history should still be symmetrical |
| 15:42.28 | seanbright | if you review the bug notes, i point out exactly where the bug is |
| 15:42.38 | seanbright | jsmith: they are. if you don't patch asterisk. |
| 15:42.45 | jsmith | If you encode whitespace before writing the history, you should unencode it when you read the history |
| 15:42.49 | seanbright | ok, i'm done with this |
| 15:42.53 | seanbright | you guys handle it how you want |
| 15:43.01 | jsmith | seanbright: I'll go back and re-read the code... I could be wrong |
| 15:43.05 | jsmith | seanbright: I'm sorry to get you upset |
| 15:43.06 | seanbright | since that is the inevitable conclusion to all of this anyway |
| 15:43.12 | seanbright | you're not listening is all |
| 15:43.14 | seanbright | but that's fine. |
| 15:43.25 | jsmith | I'm not listening, and I should be. I'm sorry |
| 15:43.31 | jsmith | shuts his mouth and opens his ears |
| 15:44.12 | seanbright | bad example. imagine we package an internal math library that has an 'add(int a, int b)' function; |
| 15:44.24 | seanbright | and in the internal library, the code for add is this: |
| 15:44.28 | seanbright | return a + b + 1; |
| 15:44.33 | seanbright | which is clearly wrong |
| 15:44.47 | seanbright | but everywhere in asterisk where we call add, it is called like this: |
| 15:44.48 | jsmith | I'm with you so far |
| 15:44.53 | *** join/#asterisk-bugs caio1982 (~caio1982@CAcert-br/caio1982) |
| 15:44.56 | seanbright | int result = add(a, b) - 1; |
| 15:45.02 | jsmith | Still with you |
| 15:45.21 | seanbright | so without intent, we worked around the bug in our internal libedit at some point |
| 15:45.38 | seanbright | based on my looking at svn logs, this is back in the early days of asterisk, like back when it was in cvs |
| 15:46.10 | seanbright | so fedora came along and patched asterisk to use an external libedit |
| 15:46.26 | jsmith | Still with you |
| 15:46.43 | seanbright | which doesn't exhibit the bug. this means that our "work around" in asterisk is using the libedit library incorrectly. |
| 15:46.52 | seanbright | now. |
| 15:47.06 | seanbright | the 100% absolute correct thing to do is: |
| 15:47.11 | seanbright | a) update our internal version of libedit |
| 15:47.22 | seanbright | b) change asterisk to be able to link against the system libedit library |
| 15:47.39 | seanbright | c) fall back on (a) if you can't find (b) |
| 15:47.43 | seanbright | and that is fine |
| 15:48.09 | seanbright | but in this case, this is a bug on the fedora side. along with their patches they should include one to remove our "work around" to the bug |
| 15:48.12 | jsmith | We're in agreement there |
| 15:48.55 | jsmith | As to A, B, and C |
| 15:48.55 | seanbright | you could argue all day that we should work symmetrically with a system libedit |
| 15:49.05 | leifmadsen | b) and c) are feature requests |
| 15:49.17 | jsmith | Sure... b) and c) are feature requests |
| 15:49.21 | leifmadsen | if someone provides a patch for that, then fine, but it is not a bug |
| 15:49.25 | jsmith | If I'm not mistaken, they've already been submitted |
| 15:49.32 | leifmadsen | where? |
| 15:49.46 | jsmith | leifmadsen: If they haven't been submitted in the bug tracker, I'll get jcollie to do so |
| 15:50.06 | seanbright | i have a branch where i am working on updating libedit |
| 15:50.08 | jsmith | leifmadsen: Fedora has a policy of trying to push patches upstream, except in cases where they don't make sense |
| 15:50.13 | seanbright | if i am wasting my time, tell me now |
| 15:50.19 | jsmith | seanbright: No, it's not a waste of time |
| 15:50.24 | leifmadsen | seanbright: no, you're not -- I'm pretty much in agreement with you |
| 15:50.27 | jsmith | very much thinks it's worth doing |
| 15:50.52 | seanbright | most systems ship or have packages for libedit |
| 15:50.57 | leifmadsen | yes, lots of things are worth doing, but in the case of 16858 there is no bug that needs to be fixed -- only feature requests based on the information provided |
| 15:51.04 | seanbright | but for the BEs i think the internal versioin is still needed |
| 15:51.28 | seanbright | though that is above my pay grade |
| 15:51.28 | jsmith | The _only_ question in my mind is that for the bug fix, who should fix the problem... Was it a long-time-ago-poorly-done-hack on the side of Asterisk, or is it a "Fedora should add another patch because they're the one triggering the problem" deal? |
| 15:51.30 | leifmadsen | because to resolve 16858 based on what seanbright is saying, a feature request needs to be provided, at which point it could only go into trunk anyways |
| 15:51.53 | jsmith | seanbright: What do you mean by "BEs"? |
| 15:52.12 | seanbright | business editions |
| 15:52.17 | seanbright | commercial asterisk |
| 15:52.26 | seanbright | oh wait |
| 15:52.27 | seanbright | nevermind |
| 15:52.33 | seanbright | i'm thinking readline |
| 15:53.01 | jsmith | Yeah... I don't know of any modern distro that doesn't provide libedit |
| 15:54.06 | leifmadsen | well at this point, I'd say the issue should be closed about what needs to be done to provide linking to an external library, and that it should be submitted as a separate issue with patches |
| 15:54.22 | seanbright | well the other problem... |
| 15:54.28 | leifmadsen | oh joy! |
| 15:54.33 | leifmadsen | kicks seanbright in the pants |
| 15:54.49 | seanbright | once this is 'fixed' we might have problems with existing .asterisk_history files |
| 15:55.20 | seanbright | actually, no. it will work. |
| 15:55.21 | jsmith | Yeah... good catch |
| 15:55.32 | seanbright | it was still decode properly regardless |
| 15:55.37 | *** join/#asterisk-bugs davidbrillert (~aragon125@h216-235-8-130.host.egate.net) |
| 15:55.45 | seanbright | and then use the new encoding mechanism when necessary |
| 15:55.49 | jsmith | Right... |
| 15:55.56 | seanbright | ok, that's fine then. |
| 15:56.34 | jsmith | The Fedora packager has agreed to submit the "use external libedit" patch |
| 15:56.48 | seanbright | wonderful |
| 15:56.57 | seanbright | well that's clearly a step in the right direction |
| 15:57.26 | jsmith | In the meantime, updating the internal version of libedit wouldn't hurt either |
| 15:57.43 | jsmith | (and again, I'm sorry I was so ugly earlier) |
| 15:57.50 | leifmadsen | ok, I think a note should be made on that issue that states what the problem is, and what the solution to the problem is, and that someone will need to provide patches to resolve it as it is more of a feature request than a bug. Also, I would imagine this can only go into trunk. |
| 15:58.03 | *** join/#asterisk-bugs jpeeler (~jpeeler@asterisk/digium-software-dev/jpeeler) |
| 15:58.07 | seanbright | jsmith: while i think the reporter is a complete asshole, if he had a legitimate bug that i thought to be our responsibility, i would fix it. |
| 15:58.09 | leifmadsen | at least based on my understanding of the issue |
| 15:58.43 | seanbright | jsmith: so it's not just a personal issue i have |
| 15:59.11 | seanbright | leifmadsen: you are correct. |
| 15:59.15 | jsmith | seanbright: I agree re: the reporter, and that the issue is nebulous at best. I think a clear answer of "In order to fix this, here's what we propose" is in order |
| 15:59.27 | seanbright | agreed |
| 15:59.32 | jsmith | Stating actions a), b), and c) above |
| 15:59.41 | jsmith | And state clearly that those are feature requests, and not bugs |
| 16:00.09 | jsmith | Also state that the Fedora packager is aware of the issue, and will be submitting a patch for b) |
| 16:00.25 | leifmadsen | seanbright: would you mind writing that note as you're the one who most clearly understands the situation and can write it succinctly? |
| 16:00.27 | seanbright | is the fedora packager aware of the bug in their patches? |
| 16:00.34 | seanbright | leifmadsen: already working on it |
| 16:00.38 | leifmadsen | seanbright: you're the best! |
| 16:00.58 | jsmith | seanbright: Aye... |
| 16:01.08 | seanbright | excellent |
| 16:01.10 | jsmith | seanbright: The reporter reported the problem to Fedora/RH bugzilla as well |
| 16:01.20 | seanbright | ok, good. |
| 16:01.22 | leifmadsen | was he as big of an asshole there too? |
| 16:01.26 | Marquis42 | Is he as much of an ass there too? |
| 16:01.28 | Marquis42 | heh |
| 16:01.30 | seanbright | heh |
| 16:01.30 | jsmith | leifmadsen: No idea... didn't look |
| 16:01.31 | leifmadsen | Marquis42++ |
| 16:01.34 | *** join/#asterisk-bugs ccesario (~ccesario@189.88.3.2) |
| 16:01.35 | Marquis42 | :D |
| 16:01.41 | seanbright | leifmadsen: based on my research - this is par-for-the-course with him. |
| 16:02.03 | leifmadsen | it's amazing he gets anything done |
| 16:02.18 | seanbright | https://bugzilla.redhat.com/show_bug.cgi?id=174036#c3 |
| 16:02.21 | seanbright | enjoy that one |
| 16:02.42 | seanbright | my favorite part: |
| 16:02.43 | seanbright | Perhaps you should take the time to actually reproduce the steps that |
| 16:02.43 | seanbright | I took to trouble to itemise before mouthing off with ludicrous statements. |
| 16:02.49 | seanbright | heh |
| 16:03.40 | Marquis42 | Well, at least he's consistent... |
| 16:04.00 | leifmadsen | ;) |
| 16:05.33 | *** join/#asterisk-bugs The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 16:10.51 | seanbright | leifmadsen: jsmith: http://seanbright.pastebin.com/UqvXTsmP |
| 16:11.39 | seanbright | he wasn't the one who submitted the issue to fedora, it was someone else |
| 16:12.57 | leifmadsen | seanbright: looks good to me! |
| 16:15.14 | Entomologist | *** CLOSED (16858) [Core/General] [patch] asterisk command history loads as unusable garbage |
| 16:15.15 | Entomologist | Reported by: jw-asterisk |
| 16:15.15 | jsmith | seanbright, leifmadsen: http://seanbright.pastebin.com/iBpxtBnj (slight changes) |
| 16:15.15 | Entomologist | https://issues.asterisk.org/view.php?id=16858 |
| 16:15.16 | Entomologist | ********************************************************* |
| 16:15.20 | seanbright | crap |
| 16:15.22 | jsmith | Oh well... no biggie |
| 16:15.37 | jsmith | I just showed the difference between "short term: Fedora fixes" and "long term: Asterisk changes" |
| 16:15.41 | jsmith | Not a big deal |
| 16:15.49 | jsmith | I can add another note for clarification, if you'd like |
| 16:15.49 | seanbright | right |
| 16:16.04 | seanbright | sorry i didn't wait for feedback. sure. go ahead. |
| 16:16.34 | seanbright | jcollie attached the patch for #2 |
| 16:16.36 | seanbright | to that issue |
| 16:16.54 | leifmadsen | I think he said he attached the patch from Fedora that is the culprit |
| 16:17.08 | leifmadsen | at least that's the impression I got... |
| 16:17.33 | seanbright | meh... it will work for #2. |
| 16:17.37 | leifmadsen | ah ok |
| 16:17.40 | leifmadsen | should it be applied now? |
| 16:17.52 | seanbright | i don't think it handles the 'fallback' scenario |
| 16:18.01 | seanbright | which it will need to before it gets applied |
| 16:18.08 | leifmadsen | ok coolio |
| 16:19.00 | seanbright | looks pretty straight-forward |
| 16:20.01 | jsmith | On the bright side, I just submitted a feature patch for something totally unrelated! |
| 16:20.04 | jsmith | https://issues.asterisk.org/view.php?id=16972 |
| 16:20.50 | seanbright | nifty |
| 16:21.07 | seanbright | if (conference_bridge->users == 1) { |
| 16:21.17 | seanbright | is that just "there is at least 1 user?" |
| 16:21.36 | seanbright | oh nevermind |
| 16:21.42 | seanbright | is not smart today |
| 16:21.54 | russellb | s/today// |
| 16:22.13 | seanbright | you didn't chime in on all of this? |
| 16:22.15 | seanbright | i'm amazed |
| 16:22.29 | seanbright | something like "close it. move on." is what i was expecting |
| 16:22.30 | russellb | i haven't been paying attention |
| 16:22.36 | seanbright | ah |
| 16:22.39 | russellb | you know me well, though |
| 16:23.00 | file | don't fall for it, that statement is a trap! |
| 16:23.14 | leifmadsen | I just think its funny he chimes in right at the point where he can correct you with a regex :) |
| 16:23.43 | jsmith | seanbright: I could have said if (conference_bridge->users >= 1) { |
| 16:23.57 | jsmith | seanbright: but it would just be additional overhead that doesn't do anything useful... |
| 16:24.17 | *** join/#asterisk-bugs Deeewayne (~dwayne@75.76.254.162) |
| 16:24.17 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 16:24.26 | jsmith | (No reason to continue to set the dev state to INUSE when you know there's already at least one persons in the conference) |
| 16:24.48 | jsmith | If we wanted to get fancy, we could put it in a RINGING state while non-marked users are waiting for the marked user |
| 16:24.58 | jsmith | But I don't have time to code that this morning |
| 16:26.01 | seanbright | leifmadsen: he wasn't correcting me. he was insulting me. heh. |
| 16:26.05 | seanbright | so his timing was even better. |
| 16:26.28 | leifmadsen | seanbright: well, its your opinion he wasn't correcting you :) |
| 16:26.38 | russellb | close it and move on already |
| 16:26.40 | russellb | :-p |
| 16:28.24 | russellb | even the libedit we have works _perfectly fine_ |
| 16:29.31 | russellb | this whole bug was a complete waste of time for everyone involved |
| 16:31.23 | russellb | (except perhaps those in charge of breaking asterisk in fedora, but finding that out was done at our expense) |
| 16:31.35 | russellb | moving on kthx! |
| 16:32.39 | seanbright | heh |
| 16:32.59 | seanbright | you don't own me, man |
| 16:33.39 | russellb | this is true |
| 16:36.01 | Corydon76-dig | purchases seanbright |
| 16:39.02 | jsmith | Hey, while we're on the topic of Fedora patches... anybody wanna look at https://issues.asterisk.org/view.php?id=16155 |
| 16:40.27 | seanbright | i really want to require pkg-config to regenerate configure |
| 16:40.28 | russellb | what if pkg-config isn't there? I'd rather it fall back to the existing method of using the library provided tool |
| 16:40.44 | seanbright | there are some macros that make checking for this stuff easier |
| 16:41.44 | russellb | that was my 1-lien review of the patch referenced |
| 16:43.30 | *** join/#asterisk-bugs ccesario_ (~ccesario@189.88.3.2) |
| 19:10.51 | Entomologist | *** CLOSED (16930) [Applications/app_followme] [patch] [regression] app_followme playing wrong sound files |
| 19:10.51 | Entomologist | Reported by: ianc Karma: 0 |
| 19:10.52 | Entomologist | https://issues.asterisk.org/view.php?id=16930 |
| 19:10.52 | Entomologist | ********************************************************* |
| 19:22.55 | *** join/#asterisk-bugs corretico (~laguilar@201.201.46.106) |
| 19:30.44 | Entomologist | *** CLOSED (16902) [Channels/chan_dahdi] Compile fails in dahdi_show_status with kernel 2.6.33 |
| 19:30.45 | Entomologist | Reported by: colbec |
| 19:30.45 | Entomologist | https://issues.asterisk.org/view.php?id=16902 |
| 19:30.46 | Entomologist | ********************************************************* |
| 19:43.05 | *** join/#asterisk-bugs corretico (~laguilar@201.201.46.106) |
| 20:21.57 | *** join/#asterisk-bugs TheDavidFactor (~chatzilla@nc-71-0-16-133.dhcp.embarqhsd.net) |
| 20:53.14 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 20:53.14 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 21:01.54 | *** join/#asterisk-bugs TheDavidFactor (~chatzilla@nc-71-0-16-133.dhcp.embarqhsd.net) |
| 23:29.58 | Marquis42 | Corydon76-dig: I saw you tried to reproduce the crash in issue 16876. Do you have any kind of distributed events compiled and configured? |