| 05:53.14 | Corydon76-dig | Marquis42: I do not |
| 05:54.03 | Corydon76-dig | Marquis42: but if the crash cannot be reproduced outside of that branch, then the issue is within that branch |
| 10:13.22 | *** join/#asterisk-bugs codefreeze-lap (~murf@mail.parsetree.com) |
| 12:59.47 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 13:00.51 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:00.51 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 13:16.43 | *** join/#asterisk-bugs miguel3239 (~miguel323@ns1.nashuacs.com) |
| 13:24.28 | leifmadsen | russellb: w00t! bamboo caught an XML parsing bug! |
| 13:34.07 | mvanbaak | leifmadsen: do you happen to know if we can test a branch with bamboo before merging it to trunk ? |
| 13:34.10 | *** join/#asterisk-bugs Deeewayne (~dwayne@c-71-207-214-190.hsd1.al.comcast.net) |
| 13:34.10 | *** mode/#asterisk-bugs [+o Deeewayne] by ChanServ |
| 13:42.39 | russellb | mvanbaak: it is possible, yes |
| 13:43.07 | russellb | though we need to do some work to make it easy |
| 13:44.13 | russellb | thinks |
| 13:44.29 | russellb | actually, as long as you have permissions to create build plans in bamboo, it already is easy |
| 13:46.09 | russellb | which I don't see a problem with providing committers |
| 13:46.15 | russellb | providing to* |
| 13:46.50 | russellb | leifmadsen: w00t indeed |
| 13:50.19 | russellb | leifmadsen: mnicholson's external test that does a blind transfer has also found a really nasty crash |
| 13:54.48 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 14:06.52 | Deeewayne | russellb, ping |
| 14:10.04 | russellb | ohai |
| 14:10.08 | Deeewayne | hey |
| 14:10.11 | Deeewayne | how's it going? |
| 14:10.17 | russellb | pretty good!, you? |
| 14:10.22 | Deeewayne | good, thanks |
| 14:10.54 | russellb | res_fax is in trunk now :-) |
| 14:10.55 | Deeewayne | I was just wondering what the rational was for changing the copyrights on the taskprocessor modules from Dwayne Hubbard to Digium was |
| 14:11.04 | Deeewayne | M248226 |
| 14:11.06 | MuffinMan | Failed to retrieve issue page for 248226. Does it exist? |
| 14:11.18 | Deeewayne | yeah, I saw that. congrats :-) |
| 14:11.41 | mvanbaak | russellb: nice |
| 14:12.04 | mvanbaak | russellb: I just thought it would be a good test. with all the unit tests etc |
| 14:12.05 | russellb | ah, that's just how the terms of employment work. any asterisk code you write while employed by digium is copyright digium |
| 14:12.13 | russellb | mvanbaak: indeed |
| 14:12.16 | mvanbaak | make sure everything is ok before merging it |
| 14:12.24 | russellb | mvanbaak: of course, they can be run manually before merge, too :-) |
| 14:12.32 | mvanbaak | yeah |
| 14:12.57 | mvanbaak | hhmm, idea |
| 14:13.08 | mvanbaak | will take some time to implement it but hear me out |
| 14:13.14 | Deeewayne | oh, so all modules written by any digium employees were changed to copyright digium? |
| 14:13.28 | russellb | yup, i've been fixing a number of headers as I see them |
| 14:13.33 | russellb | this was not a specific case by any means |
| 14:13.48 | mvanbaak | stuff that gets posted on reviewboard -> bamboo -> if ok, add a shipit from the bamboo user/if not ok, add a comment with the error |
| 14:13.51 | russellb | (your name as the author is still there, of course) |
| 14:14.21 | russellb | mvanbaak: heh, that would be tricky to automate |
| 14:14.30 | mvanbaak | I know |
| 14:14.36 | mvanbaak | but wouldn't it be sexy ? |
| 14:14.43 | russellb | sure :-) |
| 14:15.00 | russellb | I welcome any interested help in doing infrastructure improvements like that ;-) |
| 14:15.13 | russellb | but first we need to get these new VMs in bamboo ;-) |
| 14:15.19 | mvanbaak | yup ;) |
| 14:15.36 | russellb | that's next on my list after I get the external test suite integrated |
| 14:15.47 | mvanbaak | cool |
| 14:15.50 | russellb | i got derailed because the first external test is showing a nasty crash in trunk, heh |
| 14:15.59 | russellb | but i'm about to commit a fix |
| 14:16.10 | mvanbaak | I'll start reading up on the api for bamboo and rb |
| 14:16.18 | mvanbaak | maybe something can be automated there |
| 14:16.30 | russellb | and by "about to", I mean "just did" |
| 14:20.18 | mvanbaak | lol |
| 14:20.32 | mvanbaak | hhmm, the reviews and diffs for a review can be fetch pretty easily |
| 14:23.04 | russellb | bamboo probably has a really nice API, though I haven't looked |
| 14:23.23 | russellb | the JIRA API is very good though (product from the same company) |
| 14:26.31 | mvanbaak | hhmm, it's not possible to create a new plan using the api (at first look) |
| 14:26.59 | russellb | it might have to be a special predefined reviewboard plan ... |
| 14:27.27 | russellb | and perhaps the script it runs to do the build/test could pull diff test requests off of a queue |
| 14:27.52 | mvanbaak | yeah |
| 14:28.05 | mvanbaak | was thinking that way as well |
| 14:28.15 | mvanbaak | you can put a build into the queue |
| 14:28.19 | mvanbaak | with the api |
| 14:28.26 | leifmadsen | w00t external test suite crash finding! (and ultimate fixing!) |
| 14:28.33 | russellb | and you just say "run the reviewboard test plan", and runs the script which pulls from the queue and tests the proper branch, patch, etc |
| 14:28.58 | russellb | leifmadsen: seems appropritate that it would be a transfer bug, heh |
| 14:29.11 | mvanbaak | so make the special plan not run automagically, but wait for the instruction, probably with a variable to tell it what review id to use |
| 14:30.11 | russellb | http://bamboo.asterisk.org/build/viewBuildResultsSuccessfulTests.action?buildKey=AST-TRUNKTESTING&buildNumber=18 |
| 14:30.19 | russellb | finally, external test suite integrated and passing! |
| 14:30.50 | mvanbaak | niiiiiiiice ! |
| 14:31.02 | leifmadsen | so hawt |
| 14:31.04 | leifmadsen | I need to built some tests |
| 14:31.06 | leifmadsen | build* |
| 14:31.12 | leifmadsen | but first, I should finish that RC release |
| 14:31.27 | russellb | heh |
| 14:32.11 | leifmadsen | oh god, the fiancee is going dress shopping today |
| 14:32.20 | leifmadsen | luckily I will just be cruising downtown with friends jumping between bars :) |
| 14:32.21 | mvanbaak | nice |
| 14:32.30 | mvanbaak | it means you have all the time of the world |
| 14:32.32 | russellb | leifmadsen: drink! |
| 14:32.53 | leifmadsen | russellb: yes, I will be drinking fruit juices all day! |
| 14:33.25 | russellb | and by fruit, you mean ... hops? |
| 14:33.43 | leifmadsen | potentially |
| 14:33.50 | mvanbaak | I hope so |
| 14:33.53 | leifmadsen | there will likely be a ceasar in there somewhere |
| 14:34.12 | leifmadsen | gonna be about 8C out today and super sunny |
| 14:34.18 | leifmadsen | pretty excited to get out there |
| 14:35.00 | leifmadsen | its too bad all the XML documentation wasn't in a single module or location |
| 14:35.04 | leifmadsen | that'd make it so much easier to review |
| 14:35.29 | leifmadsen | I mean, I can review the core-en_US.xml file, but modifying the code will just take a bit longer |
| 14:36.05 | leifmadsen | continues to think out loud while he waits for this script to run |
| 14:37.23 | leifmadsen | oh eff! I just realized I'm going to have to re-create these releases now because the -summary files are going to be very wrong |
| 14:37.36 | russellb | leifmadsen: :-( |
| 14:37.49 | leifmadsen | sad face indeed |
| 14:38.06 | russellb | don't think you'll be able to generate one at all |
| 14:38.09 | leifmadsen | I guess I just can't create a release summary for anything but the first RC at this point... |
| 14:38.15 | russellb | until we fix it to handle what we talked abotu a few weeks ago |
| 14:38.24 | russellb | yes, we are on the same page, heh |
| 14:38.28 | leifmadsen | :D |
| 14:38.45 | leifmadsen | maybe I should just stop creating release summary files altogether until it gets fixed |
| 14:38.55 | leifmadsen | because it will be inaccurate unless the first RC gets released |
| 14:39.24 | russellb | for RCs you mean? |
| 14:39.34 | russellb | or actually, just period, huh |
| 14:40.23 | leifmadsen | well, because of the way the summary files are generated, they only get generated correctly when you run a mkrelease directly against a branch (i.e latest changes) which is an RC1. Beyond that, they will always be wrong. |
| 14:40.34 | russellb | right.. |
| 14:40.42 | russellb | so I need to fix that super soon, then |
| 14:40.50 | russellb | did we finish our documentation of required changes on wave? |
| 14:40.52 | leifmadsen | ya, exactly -- these summary files we've been including have practically been useless (and potentially harmful) if people were using them to determine what changed |
| 14:41.01 | leifmadsen | I think we pretty much finished it ya |
| 14:41.04 | russellb | ok.. |
| 14:41.06 | russellb | HRM |
| 14:41.13 | russellb | sounds like a project for this week. |
| 14:41.27 | leifmadsen | ya, at this point I think I'm just gonna stop using release summary files |
| 14:41.33 | leifmadsen | which means I have to rebuild these tags |
| 14:41.43 | leifmadsen | I'll just revert the summary files |
| 14:41.51 | leifmadsen | then re-build the tarballs |
| 14:42.11 | russellb | that's what I'd do. |
| 14:42.14 | leifmadsen | aye |
| 14:42.22 | leifmadsen | and what I will inadvertantly do as well |
| 14:42.30 | leifmadsen | shakes his fist at mkrelease :D |
| 14:42.41 | russellb | at least we have a plan for fixing it |
| 14:42.44 | russellb | that's ... a start |
| 14:42.47 | leifmadsen | although it does make the process significantly easier in most cases |
| 14:42.53 | leifmadsen | yay starts! :) |
| 14:43.05 | russellb | starts are easier than finishes |
| 14:44.25 | leifmadsen | man, learning how to revert the latest commit has been super handy lately ... |
| 14:44.43 | russellb | do you know how to revert any commit? |
| 14:45.05 | russellb | svn merge -c -<rev> . && svn commit -m "revert rev <rev>" |
| 14:45.15 | leifmadsen | I haven't got that far..... I've been using: svn merge -c -<revision> . |
| 14:45.21 | leifmadsen | oh, that works for any revision? nice! |
| 14:45.28 | leifmadsen | I was thinking it'd revert anything from that revision forward |
| 14:46.03 | russellb | nope, reverts that rev specifically |
| 14:46.31 | leifmadsen | mad hawtness |
| 14:46.37 | leifmadsen | now I just want to start reverting things |
| 14:46.42 | leifmadsen | resists |
| 16:57.15 | *** join/#asterisk-bugs sgimeno (~chatzilla@81.37.152.168) |
| 21:02.05 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 22:49.35 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |