| 00:26.55 | Entomologist | *** CLOSED (17667) [Resources/res_fax] [patch] update res_fax to the xml documentation style |
| 00:26.55 | Entomologist | Reported by: snuffy |
| 00:26.56 | Entomologist | https://issues.asterisk.org/view.php?id=17667 |
| 00:26.56 | Entomologist | ********************************************************* |
| 00:57.38 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 01:13.46 | Entomologist | *** CLOSED (17639) [Resources/res_srtp] Crash when hangup a srtp call |
| 01:13.46 | Entomologist | Reported by: vrban |
| 01:13.47 | Entomologist | https://issues.asterisk.org/view.php?id=17639 |
| 01:13.47 | Entomologist | ********************************************************* |
| 05:50.58 | philipp64 | can someone please change the status of 17665 to "patch tested and verified"? thanks. |
| 06:26.43 | *** join/#asterisk-bugs mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |
| 06:30.57 | *** join/#asterisk-bugs mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |
| 12:47.11 | *** join/#asterisk-bugs mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |
| 16:59.14 | Entomologist | *** CLOSED (17616) [Core/BuildSystem] [patch] Configure sets ac_cv_fork_works=no incorrectly for uclibc |
| 16:59.15 | Entomologist | Reported by: pprindeville |
| 16:59.15 | Entomologist | https://issues.asterisk.org/view.php?id=17616 |
| 16:59.16 | Entomologist | ********************************************************* |
| 17:00.58 | philipp64 | Corydon76-dig: thanks. |
| 17:14.33 | Corydon76-dig | Understand that configure is a rendered file. You cannot just patch that file and expect that it will stay that way. |
| 17:16.16 | philipp64 | right. but I've been told that whenever I patch configure.ac or autoconf/*.m4, I'm expected to generate a new configure file and diff it as part of the patch, so there's no disagreement between configure's source components and configure itself at any given time. |
| 17:16.18 | MuffinMan | Failed to retrieve issue page for 4. Does it exist? |
| 17:21.02 | philipp64 | on M17665, can someone please delete attachment 17665.diff ? it was not against rHEAD and doesn't apply cleanly (it conflicts with 276909). thanks. |
| 17:21.04 | MuffinMan | [ready for testing] [Asterisk] Channels/chan_sip/General 0017665: [patch] Regression: Externip has port set to 0 reported by mmichelson https://issues.asterisk.org/view.php?id=17665 |
| 17:27.44 | philipp64 | Corydon76-dig: was there a reason that the 3rd part of the patch was left out? |
| 17:28.08 | philipp64 | is it because of the external repo? |
| 17:32.41 | philipp64 | Corydon76-dig: did that just go into the wrong repo? |
| 17:33.02 | philipp64 | you committed into 1.4, not 1.6.2 or trunk. |
| 17:35.13 | *** join/#asterisk-bugs tzafrir (~tzafrir@212.179.75.202) |
| 17:35.42 | Corydon76-dig | 3rd part? |
| 17:37.04 | Corydon76-dig | Oh. completely different repo |
| 17:37.45 | philipp64 | that... and menuselect had the same cruft in menuself/acinclude.m4 ... but I assume that menuselect doesn't fork() anyway... so it's a moot point. |
| 17:37.47 | MuffinMan | Failed to retrieve issue page for 4. Does it exist? |
| 17:38.00 | philipp64 | it also only gets run on the build machine, not the target. |
| 17:38.11 | Corydon76-dig | Correct, so it's mostly irrelevant |
| 17:39.55 | philipp64 | ok... might be simpler to leave things consistent. but either way is fine. |
| 17:40.28 | Corydon76-dig | On differing repos, consistency is irrelevant. Consistency only matters between multiple branches on the same repo |
| 17:42.34 | Entomologist | *** CLOSED (17616) [Core/BuildSystem] [patch] Configure sets ac_cv_fork_works=no incorrectly for uclibc |
| 17:42.35 | Entomologist | Assigned to: tilghman |
| 17:42.35 | Entomologist | Reported by: pprindeville |
| 17:42.36 | Entomologist | https://issues.asterisk.org/view.php?id=17616 |
| 17:42.36 | Entomologist | ********************************************************* |
| 17:47.36 | Corydon76-dig | You should wait a bit before reopening issues for that reason |
| 17:49.43 | philipp64 | ok. I was just caught a little offguard... I thought 1.4 and 1.6 wouldn't be picking up any fixes that weren't critical, so I was surprised when it didn't first go into trunk. |
| 17:50.06 | Corydon76-dig | btw, for patches on mantis, diffing configure isn't necessary or even desireable |
| 17:50.27 | Corydon76-dig | The only time when we care about regenerating configure are for people who actually commit into the repo |
| 17:50.52 | philipp64 | why's that? it's sometimes a little difficult to figure out what a .m4 change will look like once it goes through the machinery... |
| 17:50.54 | MuffinMan | Failed to retrieve issue page for 4. Does it exist? |
| 17:51.01 | Corydon76-dig | (or for people who don't have autoconf/automake on their systems) |
| 17:51.26 | philipp64 | (I've been stung by not using enough quoting in m4 plenty of times...) |
| 17:51.27 | MuffinMan | Failed to retrieve issue page for 4. Does it exist? |
| 17:52.04 | Corydon76-dig | For all intents and purposes, 'configure' is a binary file |
| 17:52.35 | philipp64 | ok. |
| 17:53.39 | Corydon76-dig | It's relevant when you need non-developers to do testing, but not relevant for developers to commit |
| 17:54.36 | philipp64 | btw, if you have a moment, can you delete 17665.diff from 17665? it was generated against an out-of-date revision. |
| 17:54.42 | philipp64 | thanks. |
| 17:55.12 | philipp64 | I backreved, patched, and upreved again, then generated new diffs and posted those. |
| 17:55.37 | philipp64 | oh, and please update the status as "fix tested" or whatever. |
| 18:01.52 | philipp64 | Corydon76-dig: did you intend other changes to go in the same commit? include/asterisk/autoconfig.h.in got modified in r277776 |
| 18:02.57 | philipp64 | Corydon76-dig: thanks for updating 17665. |
| 18:04.24 | Corydon76-dig | philipp64: Again, that is a RENDERED file |
| 18:05.14 | Corydon76-dig | Just like configure |
| 18:05.30 | philipp64 | ok. thought that your repo might have had residue left over from other work that accidentally got included. |
| 18:06.17 | Corydon76-dig | The svnmerge tool explicitly prohibits that |
| 18:10.15 | philipp64 | good to know. |
| 18:21.32 | *** join/#asterisk-bugs philipp64|laptop (~chatzilla@mail.redfish-solutions.com) |
| 18:30.26 | *** join/#asterisk-bugs philipp64 (~chatzilla@mail.redfish-solutions.com) |
| 18:40.29 | *** join/#asterisk-bugs philipp64|laptop (~chatzilla@mail.redfish-solutions.com) |
| 22:06.27 | *** join/#asterisk-bugs mpe (~mpe@0x4dd624b2.adsl.cybercity.dk) |