| 00:15.00 | Marquis42 | leifmadsen: Have a minute to talk about m18350? |
| 00:15.01 | MuffinMan | [acknowledged] [Asterisk] Channels/chan_sip/General 0018350: asterisk crash when setting outbound mwi subscription in sip.conf reported by gbour https://issues.asterisk.org/view.php?id=18350 |
| 00:44.52 | leifmadsen | Marquis42: sure |
| 00:45.55 | Marquis42 | leifmadsen: OK, well the question really boils down to whether I fix it the easy way and stick to the letter of the sample config or whether I continue down the hard path and not waste somebody's effort in supporting multiple transport types for mwi subscriptions. :/ |
| 00:46.15 | leifmadsen | o.O |
| 00:46.17 | leifmadsen | hmmmm |
| 00:46.20 | Marquis42 | Heh |
| 00:46.40 | Marquis42 | The sample config suggests something like: mwi => 1234:password@mysipprovider/1234 |
| 00:46.46 | leifmadsen | vs? |
| 00:47.34 | Marquis42 | That's easy. But really, except the front-end parsing the rest of the code supports transports and ports, so something like this is possible (assuming I write the parser...): 1234:password@tcp://mysipprovider.com:5060/1234 |
| 00:47.47 | leifmadsen | oh yuck |
| 00:48.00 | Marquis42 | Oh, it's ugly. No doubt about that. But it *could* work. |
| 00:48.01 | Marquis42 | :) |
| 00:48.02 | leifmadsen | I've seen this path before with register => |
| 00:48.06 | leifmadsen | I don't like it |
| 00:48.13 | Marquis42 | Absolutely, this is exactly the same kind of thing. |
| 00:48.29 | leifmadsen | that's the wrong way to solve it. We should not make that string complex and have to fix 12 bugs to get it right |
| 00:48.31 | Marquis42 | The simple fix just means we will only support udp transport. |
| 00:48.36 | Marquis42 | heh |
| 00:48.39 | Marquis42 | Agreed |
| 00:48.47 | leifmadsen | I'd rather see a different thing entirely if we want to support multiple options like: |
| 00:49.09 | leifmadsen | [mwi] |
| 00:49.10 | leifmadsen | ... |
| 00:49.16 | leifmadsen | not sure exactly what it'd look like |
| 00:49.22 | leifmadsen | or an mwi.conf or something |
| 00:49.25 | Marquis42 | Right |
| 00:49.29 | leifmadsen | [mwi_provider] |
| 00:49.38 | Marquis42 | And that's not a 1.8 fix kind of thing. |
| 00:49.40 | leifmadsen | transport=udp,tcp |
| 00:49.42 | leifmadsen | right |
| 00:49.51 | leifmadsen | just do the easy fix |
| 00:50.00 | leifmadsen | that's the bug fix, then we can discuss how we'd do the more extensive one |
| 00:50.02 | leifmadsen | oh! |
| 00:50.05 | Marquis42 | OK, then I'll go with that. Thanks for talking it through. |
| 00:50.06 | leifmadsen | and add some documentation there |
| 00:50.12 | Marquis42 | Absolutely! |
| 00:50.15 | leifmadsen | "Only UDP is supported..." |
| 00:50.16 | leifmadsen | etc |
| 00:50.21 | Marquis42 | Indeed |
| 00:52.22 | Marquis42 | Thanks again |
| 00:52.31 | leifmadsen | np, thanks! |
| 00:54.46 | Marquis42 | Not a problem. This was actually kinda fun. :) |
| 01:03.04 | leifmadsen | :D |
| 01:03.05 | leifmadsen | weee!@ |
| 01:03.11 | Marquis42 | haha |
| 03:02.36 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 03:47.28 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 07:55.32 | *** join/#asterisk-bugs mpe (~mpe@gate.ipvision.dk) |
| 07:58.14 | *** join/#asterisk-bugs tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 09:37.21 | *** join/#asterisk-bugs mpe_ (~mpe@gate.ipvision.dk) |
| 09:37.54 | *** join/#asterisk-bugs mpe (~mpe@gate.ipvision.dk) |
| 12:20.21 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:20.21 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
| 14:11.54 | *** join/#asterisk-bugs infobot (~infobot@rikers.org) |
| 14:11.54 | *** topic/#asterisk-bugs is Asterisk Bugs Discussion -=- http://issues.asterisk.org/ -=- http://asterisk.org/developers/bug-guidelines - Discussions not related to reported issues should be in #asterisk -=- Join #asterisk-testing for help with testing issues marked Ready for Testing -=- http://xkcd.org/583/ -=- An issue tracker full of activity is a sign of a healthy project |
| 15:13.13 | *** join/#asterisk-bugs putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:13.13 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 17:31.09 | *** join/#asterisk-bugs The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 18:04.40 | *** join/#asterisk-bugs bbryant (~brett@c-76-26-221-79.hsd1.sc.comcast.net) |
| 18:04.40 | *** mode/#asterisk-bugs [+o bbryant] by ChanServ |
| 21:26.18 | *** join/#asterisk-bugs elguero (~miguel323@ns1.nashuacs.com) |
| 21:57.06 | *** join/#asterisk-bugs Entomologist (~nobody@nat/digium/x-swktvkruzjapkqpu) |
| 22:00.34 | Entomologist | *** CLOSED (18051) [Channels/chan_sip/General] SIP brute force attemps having a DoS effect |
| 22:00.34 | Entomologist | Reported by: eeman |
| 22:00.35 | Entomologist | https://issues.asterisk.org/view.php?id=18051 |
| 22:00.35 | Entomologist | ********************************************************* |
| 22:59.08 | *** join/#asterisk-bugs tzafrir_laptop (~tzafrir@bzq-218-155-146.cablep.bezeqint.net) |
| 23:20.20 | *** join/#asterisk-bugs seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 23:20.20 | *** mode/#asterisk-bugs [+o seanbright] by ChanServ |
| 23:40.43 | *** join/#asterisk-bugs tzafrir (~tzafrir@212.179.75.202) |