| 04:34.04 | *** join/#asterisk-bugs irroot (~gregory@197.105.18.172) |
| 08:27.25 | *** join/#asterisk-bugs tzafrir (~tzafrir@local.xorcom.com) |
| 09:01.41 | *** join/#asterisk-bugs irroot (~gregory@197.174.253.206) |
| 10:13.54 | *** join/#asterisk-bugs irroot (~gregory@197.104.105.11) |
| 11:44.38 | *** join/#asterisk-bugs irroot (~gregory@197.106.243.133) |
| 12:08.50 | *** join/#asterisk-bugs oej (~olle@static-213-115-251-100.sme.bredbandsbolaget.se) |
| 13:18.12 | *** join/#asterisk-bugs irroot (~gregory@197.108.119.84) |
| 14:05.09 | *** join/#asterisk-bugs serafie (~erin@nat/digium/x-txytgnlcrqttydgh) |
| 14:44.07 | *** join/#asterisk-bugs irroot (~gregory@197.169.46.11) |
| 15:14.02 | *** join/#asterisk-bugs zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 15:24.58 | *** join/#asterisk-bugs The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 15:25.04 | *** join/#asterisk-bugs putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:25.04 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 15:42.58 | *** join/#asterisk-bugs irroot (~gregory@197.173.239.11) |
| 16:01.36 | *** join/#asterisk-bugs Dunling_ (~dunlingli@mail.unleashbts.com) |
| 16:06.08 | *** part/#asterisk-bugs Dunling_ (~dunlingli@mail.unleashbts.com) |
| 16:12.36 | *** join/#asterisk-bugs Dunling_ (~dunlingli@mail.unleashbts.com) |
| 16:56.52 | leifmadsen | you should login, then you may need to reopen the issue, then you attach the file |
| 16:57.02 | leifmadsen | you probably can't attach it because the issue is closed |
| 17:13.51 | *** join/#asterisk-bugs oej (~olle@87.96.134.129) |
| 18:22.01 | *** join/#asterisk-bugs irroot (~gregory@197.104.117.199) |
| 18:43.22 | *** join/#asterisk-bugs irroot (~gregory@197.174.108.107) |
| 19:10.02 | *** join/#asterisk-bugs oej (~olle@87.96.134.129) |
| 19:18.51 | *** join/#asterisk-bugs irroot (~gregory@197.169.161.132) |
| 20:59.34 | leifmadsen | putnopvut: ping? |
| 21:42.58 | putnopvut | leifmadsen: pong |
| 21:45.36 | leifmadsen | putnopvut: I know you probably don't really remember, but is there a reason why when you have strategy=ringall in app_queue that ringinuse=yes isn't applicable? |
| 21:45.52 | leifmadsen | I'm talking about the note in app_queue.c on line 2923 (Asterisk 10 branch) |
| 21:46.25 | putnopvut | Let me have a look... |
| 21:46.57 | putnopvut | (I don't have a checkout of the 10 branch. give me a sec) |
| 21:47.00 | leifmadsen | this is in relation to: https://issues.asterisk.org/jira/browse/ASTERISK-18754 |
| 21:47.01 | leifmadsen | np |
| 21:47.04 | leifmadsen | no rush |
| 21:54.46 | putnopvut | I think you may be reading too much into that comment. The function tries to determine if any members are available to answer the call. When ringall is used, then as soon as there is at least one available member, then that answers the question that "yes, there are indeed members to call." It appears in that function that if ringinuse is set to "yes" for the queue, then we should consider the member to be available. Now, |
| 21:54.47 | putnopvut | the fact that the calls are not delivered to the busy extension likely has to do with some later logic which extensions to call. I'll have a look at the ring_entry and ring_one functions to see if there is anything there that looks suspicious. |
| 21:56.42 | leifmadsen | putnopvut: ok that make sense -- that's why I wanted to check with someone who maybe knew the code a bit better |
| 22:02.41 | putnopvut | leifmadsen: okay, possible reason found. Do you have any idea what the "ignorebusy" option is? |
| 22:03.07 | leifmadsen | well, I didn't see it in queues.conf -- but I did notice it as an option to Queue() |
| 22:03.08 | putnopvut | It appears that for dynamic realtime members, if a specific value for "ignorebusy" is not provided, it is assumed to be enabled. This doesn't appear to be the case for static members. |
| 22:03.09 | leifmadsen | never used it though |
| 22:03.21 | leifmadsen | huh |
| 22:03.44 | leifmadsen | <PROTECTED> |
| 22:03.52 | leifmadsen | not terribly descriptive |
| 22:04.00 | putnopvut | That *may* be what's causing this to happen, because the ring_entry function will not ring a busy member if either the ringinuse is set to "no" or if the member has ignorebusy set to true. |
| 22:04.17 | putnopvut | You'd probably want to look in the queues.conf.sample file for more info on it. |
| 22:04.37 | leifmadsen | funny enough, that file does not include 'ignorebusy' |
| 22:04.45 | file | not found |
| 22:04.46 | leifmadsen | s/that file/queues.conf.sample/g |
| 22:05.03 | putnopvut | leifmadsen: it does for me, in that it is mentioned, but an example usage is not shown. |
| 22:05.14 | putnopvut | It appears to be a per-member setting of ringinuse. |
| 22:05.33 | leifmadsen | sorry, that's what I meant (no example usage) |
| 22:05.35 | putnopvut | So in other words, if you have ringinuse set to yes for the queue, you can set ignorebusy for a specific member in order to have that one skipped. |
| 22:05.35 | leifmadsen | hmmmm |
| 22:05.55 | leifmadsen | what about when you use dynamic members set from the CLI? |
| 22:06.04 | putnopvut | Let me check about that. |
| 22:06.06 | leifmadsen | wonder if that is available from a function or AddQueueMember() |
| 22:06.34 | leifmadsen | does not show in the documentation |
| 22:07.57 | putnopvut | It appears that you cannot set that via AddQueueMember() |
| 22:08.11 | leifmadsen | when the heck was that option even added? it seems.... new |
| 22:08.14 | leifmadsen | I had never heard of it |
| 22:08.28 | putnopvut | Let's do the blame game here... |
| 22:08.44 | putnopvut | (I certainly didn't add it) |
| 22:08.53 | jsmith | putnopvut: I still say we burn app_queue to the ground and rebuild it from scratch :-) |
| 22:09.01 | seanbright | jsmith: patches welcome |
| 22:09.07 | leifmadsen | that ^^^ |
| 22:09.24 | leifmadsen | app_queue works fine in many many cases |
| 22:10.17 | jsmith | leifmadsen: And in many cases, it doesn't. |
| 22:10.36 | jsmith | (Or, in some, is so convoluted that you *can't* easily tell whether or not it's doing the right thing) |
| 22:10.46 | leifmadsen | I'll take it rather than nothing |
| 22:11.04 | jsmith | Sure, as would I |
| 22:11.11 | putnopvut | leifmadsen: it appears that irroot added the ignorebusy option in rev 325483 |
| 22:11.25 | leifmadsen | hmmm, ok I'm going to have to ask him to better document it |
| 22:11.31 | putnopvut | Along with a few other things. |
| 22:11.39 | jsmith | But there's a level of technical debt there... sooner or later, it's going to be more efficient to rebuild it using modern APIs (astobj2, anyone?) than continuing to fight it |
| 22:11.40 | leifmadsen | facepalms |
| 22:11.47 | putnopvut | And I'm correct about what ignorebusy does, btw. |
| 22:12.04 | leifmadsen | putnopvut: it sounds like it should be enabled for static peers too |
| 22:12.17 | leifmadsen | not sure why it is enabled for one type of peer but not another |
| 22:14.03 | putnopvut | Yeah, and I'm not even sure if it's possible to set it on static members. |
| 22:14.10 | putnopvut | Like even using queues.conf |
| 22:15.04 | leifmadsen | this seems like a regression to me |
| 22:15.37 | putnopvut | Yeah, it's very inconsistent. You can only set the option for dynamic realtime peers, and it's on by default for them but no other types. |
| 22:17.22 | putnopvut | Oh, AND the ignorebusy option does not persist with persistent members. |
| 22:21.19 | putnopvut | Not sure who gave the ship it on that review but... |
| 22:25.45 | leifmadsen | putnopvut: wow that is a mess |
| 22:42.51 | leifmadsen | putnopvut: ok thanks for your analysis -- I'm going to open another issue |
| 23:19.36 | *** join/#asterisk-bugs tzafrir (~tzafrir@bzq-218-155-170.cablep.bezeqint.net) |