| 00:33.02 | *** join/#asterisk-bugs superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:40.09 | *** join/#asterisk-bugs superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:48.55 | *** join/#asterisk-bugs superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:28.24 | *** join/#asterisk-bugs mjordan (~mjordan@75.76.55.191) |
| 01:28.24 | *** mode/#asterisk-bugs [+o mjordan] by ChanServ |
| 01:39.36 | *** join/#asterisk-bugs superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:50.14 | *** join/#asterisk-bugs mjordan (mjordan@nat/digium/x-opqkhjoqfvesayjl) |
| 01:50.14 | *** mode/#asterisk-bugs [+o mjordan] by ChanServ |
| 02:31.23 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 07:48.52 | *** join/#asterisk-bugs darkbasic_ (~quassel@niko.linuxsystems.it) |
| 08:39.40 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 09:04.32 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 10:06.25 | *** join/#asterisk-bugs darkbasic_ (~quassel@niko.linuxsystems.it) |
| 10:33.42 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 11:55.56 | *** join/#asterisk-bugs tzafrir (~tzafrir@89.138.252.59) |
| 12:08.38 | *** join/#asterisk-bugs sgriepentrog (sgriepentr@nat/digium/x-avgtgrruvdrxteib) |
| 12:32.30 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 12:43.21 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 13:04.54 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 13:10.49 | *** join/#asterisk-bugs darkbasic_ (~quassel@niko.linuxsystems.it) |
| 13:17.46 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 13:30.33 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 13:51.26 | *** join/#asterisk-bugs darkbasic_ (~quassel@niko.linuxsystems.it) |
| 14:06.50 | *** join/#asterisk-bugs putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:06.50 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
| 14:17.19 | *** join/#asterisk-bugs newtonr (RustyNewto@nat/digium/x-tzhaqjdbldepkkla) |
| 14:17.19 | *** mode/#asterisk-bugs [+o newtonr] by ChanServ |
| 14:18.27 | *** part/#asterisk-bugs mjordan (mjordan@nat/digium/x-opqkhjoqfvesayjl) |
| 14:29.58 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 15:01.32 | *** join/#asterisk-bugs mjordan (mjordan@nat/digium/x-xuahzibjztepzreq) |
| 15:01.32 | *** mode/#asterisk-bugs [+o mjordan] by ChanServ |
| 15:30.53 | *** join/#asterisk-bugs darkbasic_ (~quassel@niko.linuxsystems.it) |
| 16:08.11 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 16:29.43 | *** join/#asterisk-bugs superscrat (asanders@nat/digium/x-xtafenenjxhkenmk) |
| 17:12.38 | *** join/#asterisk-bugs ibercom (5332cb81@gateway/web/freenode/ip.83.50.203.129) |
| 17:13.51 | ibercom | Revision http://svnview.digium.com/svn/asterisk?view=revision&revision=434469 |
| 17:15.14 | ibercom | It should remove the following assignment: |
| 17:16.26 | ibercom | line 727: enum ast_event_type event_type = -1; |
| 17:16.33 | ibercom | It is not necessary to assign -1 |
| 17:18.11 | ibercom | Fix description ...The enum can never be negative... |
| 17:29.53 | ibercom | Does anyone agree? |
| 17:46.30 | mjordan | ibercom: you'll need to be more specific. |
| 17:46.36 | mjordan | line 727 of which file? |
| 17:46.54 | ibercom | event.c |
| 17:47.00 | ibercom | Revision http://svnview.digium.com/svn/asterisk?view=revision&revision=434469 |
| 17:48.03 | mjordan | assigning -1 to it is a NoOp at this point. It probably should be removed. |
| 17:49.26 | ibercom | Fix's description specified ...The enum can never be negative... |
| 17:50.23 | ibercom | I guess that's not necessary "= -1" |
| 17:50.54 | mjordan | and I just agreed that it should be removed. |
| 17:50.57 | mjordan | shrugs |
| 17:53.29 | ibercom | I don't know if clan warnings have been applied to asterisk 11 or only to asterisk 13 |
| 17:53.38 | ibercom | clang should detect it. |
| 17:54.49 | mjordan | they're both LTS branches. clang compiler support was added to 11. |
| 17:54.59 | mjordan | if you feel strongly about it, participate in the reviews. They're public, and on review board. |
| 17:56.12 | mjordan | But I'll go in and remove the -1 you pointed out later this afternoon. |
| 17:57.57 | ibercom | I have tried sometime but it's complicated :-) My english is bad. |
| 17:58.44 | ibercom | That's all. |
| 18:15.15 | *** join/#asterisk-bugs sgriepentrog (sgriepentr@nat/digium/x-afjcxiuyulvjvjrl) |
| 18:32.45 | *** join/#asterisk-bugs sgriepentrog (sgriepentr@nat/digium/x-qmpjijknwlhlzsmd) |
| 20:13.56 | *** join/#asterisk-bugs sgriepentrog (sgriepentr@nat/digium/x-aczsabclzwppgspt) |
| 20:17.12 | *** join/#asterisk-bugs darkbasic (~quassel@niko.linuxsystems.it) |
| 21:28.41 | *** join/#asterisk-bugs tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 23:14.23 | *** join/#asterisk-bugs elguero (~miguel323@2001:470:1f06:12c4::2) |