| 00:19.55 | *** join/#asterisk-dev moy (n=moy@189.169.61.171) |
| 00:20.01 | moy | russellb: you around? |
| 00:21.24 | moy | someone who can tell if the "People" field in the reviewboard should be set to nicknames or something, or what is that for? can be just ignored along with "Groups" |
| 00:21.50 | seanbright | set groups to 'asterisk' |
| 00:21.55 | seanbright | that will include all of us |
| 00:21.59 | seanbright | (if that is your intent) |
| 00:22.25 | moy | seanbright: thanks :) |
| 00:22.32 | seanbright | np |
| 00:34.52 | *** join/#asterisk-dev jeffg (i=O5i7YaBF@pdpc/supporter/active/jeffg) |
| 00:36.34 | moy | seanbright: the branch should be the complete URL, http or https? |
| 00:37.18 | *** join/#asterisk-dev kamanashisroy (n=kamanash@119.30.34.4) |
| 00:40.23 | moy | heh, the View Diff button launches a nice python Traceback |
| 00:45.08 | seanbright | ummmm |
| 00:45.21 | seanbright | what did you do a diff against? |
| 00:45.30 | seanbright | <PROTECTED> |
| 00:45.37 | moy | yeah, /trunk |
| 00:45.56 | seanbright | the use that for root path |
| 00:46.19 | moy | I did "New Review Request" and in Base Diff Path specified /trunk |
| 00:46.25 | seanbright | right |
| 00:46.27 | seanbright | that should work |
| 00:46.39 | moy | then in diff file attached the output of svn diff |
| 00:46.53 | moy | per russellb instructions |
| 00:46.56 | seanbright | right |
| 00:47.11 | moy | then click "create review" button |
| 00:47.12 | seanbright | and that doesn't work |
| 00:47.14 | seanbright | ? |
| 00:47.39 | moy | exactly, just after that, I chose "View Diff" and I get the python Traceback |
| 00:47.54 | seanbright | it might have to do the with content of the diff |
| 00:48.04 | seanbright | the "old" and "new" paths |
| 00:48.19 | moy | http://www.pastebin.ca/1248320 |
| 00:48.23 | moy | ah |
| 00:48.42 | seanbright | --- channels/chan_sip.c (revision 155433) |
| 00:48.42 | seanbright | +++ channels/chan_sip.c (working copy) |
| 00:48.47 | seanbright | like those ^^^ |
| 00:50.10 | moy | mmm so this does not work: http://kentaurus.net/mfcr2.diff.txt ? |
| 00:50.29 | seanbright | hmmm |
| 00:50.49 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 00:50.51 | seanbright | hold |
| 00:51.00 | moy | ok |
| 00:52.29 | seanbright | try this one |
| 00:52.30 | seanbright | http://www.seanbright.com/moy.diff |
| 00:52.39 | seanbright | just for giggles |
| 00:54.35 | moy | ah! much better :) |
| 00:54.40 | seanbright | good good |
| 00:55.49 | seanbright | did you use 'svn diff' to make the diff? |
| 00:56.58 | moy | yeah, svn diff <trunkurl> <branch-url> |
| 00:57.06 | seanbright | hrmm. |
| 00:57.19 | seanbright | the (../foo) stuff might have fudged it up |
| 01:07.14 | *** join/#asterisk-dev DagMoller (n=aguirre@unaffiliated/dagmoller) |
| 01:07.47 | *** part/#asterisk-dev DagMoller (n=aguirre@unaffiliated/dagmoller) |
| 01:32.11 | *** join/#asterisk-dev jtodd (n=jtodd@blob.fox-den.com) |
| 02:05.55 | *** join/#asterisk-dev drumkilla (n=russell@asterisk/digium-open-source-team-lead/russellb) |
| 02:05.55 | *** mode/#asterisk-dev [+o drumkilla] by ChanServ |
| 02:11.39 | *** join/#asterisk-dev drumkilla (n=russellb@asterisk/digium-open-source-team-lead/russellb) |
| 02:11.39 | *** mode/#asterisk-dev [+o drumkilla] by ChanServ |
| 02:27.40 | *** join/#asterisk-dev eliel (n=eliel@190.177.227.71) |
| 02:27.40 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 03:20.46 | *** join/#asterisk-dev lmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 03:20.46 | *** mode/#asterisk-dev [+o lmadsen] by ChanServ |
| 04:09.01 | *** join/#asterisk-dev jeffspeff2 (n=jeff@c-69-245-31-86.hsd1.ky.comcast.net) |
| 04:15.28 | *** join/#asterisk-dev jameswf (n=james@ip68-3-60-66.ph.ph.cox.net) |
| 04:45.35 | *** join/#asterisk-dev jeffspeff2 (n=jeff@c-69-245-31-86.hsd1.ky.comcast.net) |
| 04:47.34 | *** join/#asterisk-dev jeffspeff2 (n=jeff@c-69-245-31-86.hsd1.ky.comcast.net) |
| 04:49.22 | *** join/#asterisk-dev jeffspeff (n=jeff@c-69-245-31-86.hsd1.ky.comcast.net) |
| 04:58.06 | *** join/#asterisk-dev bbryant (n=brett@c-68-59-20-153.hsd1.sc.comcast.net) |
| 04:58.06 | *** mode/#asterisk-dev [+o bbryant] by ChanServ |
| 05:01.59 | *** join/#asterisk-dev IgorG|note (n=IgorG|no@host-92-124-187-86.pppoe.omsknet.ru) |
| 06:49.35 | snuff-home | mm.. if i want to sync my branch to trunk.. say i just did a svn diff http://mybranch http://trunk > outfile.diff; cd mybranch ;patch -p0 < ../oufile.diff |
| 06:49.42 | snuff-home | would that work? |
| 08:00.40 | moy | snuff-home: why not use svn merge? |
| 08:09.14 | tzafrir_laptop | svn merge won't handle conflicts |
| 08:09.32 | tzafrir_laptop | and you still need to tell it (manually) from what exact point to merge |
| 08:11.34 | tzafrir_laptop | BTW: reiviewboard also shares one of svn's minor/trivial issues for me: |
| 08:12.01 | tzafrir_laptop | 'svn diff' does not show the name of the function (diff -p) |
| 08:54.16 | moy | tzafrir_laptop: what you mean by handle conflicts? aside of marking the conflict when not possible to merge the file, what else should svn merge do? |
| 08:55.12 | tzafrir_laptop | err... sorry. "handle conflicts" is the wrong word |
| 08:55.41 | tzafrir_laptop | svn does not keep the information of what was already merged |
| 08:56.07 | moy | ah yeah, I've been bit by that already |
| 08:59.32 | moy | tzafrir_laptop: btw, russellb said he would like to include the r2 stuff in 1.6.3, the review is already out there |
| 09:00.06 | tzafrir_laptop | anyway, what is the purpose of those monitor threads in the mfcr2 support? (though if you're replying on-list that's also good) |
| 09:00.28 | tzafrir_laptop | my reply is already out there |
| 09:04.27 | moy | will reply on the list later, now I'm a bit busy for a lengthy appropriate answer there, but the short answer is I wanted to stay away from current code and avoid using the current monitor thread since most handling in the monitor is R2 specific. |
| 09:05.14 | moy | as of the spandsp version, the detector/generator is embedded, no need to link to spandsp, there is no much benefit on linking anyway, from all the components in spandsp the MF stuff is not likely to get important updates |
| 09:39.46 | tzafrir_laptop | is that code included in openr2? |
| 09:40.04 | moy | correct |
| 10:53.29 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 10:53.29 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:23.18 | tzafrir_laptop | any problem with the annonymous svn mirror? |
| 12:28.58 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 12:28.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:53.13 | tzafrir_laptop | anybody else having problems? Or does it work for anybody else? |
| 12:53.24 | tzafrir_laptop | svn ls http://svn.digium.com/svn/asterisk |
| 13:12.10 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 13:12.10 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:19.11 | *** join/#asterisk-dev sasargen (n=chatzill@174-146-130-228.pools.spcsdns.net) |
| 13:26.43 | *** join/#asterisk-dev jeffg (i=zliZuPxO@pdpc/supporter/active/jeffg) |
| 13:50.30 | *** join/#asterisk-dev DagMoller (n=aguirre@unaffiliated/dagmoller) |
| 13:50.55 | *** part/#asterisk-dev DagMoller (n=aguirre@unaffiliated/dagmoller) |
| 13:53.05 | *** join/#asterisk-dev shazaum (n=shazaum@unaffiliated/shazaum) |
| 14:58.38 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 14:58.38 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:36.03 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 16:49.23 | *** join/#asterisk-dev russellb (n=russell@asterisk/digium-open-source-team-lead/russellb) |
| 16:49.23 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 16:49.40 | *** join/#asterisk-dev anthm][ (n=anthm@72.59.201.204) |
| 16:51.00 | *** join/#asterisk-dev eliel (n=eliel@151-202-114-200.fibertel.com.ar) |
| 16:51.00 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 16:52.03 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 16:52.38 | russellb | Corydon76-dig: got the message, not sure what's up |
| 16:52.41 | russellb | server isn't responding at all |
| 16:54.09 | Corydon76-dig | russellb: thought I'd give you a heads up |
| 16:55.40 | russellb | thanks |
| 16:56.22 | eliel | hello, you were talking about bugs.digium.com isnt it? |
| 16:56.26 | russellb | yes |
| 16:56.34 | russellb | and svn, and reviewboard, and whatever else is on that box |
| 16:56.35 | russellb | heh |
| 16:56.50 | russellb | (public svn) |
| 16:57.19 | eliel | yeaph |
| 16:58.39 | Corydon76-dig | I figured Twitter was the fastest way to notify you without calling and risking waking you up or something |
| 16:59.52 | Corydon76-dig | or interrupting you if you were already working on it |
| 17:00.52 | *** join/#asterisk-dev getsql08 (n=getsql05@70.5.226.189) |
| 17:01.07 | russellb | Corydon76-dig: yep, twitter is fine :) |
| 17:01.11 | russellb | email is fine, too |
| 17:01.18 | russellb | email is actually how i saw it .. |
| 17:01.33 | Corydon76-dig | Ah. |
| 17:01.36 | *** join/#asterisk-dev outtolunc (n=me@c-67-188-204-139.hsd1.ca.comcast.net) |
| 17:01.41 | getsql08 | <PROTECTED> |
| 17:02.01 | Corydon76-dig | getsql08: not here. Use the -biz list |
| 17:11.29 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 17:11.29 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:23.03 | russellb | Corydon76-dig: Kevin is going by the colo to see what's up |
| 17:23.34 | russellb | So, give it a few hours and I suspect it'll be back to life |
| 17:34.11 | Corydon76-dig | russellb: cool |
| 17:44.47 | *** join/#asterisk-dev russellb (n=russell@asterisk/digium-open-source-team-lead/russellb) |
| 17:44.47 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 18:11.13 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 18:56.36 | *** join/#asterisk-dev blitzrage (n=blitzrag@asterisk/documenteur-extraordinaire/blitzrage) |
| 18:56.36 | *** mode/#asterisk-dev [+o blitzrage] by ChanServ |
| 19:14.37 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 19:44.00 | *** join/#asterisk-dev jeffspeff (n=jeff@c-69-245-31-86.hsd1.ky.comcast.net) |
| 19:46.39 | *** join/#asterisk-dev russellb (n=russell@asterisk/digium-open-source-team-lead/russellb) |
| 19:46.39 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 20:01.39 | *** join/#asterisk-dev sasargen (n=chatzill@72.58.119.227) |
| 20:09.00 | *** join/#asterisk-dev stevie_ramjet (n=putnopvu@c-71-228-178-34.hsd1.al.comcast.net) |
| 20:09.00 | *** mode/#asterisk-dev [+o stevie_ramjet] by ChanServ |
| 20:11.23 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 20:35.29 | *** join/#asterisk-dev russellb (n=russell@asterisk/digium-open-source-team-lead/russellb) |
| 20:35.29 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 21:07.46 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 21:07.46 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:08.48 | *** join/#asterisk-dev eliel (n=eliel@190.177.227.71) |
| 21:08.48 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 21:25.26 | eliel | oej: may I ask you a question regardin chan_sip? at line 20139 of trunk: inside sipsock_read() I have this line: |
| 21:25.40 | eliel | if (res == sizeof(req.data) - 1) { |
| 21:26.05 | eliel | req.data is a struct ast_str |
| 21:26.07 | oej | and... |
| 21:26.21 | oej | Yes, someone changed that. A |
| 21:26.25 | eliel | is this working? |
| 21:26.57 | oej | I haven't got an idea. |
| 21:27.12 | eliel | oej: it looks bogus... |
| 21:27.12 | oej | There's so many issues... |
| 21:27.23 | oej | Yes, I agree |
| 21:30.23 | russellb | that code is basically a no-op ... *fixes it* |
| 21:33.52 | eliel | it is a noop unless planets align and res becomes equal to sizeof(struct ast_str) in that case the packet will be lost |
| 21:33.57 | eliel | (though) |
| 21:34.28 | eliel | but actually if res == sizeof(struct ast_str) is because packet is already lost... |
| 21:34.59 | russellb | yeah, but a SIP packet that is about 12 bytes (or whatever it is) is unlinkely :) |
| 21:37.34 | eliel | to make sure that ast_str_set allocate the necesarry buffer we could check the result against AST_DYNSTR_BUILD_FAILED? |
| 21:38.29 | russellb | yeah. |
| 21:38.41 | russellb | so, you're right, it's not really checking for failure ... |
| 21:48.32 | russellb | now it does |
| 21:51.54 | eliel | you miss ast_free(req.data) before the "return -1" |
| 21:52.52 | russellb | well, I don't think you can do that .. |
| 21:53.02 | russellb | because if it failed, that means ast_realloc() failed ... |
| 21:53.18 | russellb | let's see ... |
| 21:53.52 | eliel | if ast_realloc failed the buffer remains untouched?? (though) |
| 21:54.12 | russellb | well, realloc() free's the buffer you pass it |
| 21:54.46 | eliel | ok, so, it is not necesary |
| 21:54.51 | russellb | nods |
| 21:59.49 | eliel | ok, chan_sip is strange! at the end of sipsock_read() we are setting req.data = NULL (?? for what? i dont know)... he |
| 22:01.24 | russellb | after freeing it? |
| 22:01.27 | putnopvut | yeah |
| 22:01.30 | eliel | yeap |
| 22:01.53 | putnopvut | do any other threads potentially reference req.data in some way? |
| 22:01.57 | putnopvut | Because then it makes sense. |
| 22:02.05 | eliel | it is a local var |
| 22:02.10 | putnopvut | req is. |
| 22:02.15 | putnopvut | But not necessarily req.data |
| 22:02.21 | eliel | aaah, you are right... |
| 22:03.07 | putnopvut | for all I know req.data may not be referenced by other threads. I'm just saying that setting it to NULL may not be completely pointless. |
| 22:06.14 | russellb | It's ... good practice, heh |
| 22:09.37 | wedhorn | Wouldn't if be better to set it to NULL before freeing (we had something similar in chan_skinny)? |
| 22:11.43 | russellb | Welllllllll |
| 22:11.58 | russellb | First, I assume you mean save off the pointer, set it to NULL, and free what you saved off ... |
| 22:12.03 | russellb | otherwise, you have a mem leak |
| 22:12.27 | russellb | Second, that really shouldn't be necessary. If that actually fixes a problem, the problem is the lack of proper synchronization of access to that memory. |
| 22:13.18 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 22:15.07 | wedhorn | umm, my bad, should have read further back. I "assumed" it was freeing req (not req.data). |
| 22:15.32 | russellb | no problem, :) |
| 22:17.18 | wedhorn | while there are some people around, anyone familiar with channel codec prefs? |
| 22:43.57 | *** join/#asterisk-dev eliel_ (n=eliel@190.177.216.156) |
| 22:44.04 | *** part/#asterisk-dev wwalker (n=wwalker@pdpc/supporter/sustaining/wwalker) |
| 22:45.06 | *** join/#asterisk-dev DarkRift (n=dark@bas1-sthubert21-1279505477.dsl.bell.ca) |
| 23:14.54 | *** join/#asterisk-dev outtolunc (n=me@c-67-188-204-139.hsd1.ca.comcast.net) |
| 23:27.12 | *** join/#asterisk-dev eliel (n=eliel@190.177.208.144) |
| 23:27.12 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 23:52.27 | *** join/#asterisk-dev KP7 (n=chatzill@dsl001-145-071.phl1.dsl.speakeasy.net) |
| 23:55.03 | KP7 | this might be the wrong place for this but is there a revision of dahdi-linux that will compile against kernel 2.6.26.3? I've tried whats in trunk as well as 2.10-rc2 from tags and of course the main 2.0.0 release |
| 23:55.45 | seanbright | if you've tried with trunk and it doesn't work, then no. |
| 23:55.58 | KP7 | ok |
| 23:56.25 | KP7 | do i need to upgrade my kernel higher or should i downgrade asterisk and zaptel? |
| 23:56.41 | KP7 | rather got back to a version that uses zaptel |
| 23:57.16 | seanbright | i doubt downgrading to zaptel would help |
| 23:57.35 | seanbright | 2.6.26 is a relatively new kernel, no? |
| 23:58.22 | KP7 | yes, but apparently there was bug with dahdi around that version |
| 23:58.33 | seanbright | what is the error you get during compilation? |
| 23:58.36 | seanbright | with dahdi trunk? |
| 23:59.00 | KP7 | http://bugs.digium.com/view.php?id=12944 <-- thats what I found posted about the bug |
| 23:59.31 | KP7 | the error i get with trunk is /usr/local/src/VoIP/dahdi-linux/drivers/dahdi/dahdi-base.c:1810: error: implicit declaration of function `print_debug_writebuf' |
| 23:59.39 | KP7 | thats the first one |