| 00:02.22 | *** join/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 00:02.26 | *** part/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 00:09.05 | *** join/#asterisk-dev felipe_ (n=felipe@my.nada.kth.se) |
| 00:42.43 | *** join/#asterisk-dev Mw3 (i=mw3@mw3.hu) |
| 01:15.24 | *** join/#asterisk-dev eliel (n=eliels@151-202-114-200.fibertel.com.ar) |
| 01:15.24 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 01:31.09 | *** join/#asterisk-dev smbrienz (n=guest@host212-203-dynamic.10-87-r.retail.telecomitalia.it) |
| 01:52.57 | *** join/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 01:53.34 | *** part/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 01:56.56 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 01:56.57 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 02:13.09 | *** join/#asterisk-dev shido6 (n=shido6@96-28-34-156.dhcp.insightbb.com) |
| 02:22.58 | *** join/#asterisk-dev Deeewayne (n=dwayne@c-76-29-245-9.hsd1.al.comcast.net) |
| 02:22.59 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 02:48.41 | *** join/#asterisk-dev mnicholson_ (n=matthew@adsl-249-92-197.hsv.bellsouth.net) |
| 03:16.22 | *** join/#asterisk-dev moy (n=moy@CPE001cdfec4cee-CM00080dab8485.cpe.net.cable.rogers.com) |
| 03:38.35 | *** join/#asterisk-dev JackEStorm (n=no@ip24-252-118-155.no.no.cox.net) |
| 03:47.04 | *** join/#asterisk-dev infobot (i=ibot@rikers.org) |
| 03:47.04 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and Tier 3.14159265 support is in #asterisk -=- Leif Madsen is now the Open Source Release and Issue Tracker Manager. Blame all problems you find on him. That is all. -=- http://xkcd.com/303/ -=- ViewVC for SVN is currently down for the foreseeable future |
| 04:26.59 | *** join/#asterisk-dev CunningPike (n=CunningP@S01060014bf81366b.vc.shawcable.net) |
| 04:44.35 | *** join/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 04:44.40 | *** part/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 05:28.06 | *** join/#asterisk-dev lasko (n=lasko@pool-71-111-24-127.ptldor.dsl-w.verizon.net) |
| 05:45.44 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 05:45.44 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:02.17 | *** join/#asterisk-dev mog (n=mog@c-68-62-169-246.hsd1.al.comcast.net) |
| 06:02.22 | *** mode/#asterisk-dev [+o mog] by ChanServ |
| 06:06.31 | *** join/#asterisk-dev sergee (n=serg@voip1.west-call.com) |
| 06:47.06 | *** join/#asterisk-dev obnauticus (n=obnautic@about/windows/regular/obnauticus) |
| 07:23.02 | *** join/#asterisk-dev tamiel (n=tamiel@213.30.183.226) |
| 07:31.59 | *** join/#asterisk-dev lasko (n=lasko@pool-71-111-24-127.ptldor.dsl-w.verizon.net) |
| 07:37.04 | *** join/#asterisk-dev Greek-B0y (n=greek@41.222.89.77) |
| 07:40.37 | *** join/#asterisk-dev Pazzo (n=ugelt@host156-36-static.14-79-b.business.telecomitalia.it) |
| 07:56.52 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 07:56.52 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:41.28 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 09:41.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:05.17 | *** join/#asterisk-dev sergee (n=serg@voip1.west-call.com) |
| 10:24.08 | *** join/#asterisk-dev Captain_Jasp (n=waz@62.6.159.182) |
| 10:24.17 | *** part/#asterisk-dev Captain_Jasp (n=waz@62.6.159.182) |
| 10:45.02 | ThoMe | Hur kommer du igång? |
| 10:45.07 | ThoMe | ups wrong channel |
| 11:07.31 | *** join/#asterisk-dev oej (n=olle@host-n36-118.homerun.telia.com) |
| 11:07.31 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:09.18 | *** join/#asterisk-dev oej_ (n=olle@host-n36-118.homerun.telia.com) |
| 11:20.51 | *** join/#asterisk-dev oej (n=olle@host-n36-118.homerun.telia.com) |
| 11:20.51 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:46.05 | *** join/#asterisk-dev JT (n=j@unaffiliated/jt) |
| 11:51.34 | *** join/#asterisk-dev JT (n=j@unaffiliated/jt) |
| 12:11.58 | *** join/#asterisk-dev snuff-home (n=snuffy@203-219-29-182-bri-ts6-2600.tpgi.com.au) |
| 12:11.58 | *** join/#asterisk-dev tamiel (n=tamiel@213.30.183.226) [NETSPLIT VICTIM] |
| 12:11.58 | *** join/#asterisk-dev denon (i=denon@synapse.subneural.net) [NETSPLIT VICTIM] |
| 12:11.58 | *** join/#asterisk-dev seanbright (n=sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 12:11.58 | *** mode/#asterisk-dev [+oo snuff-home seanbright] by irc.freenode.net |
| 12:13.30 | *** join/#asterisk-dev shido6 (n=shido6@96-28-34-156.dhcp.insightbb.com) |
| 12:19.05 | *** join/#asterisk-dev caio1982 (i=caio1982@CAcert-br/caio1982) |
| 12:31.14 | *** join/#asterisk-dev snuff-home (n=snuffy@203-219-29-182-bri-ts6-2600.tpgi.com.au) |
| 12:31.14 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 12:47.12 | *** join/#asterisk-dev eliel (n=eliels@200.61.172.61) |
| 12:47.20 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 12:48.22 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:48.22 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:52.14 | *** join/#asterisk-dev mosty (n=mosty@213.66.224.163) |
| 12:52.49 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:52.49 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:05.21 | *** join/#asterisk-dev bkruse (n=bkruse@76.73.154.120) |
| 13:05.21 | *** mode/#asterisk-dev [+o bkruse] by ChanServ |
| 13:06.13 | *** join/#asterisk-dev smbrienz (n=guest@87.10.203.212) |
| 13:25.43 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 13:25.43 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:51.56 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:51.56 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 14:02.55 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 14:02.55 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 14:18.40 | *** join/#asterisk-dev moy (n=chatzill@74.12.124.89) |
| 14:22.50 | *** join/#asterisk-dev sruffell (n=sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:22.50 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:27.40 | *** join/#asterisk-dev Deeewayne (n=dwayne@75.76.254.162) |
| 14:27.41 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 14:43.37 | *** join/#asterisk-dev Juggie (n=Juggie@CPE001601df17fb-CM001ceac25ada.cpe.net.cable.rogers.com) |
| 14:43.48 | *** join/#asterisk-dev joshaidan (n=joshaida@S01060090f8009fa6.tb.shawcable.net) |
| 15:24.11 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 15:28.09 | *** join/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 15:28.23 | *** part/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 15:30.06 | *** join/#asterisk-dev caio1982 (i=caio1982@CAcert-br/caio1982) |
| 15:32.58 | *** join/#asterisk-dev marv[work] (n=timr@router.asteriasgi.com) |
| 15:35.38 | JunK-Y | hi guys |
| 15:36.54 | russellb | waves to JunK-Y |
| 15:37.59 | *** join/#asterisk-dev BlargMaN00 (n=blarg@12.234.16.130) |
| 15:38.04 | JunK-Y | how are you russellb ? |
| 15:41.08 | russellb | alive, but not awake |
| 15:44.03 | JunK-Y | same here |
| 15:44.17 | JunK-Y | any idea, why Queue() doesnt ast_answer() by default? |
| 15:46.20 | jsmith | JunK-Y: Because some people don't want to answer the call until they actuall connect you to a queue member or agent! |
| 15:46.29 | leifmadsen | aye |
| 15:46.29 | jsmith | JunK-Y: Slick, isn't it? |
| 15:46.37 | jsmith | loves the concept of early media |
| 15:46.55 | JunK-Y | ya, cause sonce they're no early media, they wont hear the music anyways, no? |
| 15:47.10 | JunK-Y | i propose an option to answer, whatcha think? |
| 15:47.20 | JunK-Y | leifmadsen: how was it360 btw? |
| 15:47.58 | Corydon76-dig | adds late media to SIP |
| 15:49.26 | JunK-Y | Corydon76-dig: do you have few minutes? ive notice in some cause, asterisk doesnt send an iax2 ANSWER frame after an async_goto |
| 15:50.07 | jsmith | JunK-Y: Why not just call Answer() before calling Queue()? |
| 15:50.15 | jsmith | JunK-Y: Does it really need to be an option? |
| 15:50.16 | Corydon76-dig | JunK-Y: the person to talk to would be theboywonder |
| 15:50.22 | *** join/#asterisk-dev CunningPike (n=CunningP@204.239.10.119) |
| 15:51.14 | JunK-Y | jsmith: cause if you forget to add an answer queue(), you wont see anything bad in ur cli, so yo will think "everything is okay:", but that's not |
| 15:51.23 | JunK-Y | like starting moh, etc |
| 15:51.32 | JunK-Y | but of course, this is not happenning |
| 15:51.39 | JunK-Y | The_Boy_Wonder: ping? |
| 15:51.50 | The_Boy_Wonder | hey |
| 15:51.55 | JunK-Y | whois The_Boy_Wonder |
| 15:51.57 | jsmith | JunK-Y: If you remember to set the option, then you'd remember to call Answer() |
| 15:52.15 | jsmith | JunK-Y: If you forget to call Answer(), then you'd forget to add the option to Queue() |
| 15:52.37 | jsmith | JunK-Y: (and I don't think it's a good idea to change the default behavior of Queue() to answer *without* a noanswer option) |
| 15:52.41 | JunK-Y | The_Boy_Wonder: want to take a look at 2 iax scenarios, in which case the 2nd isnt sending an ANSWER frame? |
| 15:52.43 | russellb | JunK-Y: The_Boy_Wonder is David Vossel, a developer here at Digium |
| 15:53.03 | russellb | JunK-Y: I'm going to proxy decline for The_Boy_Wonder :-) |
| 15:53.08 | russellb | he's working on a bug for me right now :-p |
| 15:53.08 | The_Boy_Wonder | lol |
| 15:53.13 | JunK-Y | russellb: thats what ive figured out, batman! |
| 15:53.22 | The_Boy_Wonder | ! |
| 15:53.43 | JunK-Y | davidvos@asterisk/batman-developer/dvossel i love this |
| 15:54.03 | JunK-Y | russellb: all right, i will leave him to you. |
| 15:54.10 | JunK-Y | The_Boy_Wonder: just ping me when you get time. |
| 15:54.48 | JunK-Y | jsmith: okay |
| 15:54.59 | JunK-Y | so when the early media then ? :) |
| 15:55.04 | The_Boy_Wonder | JunK-Y will do, probably later this afternoon |
| 15:55.31 | JunK-Y | all right, thanks |
| 16:07.35 | *** join/#asterisk-dev shazaum (n=shazaum@unaffiliated/shazaum) |
| 16:08.01 | *** join/#asterisk-dev mog (n=mog@c-68-62-169-246.hsd1.al.comcast.net) |
| 16:08.01 | *** mode/#asterisk-dev [+o mog] by ChanServ |
| 16:08.54 | *** join/#asterisk-dev Octothorpe (n=Octothor@pdpc/supporter/professional/octothorpe) |
| 17:10.25 | *** join/#asterisk-dev DarkRift (n=dark@65.92.166.150) |
| 17:26.52 | *** join/#asterisk-dev davevg-btwtech (n=davevg-b@nj-67-76-177-147.sta.embarqhsd.net) [NETSPLIT VICTIM] |
| 17:32.06 | *** join/#asterisk-dev janinge (i=j@ninge.net) [NETSPLIT VICTIM] |
| 17:33.27 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@bzq-179-75-202.static.bezeqint.net) |
| 17:33.27 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 17:41.59 | tzafrir_laptop | is back to civilization^Winternet connectivity |
| 17:44.15 | leifmadsen | Octothorpe: y0! |
| 17:47.22 | russellb | The_Boy_Wonder: ping |
| 17:47.57 | russellb | The_Boy_Wonder: in 187426, you added the ast_strdupa() to get_cid_name(), but that needs to be done with the channel locked. |
| 17:48.06 | putnopvut | russellb: he just left for lunch. |
| 17:48.07 | russellb | so you'll need to lock/unlock the channel from within that function |
| 17:48.09 | russellb | rawr |
| 17:48.12 | *** join/#asterisk-dev qdk (n=qdk@146.63.48.86.ip.jay.net) |
| 17:48.21 | putnopvut | he'll see it when he gets back though. |
| 17:48.25 | russellb | true |
| 18:08.02 | tzafrir_laptop | Any point in keeping asterisk/trunk/contrib/initd.d/rc.mandriva.zaptel ? |
| 18:09.21 | Corydon76-dig | tzafrir_laptop: are you saying that Mandriva is not a legitimate distribution? |
| 18:09.47 | tzafrir_laptop | no. I'm saying that a zaptel init,.d script does not belong in the asterisk tarball |
| 18:10.13 | tzafrir_laptop | rc.mandriva.asterisk certainly belongs there |
| 18:14.59 | Corydon76-dig | I'm fine with moving it |
| 18:19.45 | *** join/#asterisk-dev Pazzo (n=ugelt@reserved-225136.rol.raiffeisen.net) |
| 18:48.01 | russellb | Corydon76-dig: before you spend more time on merging that manager patch, please read my message on the -dev list |
| 18:48.23 | Corydon76-dig | k |
| 18:52.35 | Corydon76-dig | russellb: I've replied. |
| 18:59.53 | mvanbaak | russellb: ping |
| 19:03.22 | putnopvut | astman.c isn't compiling in 1.6.0 presently, FYI. |
| 19:03.22 | putnopvut | Looks like a problem in lock.h |
| 19:03.22 | putnopvut | Ah, trying to pass a timeval pointer where a timespec pointer is expected. |
| 19:03.22 | putnopvut | That would be problematic. |
| 19:03.22 | putnopvut | Corydon76-dig: ^^^ Looks like the new stuff you added caused this. |
| 19:03.26 | Corydon76-dig | putnopvut: fixing |
| 19:03.30 | putnopvut | Looks like it's just a typo. |
| 19:03.32 | Corydon76-dig | putnopvut: stupid conflicts |
| 19:03.40 | *** join/#asterisk-dev pmhaddad-work (n=pmhaddad@141.219.87.43) |
| 19:04.08 | putnopvut | Corydon76-dig: thanks |
| 19:06.21 | mvanbaak | russellb: I replied to your mail on -dev about reviewboard |
| 19:06.39 | mvanbaak | it's an issue I have been wondering about for some time now |
| 19:11.09 | mvanbaak | how to make sure code on reviewboard that's get the 'ship it' mark is contributed with a signed license |
| 19:11.53 | putnopvut | mvanbaak: I think that consideration is why russell added the portion in the guidelines about us preferring that the issue go through Mantis. |
| 19:13.15 | mvanbaak | yeah, but still. |
| 19:13.28 | mvanbaak | on mantis there's actually a way to track it |
| 19:13.34 | mvanbaak | on reviewboard there isn't |
| 19:14.17 | seanbright | so what is the proposed remedy? |
| 19:14.54 | mvanbaak | add the same restriction as we have on mantis to reviewboard |
| 19:15.35 | seanbright | we already did that i thought |
| 19:15.43 | mvanbaak | link it to the license database we already have on mantis (we already get the users from there) |
| 19:15.55 | seanbright | the mantis-auth-backend.diff.txt in repotools/reviewboard is checking licenses at least |
| 19:16.06 | seanbright | + user.response_str = "You do not have a current license agreement. You must complete the electronic license agreement on http://bugs.digium.com/ to log in to reviewboard." |
| 19:16.23 | mvanbaak | hhmm |
| 19:16.32 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 19:16.41 | mvanbaak | if that's in production, my point is moot |
| 19:17.08 | mvanbaak | I did not notice it, because I do have a signed license |
| 19:18.22 | putnopvut | Ah, good catch seanbright. Looks like russell may have already thought of that point. |
| 19:19.18 | file | right |
| 19:19.34 | file | it shouldn't let you in if you don't have an active license agreement on file |
| 19:19.40 | file | if it doesn't that is ungood |
| 19:19.47 | seanbright | puts an active license agreement on file |
| 19:19.57 | *** join/#asterisk-dev outtolunc (n=me@adsl-66-218-53-172.dslextreme.com) |
| 19:19.59 | file | no! don't overwrite it! |
| 19:20.08 | seanbright | reverts |
| 19:20.51 | Corydon76-dig | adds a sublicensing clause to file |
| 19:28.42 | mvanbaak | rerelease it under 3-clause BSD license |
| 19:41.01 | *** join/#asterisk-dev anthm][ (n=anthm@CPE-70-92-139-151.wi.res.rr.com) |
| 20:03.03 | *** join/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 20:03.11 | *** part/#asterisk-dev djbelieny (n=djbelien@72-48-61-165.dyn.grandenetworks.net) |
| 20:26.37 | mvanbaak | hhmm, I have an idea |
| 20:27.15 | mvanbaak | what if we add an extra link for code patches on mantis that will only show for bugmarshals and the submitter of the patch that will put the patch on reviewboard |
| 20:27.22 | mvanbaak | 'submit for review' |
| 20:28.08 | mvanbaak | it will take the synopsis and additional info as data for the review, adds the patch, and submits it |
| 20:28.25 | mvanbaak | that will lower the bar to actually use it |
| 20:28.44 | mvanbaak | I just removed olle's email so cannot reply to it from my mutt |
| 20:28.58 | mvanbaak | any webbased interface to reply on the list ? |
| 20:29.17 | oej | hey, friend. Removed me? |
| 20:30.37 | mvanbaak | removed the email you sent |
| 20:30.54 | mvanbaak | http://marc.info/?l=asterisk-dev&m=123930502630329&w=2 |
| 20:30.56 | mvanbaak | that one |
| 20:31.18 | mvanbaak | I hit $ in mutt and then I thought: dammit, I wanted to reply |
| 20:31.51 | mvanbaak | oej: what you think about my idea ? |
| 20:32.11 | putnopvut | mvanbaak: I know I'm not oej, but may I step in and say that I like it? |
| 20:32.23 | mvanbaak | putnopvut: of course ! |
| 20:32.29 | oej | putnopvut: YOu may be my proxy. I'm too tired. |
| 20:32.41 | putnopvut | I'd love to be able to press a button and move a patch to review board. |
| 20:32.48 | mvanbaak | putnopvut: me too |
| 20:32.59 | putnopvut | Then I can just point the submitter to the comments I made there instead of asking them to upload the review themselves. |
| 20:33.18 | mvanbaak | putnopvut: that's the whole idea |
| 20:33.19 | Corydon76-dig | oej: do you believe that we should change interfaces in the middle of a release cycle? |
| 20:33.40 | oej | corydon: No. Just teasing. Sorry for that. |
| 20:33.43 | mvanbaak | putnopvut: and, it will be easier for committers to get their patches on reviewboard |
| 20:33.48 | file | it's a bit more involved, you do have to give reviewboard the right branch information so it can actually use the diff |
| 20:34.08 | Corydon76-dig | file: the branch information is located within a field in Mantis |
| 20:34.08 | mvanbaak | file: mantis has that info |
| 20:34.27 | Corydon76-dig | unless you're talking about developer branches |
| 20:34.51 | mvanbaak | that can be solved |
| 20:35.06 | Corydon76-dig | developer branches should be done from the command line, anyway |
| 20:35.34 | mvanbaak | add a version in the dropdown "developer branch" and let the submitter of the patch specify 'mvanbaak/foo-branch' |
| 20:36.31 | mvanbaak | it's not that hard. clicking the link can create the cli commands to checkout the branch and run the post-review script on it |
| 20:37.08 | mvanbaak | just queue it and let some cronjob handle the actual submitting of reviews |
| 20:41.48 | Corydon76-dig | oej: I'm guessing Russell agrees, since he hasn't responded |
| 20:42.41 | oej | corydon76-d: Ok |
| 20:44.11 | Corydon76-dig | Or he could be off putting out fires or in meetings or..... |
| 20:44.37 | mvanbaak | adding some extra time to his holidays ;) |
| 20:44.53 | russellb | Corydon76-dig: I have been in meetings |
| 20:45.29 | mvanbaak | russellb: scroll up |
| 20:45.30 | mvanbaak | ;) |
| 20:45.44 | mvanbaak | I had a great idea |
| 20:45.51 | Corydon76-dig | Yay meetings! |
| 20:45.52 | mvanbaak | of course totally not backed with code |
| 20:49.12 | Corydon76-dig | I was also looking at the deadlock detection code in trunk and realized that we could replace a bunch of busy loops with timed locks |
| 20:49.55 | russellb | before you go do anything like that, please post it up for review |
| 20:50.06 | Corydon76-dig | Will do |
| 20:50.17 | russellb | thanks :-) |
| 20:50.44 | Corydon76-dig | I realized it during the merge and restrained my urge to do it right then |
| 20:51.50 | Corydon76-dig | Ooooh, just realized that we have pthread_mutex_timedlock, too |
| 20:52.30 | Corydon76-dig | We could totally knock out a bunch of busy loops |
| 20:52.37 | russellb | oh dear |
| 20:52.55 | russellb | be careful to not go fix bugs that don't exist :-) |
| 20:53.01 | Corydon76-dig | Heh |
| 20:54.36 | russellb | I'm not going to be able to respond to the AMI thread until late tonight, probably |
| 20:57.23 | mvanbaak | russellb: what you think of my idea bout mantis -> reviewboard |
| 20:59.16 | russellb | I think it's a great idea, I've had that in my mind for a long time |
| 20:59.25 | russellb | the issue is someone actually implementing and testing it |
| 20:59.32 | mvanbaak | uhhuh |
| 20:59.33 | russellb | but i'm on board with the theory :-) |
| 20:59.44 | mvanbaak | hence my remark: 22:45 <@ mvanbaak> of course totally not backed with code |
| 21:03.14 | russellb | nods |
| 21:03.32 | russellb | I don't think the logistical issues of getting the code posted are the biggest concern |
| 21:03.58 | mvanbaak | it's the issue of finding the branch to compare with |
| 21:04.06 | mvanbaak | specially when talking dev branches |
| 21:04.15 | russellb | It's getting the development community to agree to continue to raise the bar on code quality by expanding the process and work we do up front before commit |
| 21:04.33 | mvanbaak | not if we have this mantis change in place |
| 21:04.45 | russellb | that just gets the code posted |
| 21:04.53 | mvanbaak | leif or some other bugmarshal or the dev assigned to the issue can simply hit the link |
| 21:04.56 | russellb | that's a tiny amount of work compared to actually going through the process of getting code reviewed |
| 21:05.00 | russellb | and reviewing other people's code |
| 21:05.00 | mvanbaak | and it will be on rb |
| 21:05.14 | russellb | _that_ is what we have to all be on board with |
| 21:05.21 | mvanbaak | ah |
| 21:05.30 | mvanbaak | well, no review for 4 weeks == ok |
| 21:05.38 | mvanbaak | put something like that in place |
| 21:06.00 | russellb | it means we're doing more work (reviewing code, ensuring your code gets reviewed) for the benefit of raising quality standards and practices |
| 21:06.04 | mvanbaak | with code written by a comitter for an issue you can do that |
| 21:06.17 | mvanbaak | for code submitted by someone we dont really know it's different |
| 21:07.06 | mvanbaak | because if I fuckup chan_skinny you can reach me and if I cant resolve it in a timely matter I can revert it and start working on it in a devbranch |
| 21:07.21 | mvanbaak | with patches sent in by the community without commit access it's a bit harder to track it |
| 21:08.50 | mvanbaak | and with only a few patches on reviewboard it already shows we cant keep up |
| 21:08.54 | mvanbaak | sorry to say this |
| 21:09.09 | mvanbaak | but there are patches on there with 'last update: 3 months ago' |
| 21:09.56 | mvanbaak | 50% is over a month old |
| 21:10.09 | mvanbaak | update date that is |
| 21:12.20 | russellb | and there is a mantis issue that was opened in january of 2005 |
| 21:12.47 | russellb | but regardless of age, we shouldn't just throw it in because it has been a while, we have to set standards for quality, and it can't go in until they are met |
| 21:14.10 | russellb | heh |
| 21:14.14 | russellb | oops. |
| 21:16.07 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 21:21.26 | mvanbaak | yeah |
| 21:21.30 | mvanbaak | I know what you mean |
| 21:22.24 | mvanbaak | it's just that reviewboard submissions are patches that the dev think it's finished. if we use reviewboard for patches that are set to 'ready for review' testing is already done |
| 21:22.40 | mvanbaak | with bugreports it's a bit different |
| 21:24.07 | mvanbaak | for example, a bug in chan_skinny that the 5th MWI button on $exotic_no_longer_available_device is blinking instead of on when there's voicemail is ok to stay there for a year (if no patch is submitted) but a review means ppl went thru all the work to create a patch, test it, and upload it with a signed agreement |
| 21:24.37 | mvanbaak | so they should be processed a bit sooner then the bugreport without patch on an issue that's not really important |
| 21:25.18 | russellb | right, so now you're talking about prioritizing bug reports .. |
| 21:25.32 | russellb | I can't set up priorities that apply to the community |
| 21:25.39 | russellb | as nobody agrees on what is most important |
| 21:25.58 | russellb | you can say what's most important to you, and I can say what's most important to me, and we go work on those things .. |
| 21:26.20 | mvanbaak | I know |
| 21:26.45 | mvanbaak | but an issue with code ready for review is almost done |
| 21:27.04 | mvanbaak | and an issue without code at all is going to take some time. |
| 21:27.14 | mvanbaak | I'm not saying digium has to do all the work |
| 21:27.24 | russellb | oh trust me, not all issues with code are even close to ready :-) |
| 21:27.25 | mvanbaak | bugmarshals should also monitor reviewboard |
| 21:27.36 | mvanbaak | I know |
| 21:27.37 | russellb | but I get your point. |
| 21:27.48 | mvanbaak | that's why I said: issues with code 'ready for review' |
| 21:28.15 | russellb | ah |
| 21:28.47 | mvanbaak | it's always hard to manage this type of things |
| 21:28.48 | mvanbaak | I know |
| 21:29.06 | mvanbaak | I'm tech/release/core manager of a couple of projects |
| 21:29.47 | *** part/#asterisk-dev marta (n=marta@onelab1.iet.unipi.it) |
| 21:37.25 | mvanbaak | <PROTECTED> |
| 21:37.51 | russellb | <PROTECTED> |
| 21:38.02 | mvanbaak | sorry |
| 21:38.07 | mvanbaak | blame my cat |
| 21:38.14 | mvanbaak | she was walking around on my ibook |
| 21:39.14 | mvanbaak | http://picasaweb.google.com/mvanbaak/Tekkel#5269394864692818098 |
| 21:39.18 | mvanbaak | that's her |
| 21:51.05 | mvanbaak | AST-* is your internal bugtracker ? |
| 21:51.27 | russellb | nods |
| 21:52.08 | mvanbaak | that makes it clear. thank you |
| 22:08.50 | snuff-home | sighs.. i forgot to fix automerge on ao2_jabber again.. *crosses fingers n hopes for best* |
| 22:12.58 | mvanbaak | I'm going to bed |
| 22:12.59 | mvanbaak | bye |
| 22:14.12 | snuff-home | later mvanbaak |
| 22:31.48 | *** join/#asterisk-dev shazaum (n=shazaum@unaffiliated/shazaum) |
| 22:32.59 | *** join/#asterisk-dev eliel (n=eliels@151-202-114-200.fibertel.com.ar) |
| 22:32.59 | *** mode/#asterisk-dev [+o eliel] by ChanServ |
| 23:03.00 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 23:23.18 | *** part/#asterisk-dev macli (n=macli@nmc.brc.ubc.ca) |
| 23:31.20 | *** join/#asterisk-dev shazaum (n=shazaum@unaffiliated/shazaum) |