| 00:06.49 | snuff-work | lol |
| 00:17.25 | *** join/#asterisk-dev Deeewayne (n=dwayne@c-71-228-179-90.hsd1.al.comcast.net) |
| 00:17.25 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 00:56.56 | *** join/#asterisk-dev Ta^3 (n=tacvbo@189.146.189.241) |
| 01:26.34 | *** join/#asterisk-dev Mw3 (i=mw3@88.151.97.220) |
| 03:07.14 | *** join/#asterisk-dev JimDickenson (n=dickenso@c-98-232-185-121.hsd1.or.comcast.net) |
| 05:06.50 | *** join/#asterisk-dev Tim_Toady (n=moi@adsl119-198.kln.forthnet.gr) |
| 05:11.16 | *** join/#asterisk-dev ms110 (n=shehzad@122.169.77.107) |
| 05:17.24 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 05:17.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 05:30.04 | *** join/#asterisk-dev jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 05:33.41 | *** part/#asterisk-dev jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 05:43.47 | *** join/#asterisk-dev mog (n=mog@c-68-62-169-247.hsd1.al.comcast.net) |
| 05:43.47 | *** mode/#asterisk-dev [+o mog] by ChanServ |
| 05:47.29 | *** join/#asterisk-dev jmls_ (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 05:53.56 | *** join/#asterisk-dev jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 05:58.07 | jmls | morning all |
| 05:58.20 | jmls | is feeling much better after the first cup of coffee |
| 05:59.10 | mvanbaak | same here :) |
| 06:00.07 | oej | morning |
| 06:02.07 | mvanbaak | mornin |
| 06:04.23 | *** join/#asterisk-dev fiddur (n=fiddur@dhcp08.textalk.com) |
| 06:07.16 | *** join/#asterisk-dev |Cybex| (n=John@atwork-26.r-212.178.82.atwork.nl) |
| 06:16.06 | snuff-work | afternoon ppls |
| 06:16.09 | snuff-work | ;) |
| 06:23.38 | fiddur | g'morning :) |
| 06:25.14 | *** join/#asterisk-dev obnauticus (n=l@about/windows/regular/obnauticus) |
| 06:25.24 | *** join/#asterisk-dev sergee (n=serg@voip1.west-call.com) |
| 06:29.18 | mvanbaak | hahahaha |
| 06:29.36 | mvanbaak | oej: your commit left a comment on a very old bug |
| 06:29.54 | snuff-work | oej.. mute audio has an optionally flag as to which way? or because you hear it (vs talking) |
| 06:31.12 | oej | mvanbaak: What do you mean? |
| 06:31.22 | oej | snuff_work: yes |
| 06:31.46 | russellb | oej: When you said Reviewboard #345, it probably added a comment to issue #345 |
| 06:31.52 | mvanbaak | oej: the reviewboard url had an id of a ticket. So svnbot left your commit as comment on issue 345 |
| 06:31.53 | russellb | it will grab "#<issue>" |
| 06:32.07 | oej | :-) |
| 06:32.11 | oej | Someone will be surprised |
| 06:32.16 | russellb | typically, we do "Review: https://reviewboard.asterisk.org/r/345/" |
| 06:32.16 | oej | russellb: Up late? |
| 06:32.19 | russellb | nods |
| 06:32.34 | mvanbaak | funny thing is: the issue was to add 'logger rotate' to asterisk |
| 06:32.36 | russellb | if you use the syntax I just said, the review request will get closed out for you automatically |
| 06:32.38 | oej | I tried to find that in the doxygen, because I could not find a commit with it... Next time. |
| 06:32.46 | mvanbaak | so I was like: WTF ? |
| 06:32.49 | russellb | it's there somewhere, let me look ... |
| 06:33.10 | russellb | http://www.asterisk.org/doxygen/trunk/CommitMessages.html |
| 06:33.13 | oej | If it is, then it's to early for me... gotta go take a shower |
| 06:33.26 | oej | Ahh, I just checked the reviewboard part |
| 06:33.59 | oej | bad |
| 06:34.04 | russellb | oh, and a cool thing you can do with svn ... you can go back and edit commit messages |
| 06:34.07 | russellb | no big deal ... |
| 06:34.11 | russellb | just sharing info |
| 06:34.34 | *** join/#asterisk-dev tzafrir_laptop (n=tzafrir@local.xorcom.com) |
| 06:34.34 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 06:34.48 | russellb | $ svn propedit --revprop -r 215382 svn:log https://origsvn.digium.com/svn/asterisk/ |
| 06:35.23 | oej | I know, but it won't change much... |
| 06:36.07 | russellb | I can fix the URL if you'd like. My scripts that parse commit messages will appreciate it. :-) |
| 06:37.03 | russellb | done |
| 06:38.58 | oej | That was an unknown reason to fix it... |
| 06:39.07 | oej | Thanks |
| 06:39.57 | oej | That match-on-contact stuff needs to be fixed too, Russell. It breaks backwards compatibility and is a bad hack... I must have been sleeping when it was committed. |
| 06:40.02 | oej | And it's in release code. |
| 06:42.32 | oej | Time for a shower :-) |
| 06:42.37 | russellb | the parsing of commit messages is done for the release summary that is distributed with releases. However, I don't think it looks for reviewboard URLs yet ... |
| 06:42.54 | russellb | goes back to look for the match on contact commit to refresh my memory ... |
| 06:43.19 | oej | I am trying to find the commit |
| 06:43.56 | oej | running svn blame here takes forever, you have a faster connection to the server |
| 06:44.29 | russellb | someone shared a good idea with me the other day - having a local copy of asterisk in a git repository, instant blame that way |
| 06:44.33 | oej | and svnview... I missed it |
| 06:45.05 | oej | But it will take a while to import from svn to git ;-) |
| 06:46.11 | russellb | yeah, that takes a day or so, heh. |
| 06:46.28 | oej | For someone who is on a good connection to the svn server... |
| 06:47.55 | russellb | found it in svn log i think |
| 06:48.02 | russellb | 193387 |
| 06:53.15 | oej | No bug, no reviewboard |
| 06:53.22 | russellb | should go back to bed ... |
| 06:54.01 | oej | Thanks for finding this. It really needs to be reverted. |
| 06:54.12 | oej | Can you handle that with dvossel tomorrow? |
| 06:55.05 | russellb | I will review it tomorrow, yeah. |
| 06:57.23 | oej | Ok, you are allowed to go back to bed ;-) |
| 07:06.09 | mvanbaak | 08:43 <@ russellb> someone shared a good idea with me the other day - having a local copy of asterisk in a git repository, instant blame that way |
| 07:06.14 | mvanbaak | svk can do that as well |
| 07:12.11 | *** join/#asterisk-dev Hatrix (n=Hatrix@213.201.24.127.static.user.ono.com) |
| 07:28.41 | mvanbaak | hhmm, svk sync takes forever as well |
| 07:28.44 | mvanbaak | Syncing https://origsvn.digium.com/svn/asterisk/trunk |
| 07:28.44 | mvanbaak | Retrieving log information from 1 to 215414 |
| 07:29.50 | russellb | ok, so i haven't gone back to bed yet ... :-p |
| 07:30.01 | russellb | stupid internet ... being distracting ... |
| 07:30.08 | russellb | i'm also trying to import trunk into mercurial |
| 07:30.17 | russellb | but it's taking even longer than git did |
| 07:33.55 | russellb | passes out for real this time |
| 07:34.23 | *** join/#asterisk-dev oej (n=olle@ns.webway.se) |
| 07:34.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:51.09 | *** join/#asterisk-dev tamiel (n=tamiel@213.30.183.226) |
| 07:59.01 | *** join/#asterisk-dev ZX81 (n=Matt_Rid@121.74.5.86) |
| 08:03.05 | tzafrir_laptop | mvanbaak, russellb, reminder: http://git.tzafrir.org.il/?p=asterisk-tools.git;a=blob;f=git-asterisk-howto |
| 08:04.00 | tzafrir_laptop | Though if anybody knows how to use it for team branches as well, I'm interested |
| 08:06.37 | oej | You could publish that on asterisk.org or include it in doc/dev in trunk. It's a good document I think |
| 08:06.55 | oej | "The main Asterisk repository tends to get new commits occasionally" - statement of the day! ;-) |
| 08:10.06 | *** join/#asterisk-dev jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 08:14.58 | tzafrir_laptop | oej, do you think it's worth adding to doc/dev ? |
| 08:16.01 | oej | Yep, it's good stuff. Obvsiously. Even Russell, who's practically sitting on top of the SVN, thinks it is worth filling the hard disk drive with a GIT repo. |
| 08:16.48 | oej | We might want a copy of the tools in a repo in origsvn or community or so for backup. |
| 08:28.50 | *** join/#asterisk-dev _ys (n=ys@xgw.infor.net.ru) |
| 08:30.28 | *** join/#asterisk-dev fiddur (n=fiddur@dhcp08.textalk.com) |
| 08:38.10 | tzafrir_laptop | Done. https://issues.asterisk.org/view.php?id=15814 |