| 00:50.22 | *** join/#asterisk-dev snuff-work (n=aaa@120.17.88.140) |
| 00:50.22 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 01:32.57 | paravoid | are there any plans/list of tasks for ipv6? |
| 01:33.24 | paravoid | Google doesn't reveal much, only a weird fork called asteriskv6 |
| 02:11.57 | seanbright | http://svnview.digium.com/svn/asterisk/team/group/v6/trunk/ |
| 02:32.42 | snuff-work | paravoid: its on the todo.. but other than that i think its just sitting there |
| 02:37.21 | *** join/#asterisk-dev xpot-mobile (n=xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 02:44.57 | *** join/#asterisk-dev philipp64 (n=chatzill@63.224.43.239) |
| 03:38.10 | *** join/#asterisk-dev jeffg (n=jeffg@pdpc/supporter/professional/jeffg) |
| 04:10.01 | *** part/#asterisk-dev alecdavis (n=alec@202.36.76.21) |
| 06:37.08 | *** join/#asterisk-dev xpot (n=xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 06:51.08 | *** join/#asterisk-dev snuff-work (n=aaa@210.9.82.197) |
| 06:51.08 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 07:13.09 | *** join/#asterisk-dev xpot (n=xpot@70-91-210-233-BusName-Utah.hfc.comcastbusiness.net) |
| 07:35.13 | *** join/#asterisk-dev mpe (n=mpe@gate.ipvision.dk) |
| 08:20.41 | *** join/#asterisk-dev vrban (n=chatzill@p50997436.dip0.t-ipconnect.de) |
| 08:48.20 | *** join/#asterisk-dev tamiel (n=tamiel@213.30.183.226) |
| 08:49.02 | *** join/#asterisk-dev DarkRift (n=dark@65.92.167.131) |
| 08:50.44 | *** join/#asterisk-dev beres (n=nihil@79.143.115.228) |
| 10:08.28 | *** join/#asterisk-dev jmls (n=jmls@host217-36-208-155.in-addr.btopenworld.com) |
| 10:08.54 | jmls | gooooood morrrrrrrrrrrrrrring all ! |
| 10:09.03 | jmls | is in happy place |
| 10:09.05 | jmls | ;) |
| 10:09.25 | jmls | got a real -dev type question here |
| 10:10.21 | jmls | how difficult would it be to temporarily swap one of the channels of mixmonitor to another sound source (like white noise or a gsm file), and then swap it back to the original channel ? |
| 10:10.54 | jmls | could that be done with the new audio hooks in 1.6xx ? |
| 10:11.03 | jmls | waits with bated breath ... |
| 10:19.31 | jmls | turns blue |
| 10:19.35 | jmls | :) |
| 10:20.01 | jmls | got ..... to ... hold ... out until ... USA .... wakes .... up .... |
| 10:20.04 | jmls | gasp |
| 10:20.24 | jmls | or are you all playing cod mw2 ? |
| 10:35.18 | snuff-home | hehe |
| 10:35.56 | snuff-home | jmls: i think they are sleepin still |
| 10:44.34 | jmls | looks like it |
| 10:44.36 | jmls | :( |
| 10:46.44 | snuff-home | i'd say give it 4 hrs.. |
| 10:48.23 | snuff-home | ur mixmonitor thing.. would u cause that by doing some dtmf to activate a 'feature' |
| 10:48.26 | snuff-home | ? |
| 10:50.05 | *** join/#asterisk-dev mpe (n=mpe@gate.ipvision.dk) |
| 10:57.12 | jmls | snuff-home: no, I need to send an AMI command. Let's say that we have channel A and B, with Mixmonitor recording the call. My agent is on B and needs to take a card number for a purchase. I want the agent to hear the card number, but for the number not to be recorded in the mixmonitor file. I can pause the recording, but that is not ideal. |
| 10:57.55 | snuff-home | ah.. |
| 10:58.10 | jmls | so, when the agent enters the card number field, I send an AMI command and inject "music" into the recording. When they leave the field, I send another AMI command and "normal" service is resumed. |
| 10:59.44 | snuff-home | interesting.. i'm sure they might have some ideas.. i am newb @ audiohooks |
| 11:00.37 | jmls | current commercial systems cost 10k+ per year. ;) |
| 11:27.29 | snuff-home | mm.. it shouldn't be too hard to make it silence though |
| 11:28.03 | jmls | silence would be goof |
| 11:28.07 | jmls | heh. good |
| 11:32.54 | snuff-home | but take my guess with grain of salt.. russ/file would be ppl who'd know :) |
| 11:59.28 | *** join/#asterisk-dev caio1982_ (i=caio1982@CAcert-br/caio1982) |
| 12:08.25 | *** join/#asterisk-dev caio1982 (i=caio1982@CAcert-br/caio1982) |
| 12:14.28 | *** join/#asterisk-dev puzzled (n=foobar@puzzled.xs4all.nl) |
| 12:21.10 | jmls | hmm. 7am. must be time for people to be awake :) |
| 12:21.20 | jmls | ~ring devs |
| 12:21.20 | infobot | before devs dies, they see the ring |
| 12:21.32 | jmls | whoa! |
| 12:21.49 | jmls | recalls the assasins |
| 12:22.10 | jmls | ~calm devs |
| 12:22.10 | infobot | ACTION sooths devs, offers a backrub, tea, a jacuzzi and anything else that might help calm devs down. |
| 12:22.16 | jmls | heh |
| 12:22.32 | jmls | maybe not anything else ;) |
| 12:22.42 | jmls | is a married potato |
| 12:35.17 | *** join/#asterisk-dev Victor_Yure (n=victor@unaffiliated/victoryure/x-837844) |
| 12:39.59 | *** join/#asterisk-dev kpfleming (n=kpflemin@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:40.00 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 13:02.12 | *** join/#asterisk-dev anonymouz666 (n=anonymou@189.24.121.163) |
| 13:12.45 | *** join/#asterisk-dev leifmadsen (n=Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 13:12.45 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:36.39 | jmls | file: ping ? |
| 13:36.49 | file | I didn't do it? |
| 13:36.59 | jmls | not yet you haven't ;) |
| 13:37.07 | jmls | but I want you to ... |
| 13:37.35 | jmls | did you catch my question earlier about mixmonitor ? |
| 13:37.44 | file | reads up |
| 13:38.19 | file | how are you injecting the audio? |
| 13:38.22 | file | a chanspy whisper? |
| 13:38.59 | jmls | I want to either mute or replace the audio going into mixmonitor from channel A |
| 13:39.11 | jmls | and then restore it when desired |
| 13:39.33 | jmls | so that the card number is not recorded in the mixminitor file |
| 13:39.40 | file | the answer to my question above changes how I answer ^_^ |
| 13:39.55 | jmls | um , ok, |
| 13:40.43 | jmls | just using Mixmonitor in the dialplan |
| 13:40.52 | file | right |
| 13:40.57 | file | but how are you injecting your card number? |
| 13:41.13 | jmls | the guy on the phone reads it out to my agent ;) |
| 13:41.21 | file | ohhhh... erm |
| 13:41.34 | jmls | I can intercept the point where they are about to take the card details |
| 13:41.41 | jmls | and send an AMI command |
| 13:41.50 | file | uh, yeah, that's not easy with the current way of things... |
| 13:42.06 | file | BUT |
| 13:42.14 | jmls | jmls likes a big BUT ;) |
| 13:42.23 | *** join/#asterisk-dev jeffg (n=jeffg@pdpc/supporter/professional/jeffg) |
| 13:42.40 | file | I bet you could add a flag to audiohooks that causes it to ignore audio it got from the channel and use silence |
| 13:42.46 | jmls | cooool |
| 13:42.49 | file | and then add AMI actions to mixmonitor to set/unset the flag |
| 13:42.55 | jmls | yeah |
| 13:43.19 | jmls | mute is just as good as any other audio |
| 13:43.28 | jmls | for my purposes, anyway |
| 13:43.47 | file | yup yup |
| 13:44.57 | jmls | I take it that this would have to be a 1.6 / trunk feature, not back-portable to 1.4 ? |
| 13:45.17 | file | trunk only for inclusion |
| 13:45.28 | file | 1.4 has audiohooks as well. |
| 13:45.33 | jmls | oohhh, ok |
| 13:45.37 | file | (if you wish to maintain your own backport) |
| 13:45.50 | jmls | and mixmonitor uses audiohooks in 1.4 |
| 13:46.06 | jmls | ? |
| 13:46.17 | jmls | (sorry, missed the ? to make it a question!) |
| 13:46.22 | file | yes |
| 13:47.20 | jmls | yummy |
| 13:47.58 | jmls | is it a difficult task ? |
| 13:48.51 | file | not really |
| 13:50.16 | jmls | 's day is just getting better and better |
| 13:57.23 | jmls | could you use the ast_audiohook_volume_adjust function to set the volume to 0 ? |
| 13:57.48 | *** join/#asterisk-dev moy (n=moy@74.12.123.169) |
| 13:57.50 | jmls | or would that affect the whole channel, not just mixmonitor |
| 13:58.48 | file | whole channel. |
| 14:06.51 | jmls | dammit |
| 14:06.53 | jmls | :( |
| 14:17.05 | *** join/#asterisk-dev elguero (n=_miguel3@ns1.nashuacs.com) |
| 14:30.45 | *** join/#asterisk-dev putnopvut (n=putnopvu@asterisk/master-of-queues/mmichelson) |
| 14:30.45 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:03.47 | *** join/#asterisk-dev kpfleming (n=kpflemin@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:03.48 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:35.22 | *** join/#asterisk-dev The_Boy_Wonder (n=vossel@asterisk/batman-developer/dvossel) |
| 15:35.22 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 15:36.40 | *** join/#asterisk-dev sruffell (n=sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:36.40 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:40.46 | jmls | surrenders. |
| 15:41.09 | jmls | ok, don't think I can do this myself, despite it being "not really" difficult :( |
| 15:43.49 | Corydon76-dig | pokes jmls with a pointy stick |
| 15:51.30 | leifmadsen | oej added mutestream to trunk -- does that help at all? |
| 15:51.53 | leifmadsen | perhaps he figured something out already to make your implementation easier? |
| 15:52.49 | file | that uses an audiohook to silenceify audio to/from the channel, it's not for control at the level of something going to an audiohook itself |
| 15:53.35 | jsmith | file: Since you're the audiohook expert, why not use this opportunity to teach us all a thing or two about building a simple audiohook :-p |
| 15:53.48 | file | he doesn't need to build an audiohook |
| 15:54.19 | jsmith | Oh, just an AMI action to unbridge the audio from the monitor, and then re-bridge it? |
| 15:54.22 | kpfleming | this is for mixmonitor? |
| 15:54.29 | jsmith | Yeah, I think so |
| 15:54.34 | jsmith | If I'm understanding right |
| 15:54.49 | kpfleming | yeah... no need for a new audiohook, and you can't use mutestream because the captured audio isn't going to a channel |
| 15:55.15 | jsmith | Think of it as PauseMonitor(), only just inserting silence instead of pausing the recording |
| 15:55.21 | kpfleming | yep |
| 15:55.56 | *** join/#asterisk-dev jpeeler (n=jpeeler@asterisk/digium-software-dev/jpeeler) |
| 15:55.56 | *** mode/#asterisk-dev [+o jpeeler] by ChanServ |
| 15:57.18 | jmls | Corydon76-dig: that wasn't very nice |
| 15:57.22 | file | jmls: if you ask a specific question or describe where you are having a problem I can answer |
| 15:57.31 | jmls | (i have much delated reactions!) |
| 15:58.11 | jmls | file: thanks |
| 15:58.17 | Corydon76-dig | Not to mention nispellef |
| 15:58.21 | jmls | don't forget I am no c man;) |
| 15:58.46 | jmls | Corydon76-dig: yeah yeah. I didn't have a gud edukation where gru up I |
| 15:59.24 | jmls | file. Ok. My first thought was to turn the volume on the audio hook to zero |
| 15:59.43 | jmls | but I would also then need to record the previous volume value and use it when restored |
| 15:59.45 | jmls | yuk |
| 15:59.56 | Corydon76-dig | cuz I'm the Tilghman... yeah yeah-ah, I'm the Tilghman... And you're working for no one but me... |
| 16:00.07 | kpfleming | wanders away |
| 16:00.21 | file | jmls: silence is zeroes, create a buffer that contains zeroes the same size as the buffer that contains the real audio |
| 16:00.44 | file | jmls: save a pointer to the current buffer of audio, change the frame data pointer to go to the buffer containing all zeroes |
| 16:00.45 | jmls | in each frame received by the audio hook |
| 16:01.01 | file | jmls: have ast_slinfactory_feed get called, then restore the frame data pointer to the old one |
| 16:01.18 | file | silence will get put in. |
| 16:01.38 | jmls | this is in audiohook.c, right ? |
| 16:01.43 | file | yes |
| 16:01.52 | jmls | yay! got something right ;) |
| 16:02.28 | jmls | ast_audiohook_volume_adjust ... ? |
| 16:02.31 | jmls | no no. |
| 16:02.33 | jmls | sorry. |
| 16:02.44 | Corydon76-dig | (Sorry. He said C man, and the Beatles' Taxman immediately rose to mind.) |
| 16:02.45 | file | ast_audiohook_write_frame |
| 16:03.06 | jmls | wow. strange, I copied _frame, pasted _volume adjust. Did it again ! |
| 16:03.13 | Corydon76-dig | (It's FRIDAY!) |
| 16:03.26 | jmls | file , that's where I was looking |
| 16:04.02 | jmls | would it make sense to create the silence buffer at the top level, so I'm not creating and releasing the buffer the whole time ? |
| 16:05.04 | file | ummm I'd just put it on the stack, it's not that huge |
| 16:05.42 | jmls | c thing. No idea what you just said ... told you when it comes to C I'm stupid. Willing to try, but stupid |
| 16:07.48 | jmls | the other thing that got me was how do I find what audiohook is used by mixmonitor . I was looking at the mixmonitor structure which has the ast_audio_hook structure |
| 16:10.11 | seanbright | "put it on the stack" = "just make it a local variable in the fuction" |
| 16:10.24 | jmls | oh. see, that was easier ;) |
| 16:10.52 | seanbright | i need that feature as well, so send me your patch when you're done |
| 16:10.53 | seanbright | :-) |
| 16:11.02 | file | as for your second statement you don't need to know something is used by mixmonitor in audiohook, you just need flags in audiohook to enable this feature |
| 16:11.11 | file | and since you have the audiohook itself in mixmonitor you can set/unset the flags there |
| 16:12.22 | *** join/#asterisk-dev anthm (n=anthm@freeswitch/developer/anthm) |
| 16:14.32 | jmls | file, you are going to regret this. I can feel it. (offering to help, that it) |
| 16:14.40 | jmls | yeah, ok, was getting to that point. I think. However, how do I know which channel to mute ? |
| 16:15.20 | file | shrugs |
| 16:15.33 | file | that's up to you :P |
| 16:16.43 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 16:19.52 | jmls | Mixmonitor is on the originating channel. (is that mixmonitor->autochan->chan ?) and I can get the bridged channel by ast_bridged_channel(mixmonitor->autochan->chan) |
| 16:22.00 | seanbright | are you working against 1.4 SVN? |
| 16:22.10 | jmls | at the moment, yes |
| 16:22.21 | jmls | although if I have to move to 1.6, I will .. |
| 16:25.48 | seanbright | meh... i shouldn't get involved |
| 16:25.52 | seanbright | i'll just lead you astray |
| 16:41.15 | jmls | seanbright: you can't say that ! |
| 16:55.34 | jmls | maybe he can ... |
| 16:55.54 | seanbright | heh |
| 17:01.21 | *** join/#asterisk-dev CunningPike (n=CunningP@204.239.8.157) |
| 17:02.03 | *** join/#asterisk-dev jtodd (i=amy33aok@asterisk/community-director-and-tie-dye-shirt-lover/jtodd) |
| 17:02.03 | *** mode/#asterisk-dev [+o jtodd] by ChanServ |
| 17:19.46 | *** join/#asterisk-dev Corydon76-dig (i=silver@c-69-137-80-31.hsd1.tn.comcast.net) |
| 17:19.46 | *** mode/#asterisk-dev [+o Corydon76-dig] by ChanServ |
| 17:21.34 | jmls | file: could I just swap the frame for a NULL frame (Empty, useless frame) ? |
| 17:21.45 | *** join/#asterisk-dev elguero (n=elguero@12.187.84.162) |
| 17:22.22 | file | 'tis not silence, it'll mess stuff up |
| 17:22.29 | jmls | bummer |
| 17:22.39 | file | you can certainly try |
| 17:22.48 | jmls | gee, thanks ;) |
| 17:22.59 | jmls | really doesn't want segfaults on his hands |
| 17:23.48 | jmls | wtf does |
| 17:23.50 | jmls | union { void *ptr; uint32_t uint32; char pad[8]; } |
| 17:23.58 | jmls | mean in the real world ? |
| 17:24.06 | jmls | :P |
| 17:24.22 | jmls | the bigger of the three ? |
| 17:24.28 | Qwell | the correct of the three |
| 17:24.57 | jmls | three ? or four ? |
| 17:25.18 | *** join/#asterisk-dev TheDavidFactor (n=chatzill@fw1.safedataisp.net) |
| 17:25.32 | jmls | so, union { void *ptr; uint32_t uint32; char pad[8]; } data; is just a pointer to data ? |
| 17:26.25 | Qwell | better let somebody else explain how that works |
| 17:26.36 | jmls | urrrggghhhh |
| 17:26.50 | jmls | how do you guys deal with this stuff day in and day out. |
| 17:26.56 | jmls | It's , like, horrible ! |
| 17:27.43 | kpfleming | nope. it's C. :-) |
| 17:29.33 | file | A, B, C! |
| 17:29.38 | file | it's easy as 1, 2, 3 |
| 17:29.50 | jmls | bullexcrement |
| 17:30.57 | jmls | does "short buf[size_t]; " init buf to zeros, or do I need to explictly do that |
| 17:34.07 | seanbright | you need to do it |
| 17:34.12 | seanbright | just use memset |
| 17:34.17 | seanbright | err |
| 17:34.51 | seanbright | short buf[1024] = { 0 }; |
| 17:34.55 | seanbright | that will initialize it to 0 |
| 17:35.22 | jmls | short buf[samples]; |
| 17:35.22 | jmls | struct ast_frame frame = { |
| 17:35.22 | jmls | .frametype = AST_FRAME_VOICE, |
| 17:35.22 | jmls | .subclass.codec = AST_FORMAT_SLINEAR, |
| 17:35.22 | jmls | .data.ptr = buf, |
| 17:35.22 | jmls | .datalen = sizeof(buf), |
| 17:35.24 | jmls | .samples = samples, |
| 17:35.26 | jmls | }; |
| 17:35.41 | seanbright | ~pb |
| 17:35.42 | infobot | [~pb] A "pastebin" is a web-based service where you can paste anything over 3 lines without flooding the channel. Here are links to a few : http://www.pastebin.com , http://pastebin.ca , http://channels.debian.net/paste , http://paste.lisp.org , http://bin.cakephp.org/ , or apt-get install pastebinit |
| 17:35.54 | jmls | 3 lines. Dammit. Thought it was 10 |
| 17:35.55 | jmls | sorry |
| 17:36.02 | jmls | I even counted ;) |
| 17:36.36 | jmls | so what is data.ptr set to in this case ? Unknown ? |
| 17:37.00 | jmls | or doesn't matter, coz it's going to get written into ? |
| 17:37.40 | file | it points to buf |
| 17:39.00 | jmls | so it doesn't matter what buf contains at this point in time ? |
| 17:39.25 | seanbright | correct |
| 17:39.38 | seanbright | but like i said |
| 17:39.50 | seanbright | short buf[samples] = { 0 }; |
| 17:39.57 | seanbright | that will fill buf with zeroes |
| 17:42.07 | seanbright | you can also do: short buf[1024] = {[0 ... 1023] = 42}; |
| 17:42.13 | seanbright | but that won't do what you want |
| 17:42.15 | seanbright | heh |
| 17:54.44 | jmls | thanks seanbright |
| 17:54.56 | jmls | poc code coming up soon ;) |
| 17:55.15 | Qwell | shoves seanbright into an undersized buffer |
| 17:57.03 | Corydon76-dig | jmls: A union is a set of variables that occupy the same memory space |
| 17:59.13 | jmls | Corydon76-dig: sounds nasty |
| 17:59.17 | Corydon76-dig | jmls: the general use of a union is variable whose type varies based upon some other variable in the struct. |
| 18:01.28 | Corydon76-dig | jmls: I have structs within unions in some places, especially when the purpose is one of decoding a stream of characters |
| 18:02.40 | Corydon76-dig | So the memory is filled with a stream of characters, and then you interpret what it all means, because the characters happen to line up in the struct... it's like a special decoder ring |
| 18:04.09 | Corydon76-dig | In fact, decoder ring is usually the easiest way of thinking about a union |
| 18:12.09 | *** join/#asterisk-dev Marquis42 (n=bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 18:37.33 | jmls | file: added some code to mute if flag set - there is currently no way of setting the flag, but just wanted to check I was in the right place. |
| 18:37.38 | jmls | http://pastebin.ca/1771033 |
| 18:37.53 | jmls | my changes prefixed with jmls |
| 18:38.08 | file | seem to be, yes |
| 18:39.20 | jmls | wow. |
| 18:39.33 | jmls | didn't expect that :-D |
| 18:39.44 | file | I'd make it two flags for muting based on the direction |
| 18:40.31 | jmls | right, was going to ask that. If mixmonitor is on channel A, is the person speaking on channel A reading or writing ? |
| 18:40.49 | jmls | sorry, should say, is the audio channel on A read or write ;) |
| 18:41.02 | file | audio coming from channel A is read |
| 18:41.06 | file | audio going to channel A is write |
| 18:42.03 | jmls | so I should check the direction with the appopriate flag |
| 18:42.15 | jmls | if direction = 1 and mute_read then zero |
| 18:42.15 | file | sure |
| 18:42.21 | jmls | cool. |
| 18:42.42 | jmls | dives back into the wonderful C language |
| 18:47.03 | seanbright | i hate alloca |
| 18:47.05 | seanbright | that is all. |
| 18:48.03 | seanbright | where is buf declared? |
| 18:48.07 | seanbright | i don't see it in your code |
| 18:48.51 | seanbright | nevermind. i think you just typo'd. |
| 18:57.53 | jmls | ok, try #2. Added read/write and fixed typo ;) |
| 18:57.54 | jmls | http://pastebin.ca/1771033 |
| 18:59.13 | jmls | seanbright: what would you use instead of alloca ? |
| 19:02.11 | *** join/#asterisk-dev alecdavis (n=sivad@202-78-149-14.cable.telstraclear.net) |
| 19:05.55 | *** join/#asterisk-dev moy (n=moy@74.12.123.169) |
| 19:16.23 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 19:24.21 | jmls | mmmm. |
| 19:24.31 | jmls | does ast_set_flag(audiohook, AST_AUDIOHOOK_MUTE_READ); |
| 19:24.45 | jmls | set the flag ? if so, how do you reset it ;) |
| 19:25.00 | jmls | I've tried reset, unset to no avail |
| 19:25.05 | Qwell | clear |
| 19:25.19 | jmls | that orthagonal ;) |
| 19:25.35 | Qwell | NIH |
| 19:36.28 | jmls | right. I think I've added options into audiohook.c to set the appropriate flags. I've tried to be clever and de-duplicate code. Probably failed, but like to know why ;) |
| 19:36.29 | jmls | ast_set_flag(audiohook, AST_AUDIOHOOK_MUTE_READ); |
| 19:36.36 | jmls | dammit. bloody paste |
| 19:36.39 | jmls | http://pastebin.ca/1771106 |
| 19:52.25 | jmls | crap. compile failed. |
| 19:52.32 | jmls | :( |
| 19:52.38 | jmls | ~smack jmls |
| 19:52.39 | infobot | ACTION smacks jmls upside the head. |
| 19:53.02 | snuff-home | heh everyone gets compilation failures coding :) |
| 19:53.18 | jmls | I copied the def for buf from app_sms.c |
| 19:53.37 | jmls | what should the def for frame data be ? int ? |
| 19:53.50 | jmls | sorry, pointer to frame data |
| 19:54.32 | jmls | see line 30 of http://pastebin.ca/1771106 |
| 19:54.47 | seanbright | use the source, jmls. |
| 19:55.05 | jmls | i tried. and failed. I am not destined to be a jedi knight |
| 19:55.17 | jmls | maybe I'm more on the dark side |
| 19:55.19 | *** part/#asterisk-dev Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 19:55.21 | seanbright | http://svnview.digium.com/svn/asterisk/branches/1.4/include/asterisk/frame.h?view=markup |
| 19:55.23 | *** join/#asterisk-dev Qwell (i=north@pdpc/sponsor/digium/Qwell) |
| 19:55.23 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 19:55.29 | seanbright | look at 'struct ast_frame' |
| 19:55.32 | seanbright | line 134 |
| 19:55.43 | snuff-home | mm.. also your frame.data should be frame->data |
| 19:56.04 | jmls | void ?? that doesn't help ! |
| 19:56.15 | jmls | or does it ? |
| 19:56.20 | jmls | hates C |
| 19:56.31 | seanbright | snuff-home is right |
| 19:56.36 | seanbright | frame->data |
| 19:56.51 | seanbright | i feel like we're in #c |
| 19:57.14 | jmls | hey, at least I'm trying to implement a feature. |
| 19:57.29 | jmls | sulks |
| 19:57.44 | seanbright | true |
| 19:57.46 | seanbright | you're doing good |
| 19:57.50 | seanbright | go jmls, go! |
| 19:58.07 | jmls | now I feel patronised ;) |
| 19:58.23 | jmls | ->data it is |
| 19:59.05 | jsmith | jmls: Don't let 'em get to ya... Just keep on coding and learning... and coding and learning! |
| 20:00.03 | seanbright | yes. |
| 20:00.04 | jmls | heh |
| 20:00.07 | leifmadsen | learn first, code second |
| 20:00.10 | seanbright | not trying to patronize |
| 20:00.17 | seanbright | or *ise |
| 20:00.18 | jmls | I take it frame.datalen should be frame->datalen |
| 20:00.24 | seanbright | correct |
| 20:00.44 | seanbright | -> is the 'indirect member selector |
| 20:00.47 | seanbright | it's short for: |
| 20:00.51 | seanbright | (*frame).datalen |
| 20:01.30 | jmls | ok so I have |
| 20:01.31 | jmls | void *mutedbuf |
| 20:01.41 | jmls | void *data |
| 20:01.42 | snuff-home | heh i never knew it was short for that seanbright.. just knew pointers use -> and non pointers are . |
| 20:01.50 | jmls | in frame.h |
| 20:02.27 | seanbright | the reason a void * is used is because it could point to anything |
| 20:02.37 | jmls | but originalbuf = frame->data; |
| 20:03.10 | jmls | gives me error: incompatible types in assignment |
| 20:03.20 | seanbright | what is originalbuf declared as? |
| 20:03.33 | jmls | sorry, same as mutedbuf |
| 20:03.37 | snuff-home | output_t ? |
| 20:03.43 | jmls | void |
| 20:04.02 | seanbright | pastebin a diff |
| 20:04.22 | jmls | gotta put the kids to bed. be right back |
| 20:04.26 | seanbright | ok |
| 20:04.26 | kpfleming | you cannot declare a variable as 'void', there is no such type |
| 20:04.33 | seanbright | i think he means void * |
| 20:04.40 | kpfleming | well, he might. :-) |
| 20:04.47 | seanbright | yeah |
| 20:04.54 | seanbright | so chan_mobile |
| 20:06.10 | seanbright | going to buy a phone so i can play with chan_mobile. need a recommendation that will work. |
| 20:08.49 | leifmadsen | mnicholson would be the best one to ask |
| 20:09.01 | leifmadsen | my E71 almost works, but I haven't gone back to test it thoroughly yet |
| 20:09.10 | leifmadsen | I think its the bluetooth adapter I'm using, and not the phone |
| 20:09.22 | Qwell | seanbright: you could buy an android phone, and fix chan_mobile so it works there :p |
| 20:09.27 | seanbright | heh |
| 20:09.28 | leifmadsen | Qwell: shhhhh |
| 20:09.34 | leifmadsen | Qwell: I was trying to trick him into that very thing! |
| 20:09.58 | snuff-home | leifmadsen: yes the bug is a dupe (cdr rounding up seconds) |
| 20:10.04 | leifmadsen | is there a module or something you can use to have asterisk detect when you're in your office vs. away from your office by using the BT in your phone? |
| 20:10.11 | leifmadsen | snuff-home: ok cool, that's what I though |
| 20:10.12 | leifmadsen | t |
| 20:10.24 | Qwell | leifmadsen: sure.. a hint on Mobile/bob |
| 20:10.30 | leifmadsen | ah yes |
| 20:10.36 | leifmadsen | I hadn't thought of that approach :) |
| 20:10.39 | seanbright | what provider has the android in the states? |
| 20:10.41 | seanbright | t-mobile? |
| 20:10.46 | Qwell | and at&t |
| 20:10.52 | Qwell | err, wait |
| 20:10.55 | jsmith | Qwell: AT&T has an android model? |
| 20:10.56 | Qwell | Verizon? Whoever has the Droid |
| 20:10.58 | leifmadsen | and joshleiftelcomvoxmartenterprisesinc |
| 20:11.06 | jsmith | Qwell: I thought it was Sprint and T-Mobile and Verizon |
| 20:12.02 | file | shouldn't you people be working? |
| 20:12.03 | file | :P |
| 20:12.05 | seanbright | ok, so vzw |
| 20:12.12 | jsmith | file: I *am* working... |
| 20:12.21 | file | jsmith: SHENANIGANS! |
| 20:12.26 | Qwell | seanbright: or get a developer model, and get no carrier |
| 20:12.27 | jsmith | file: (waiting for my document to compile) |
| 20:12.44 | seanbright | Qwell: how do i pull that off? |
| 20:13.01 | Qwell | I don't know if they have new ones, but there was the ADP1 at one point |
| 20:13.41 | seanbright | nice. |
| 20:14.12 | Qwell | or get a used one off ebay and just unlock it |
| 20:14.27 | Qwell | if you don't require cell stuff, there isn't much sense paying a provider |
| 20:14.30 | seanbright | jeez |
| 20:14.32 | seanbright | this is all complicated |
| 20:14.34 | Qwell | (of course, if you do...well...) |
| 20:14.34 | seanbright | nevermind |
| 20:14.36 | seanbright | heh |
| 20:15.26 | kpfleming | all four major carriers in the US have Android phones now, or will have in the next 60 days |
| 20:17.59 | *** join/#asterisk-dev atis_work (n=atis_wor@193.238.212.171) |
| 20:18.27 | seanbright | will wait on at&t |
| 20:18.38 | seanbright | since i already have them |
| 20:20.55 | jmls | oh, yuck |
| 20:21.16 | jmls | svn diff gives all the changes to files modified y ./config |
| 20:21.21 | jmls | (by) |
| 20:21.35 | jmls | ast_expr2.y, for example |
| 20:22.02 | seanbright | ok, so 'svn diff apps/ include/' |
| 20:22.14 | jmls | I did svn diff main ;) |
| 20:22.22 | jmls | where audiohooks.c is |
| 20:22.27 | seanbright | ah right |
| 20:22.31 | jmls | :) |
| 20:22.40 | seanbright | thought you modified mixmonitor |
| 20:22.54 | jmls | soon. but not yet. not yet |
| 20:23.10 | jmls | wonders if people are as fixated with that movie as he is |
| 20:24.01 | seanbright | apparently not |
| 20:24.21 | jmls | is disappointed |
| 20:24.43 | jmls | old movie. Turned an Aussie into a star. And not Mel. |
| 20:25.28 | seanbright | yahoo serious? |
| 20:25.32 | jmls | pastebin of audiohook.c is in error: incompatible types in assignment |
| 20:25.45 | jmls | ffs. pigeon paste in driving me nuts |
| 20:25.49 | jmls | http://pastebin.ca/1771165 |
| 20:26.02 | jmls | Gladiator |
| 20:26.05 | seanbright | originalbuf = frame.data; |
| 20:26.14 | seanbright | that's wrong |
| 20:26.28 | seanbright | -> not . |
| 20:26.28 | jmls | crap. thought I'd fixed that |
| 20:26.44 | jmls | see line below ;) |
| 20:26.44 | seanbright | mutedbuf = alloca(frame.datalen); |
| 20:26.47 | seanbright | also wrong |
| 20:26.49 | seanbright | frame->datalen |
| 20:26.59 | seanbright | frame.data = originalbuf; |
| 20:27.00 | seanbright | also wrong |
| 20:27.01 | seanbright | frame->data |
| 20:27.03 | seanbright | heh |
| 20:28.08 | jmls | originalbuf = frame->data; still gives me error: incompatible types in assignment |
| 20:28.49 | seanbright | can you paste the full error message |
| 20:29.16 | kpfleming | what version of asterisk are you compiling against? |
| 20:29.23 | seanbright | 1.4 |
| 20:29.53 | jmls | trunk at the moment |
| 20:29.56 | seanbright | heh |
| 20:29.58 | kpfleming | trunk is very different |
| 20:30.04 | seanbright | you said 1.4 earlier |
| 20:30.05 | jmls | then I'll do the backport |
| 20:30.08 | kpfleming | in trunk that will have to be originalbuf=frame->data.ptr |
| 20:30.16 | jmls | ohhhh |
| 20:30.16 | kpfleming | because frame->data is a union |
| 20:30.25 | seanbright | gives up |
| 20:30.29 | jmls | yeah, I was warned about the unions .... |
| 20:31.02 | jmls | seanbright: I want to use 1.4 - but thought that I should write this against trunk, get it committed and then try the backport |
| 20:31.11 | jmls | was that the wrong way to do this ? |
| 20:31.20 | jsmith | would have done it the same way |
| 20:31.41 | kpfleming | if you actually want to use it, i'd suggest doing it against 1.4 so you can test it well, then forward port it |
| 20:32.03 | kpfleming | otherwise your testing will be subject to any problems/annoyances that trunk may have in your environment |
| 20:32.24 | jsmith | kpfleming: trunk isn't perfect? |
| 20:32.30 | jsmith | blinks |
| 20:32.36 | kpfleming | nope |
| 20:34.43 | jmls | woot! got passed compilation. Some warnings, will try and fix them myself. ;) |
| 20:42.09 | snuff-home | anyone else feel like testing my hi-res cdr? i seem to be in need of testers :) |
| 20:43.43 | jmls | mmn. looking through the source, I see all void are declared as statics. |
| 20:45.19 | jmls | which removes one of my error messages .... ;) |
| 20:49.45 | snuff-home | jmls: if u want help resolving warnings/errors pastebin them as well as current code |
| 20:57.18 | jmls | snuff-home: sorted !! |
| 20:57.44 | snuff-home | go jmls :) |
| 20:58.27 | jmls | audiohooks.c compiles now with no errors. I added static to the void declarations to remove the " error: incompatible types in assignment" |
| 20:58.38 | jmls | nope. that wasn't the error |
| 20:58.40 | jmls | crap. |
| 20:58.44 | snuff-home | heh.. |
| 20:58.46 | jmls | "may be used uninitialized in this function" |
| 20:58.47 | kpfleming | static does not change the type of a variable |
| 20:59.16 | jmls | kpfleming: "may be used uninitialized in this function" was the warning i was getting |
| 20:59.43 | jmls | for some reason pigeon pastes something else if I ctrl-v. I have to "paste as plain text" and keep forgetting :) |
| 21:00.14 | jmls | I also had to add the declarations of the new functions to audiohook.h |
| 21:00.27 | kpfleming | well, adding static to cure that warning would not be the correct method |
| 21:00.28 | jmls | now, on to modify app_mixmonitor |
| 21:00.34 | jmls | kpfleming: bugger |
| 21:00.59 | jmls | thought that if the warning was removed all was well with the world. |
| 21:01.05 | jmls | apparantly not with C. |
| 21:01.21 | seanbright | no |
| 21:01.31 | kpfleming | that's not really true with any language |
| 21:01.39 | seanbright | what is the full error message |
| 21:01.53 | jmls | so, "void *originalbuf" gave me a "may be used uninitialized in this function" |
| 21:02.03 | seanbright | void *originalbuf = NULL; |
| 21:02.15 | kpfleming | that means you are accessing the contents of that variable without having put anything into it |
| 21:02.19 | seanbright | yo udon't want static there |
| 21:02.19 | jmls | see, that's why you are all so smart |
| 21:02.39 | kpfleming | while you can force it to have a value in advance, you really need to understand the code flow to make sure that the access to the variable is done at the rigth time |
| 21:03.13 | seanbright | well i am smart... but that is not the reason |
| 21:03.25 | jmls | that's what I was confused. http://pastebin.ca/1771165 |
| 21:03.56 | jmls | it was warning me about originalbuf |
| 21:04.18 | jmls | as you can see, originalbuf is set at 27 and 39, and possibly accessed at 49 |
| 21:04.51 | jmls | mutedbuf was ok, I presume because I assign before I access |
| 21:05.03 | seanbright | but line 27 and 39 may never get executed because of the 'if' statements |
| 21:05.16 | kpfleming | correct |
| 21:05.19 | seanbright | so you have to initialize originalbuf |
| 21:05.24 | seanbright | so change: |
| 21:05.25 | kpfleming | it is conditionally set |
| 21:05.28 | seanbright | void *originalbuf; |
| 21:05.29 | seanbright | to: |
| 21:05.34 | seanbright | void *originalbuf = NULL; |
| 21:05.55 | seanbright | and lines 38 and 39 are still wrong (they use . instead of ->) |
| 21:06.15 | seanbright | as is line 49 |
| 21:06.32 | jmls | to be pedantic, or I could add a full if (ast_test_flag(audiohook, AST_AUDIOHOOK_MUTE_READ) && direction == AST_AUDIOHOOK_DIRECTION_READ)) || .... |
| 21:06.39 | jmls | seanbright: I haven't repasted |
| 21:06.40 | jmls | ;) |
| 21:06.43 | kpfleming | the test on line 48 should be 'if (originalbuf != NULL)' |
| 21:06.56 | kpfleming | that way you don't have to worry about how originalbuf got set |
| 21:07.02 | seanbright | indeed |
| 21:07.48 | jmls | this is why I find C distateful. It prevents newbies from joining the grown-up world =-O |
| 21:08.01 | seanbright | it's not that complicated |
| 21:08.17 | kpfleming | not at all |
| 21:08.26 | kpfleming | none of what you are dealing with would be considered complicated |
| 21:08.41 | kpfleming | that's just logic and algorithms, would be the same in any programming language with slightly different syntax |
| 21:09.35 | jmls | likes DEF VAR a AS LONGCHAR NO-UNDO. a = "whatever you want, however long you want it". As long as it is less than 2GB ... |
| 21:10.05 | kpfleming | dynamically typed languages suck :-) |
| 21:10.13 | russellb | python == win |
| 21:10.15 | jmls | heh |
| 21:10.37 | russellb | I wish I had more time to write python code. It makes me happy. |
| 21:10.40 | seanbright | char *var = strdup("whatever you want, however long you want it"); // Until you're out of memory |
| 21:10.52 | putnopvut | import antigravity |
| 21:10.55 | putnopvut | oblig |
| 21:10.56 | jmls | but you have to remember to add the bloody * |
| 21:10.59 | jmls | or & |
| 21:11.04 | jmls | or -> |
| 21:11.06 | jmls | or . |
| 21:11.08 | seanbright | or NO-UNDO |
| 21:11.17 | seanbright | what effing language is that? |
| 21:11.34 | jmls | or whatever the compiler says you need when you have no idea what the hell symbol you have to use ;) |
| 21:11.51 | seanbright | & - take address of |
| 21:11.55 | seanbright | * - dereference |
| 21:12.01 | putnopvut | That's why it's helpful to learn the language and THEN try to code in it ;) |
| 21:12.06 | seanbright | . - member |
| 21:12.10 | jmls | NO-UNDO == if transaction rolls back, do not change the value back to what it was before the transaction started |
| 21:12.20 | seanbright | -> - short hand for (*x).whatever |
| 21:12.23 | seanbright | done and done |
| 21:12.26 | jmls | putnopvut: OI! I thought you were my friend ;) |
| 21:12.30 | putnopvut | lol |
| 21:12.46 | seanbright | pointers took me the longest to understand |
| 21:12.50 | jmls | I am in awe of C developers |
| 21:12.51 | seanbright | once i did, c is pretty easy |
| 21:12.58 | seanbright | relatively. |
| 21:13.17 | snuff-home | u can make python rather complex |
| 21:13.33 | jmls | at least I can't create a segfault because I missed a * or & or . or whatever ;) |
| 21:13.49 | jmls | is a sensitive soul , needs insulating from bad segfaults |
| 21:14.06 | Corydon76-dig | As opposed to good segfaults? |
| 21:14.13 | putnopvut | I love good segfaults |
| 21:14.28 | jmls | yeah. Good segfaults piss off users. Bad segfaults piss off developers ... |
| 21:14.32 | seanbright | you can't compile if you miss a * or & or . |
| 21:14.39 | seanbright | unless you're playing with void * forces |
| 21:14.53 | Qwell | When in doubt, cast it to void * |
| 21:14.53 | jmls | you can if you use a null value. |
| 21:15.08 | Corydon76-dig | seanbright: I play with The Force... does that count? |
| 21:15.45 | jmls | woot. clean compile |
| 21:16.05 | jmls | now has to figure out how the hell to set the damned flags ... :( |
| 21:16.19 | jmls | app_mixmonitor.c is in his sights |
| 21:16.48 | jmls | seriously, thanks for all the help and pointers (pun intended) guys. |
| 21:17.04 | jmls | I know how ball-breaking it is to constantly help a C newbie |
| 21:17.16 | seanbright | i don't hink you do |
| 21:17.21 | jmls | heh heh |
| 21:17.21 | seanbright | think* |
| 21:17.45 | jmls | I do - I have 100 users constantly trying to "fix" the code I write |
| 21:18.35 | jmls | I was seriously asked the other day "I know I entered the wrong reference, but why didn't the system know that I had done that ??" |
| 21:19.23 | jmls | like I had to predict that they were going to type the wrong digits (12345 instead of 1357) |
| 21:19.36 | jmls | no word of a lie |
| 21:20.09 | jmls | or (related to asterisk) |
| 21:20.20 | snuff-home | hehe |
| 21:20.29 | jmls | "why didn't the system know that they were going to hang up ?" |
| 21:21.09 | jmls | or |
| 21:21.28 | jmls | "why didn't it know that they were not going to answer ..." |
| 21:21.34 | jmls | I shit you not |
| 21:22.11 | jmls | "they were at work. Why didn't it call the work number instead of home" |
| 21:22.32 | jmls | I could go on. I won't. Or I'll have to slit my wrists |
| 21:22.55 | jmls | so, yes, I know ... :) |
| 21:25.46 | kpfleming | you know what the cause of that is? |
| 21:26.01 | jmls | bad training |
| 21:26.10 | jmls | bad coding |
| 21:26.12 | kpfleming | hyphenated last names (troll <G>) |
| 21:26.20 | jmls | oooohhhh you git |
| 21:26.31 | jmls | not my fault. Blame my dad |
| 21:26.39 | kpfleming | my wife has one too, so i kid |
| 21:26.43 | jmls | hehhe |
| 21:27.08 | jmls | funny thing is, my Dad was originally "Lyndon Smith" (first, last) |
| 21:28.06 | jmls | got pretentious, decided to be called "Jon Lyndon-Smith" instead |
| 21:28.29 | jmls | so, as a nipper, my name was changed by deed poll |
| 21:29.00 | jmls | most "contacts" know me as Lyndon, because I answer the phone "Lyndon Smith" |
| 21:29.17 | jmls | can't be arsed to correct them now ;) |
| 21:29.34 | kpfleming | we know you as 'jammels' |
| 21:29.59 | jmls | Cool. thought it would be "oh no, it's him" |
| 21:30.10 | jsmith | jmls: No, I think that's reserved for me |
| 21:30.27 | jmls | thank god |
| 21:30.56 | jmls | sorry, kpfleming, shouldn't take your name in vain |
| 21:36.05 | kpfleming | no, you have me confused with someone else |
| 22:08.48 | jmls | is the opposite of mute unmute ? |
| 22:09.17 | snuff-home | i would stick to that |
| 22:10.06 | jmls | MuteMixMonitor(type) |
| 22:10.13 | jmls | type = read||write |
| 22:10.23 | jmls | what should I call read||write |
| 22:10.39 | jmls | from||to |
| 22:11.13 | jmls | source||target |
| 22:11.23 | jmls | source||destination |
| 22:11.29 | snuff-home | source| dest sounds better |
| 22:11.46 | jmls | cool. thanks. |
| 22:11.59 | jmls | this should all be up and running by tomorrow night |
| 22:12.06 | jmls | is confident and happy ;) |
| 22:14.28 | snuff-home | :) |
| 22:14.38 | kpfleming | jmls: i would go with read|write or in|out |
| 22:14.50 | kpfleming | in a single channel scenario, there is no 'source' or 'destination' |
| 22:18.33 | jmls | personally speaking, read | write has some work to explain what it actually means |
| 22:18.44 | jmls | read == from or to where ? |
| 22:19.20 | jmls | I know that read = from channel |
| 22:19.30 | jmls | write = to channel |
| 22:19.44 | jmls | guesses that he will just have to write good docs |
| 22:19.54 | jmls | that should make jsmith happy |
| 22:20.02 | snuff-home | yes.. XML doc.. for trunk :) |
| 22:20.04 | jmls | read | write it si |
| 22:20.11 | jmls | (is) |
| 22:20.11 | Qwell | read | out |
| 22:20.57 | snuff-home | mm another hot week.. average of 30C starting today |
| 22:21.11 | jmls | politically incorrect, but still very funny |
| 22:21.16 | jmls | http://pastebin.ca/1771313 |
| 22:23.29 | snuff-home | heh not bad.. |
| 22:24.07 | jmls | it helps if you are European |
| 22:24.25 | jmls | there's a lot of history between our nations .. |
| 22:27.20 | snuff-home | as aussies we know some euro history ;) |
| 22:29.28 | jmls | heh |
| 22:29.34 | jmls | you sure do |
| 22:29.59 | jmls | my bro has emigrated to Aus - near Pertg |
| 22:30.03 | jmls | Perth even |
| 22:32.13 | Corydon76-dig | snuff-home: you need to come visit here... |
| 22:32.33 | Corydon76-dig | It's just under 30 here... Fahrenheit... |
| 22:32.42 | snuff-home | i'll be fine :) |
| 22:33.01 | snuff-home | we are lucky if even in winter we get below 15C |
| 22:41.55 | Corydon76-dig | jmls: that is absolutely terrible! I love it! |
| 22:43.57 | jmls | yup |
| 22:45.25 | *** join/#asterisk-dev ccesario (n=ccesario@189-19-6-236.dsl.telesp.net.br) |
| 23:17.27 | snuff-home | time to mow some lawns |
| 23:22.18 | russellb | i'll trade you summer for winter |
| 23:22.52 | snuff-home | i dont mind my winter.. like i said.. generally its not lower than 15C.. |
| 23:24.27 | snuff-home | russ.. the cdr stuff.. i will see about trying backends myself.. but i doubt my 'tests' represent what most ppl do.. 'answer/echo/hangup' 'answer/milliwatt/hangup' :) |
| 23:25.22 | russellb | that's fine. I absolutely appreciate the work you have done |
| 23:26.05 | russellb | CDR changes make me nervous is all :-) |
| 23:26.33 | russellb | they break or change behavior a lot, and when they break, people get _very_ upset |
| 23:28.14 | file | that's an understatement |
| 23:35.31 | Corydon76-dig | Yeah, but these are backend modifications, not changes to how CDRs are generated... completely different |
| 23:35.49 | Corydon76-dig | Well, mostly different, anyway |
| 23:37.31 | russellb | heh, breaking a CDR backend such that _no_ records are stored would probably produce a similar upset level |