| 00:16.46 | *** join/#asterisk-dev jnemeth (~root@S01060010dc42a680.gv.shawcable.net) |
| 00:17.46 | *** join/#asterisk-dev dseeb_ (~Adium@CPE-58-169-103-164.lns4.bat.bigpond.net.au) |
| 00:17.56 | jnemeth | hello |
| 00:18.02 | dseeb_ | hello |
| 00:23.31 | jnemeth | The information about using reviewboard says that if you're not an actual Asterisk developer, that you should only use it when requested to do so. However, I have a patch that I want to submit that covers 4 files and ~100 lines. Is it okay to use the reviewboard, or should I submit a description and wait for a request? |
| 00:48.34 | russellb | that's fine, as long as you put it on mantis first |
| 00:48.44 | russellb | mantis is what gets it into the workflow to get reviewed |
| 00:48.59 | russellb | mantis = the process, reviewboard = a tool to aid the process when needed |
| 00:49.07 | russellb | btw, mantis being issues.asterisk.org |
| 00:50.24 | jnemeth | okay thanks... I have used issues.a.o before... |
| 02:28.54 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 03:26.12 | *** join/#asterisk-dev miguel3239 (~miguel323@ns1.nashuacs.com) |
| 04:10.26 | *** join/#asterisk-dev citywok (~citywok@67-134-194-33.dia.static.qwest.net) |
| 04:14.37 | jnemeth | russellb: still here? |
| 04:22.46 | jnemeth | Can anybody tell me how to edit an issue that I reported? |
| 05:29.25 | *** join/#asterisk-dev snuff-home (~snuffy@203-219-29-182.tpgi.com.au) |
| 05:29.25 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 08:14.44 | wdoekes2 | jnemeth: I don't see anything to review |
| 08:23.53 | jnemeth | I didn't realise it didn't upload the patch... seems it didn't like my patch format... I'm busy playing with RBTools to try to get a better patch for it... |
| 09:16.30 | wdoekes2 | or you could upload the patch on mantis ;) |
| 09:52.34 | *** join/#asterisk-dev snuff-home (~snuffy@203-219-29-182.tpgi.com.au) |
| 09:52.34 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 10:52.50 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 12:38.56 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:38.56 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 13:58.48 | *** join/#asterisk-dev Corydon76-home (pink@c-69-137-80-31.hsd1.tn.comcast.net) |
| 13:58.49 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 14:11.17 | seanbright | jnemeth: you going to upload your patch somewhere? |
| 14:11.28 | seanbright | oh, nevermind, just scrolled up |
| 17:01.43 | *** join/#asterisk-dev kaii (~kh@ciphron.de) |
| 17:40.57 | JunK-Y | seanbright: thx for M18444 |
| 17:40.59 | MuffinMan | [closed] [Asterisk] Applications/app_meetme 0018444: [patch] leak in meetme reported by junky https://issues.asterisk.org/view.php?id=18444 |
| 17:49.41 | *** join/#asterisk-dev TheDavidFactor (~chatzilla@nc-71-52-237-42.dhcp.embarqhsd.net) |
| 17:54.48 | seanbright | sure |
| 17:55.31 | seanbright | Kobaz: i just saw M18343 |
| 17:55.32 | MuffinMan | [ready for review] [Asterisk] Applications/app_meetme 0018343: [patch] [regression] meetme conf_run leaks refs reported by kobaz https://issues.asterisk.org/view.php?id=18343 |
| 17:56.02 | seanbright | i did a lot of that in a separate commit already but will get the ao2_alloc failure tests in as well |
| 17:56.14 | seanbright | hadn't seen that you already did most of the leg work :/ |
| 18:07.08 | Kobaz | aw |
| 18:07.40 | Kobaz | i've been so crazy busy I can't get back to asterisk coding just yet |
| 18:08.08 | Kobaz | although I did just finish a big effort of forward porting all my changes from 1.6.0.26 to 1.8.2.3 |
| 18:08.18 | Kobaz | let's see if it builds |
| 18:08.26 | Kobaz | i need to see if there's a bug that's been fixed since then... |
| 18:12.32 | seanbright | well crap |
| 18:12.39 | seanbright | 1.4 is ao2 too |
| 18:13.19 | Kobaz | yeah i think there's a note in there that it needs to be put in older branches |
| 18:14.51 | seanbright | good times |
| 18:21.28 | Kobaz | hmm |
| 18:21.31 | Kobaz | i'm having one problem |
| 18:21.32 | Kobaz | chan_sip.c:17252: warning: passing argument 3 of '__ao2_callback' from incompatible pointer type |
| 18:21.35 | Kobaz | /usr/home/markm/asterisk/1.8.2.3-custom/include/asterisk/astobj2.h:905: note: expected 'int (*)(void *, void *, int)' but argument is of type 'int (*)(void *, void *, int, int)' |
| 18:21.52 | Kobaz | i added a new arg to struct __show_chan_arg |
| 18:22.01 | Kobaz | and now the callbacks aren't happy |
| 18:22.41 | Kobaz | i added another int... i'm not sure where it's getting the expected type from |
| 18:22.52 | Kobaz | i changed the struct in sip.h, it should be matching |
| 18:23.31 | Kobaz | well, it not only should match... it does match in sip.h |
| 18:23.39 | Kobaz | but something else is not right |
| 18:29.42 | seanbright | doesn't appear to be related to anything i did |
| 18:30.08 | Kobaz | no, it's my own thing |
| 18:30.14 | seanbright | gotcha |
| 18:30.27 | Kobaz | i'm just wondering what's the proper way to pass in more args to an ao2 callback |
| 18:34.43 | Kobaz | hmm, it's gotta be somethign stupid, i changed the struct and it's still complaining |
| 18:34.48 | Kobaz | man my c is rusty |
| 18:36.48 | Kobaz | ooooh |
| 18:36.51 | Kobaz | damn, it is stupid |
| 18:43.41 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:6515:8d52:9477:94ee) |
| 18:44.09 | TheDavidFactor | ast_cpy_string is similar to strncpy, is there a function similar to strncat? |
| 18:44.38 | TheDavidFactor | already looked for ast_cat_string :-) |
| 18:47.28 | jnemeth | seanbright: if you're still here, the patch has been successfully posted to https://reviewboard.asterisk.org/r/1089/ |
| 18:53.26 | Kobaz | TheDavidFactor: ast_str_append |
| 18:53.49 | Corydon76-home | Also ast_str_append_substr |
| 18:54.35 | Corydon76-home | To append a length-specified non-terminated string |
| 18:57.48 | Kobaz | func_groupcount.c:717: warning: 'ast_channel_datastore_alloc' is deprecated (declared at /usr/home/markm/asterisk/1.8.2.3-custom/include/asterisk/channel.h:1045) |
| 18:57.51 | Kobaz | hmm |
| 18:57.52 | Kobaz | what's the new way |
| 18:57.53 | Kobaz | ? |
| 18:57.55 | Corydon76-home | (and ast_str_set_substr() for that matter) |
| 18:58.10 | Corydon76-home | Kobaz: ast_datastore_alloc() |
| 18:58.19 | Kobaz | k |
| 18:59.34 | Corydon76-home | Kobaz: if you read the header file, it's also indicated there |
| 18:59.38 | Kobaz | k |
| 18:59.54 | Corydon76-home | We aren't trying to trick you, honest. ;-) |
| 19:00.12 | Kobaz | hehe |
| 19:02.57 | TheDavidFactor | can ast_str_append be used on a C string (i.e char *file_to_stream) I that it had to be a ast_str to be able to use the ast_str_* functions |
| 19:03.56 | *** join/#asterisk-dev wdbl (~not@ool-44c0619d.dyn.optonline.net) |
| 19:12.32 | Kobaz | mmm, another question |
| 19:12.41 | Kobaz | hannel.c:599: error: 'struct ast_channel' has no member named 'cid' |
| 19:12.41 | Kobaz | channel.c:607: error: 'struct ast_channel' has no member named 'cid' |
| 19:12.46 | Kobaz | where is cid stored now in 1.8? |
| 19:13.12 | WIMPy | caller.id.num* |
| 19:13.29 | Kobaz | k |
| 19:14.13 | Kobaz | ast_party_id.number |
| 19:14.46 | Kobaz | hmm |
| 19:15.06 | Kobaz | er it's ast_party_caller |
| 19:16.44 | Kobaz | caller.id.number.str |
| 19:17.48 | Kobaz | yay, one more compile error to fix |
| 20:04.24 | Kobaz | <PROTECTED> |
| 20:04.27 | Kobaz | [2011-01-29 14:58:52] ERROR[23638]: lock.c:384 __ast_pthread_mutex_unlock: features.c line 5555 (bridge_exec): mutex 'current_dest_chan' freed more times than we've locked! |
| 20:04.30 | Kobaz | [2011-01-29 14:58:52] ERROR[23638]: lock.c:416 __ast_pthread_mutex_unlock: features.c line 5555 (bridge_exec): Error releasing mutex: Operation not permitted |
| 20:04.33 | Kobaz | hmm |
| 20:06.26 | Kobaz | bridge_exec() doesn't seem to grab any channels with a lock |
| 20:06.33 | Kobaz | so it's unlocking something it never locked |
| 20:32.38 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@mail.parsetree.com) |
| 20:36.13 | Kobaz | do datastores get coppied over when a channel gets masquraded? |
| 20:37.10 | Kobaz | or do you have to manually copy datastores that you want to keep |
| 20:37.49 | WIMPy | I'd like to find out who the correct flow is as well. I changed chan_lcr for 1.8, but somehow I introduced a bug while doing so. |
| 20:38.37 | WIMPy | When you use multiple lcr channels in one dial, only the fist gets te correct caller ID, the others get the extension. And I've got no idea, what's going on :-( |
| 20:43.15 | *** join/#asterisk-dev codefreeze-lap (~Steve_Mur@mail.parsetree.com) |
| 20:46.19 | *** join/#asterisk-dev TheDavidFactor (~chatzilla@nc-71-52-237-42.dhcp.embarqhsd.net) |
| 21:31.29 | *** part/#asterisk-dev wdbl (~not@ool-44c0619d.dyn.optonline.net) |
| 22:11.47 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 22:11.47 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 22:32.17 | *** join/#asterisk-dev n0tk (~n0tk@216.160.42.30) |
| 22:36.21 | *** join/#asterisk-dev elguero (~miguel323@ns1.nashuacs.com) |
| 22:48.05 | *** join/#asterisk-dev miguel3239 (~miguel323@ns1.nashuacs.com) |
| 23:29.06 | *** join/#asterisk-dev russellb (~russell@asterisk/digium-open-source-team-lead/russellb) |
| 23:29.06 | *** mode/#asterisk-dev [+o russellb] by ChanServ |