| 00:02.47 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-fvhsywkiaxhybfog) |
| 01:56.45 | *** join/#asterisk-dev mpe (~mpe@75-101-82-65.static.dsltransport.net) |
| 01:58.11 | *** join/#asterisk-dev moy (~moy@173.239.155.74) |
| 02:32.44 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 02:32.44 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:48.39 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 03:28.43 | *** join/#asterisk-dev ccesario (~ccesario@201-92-118-244.dsl.telesp.net.br) |
| 03:40.39 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@50-39-153-143.bvtn.or.frontiernet.net) |
| 03:55.33 | *** join/#asterisk-dev Fritz09 (~Adium@pop1-3802.catv.wtnet.de) |
| 04:05.43 | *** join/#asterisk-dev sustav (~alfa@nat/digium/x-zmokmnhgkzqlwwcv) |
| 04:14.13 | *** join/#asterisk-dev moy_ (~moy@bas5-toronto47-1168012481.dsl.bell.ca) |
| 05:14.07 | *** join/#asterisk-dev tzafrir (~tzafrir@212.179.75.202) |
| 05:14.08 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 05:14.56 | *** join/#asterisk-dev irroot (~irroot@pbx.distrotech.co.za) |
| 05:20.59 | *** join/#asterisk-dev oej (~olle@ns.webway.se) |
| 05:20.59 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:13.35 | *** join/#asterisk-dev vassilux (~vassili@LPuteaux-156-14-48-156.w82-127.abo.wanadoo.fr) |
| 06:22.22 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 06:22.24 | schmidts | good morning |
| 06:49.24 | *** join/#asterisk-dev sustav (~alfa@nat/digium/x-scgxckvolwbsxujh) |
| 06:50.05 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 06:50.05 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:53.42 | tzafrir | Is it just me, or are there problems with the domain digium.com ? |
| 06:55.10 | irroot | tzafrir ?? more info let me check here |
| 06:55.23 | irroot | i been on JIRA/RB works fine |
| 06:55.44 | schmidts | same for me |
| 06:55.59 | tzafrir | ok. works fine now. |
| 06:57.34 | *** join/#asterisk-dev anny__ (~chatzilla@77.42.241.114) |
| 06:58.28 | anny__ | hey all, can anyone suggest a good open source library that interfaces libiax through java or js. |
| 07:08.03 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:416:47e6:73f8:aea7) |
| 07:09.04 | tzafrir | anny__, I'm not really sure libiax is maintained anymore |
| 07:11.34 | anny__ | tzafrir: is there any alternatives |
| 07:25.13 | *** join/#asterisk-dev tamiel (~tamiel@213.30.183.226) |
| 08:41.31 | *** join/#asterisk-dev Daviey (~Daviey@ubuntu/member/daviey) |
| 10:11.03 | *** join/#asterisk-dev Marquis42 (~bfhbmw0@65-127-126-34.dia.static.qwest.net) |
| 10:16.27 | *** join/#asterisk-dev irroot (~irroot@pbx.distrotech.co.za) |
| 10:17.03 | irroot | anyone want to check the work i did on the last blocker for 1.8.7 ?? |
| 11:11.08 | *** join/#asterisk-dev black187 (5d67162a@gateway/web/freenode/ip.93.103.22.42) |
| 11:12.53 | black187 | hello I would like to post new feature to bug tracker -> Send SIP Cancel with a reason (answered elsewhere) when a pickup is performed. A calls B, C pikcup's B -> B has no missed call on his phone. I have no experience with Asterisk development (only PHP and SQL...), so I would like your feedback regarding this feature request. |
| 11:22.25 | schmidts | black187 i remember someone allready tried to code this feature |
| 11:23.48 | black187 | I did once, but didn't work -> not enough experience in coding :( |
| 11:27.36 | schmidts | ah ok :D |
| 11:28.04 | schmidts | then jira would be a good place to start |
| 11:30.05 | schmidts | black187 for which version do you want this? cause IMHO this should be very easy to append |
| 11:31.11 | black187 | For 1.8.4 or 1.8.5 or 1.8.6. |
| 11:31.55 | black187 | Do you have any solutions? |
| 11:32.55 | black187 | It should be done in features.c -> in ast_do_pickup function. But where exactly, I don't know. |
| 11:34.02 | black187 | I tried adding ast_set_flag(target, AST_FLAG_ANSWERED_ELSEWHERE); before the masquarade in "ast_do_pickup" funcion, but no success. |
| 11:36.07 | *** join/#asterisk-dev irroot (~irroot@pbx.distrotech.co.za) |
| 11:42.57 | schmidts | black187 i will try it and take a look what happens |
| 11:43.13 | black187 | schmidts -> Cool, thanks! |
| 11:51.55 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:51.55 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:52.04 | black187 | One more thing - do you guys use any IDE for Asterisk C code, and which one? |
| 11:53.00 | kpfleming | most people just use their favorite text editor |
| 11:53.11 | irroot | kpfleming hi there |
| 11:53.24 | kpfleming | irroot: morning... i thinkg |
| 11:53.44 | schmidts | VI :D |
| 11:54.37 | irroot | schmidts +1 |
| 12:00.23 | *** join/#asterisk-dev oej (~olle@static-213-115-251-100.sme.bredbandsbolaget.se) |
| 12:00.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:05.13 | irroot | hi all |
| 12:05.25 | irroot | oej you been busy :P |
| 12:15.40 | schmidts | black187 its tricky :D but i guess i have it but let me check this |
| 12:17.50 | kpfleming | it's really scary the number of people who call themselves 'Senior VOIP Engineer' and related titles on our mailing lists, but can't even figure out how to follow instructions on a wiki or accurately describe the problem they are having |
| 12:19.03 | russellb | "VOIP Engineer" implies that the engineer VoIP, which itself seems sort of odd |
| 12:19.27 | russellb | do they listen to phone calls and manually bang out IP packets? |
| 12:19.34 | schmidts | :D |
| 12:20.32 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 12:20.32 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 12:20.44 | irroot | russellb kpfleming the term engineer in the US seems to apply to someone who can plug in a flash disk un supervised .... here it is someone who has a Bsc 3year at least a technician has a Btech or similar also 3year or some proficiency proven by a practical course |
| 12:21.11 | kpfleming | this is not in the US... it's people from the subasian area (India, Pakistan, Bangladesh, etc.) |
| 12:21.42 | kpfleming | in the US the title 'Engineer' is only supposed to be used by people with at least a bachelor's degree in an engineering field recognized by the IEEE |
| 12:22.04 | irroot | yeah its caught on i suspect out sourcing the customer wants to speak to a engineer |
| 12:24.38 | oej | Hello folks |
| 12:24.53 | black187 | schmidts: Great, let me know the outcome... |
| 12:24.53 | oej | irrot: Yes? Trying to fix some larger issues. |
| 12:25.45 | oej | shmidts: Hello there |
| 12:26.01 | schmidts | hi oej ;) |
| 12:26.48 | irroot | this problem with iLBC get script blocking 1.8.7 the site it downloads from has changed the suffix from .awk to .txt i dont see the need to change it to a perl script now perhaps for 10 ?? |
| 12:30.44 | kpfleming | we're discussing what to do about the iLBC thing here at digium already |
| 12:31.30 | kpfleming | we'd really like to switch to the WebRTC version of iLBC, but that will take some development work because it's not a drop-in replacement for the code in the RFC |
| 12:32.11 | oej | Sorry for coming in late, but what's the issue with iLBC? |
| 12:32.45 | irroot | oej there changes on the site its sucked from |
| 12:32.57 | irroot | the RFC and awk script generate the code |
| 12:33.06 | oej | Ahh. |
| 12:33.14 | irroot | the prefix of the awk script has changed to .txt from .akw |
| 12:33.20 | irroot | s/akw/awk |
| 12:33.23 | irroot | s/akw/awk/ |
| 12:34.20 | kpfleming | and it probably won't even be there much longer |
| 12:34.41 | oej | Ok. |
| 12:34.42 | schmidts | black187: how does this look for you? http://pastebin.com/anFJdAGD |
| 12:35.46 | black187 | schmidts: :D perfect. Where did you make the adjustment? |
| 12:36.27 | kpfleming | irroot: but at least that's helpful... we didn't know the file was still there with that extension. i'll commit that quick fix right now. |
| 12:36.44 | schmidts | in features.c before doing the masquerade but on the right channel ;) |
| 12:37.04 | black187 | Isn't the "target" the right channel? |
| 12:37.06 | schmidts | and here is the patch against 1.8 svn : http://pastebin.com/dsSTW757 |
| 12:37.11 | schmidts | i thought so but it isnt |
| 12:37.43 | irroot | kpfleming went onto the site and figgured it out this AM |
| 12:38.07 | black187 | I will try it. Thanks! |
| 12:38.25 | schmidts | tell me if it works then i can put it on review board |
| 12:38.43 | irroot | patch on JIRA tested by me |
| 12:38.46 | kpfleming | irroot: well.. no, i won't commit that fix. the license agreement stuff is no longer present on that site, so users can't agree to the license necessary. |
| 12:39.02 | kpfleming | we're going to have to move over to the WebRTC license, if not the WebRTC implementation. we'll keep working on this today. |
| 12:39.05 | irroot | ah indeed |
| 12:39.42 | irroot | did not look at licence only functionality |
| 12:40.00 | kpfleming | right |
| 12:40.09 | kpfleming | the WebRTC-style license is better, but it doesn't apply to the code in the RFC |
| 12:40.38 | kpfleming | so now the situation is that the code in the RFC is distributed under a BSD-style license, but there is no *method* to obtain a license to use it without infringing on the patents |
| 12:40.54 | kpfleming | i will bring this up on the relevant IETF mailing list in a few minutes |
| 12:42.08 | leifmadsen | kpfleming: do you think I should just do a 1.8.7.0-rc1 now, with the expectation we will resolve this prior to release? I can just mention that we're working towards a solution to the problem, and it will be resolved prior to 1.8.7.0 full release? |
| 12:42.34 | leifmadsen | there are probably many others who can test 1.8.7.0-rc1 without the need to use ilbc stuff at all |
| 12:42.54 | kpfleming | leifmadsen: sure, go ahead |
| 12:42.59 | leifmadsen | kpfleming: ok coolio |
| 12:43.09 | irroot | i rsync the last codecs/ilbc to new folder |
| 12:43.33 | irroot | and others will do so |
| 12:43.49 | irroot | a rc is not for avg hobiest |
| 12:48.48 | kpfleming | and... done |
| 12:49.16 | oej | Which of all the mailing lists was the proper one for this issue? |
| 12:49.39 | kpfleming | well, i started with AVTCORE... we'll see where it goes from there |
| 12:50.12 | oej | Yep. Someone needs to write a hitchhiker's guide to RAI mailing lists. |
| 12:50.26 | kpfleming | it's a pretty ugly situation... an IPR disclosure was made offering royalty-free licensing terms for the code in RFC 3951, but those terms are no longer available |
| 12:50.53 | kpfleming | and Google's statements on the WebRTC site are even more confusing |
| 12:51.21 | irroot | ok folks im outta here off to Durban |
| 12:51.28 | kpfleming | as far as i know, anyone who had already executed the free license agreement with GIPS is still fine, because Google would have to honor those agreements, so this only affects new users |
| 12:51.29 | irroot | have a good weekend |
| 12:51.36 | kpfleming | irroot: it's wednesday |
| 12:51.36 | black187 | schmidts: It works perfectly. Thank you very much. I will check if I can use the same logic on call forwarding... Thank you again. |
| 12:52.24 | irroot | yeah long weekend |
| 12:52.33 | irroot | working weekend .... |
| 12:52.58 | irroot | ill sit under a bananna tree with a cocktail and the monkeys :P |
| 12:53.06 | irroot | thinking of you |
| 12:55.38 | kpfleming | ewww... i hope he doesn't actually do that |
| 12:57.40 | schmidts | black187 ok i will put it on reviewboard |
| 13:05.22 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-ijntmnkpwrpxqfjq) |
| 13:08.02 | oej | schmidts: You don't really describe the problem in reviewboard. Is the header missing or is it a new feature? |
| 13:08.56 | oej | Ahh. I get it. The header is missing in the case of pickups. Nice. THank you! |
| 13:12.11 | schmidts | oej sorry i will change this ;) |
| 13:12.32 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-ipxvxdgftipeodoq) |
| 13:12.32 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:14.06 | oej | Here's a gift: " " - you can add that between "chank" and "AST_FLAG?" |
| 13:15.04 | schmidts | :D thank you oej |
| 13:16.52 | oej | I have some more if you need :-) |
| 13:17.12 | schmidts | do you think i need some more? |
| 13:17.15 | oej | Already backported to 1.4 in my Edvx. |
| 13:17.30 | oej | I don't know, for future use maybe. Feel free to ask me when you need more spaces. |
| 13:17.50 | schmidts | there should be enough space for everyone :D |
| 13:18.15 | *** join/#asterisk-dev moy_ (~moy@173.239.155.74) |
| 13:22.37 | *** join/#asterisk-dev jeffg (~jeffg@pdpc/supporter/professional/jeffg) |
| 13:23.05 | schmidts | i am confused, where can i find the 10 branch? |
| 13:23.54 | schmidts | ok got it ;) |
| 13:31.58 | leifmadsen | branches/10 |
| 13:31.59 | leifmadsen | ? |
| 13:32.00 | leifmadsen | :) |
| 13:32.56 | schmidts | i forgot that a svn ls only shows me the local directory not whats on the server ;) |
| 13:35.34 | oej | Interesting commit - in both branches at the same time. |
| 13:39.22 | schmidts | why not its the same change |
| 13:39.23 | leifmadsen | schmidts: you didn't use merge810 and merge10trunk ? |
| 13:39.29 | leifmadsen | because you should be using the merge scripts |
| 13:39.36 | schmidts | ah ok |
| 13:40.36 | schmidts | i just have done the changes by hand, is this a problem? |
| 13:40.37 | oej | Old rules, Stefan. Tss, tss. |
| 13:40.47 | leifmadsen | yes, you should merge them |
| 13:41.03 | schmidts | ok, then i will take a look how to do this |
| 13:41.18 | leifmadsen | you've not been merging using the scripts this whole time? :) |
| 13:41.59 | leifmadsen | for example, you commit to 1.8 branch, note the revision number, then in the 10 branch, run: merge810 <revision number> |
| 13:42.23 | schmidts | nope ;) i have a clean svn directory for all branches where i only change things i check in into svn |
| 13:42.33 | schmidts | ah ok sounds easy enough ;) |
| 13:42.59 | schmidts | but to be honest most changes i have checked in was only against trunk ;) |
| 13:51.16 | schmidts | leifmadsen i have read through the wiki for this thing and i got it know, i will use the merge tools next time |
| 13:52.14 | oej | Ha. The swedish localization of svn fails to remove "this line and lines below it"... |
| 13:52.37 | schmidts | :D |
| 13:57.50 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 13:57.50 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:19.08 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 14:19.08 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:22.08 | leifmadsen | pabelanger: I wonder if those options should just be removed and placed into the DEBUG level logging? |
| 14:22.38 | pabelanger | I was thinking the same thing :D |
| 14:23.14 | pabelanger | oej: Rather then creating another configuration option to enable debug messages, I vote to use ast_debug() |
| 14:24.41 | leifmadsen | manager set debug {on|off} ? |
| 14:26.25 | schmidts | pabelanger thanks for your mail but it looks like the change is now duplicated :( |
| 14:27.14 | pabelanger | schmidts: you didn't revert your original commit |
| 14:28.19 | schmidts | i have done it before: svn merge -c -334683 . |
| 14:28.20 | schmidts | --- Reverse-merging r334683 into '.': |
| 14:28.20 | schmidts | U main/features.c |
| 14:28.57 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 14:28.57 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 14:29.06 | schmidts | aaaaahhhh ok i see what i have done wrong |
| 14:32.34 | oej | pabelanger: I can output to ast_debug but few cli messages go to that channel. |
| 14:33.31 | oej | But I fail to see how ast_debug() which is a c function call can replace an option in the manager.conf file. |
| 14:34.49 | schmidts | ok just to make it right now i go back to revision 334683 and then call the merge right? |
| 14:36.09 | leifmadsen | oej: I think we're saying you shouldn't add an option to manager.conf for debugging, but rather use the existing debugging infrastructure by controlling it via logger.conf and CLI commands like 'manager set debug {on|off}' |
| 14:36.22 | Kobaz | leifmadsen: +1 |
| 14:36.27 | leifmadsen | having debug options to turn it on and off in every .conf file is confusing and seems old school (in a bad way) |
| 14:36.37 | Kobaz | leifmadsen: +2 |
| 14:37.43 | oej | Well, we have options in sip that I use all the time to get the debugging rolling from the very load of the channel. |
| 14:38.19 | leifmadsen | right, and that is the old school way of doing things |
| 14:38.21 | oej | So you want to add another logging channel? |
| 14:38.28 | leifmadsen | sure, why not? |
| 14:38.43 | oej | the ast_debug is not part of the picture any more, that confused me. |
| 14:38.46 | leifmadsen | at least all logging is controlled from one location, and I could output all my manager logging to a file instead of the console if I wanted |
| 14:38.56 | leifmadsen | ast_log(DEBUG,...) |
| 14:39.02 | leifmadsen | or however it is being used |
| 14:39.03 | oej | Leifmadsen: Please respond to the review |
| 14:39.06 | leifmadsen | I will |
| 14:39.20 | Kobaz | yeah now that the code is up, i'll check it out too |
| 14:40.07 | oej | I don't think I have the time to rewrite it though, but welcome anyone else to contribute. |
| 14:41.53 | schmidts | ok i think i need some help now :( |
| 14:43.34 | pabelanger | schmidts: just start again. Revert your previous 2 commits, then push them into subversion |
| 14:43.54 | schmidts | when i use svn merge back to the revision before i have submitted the wrong file and i want to use merge10trunk after this i get the error that i have a local modifications. when i try to checkout the last clean rev 334682 i can use the script but commit failed cause i use not the newest version |
| 14:44.25 | oej | We've all been there. |
| 14:45.19 | pabelanger | schmidts: right, so when you revert you need to submit your changes, otherwise (as you see) svnmerge complains |
| 14:45.37 | schmidts | thats was the missing thing ;) i will try |
| 14:46.32 | *** join/#asterisk-dev Fritz09 (~Adium@pop1-3802.catv.wtnet.de) |
| 14:46.52 | oej | Closed the review for now. Hopefully I'll get resources to fix this later. |
| 14:51.09 | leifmadsen | oej: also close ASTERISK_18447? |
| 14:52.27 | schmidts | pabelanger ok now i still get the local modifications warning but this time i dont understand why |
| 14:52.53 | pabelanger | $ svn status |
| 14:53.14 | schmidts | svn status |
| 14:53.14 | schmidts | <PROTECTED> |
| 14:53.15 | schmidts | X menuselect |
| 14:53.15 | schmidts | ? pbx.c |
| 14:53.15 | schmidts | ? channels/chan_sip.c.orig |
| 14:53.15 | schmidts | ? main/svn-commit.tmp |
| 14:53.17 | schmidts | Performing status on external item at 'menuselect' |
| 14:53.19 | schmidts | X menuselect/mxml |
| 14:53.21 | schmidts | Performing status on external item at 'menuselect/mxml' |
| 14:53.45 | oej | leifmadsen: Well, yes. Put it on hold. |
| 14:54.17 | schmidts | ok i guess all things with ? arent a good idea |
| 14:54.46 | pabelanger | usually, chan_sip.c.orig and svn-commit.tmp can be removed |
| 14:55.23 | pabelanger | So, if you revert your local change, then use the merge10trunk again, do you still have a problem? |
| 14:55.30 | pabelanger | $ svn revert -R . |
| 14:55.38 | pabelanger | $ svn status |
| 14:56.37 | schmidts | doesnt change anything, i will checkout a clean version and try it with this |
| 14:56.58 | oej | Leifmadsen: Who said anything about setvar=> ?? |
| 14:57.09 | leifmadsen | oej: mjordan did per the review |
| 14:57.13 | leifmadsen | that's what I responded to |
| 14:57.26 | oej | Ahh. Okey then. Yes, that's old stuff that I try to avoid. |
| 14:57.42 | schmidts | pabelanger with a clean checkout it looks like it works now ;) |
| 14:57.45 | leifmadsen | ok, I just wanted to make sure the manager.conf file got updated to look like other files |
| 14:57.52 | leifmadsen | oej: that's why I commented |
| 14:57.58 | pabelanger | schmidts: SUCCESS! |
| 14:58.00 | pabelanger | :) |
| 15:01.01 | schmidts | i am not sure :( my changes are not made |
| 15:02.27 | schmidts | ok i guess the problem is that i didnt used the merge810 script either :( |
| 15:03.42 | schmidts | i will revert this commit also and clean it up completly |
| 15:05.18 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 15:09.03 | leifmadsen | Qwell: ping! |
| 15:09.32 | leifmadsen | https://issues.asterisk.org/jira/browse/ASTERISK-18128 <-- that issue I think was the overlapping bit space, and I think you may have already fixed that? |
| 15:13.53 | pabelanger | schmidts: hold on a second |
| 15:14.01 | schmidts | ok |
| 15:19.36 | pabelanger | schmidts: I'm a little confused why you commited your patch into branches/1.8, since this is a new feature it would usually only get committed to trunk |
| 15:20.22 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 15:20.22 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 15:21.16 | schmidts | pabelanger imho the reason header itself is the new feature which was introduced with 1.8 and for me its not a new feature to get this reason header when a pickup happens |
| 15:21.38 | kpfleming | agreed |
| 15:22.11 | mvanbaak | agreed |
| 15:22.14 | pabelanger | Okay cool, I was just confused by the patch. Thanks for the heads up |
| 15:22.46 | schmidts | ;) |
| 15:29.19 | Qwell | leifmadsen: confirm |
| 15:32.21 | schmidts | ok not merge10trunk stucks without any reason :( |
| 15:32.49 | oej | It's a bug fix. I missed what Stefan caught. |
| 15:33.32 | oej | takes all the blame for that patch |
| 15:34.52 | Qwell | schmidts: You need to disable interactive merges in your svn config. |
| 15:35.18 | Qwell | [miscelany] \n interactive-conflicts = no |
| 15:35.23 | Qwell | 2 l's.. |
| 15:35.28 | Qwell | miscellany |
| 15:37.09 | schmidts | Qwell thx ;) |
| 15:37.47 | schmidts | ok now i hope this is how it should be ;) |
| 15:38.08 | Qwell | looks right |
| 15:38.40 | schmidts | finally ;) |
| 15:39.08 | schmidts | then have a nice evening folks, its time for me to go home ;) |
| 15:39.51 | oej | Evening, folks. Have to leave this nice office, which isn't mine. The cleaning lady is about to leave and looks unsure of what to do with me. |
| 15:44.30 | jsmith | oej: That must mean it's time to find some dinner! |
| 15:50.40 | leifmadsen | Qwell: confirmed fixed you mean? |
| 15:51.57 | Qwell | leifmadsen: yes |
| 15:52.04 | leifmadsen | Qwell: closed, thanks! |
| 17:03.43 | *** join/#asterisk-dev jmls (~Julian@host217-36-208-155.in-addr.btopenworld.com) |
| 17:07.02 | leifmadsen | pabelanger: ping |
| 17:23.22 | pabelanger | If people want some easy code reviews: https://code.asterisk.org/code/cru/CR-AST-9 and https://code.asterisk.org/code/cru/CR-AST-11 |
| 17:33.40 | Kobaz | nothing jumps out at me on those, they look okay |
| 17:33.51 | wdoekes2 | pabelanger: you can drop the fflush(stdout) if you're not doing the ast_verb without LF |
| 17:38.12 | pabelanger | Kobaz: wdoekes2: mind making those comments on code.asterisk.org? I've never used this review process before and curious to see how it works |
| 17:44.55 | wdoekes2 | I can't find the Review button =) |
| 17:52.49 | pabelanger | wdoekes2: do you see 'Join this review' in the top right hand corner/ |
| 17:53.34 | russellb | a quickstart page on the wiki would be good to get people going ... |
| 17:54.44 | russellb | of course i say that but i'm not going to write it, heh |
| 17:54.59 | mvanbaak | ghehd |
| 17:55.45 | wdoekes2 | no.. no join buttons |
| 17:56.08 | pabelanger | I'm not sure then |
| 17:56.18 | russellb | are you logged in? |
| 17:56.46 | wdoekes2 | as my newly created user, yes |
| 17:56.55 | *** join/#asterisk-dev otherwiseguy (~terry@adsl-68-90-169-41.dsl.ksc2mo.swbell.net) |
| 17:57.01 | russellb | ah |
| 17:57.11 | russellb | it's probably set up with some access control |
| 17:57.34 | russellb | go to jira and fill out the license agreement |
| 17:58.39 | wdoekes2 | jira says I already have a license that is approved |
| 17:59.54 | wdoekes2 | (that user is *not* newly created) |
| 18:00.06 | russellb | it should be the same account for both |
| 18:00.12 | wdoekes2 | didn't have one on code |
| 18:00.13 | russellb | single sign on |
| 18:00.31 | wdoekes2 | login failed, had to create account, same username |
| 18:01.13 | russellb | that sounds odd to me, but maybe it's expected, I defer to kpfleming / serafie / seraphie |
| 18:01.40 | wdoekes2 | I defer back to pabelanger: you probably want to remove the fflush(stdout) |
| 18:03.39 | pabelanger | wdoekes2: ACK'd |
| 18:03.51 | pabelanger | now to get the review process working :D |
| 18:03.52 | serafie | wdoekes2: I only see one username containing your last name. |
| 18:04.46 | wdoekes2 | I created 'wdoekes' 20 minutes ago |
| 18:04.59 | wdoekes2 | on code.asterisk |
| 18:16.49 | *** join/#asterisk-dev tamiel (~tamiel@ip-183.net-81-220-86.toulouse.rev.numericable.fr) |
| 18:18.21 | leifmadsen | A gentle reminder to everyone: when writing your commit messages, please word them in such a way that it reads that you're fixing an issue, and not introducing an issue. For example, don't word your commits like this: Segfault when publishing device states via XMPP and not connected. |
| 18:19.29 | leifmadsen | (In this particular case, simply adding "Resolve" as the first word would make it clear :)) |
| 18:24.41 | Kobaz | hha |
| 18:25.04 | Kobaz | i've seen a bunch of commits like that |
| 18:26.11 | Kobaz | i usually word mine like: "There was a problem with x and y, this fixes x and resolves y" |
| 18:43.56 | leifmadsen | yes that would work :) |
| 18:44.17 | leifmadsen | it's probably natural for people to describe what the issue was, and not what they fixed I guess |
| 18:47.06 | kpfleming | well, they are copying the 'subject' from the issue, most likely |
| 18:48.45 | mvanbaak | yeah |
| 18:56.48 | wdoekes2 | oooh.. I have a new button |
| 18:57.34 | mvanbaak | gheh |
| 18:57.56 | mvanbaak | like Didi (from Dexters lab) always says: oooooooooooh, what does this button doooooooooo |
| 19:06.34 | wdoekes2 | yes.. I did that too.. I still have no idea what "anchor to fisheye" means =) |
| 20:22.33 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 20:22.34 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Astricon 2011 in Denver, Colorado: AstriDevCon on October 24. Be there! |
| 20:30.14 | pabelanger | kpfleming: yes, it removed extra line breaks (\n) from ast_verb(), but the majority was cleaning up the iax2_ack_registry function. |
| 20:30.37 | kpfleming | if there is no functional change, then that's not supposed to be done in release branches |
| 20:33.47 | pabelanger | Okay, no problem, I can remove it from the branches. The only functionality it changes it CLI output and logging |
| 20:33.57 | pabelanger | is* |
| 20:34.02 | kpfleming | no, don't take it out now. that just causes more unnecessary churn. |
| 20:35.00 | sruffell | pabelanger: CLI output is not considered part of the interface? I.e. if someone wrote a script to drive the CLI should it be consistent between releases on a particular branch? |
| 20:35.29 | kpfleming | no, CLI output is not intended to be machine consumable |
| 20:35.35 | sruffell | logs? |
| 20:35.40 | kpfleming | logs are not CLI output |
| 20:35.57 | kpfleming | but it still shouldn't change on a release branch unless there is a bug |
| 20:36.22 | sruffell | nods |
| 20:36.51 | sruffell | I was just thinking that the extra carriage returns in the logs / CLI could is user visible and might be a surprising change on a branch. |
| 20:37.02 | sruffell | s/could is/would be/ |
| 20:37.29 | kpfleming | sure, but for the CLI we wouldn't really care, if they needed to be changed to solve some other problem as well |
| 20:37.44 | kpfleming | log messages usually aren't multi-line anyway |
| 20:40.25 | pabelanger | So, it keep it simple, change to logging (ast_verb, ast_debug) should only affect trunk, when possible. |
| 20:42.04 | kpfleming | no |
| 20:42.20 | kpfleming | changes to log/verbose messages to *fix bugs* are candidates in any branches |
| 20:42.39 | kpfleming | changes that just clean up code, change formatting, etc. but don't result in any difference in useful behavior should only go into trunk |
| 20:45.00 | pabelanger | Right |
| 20:46.05 | kpfleming | and that's true across the board, not just for log/verbose messages. release branches should only be changed to correct visible problems, not just to improve code formatting, code quality, etc. |
| 20:53.56 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 20:53.56 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 20:55.30 | pabelanger | Another question, if we do bug fixes plus code formatting changes on trunk, won't that make it more difficult to merge from the previous branches? Sometimes the code is pretty bad in some locations |
| 20:57.44 | pabelanger | Maybe it is the code guideline only updates to trunk that people did not like |
| 21:13.08 | kpfleming | yes, it will make it more difficult, but the number of changes in the release branches should be quite a bit smaller than the number of changes in trunk, if we are only fixing bugs and minimizing code changes there |
| 21:26.12 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-ipxvxdgftipeodoq) |
| 21:29.37 | *** join/#asterisk-dev Corydon76-home (three@c-69-137-80-31.hsd1.tn.comcast.net) |
| 21:29.37 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 21:48.13 | *** join/#asterisk-dev moy_ (~moy@CPE002719f00364-CM0026f3a1701d.cpe.net.cable.rogers.com) |
| 22:24.18 | *** join/#asterisk-dev Corydon76-home (six@c-69-137-80-31.hsd1.tn.comcast.net) |
| 22:24.18 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 22:38.55 | *** join/#asterisk-dev tzafrir (~tzafrir@212.179.75.202) |
| 22:38.55 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:34.41 | dwayne | does anyone know if there is a particular reason why res_speech was implemented without the ability to be unloaded? And, why? |
| 23:35.11 | pabelanger | asterisk commit 332760 |
| 23:35.47 | pabelanger | JonathanRose: r332760: ast_verb(1, "INTHEFACEPUNCH!\n"); ? |
| 23:38.15 | snuff-work | lol |
| 23:45.28 | snuff-work | mm.. when did the test-suite start requiring python2.6? |