| 00:24.12 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 00:24.12 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:27.45 | tzanger | Corydon76-home: I am not seeing where you're taking the address of the channel pointer in the naming |
| 01:27.55 | tzanger | dahdi uses a counter, as does chan_sip |
| 01:28.04 | tzanger | local is ast_random() |
| 01:28.12 | Corydon76-home | Ah, right. It used to use the address, though |
| 01:28.39 | tzanger | well I can just use a counter as well. :-) |
| 01:28.58 | tzanger | autocreatepeer=no, yes or prefix |
| 01:29.10 | Corydon76-home | Wouldn't that create an issue with predictability for externally visible peers? |
| 01:29.12 | tzanger | prefix is autopeer-#### or something |
| 01:29.48 | tzanger | less so than using the from field, I think |
| 01:30.33 | tzanger | I mean I could make it so prefix is configurable as well, but that might be overengineering things |
| 01:31.03 | Corydon76-home | Or use the address coupled with a counter |
| 01:31.14 | tzanger | wouldn't the address be enough? |
| 01:32.35 | Corydon76-home | I forget the issue with the address that made us change it to a counter |
| 01:34.01 | tzanger | I'll have to add a reaper method as well, as kpleming suggested |
| 01:38.08 | tzanger | hm, it seems that it should automatically go away when it expires... now to see what the default expiration is |
| 01:39.34 | tzanger | looks like auto reaping is already covered |
| 01:39.38 | tzanger | need to test to make sure, but still |
| 01:48.50 | Corydon76-home | Huh, the DAHDI use of the auto-incrementing integer may need to use the atomic function... may be currently vulnerable to two (or more) channels getting the same name |
| 01:50.51 | Corydon76-home | Peer expiration or registration expiration? |
| 01:51.21 | Corydon76-home | Nevermind, it's the same thing |
| 03:11.02 | tzanger | Corydon76-home: yeah I noticed that too when I was digging around |
| 04:25.28 | *** part/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 05:08.48 | *** join/#asterisk-dev irroot (~gregory@197.110.156.226) |
| 05:23.49 | *** join/#asterisk-dev sezuan (bouncer@irc.scheff32.de) |
| 05:58.04 | *** join/#asterisk-dev irroot (~gregory@197.110.156.226) |
| 07:03.14 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 07:03.23 | *** part/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 07:13.14 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 07:25.46 | *** join/#asterisk-dev micols (~ident@rlogin.dk) |
| 07:35.46 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 07:35.48 | schmidts | good morning |
| 08:05.47 | wedhorn | snuff-work: you still at work? |
| 08:09.57 | *** join/#asterisk-dev acidfoo (~nib@modemcable094.94-70-69.static.videotron.ca) |
| 08:21.45 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:21.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:31.40 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 09:52.22 | schmidts | is there a way to order an ao2_callback result if there are multiple entries? |
| 09:54.13 | schmidts | core show channels verbose before 1.8 showed the channel in order of their duration, but in 1.8 its just without any order and i want to change this |
| 09:55.39 | *** join/#asterisk-dev cemeh4 (~cemeh4@193.19.228.130) |
| 10:00.30 | snuff-home | wedhorn: nope :) |
| 10:35.03 | wedhorn | snuff-home: heh, time for bed |
| 11:03.59 | *** join/#asterisk-dev chazzam (~chazz@50-81-150-34.client.mchsi.com) |
| 11:28.57 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 11:28.57 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 11:51.22 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 12:03.25 | *** join/#asterisk-dev sezuan (bouncer@irc.scheff32.de) |
| 12:17.05 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 12:45.21 | *** join/#asterisk-dev anonymouz666 (~anonymouz@187-28-37-118.poolip.RJO.embratel.net.br) |
| 12:49.34 | anonymouz666 | https://issues.asterisk.org/view.php?id=17497 - strange, this fix went to version 1.6.2 but it happens exactly the same way in 1.8.8.0-rc1. |
| 13:03.49 | anonymouz666 | "chan_sip: fixes provisional keepalive scheduled item crash" issue 17497 |
| 13:23.14 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-qhvvcnzevmmdbfey) |
| 13:23.14 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:29.18 | pabelanger | anonymouz666: the fix only when into 1.4 it looks like and blocked in 1.6.2 |
| 13:29.24 | pabelanger | not sure why |
| 13:35.48 | anonymouz666 | blocked? |
| 13:36.19 | pabelanger | Yes, for merging |
| 13:36.37 | anonymouz666 | so that explains why still happens |
| 13:37.57 | pabelanger | yes, you'll have to ask dvossel why it was blocked |
| 13:38.20 | pabelanger | my guess, he didn't think it was an issue in 1.6.2+ |
| 13:43.19 | anonymouz666 | can't talk about 1.6.2.x but definely it is in version 1.8.8.0 |
| 13:44.52 | pabelanger | anonymouz666: open a new bug, and reference the original on you submitted. We can then triage it from there and see about merging the patch |
| 13:46.04 | anonymouz666 | this one is in category "unable to reproduce" and my core files are all optimized out, I am in doubt if I can provide useful information |
| 13:58.19 | *** join/#asterisk-dev irroot (~gregory@196-210-222-7.dynamic.isadsl.co.za) |
| 14:05.54 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-gooltsrawfmfpnlv) |
| 14:23.22 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-uqsgnmojsbzzdxli) |
| 14:36.21 | *** join/#asterisk-dev Netgeeks (~chris@gw1.netgeeks.net) |
| 14:36.21 | *** join/#asterisk-dev Freeaqingme (~Freeaqing@91.214.168.110) |
| 14:43.42 | *** join/#asterisk-dev joshaidan (~brianj@S0106001c1023e838.tb.shawcable.net) |
| 14:48.24 | schmidts | wdoekes2 are you there? |
| 14:49.18 | wdoekes2 | sure |
| 14:53.15 | *** join/#asterisk-dev otherwiseguy (~otherwise@rrcs-173-197-0-67.west.biz.rr.com) |
| 14:53.53 | *** join/#asterisk-dev razu (~razu@2001:ad0:1:1:202:b3ff:fe36:921c) |
| 15:05.09 | Corydon76-home | wdoekes2: review updated |
| 15:09.49 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 15:09.49 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 15:10.49 | wdoekes2 | otherwiseguy: I tried to hack up a test in the test suite for my changes of r1533, but the flakiness of the test suite lost me a lot of time (deps on *both* python and lua? breakage when not installing make samples in the regular dir. oddly named warnings when os.link'ing from /tmp to /home. errors when failing to overwrite old backtrace.txt's. sipptester dictionary that cannot take multiple arguments (sipp option -key a b) |
| 15:15.25 | wdoekes2 | Corydon76-home: I still don't get it. if I have my console verbosity set to <= 2, and a VERBOSE_PREFIX_3 message comes along it will get the magic -1 ==> it will be treated as verbosity level 0 in console_verboser |
| 15:15.46 | wdoekes2 | i.e. it will be shown.. |
| 15:17.05 | Corydon76-home | No, you're confusing level with magic. Two different variables |
| 15:17.17 | Corydon76-home | -1 level is not translated into -1 magic. |
| 15:17.48 | wdoekes2 | let me rephrase: why do you even bother to set level in: if (level < 0) { |
| 15:18.10 | Corydon76-home | That's passed as a result of the ast_verbose() macro |
| 15:18.25 | wdoekes2 | *set* level |
| 15:18.35 | wdoekes2 | it isn't used afterwards |
| 15:18.38 | Corydon76-home | Because we need to keep the parameters of ast_verbose() constant |
| 15:19.01 | wdoekes2 | is level *read* after line 1503? |
| 15:19.01 | Corydon76-home | That's all about API compatibility |
| 15:19.06 | Corydon76-home | Nope |
| 15:19.13 | wdoekes2 | why are you setting it after 1503? |
| 15:19.32 | otherwiseguy | wdoekes2: it only has lua dependencies if you want to run the lua tests. make samples should be run. It needs to be run as root. I'm not sure I've ever had to use a sipp option that took multiple arguments. Which one was that? |
| 15:19.44 | wdoekes2 | the -key option |
| 15:20.01 | Corydon76-home | wdoekes2: You're right. I did not see that. It should be setting magic there. |
| 15:20.03 | otherwiseguy | sudo ./runtest -t tests/channels/SIP/whatever is how I test tests. |
| 15:20.33 | wdoekes2 | right Corydon76-home, i.e. moving the setting of magic to below 1515 |
| 15:20.54 | wdoekes2 | that's what I've been trying to tell you |
| 15:21.06 | Corydon76-home | Okay, you were right, that code was incorrect |
| 15:21.42 | otherwiseguy | wdoekes2: wow, that is a really odd design decision on sipp's part. -key keyword=value might have been better. |
| 15:21.50 | wdoekes2 | sipp is flaky too |
| 15:21.54 | otherwiseguy | yes. |
| 15:22.19 | otherwiseguy | It is another in a long line of programs that I would like to write a replacement for. |
| 15:22.21 | Corydon76-home | wdoekes2: Review has been updated. |
| 15:22.23 | wdoekes2 | otherwiseguy: I began working around it by passing {'-key': ('key', 'value')} |
| 15:22.43 | otherwiseguy | tricksy :-) |
| 15:25.46 | wdoekes2 | (then again.. the choice to pass a dict instead of a list should probably be revised instead) |
| 15:29.51 | wdoekes2 | *curline < 0 <-- un-signed |
| 15:31.11 | wdoekes2 | level = (char) -*((signed char *) buf) - 1; <-- probably s/buf/curline/ |
| 15:33.20 | wdoekes2 | :2213 why not an int but a char? |
| 15:33.53 | wdoekes2 | ah, because of the struct, never mind |
| 15:37.31 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:37.31 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:38.13 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 15:38.13 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:38.32 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 15:38.32 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:40.35 | wdoekes2 | Corydon76-home: I think the code could use a bit of #define STR_HAS_LOGLEVEL(x) (*(signed char*)(x)<0) and #define STR_GET_LOGLEVEL(x) (-*((signed char*)(x))-1) |
| 15:41.38 | Corydon76-home | wdoekes2: Possibly. I hate using that in a public header file, though, for use in two core files, though. |
| 15:43.23 | wdoekes2 | agreed.. but not using a define is worse.. duplicating the #define's in both c files could be acceptable |
| 15:49.20 | mjordan | wdoekes2: if a test in the testsuite fails, it tries to create a symbolic link to the test results. That will fail if the test results lies in another partition, which it warns you about - and then it copies the results over. We may want to squelch that warning, but its not surprising that you'd see that one |
| 15:49.45 | wdoekes2 | mjordan: s/symbolic/hard |
| 15:49.59 | mjordan | er, yes |
| 15:50.01 | wdoekes2 | I looked at the code and it is indeed just a warning, but it's badly formulated |
| 15:50.03 | mjordan | sorry, morning |
| 15:50.17 | mjordan | that's fine. Just was noting what you said earlier. |
| 15:50.36 | wdoekes2 | I'd rather first see a warning/error when the shutils.copy fails |
| 15:51.18 | wdoekes2 | I'll fix a patch for that later |
| 15:51.26 | *** join/#asterisk-dev hehol (~Adium@2a01:198:71d:0:21f:d0ff:fea1:568e) |
| 16:05.56 | *** join/#asterisk-dev irroot (~gregory@197.172.193.39) |
| 17:11.24 | *** join/#asterisk-dev ArtemMakhutov (~ArtemMakh@ip-95-223-215-71.unitymediagroup.de) |
| 17:29.02 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-qhvvcnzevmmdbfey) |
| 18:23.39 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:23.39 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:24.22 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:24.22 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:27.55 | *** join/#asterisk-dev irroot (~gregory@197.174.83.37) |
| 18:43.59 | *** join/#asterisk-dev zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 19:52.00 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 19:52.00 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 20:07.03 | *** part/#asterisk-dev ArtemMakhutov (~ArtemMakh@ip-95-223-215-71.unitymediagroup.de) |
| 20:10.17 | *** join/#asterisk-dev irroot (~gregory@197.105.107.161) |
| 20:12.06 | *** join/#asterisk-dev opticron (~opticron@24.96.165.228) |
| 20:12.07 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:12.07 | leifmadsen | I'm looking at https://issues.asterisk.org/jira/browse/ASTERISK-18928 which says application maps not defined with a leading * or # don't work, but I'm not seeing anything in the code that would be enforcing that. Thoughts? |
| 20:29.43 | *** join/#asterisk-dev opticron (~opticron@24.96.165.228) |
| 20:29.43 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:49.16 | *** join/#asterisk-dev opticron (~opticron@24.96.165.228) |
| 20:49.16 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:57.14 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-oojhtbsuikhgditt) |
| 20:57.14 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 20:57.28 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-cofwfnipicfbqbge) |
| 21:06.49 | *** join/#asterisk-dev sustav (~alfa@nat/digium/x-unkxcdysetavevii) |
| 22:33.57 | snuff-work | wedhorn: ping? |
| 23:01.57 | snuff-work | mm.. anyone tried 'helgrind' tool part of valgrind.. sounds interesting.. http://valgrind.org/docs/manual/hg-manual.html |
| 23:17.13 | *** join/#asterisk-dev citywok (~citywok@67-134-194-33.dia.static.qwest.net) |
| 23:20.05 | Corydon76-home | snuff-work: is it actually complete now? |
| 23:21.29 | snuff-work | i have no idea.. i was just reading on mysqlperformance blog about a person using it |
| 23:22.14 | mjordan | Corydon76-home: I'm not sure what's up yet, but it looks like the Asterisk unit tests hung on the latest patch: http://bamboo.asterisk.org/browse/ASTTRUNK-LUCID-AMD64-1250 |
| 23:35.05 | *** join/#asterisk-dev zerohalo (~zerohalo@74.60.136.128) |
| 23:36.42 | mjordan | Corydon76-home: and its apparently working on the next run. Not sure what happened to 1250. |
| 23:36.45 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-oojhtbsuikhgditt) |
| 23:49.57 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 23:49.57 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |