| 00:16.51 | *** join/#asterisk-dev seraphie (~erin@75.76.38.159) |
| 00:44.39 | *** join/#asterisk-dev otherwiseguy (~otherwise@rrcs-173-197-0-67.west.biz.rr.com) |
| 01:39.18 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 01:39.18 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:50.23 | *** join/#asterisk-dev seraphie (~erin@75.76.38.159) |
| 02:04.12 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.79) |
| 02:20.56 | *** join/#asterisk-dev mvanbaak_ (~michiel@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 02:20.57 | *** mode/#asterisk-dev [+o mvanbaak_] by ChanServ |
| 03:37.16 | *** join/#asterisk-dev seraphie (~erin@75.76.38.159) |
| 03:38.03 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.79) |
| 03:54.59 | *** join/#asterisk-dev otherwiseguy (~otherwise@cpe-69-76-221-79.kc.res.rr.com) |
| 04:26.57 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.79) |
| 05:39.38 | *** join/#asterisk-dev otherwiseguy (~otherwise@cpe-69-76-221-79.kc.res.rr.com) |
| 07:14.16 | *** join/#asterisk-dev schmidts (~schmidts@Lo20-rt01.lm33.sil.at) |
| 07:14.18 | schmidts | good morning |
| 08:34.09 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 08:59.28 | *** join/#asterisk-dev oej (~olle@fw1.gml.g.icnet.infracom.se) |
| 08:59.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:59.36 | oej | Morning |
| 08:59.40 | oej | Schmidts: Around? |
| 09:00.44 | WIMPy | [10:00] nick schmidts was last active at 13.12. 09:52:00 (0:08:27 ago) |
| 09:01.08 | oej | aha |
| 09:01.12 | oej | thanks |
| 09:04.54 | schmidts | i am here :D |
| 09:05.25 | schmidts | sorry have not seen your jabber message oej ;) |
| 09:20.33 | *** join/#asterisk-dev _ys (~Miranda@HS3-193-140.xG.SPb.SkyLink.RU) |
| 09:44.57 | *** join/#asterisk-dev _ys (~Miranda@HS3-193-103.xG.SPb.SkyLink.RU) |
| 10:36.37 | *** join/#asterisk-dev fish9370 (~Miranda@79.170.152.4) |
| 10:37.31 | fish9370 | hi, where is source file with AGI call implementation? |
| 10:40.39 | *** join/#asterisk-dev merbanan (~benjamin@h217-27-188-82.cust.tyfon.se) |
| 10:42.31 | schmidts | fish9370 sorry but i dont understand your question? do you want to know which source file handles the AGI application? |
| 10:43.49 | fish9370 | yes.. ) sorry for my english.. |
| 10:43.57 | schmidts | fish9370 maybe you are looking for res/res_agi.c |
| 10:44.21 | fish9370 | yes.. it is.. thanks.. |
| 10:45.09 | schmidts | fish9370 http://www.asterisk.org/doxygen/asterisk1.8/index.html its much easier to read here |
| 10:46.35 | fish9370 | schmidts, there is some description about AGI in `asterisk architecture overview`? |
| 10:47.00 | schmidts | proberly yes |
| 10:56.06 | fish9370 | thanks.. but i don't see.. |
| 11:01.13 | schmidts | fish9370 just go to the File List folder and search for agi.c |
| 11:02.16 | fish9370 | ok.. thanks :) |
| 11:41.46 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 11:41.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 12:23.46 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 13:00.32 | schmidts | pabelanger could you tell me why you have closed this issue: https://issues.asterisk.org/jira/browse/ASTERISK-18940 |
| 13:11.14 | *** join/#asterisk-dev otherwiseguy (~otherwise@rrcs-173-197-0-67.west.biz.rr.com) |
| 13:18.22 | leifmadsen | schmidts: he believed it to be a configuration issue, and thus he should take up the issue on asterisk-users |
| 13:18.31 | leifmadsen | schmidts: can you tell me why you think otherwise? |
| 13:20.46 | schmidts | yesterday was another guy in here with the same problem and i have found in handle_response that when looking for an OPTION message we compare against the p->method and not against the method in the cseq header, i think it is possible in some cases that asterisk handles an incoming packet (not an Option message) as an option message and this leads to this wrong values |
| 13:20.58 | schmidts | i have allready attached a patch which should solve this problem |
| 13:22.19 | schmidts | cause vetal (in #asterisk) showed me his sip.conf and qualify is turned off for this peer which you also see on the 0ms value in the lagged message, so i think the incoming 200 ok is handled as an option message |
| 13:24.14 | leifmadsen | gotcha |
| 13:24.20 | schmidts | \o to Digium |
| 13:24.25 | schmidts | really likes this: http://www.digium.com/en/products/digital/octal-span/?elq=962068c5990e429f9d078a893bc44d04&elqCampaignId=15#overview |
| 13:24.44 | leifmadsen | for some odd reason I thought someone might have mentioned that recently at Digium, but I'm likely dreaming |
| 13:25.19 | schmidts | i think you need a special situation where this could even happens |
| 13:28.54 | leifmadsen | gotcha, would be ideal to make sure the situation is documented so that the code review is quicker/easier |
| 13:29.30 | schmidts | the sip debug in this issue is very clear imho |
| 13:33.25 | *** join/#asterisk-dev oej_ (~olle@87.96.134.129) |
| 13:33.25 | *** mode/#asterisk-dev [+o oej_] by ChanServ |
| 13:41.06 | *** join/#asterisk-dev oej (~olle@fw1.gml.g.icnet.infracom.se) |
| 13:41.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:41.34 | leifmadsen | schmidts: not all of us are sip experts :) |
| 13:46.03 | Marquis42 | leifmadsen: Speak for yourself! |
| 13:46.10 | Marquis42 | is NOT a SIP expert either. ;) |
| 13:46.15 | leifmadsen | Marquis42: I think I did :) |
| 13:46.25 | leifmadsen | I only know enough to be dangerous |
| 13:46.26 | Marquis42 | Touche |
| 13:47.03 | schmidts | leifmadsen i am also not an expert but it just looks strange to use another field in this place than every where else in this function |
| 13:47.07 | Marquis42 | I hear you. I'd like to think I have a reasonable understanding but that's probably naive overconfidence which is exactly "know enough to be dangerous". |
| 13:47.36 | leifmadsen | schmidts: right, but during bug triage we rarely look at code directly |
| 13:48.22 | leifmadsen | we just make sure there is enough information for a developer to proceed with an issue, and that the issue appears legitimate. Sometimes things slip though. |
| 13:48.29 | schmidts | leifmadsen i know ;) if i havent looked at this just yesterday i havent found it |
| 13:48.39 | leifmadsen | rigth :) |
| 13:48.42 | leifmadsen | yay open source! |
| 13:48.48 | schmidts | :D |
| 13:48.57 | schmidts | btw do you think we need a review for this? |
| 13:49.15 | leifmadsen | I'm not sure what you've changed :) |
| 13:49.20 | merbanan | when I'm dialing port 1 to port 0 in my channel it hangs up directly, how do I track down why it happens ? |
| 13:50.08 | schmidts | leifmadsen take a look at the issue it is a very small change s/p->method/sipmethod ;) |
| 13:50.49 | leifmadsen | schmidts: small changes can have large implications :) |
| 13:51.04 | schmidts | i know :D i will open a review |
| 13:51.09 | leifmadsen | I'd suggest you get dvossel and/or mjordan to sign off |
| 13:51.11 | leifmadsen | thanks |
| 13:53.07 | schmidts | will do so ;) |
| 13:58.45 | merbanan | ignore me, issue fixed |
| 14:03.31 | schmidts | merbaran ok we will ignore you ;) |
| 14:05.53 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-mnxduwqncyxoqvtx) |
| 14:08.31 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-yckuzfuvyghnossm) |
| 14:08.31 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:11.01 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 14:11.01 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 14:11.35 | schmidts | hehe welcome mjordan and The_Boy_Wonder just some seconds ago i have posted some work for you ;) |
| 14:11.49 | The_Boy_Wonder | howdy! |
| 14:12.02 | schmidts | https://reviewboard.asterisk.org/r/1620 ;) |
| 14:12.02 | The_Boy_Wonder | i'm looking at your review now |
| 14:12.06 | mjordan | schmidts: I saw |
| 14:12.34 | schmidts | i guess you get mails faster from reviewboard than i do ;) |
| 14:14.26 | mjordan | in terms of defensive coding, handle_response_peerpoke should also probably check whether or not the peer actually has maxms set to something greater than 0 |
| 14:15.30 | schmidts | mjordan yes thats true |
| 14:29.30 | The_Boy_Wonder | schmidts: reviewed! |
| 14:30.11 | schmidts | thanks david |
| 14:30.38 | schmidts | i have just uploaded a new version where i have build in mjordans suggestion about checking the maxms value |
| 14:31.23 | The_Boy_Wonder | yep yep, not a bad idea |
| 14:32.25 | schmidts | The_Boy_Wonder so if you would be so kindly to take a look at v2 ;) |
| 14:32.45 | The_Boy_Wonder | schmidts: no problem |
| 14:32.56 | schmidts | thanks ;) |
| 14:33.20 | schmidts | brb coffee value is below working level :D |
| 14:37.51 | oej | mjordan: closed the review (on directive from customer). Not allowed to spend any more time discussing this on his time. It just doesn't make sense to customers to have this weird process going back and forth. |
| 14:38.36 | oej | I propably won't get any more resources to contribute back from this project. We can not behave like this. |
| 14:46.32 | leifmadsen | behave like what? |
| 14:47.38 | oej | go back and forth. I mailed the mailing list to get an architecture agreement before coding, then reviewboard and now many months later we go back and forth again... |
| 14:50.01 | jrrose | What people are saying in the middle of a conversation is generally overridden by what they are saying at the end of it though. |
| 14:51.30 | oej | I don't remember Russell changing his mind. We had discussions on IRC as well about it. |
| 14:51.45 | oej | But I don't care any more. Which upsets me even more. |
| 14:52.05 | jrrose | I don't really see why it's such a big deal to have the event called something other than a newstate event. |
| 14:52.25 | oej | Because we have it implemented at customer sites in applications... |
| 14:52.54 | jrrose | So in other words, you want it this way because you've already set things up with the expectation that they would stay the same as your patch. |
| 14:52.59 | oej | And I haven't seen any proposals for new classes of events or types of events |
| 14:54.30 | oej | jrrose: That's why I had a discussion on the list and on IRC before even writing the patch. |
| 14:55.07 | jrrose | I understand that it's frustrating. But I just don't see how we can really call something a newstate event when it has nothing to do with states. |
| 14:55.55 | jrrose | Indication make way more sense to me. And there are indications for ringing and proceeding as well, which are probably the two things which have the most in common with Progress. |
| 14:55.56 | oej | Which I wrote in my very first mail |
| 14:56.09 | oej | It makes sense from a manager standpoint, not from a signalling standpoint |
| 14:56.24 | oej | Ringing is a state, my friend. |
| 14:56.30 | jrrose | Ringing is also an indication. |
| 14:56.50 | oej | confusing early media with indications doesn't make sense to me. |
| 14:57.16 | oej | I'd rather deprecate early media. It's just a waste of bandwidth :-) |
| 14:57.22 | jrrose | I'm pretty sure we actually don't need to send progress to send early media. |
| 14:57.43 | oej | In the dialplan you have to send progress |
| 14:57.54 | jrrose | You should send progress. |
| 14:57.54 | oej | IN SIP early media is indicated with 183 Session Progress |
| 14:57.58 | jrrose | Yes |
| 14:58.04 | jrrose | But the way Asterisk treats it... |
| 14:58.10 | jrrose | The early media will be sent without the progress message. |
| 14:58.14 | oej | I added a setting in sip.conf for this stuff |
| 14:58.34 | oej | so you can either cancel out early media without progress or force the sip channel to send 183 before starting to send early media. |
| 14:58.35 | jrrose | If you use Queue without progress or answer, depending on the end point you'll still hear your music on hold and interrupt messages and such. |
| 14:58.59 | jrrose | It's just that the behavior will generally go insane depending on the phone and amount of time you listen. |
| 14:59.41 | jrrose | Yeah, I remember seeing that auto progress one. |
| 15:02.50 | *** join/#asterisk-dev zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 15:03.33 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:03.33 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:03.59 | oej | Hello from Sweden, kpfleming |
| 15:05.49 | *** join/#asterisk-dev lftsy (~lftsy@194.38.160.113) |
| 15:06.11 | kpfleming | oej: hello from snowy arizona! |
| 15:06.43 | leifmadsen | kpfleming: snow?! |
| 15:06.54 | pabelanger | I want snow in Ottawa |
| 15:07.03 | oej | we have no snow here in Sweden. I'm confused. Why did you get our snow in Arizona? |
| 15:07.03 | kpfleming | leifmadsen: yes... staying with parents in the mountains in northeast arizona, at about 6000 feet elevation. |
| 15:07.11 | leifmadsen | kpfleming: that'd do it yes |
| 15:07.13 | kpfleming | started snowing yesterday morning, has not stopped. |
| 15:07.17 | leifmadsen | kpfleming: family christmas? |
| 15:07.22 | kpfleming | leifmadsen: yes |
| 15:07.25 | leifmadsen | gotcha |
| 15:07.37 | kpfleming | and we have to head out of here today back to tucson... will be tricky heading down the mountains |
| 15:14.37 | oej | Heading down on snow - is that tricky? I would say heading UP would be a bit tricky?. |
| 15:15.38 | kpfleming | either way, but yeah... up is worse. |
| 15:15.39 | leifmadsen | harder to brake downhill than to just drive slower uphill with traction |
| 15:15.53 | kpfleming | and we have a rental car without four-wheel drive or snow tires |
| 15:16.00 | leifmadsen | I find uphill is easier, but maybe that's just me... I have been playing a lot of Forza 3 uphill climbs lately |
| 15:16.19 | kpfleming | they keep the highway pretty well plowed though, and the air temperature is over 32F, so there isn't any ice on the roads |
| 15:17.13 | leifmadsen | perfect |
| 15:26.40 | pabelanger | obligatory: http://www.youtube.com/watch?v=jkWiuFXNACI |
| 15:26.44 | pabelanger | turn volume up |
| 15:30.16 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:30.16 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:55.13 | tzafrir | looks again at AST-2011-013 |
| 15:55.50 | tzafrir | I would like to replace the long advisory text with a single line, including the important detais and a link to the advisory. |
| 15:56.20 | tzafrir | But then I noticed that the explanation in the warning gin the code is better than the one in the advisory. |
| 15:56.50 | tzafrir | Is it possible to update the text of the advisory? |
| 15:57.22 | tzafrir | (Rationale for a single line: clearer if you have multiple entries) |
| 15:57.53 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:07.37 | *** join/#asterisk-dev Qwell (~north@pdpc/sponsor/digium/Qwell) |
| 16:07.37 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 16:08.12 | oej | tzafrir: YOu looked for me yesterday |
| 16:08.34 | tzafrir | It was about this issue, basically |
| 16:08.38 | oej | Aha. |
| 16:09.15 | oej | Yes, the text in the advisories have been rather confusing. The commit has been having a better explanation of the issues. |
| 16:35.17 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 16:35.17 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 16:35.33 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 16:35.33 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 16:53.52 | *** join/#asterisk-dev chazzam (~chazz@50-81-150-34.client.mchsi.com) |
| 17:04.13 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 20:37.38 | *** join/#asterisk-dev otherwiseguy (~otherwise@rrcs-173-197-0-67.west.biz.rr.com) |
| 21:56.42 | leifmadsen | otherwiseguy: ping |
| 21:57.00 | otherwiseguy | leifmadsen: can I help you? |
| 21:57.36 | leifmadsen | otherwiseguy: perhaps |
| 21:58.26 | leifmadsen | otherwiseguy: msg'd you |
| 22:07.32 | otherwiseguy | tzafrir: I see no need to update the advisory. The only purpose of the advisory in my opinion is to let people know if they need to upgrade. Details as to what is actually going on under the hood doesn't matter. The advisory clearly lays out what combination of global/per-peer nat settings would cause a problem in each version of Asterisk. What more should it say? |
| 22:09.22 | otherwiseguy | oh, he's gone. |
| 22:09.33 | leifmadsen | how convenient! :) |
| 22:20.10 | *** join/#asterisk-dev Crowb4r (u1012@gateway/web/irccloud.com/x-oczbldsneaqwqezm) |
| 22:54.19 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-yckuzfuvyghnossm) |
| 23:13.09 | *** join/#asterisk-dev zerohalo (~zerohalo@74.60.136.128) |
| 23:33.44 | *** join/#asterisk-dev tzafrir (~tzafrir@212.179.75.202) |
| 23:33.45 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |