| 00:22.07 | *** join/#asterisk-dev zerohalo (~zerohalo@74.60.136.128) |
| 02:10.25 | luckman212 | https://issues.asterisk.org/jira/browse/ASTERISK-17146 |
| 02:10.30 | luckman212 | erm |
| 02:11.46 | luckman212 | so if this is marked 'Fixed' does that mean the patch is in SVN 1.8? There's no Target Release listed there. I am curious is there some page that explains how code is rolled from SVN-->release 'branches' ? |
| 02:11.57 | luckman212 | excuse my stupidity |
| 02:18.55 | jsmith | luckman212: You're probably going to have to check the changelogs |
| 02:19.24 | luckman212 | are those public? |
| 02:22.26 | luckman212 | I checked the release code of 1.8.8.0 and it's definitely not in there. so I was trying to figure out where this has been committed |
| 02:25.18 | jsmith | luckman212: I don't see any record of it being committed either |
| 02:25.57 | luckman212 | jsmith: where are you looking? |
| 02:26.15 | jsmith | svn logs |
| 02:27.14 | file | that history log is weird on that issue |
| 02:27.18 | luckman212 | are those public? |
| 02:27.55 | jsmith | file: Oh? |
| 02:28.13 | file | jsmith, the fix was attached after it was moved from in progress -> closed |
| 02:29.20 | jsmith | file: Ah, gotcha |
| 02:29.43 | jsmith | So, at least in theory, the fix should be in any 1.8.x release after October 19th |
| 02:30.30 | luckman212 | hmm well it's definitely not in 1.8.8.0 not sure about 1.8.9.0-rc1 |
| 02:33.38 | jsmith | file can probably give you a more definitive answer (if he's still awake) |
| 02:33.46 | file | I honestly don't know |
| 02:33.52 | jsmith | I haven't been following the releases closely enough in the past year or so |
| 02:34.39 | luckman212 | i guess if I wanted to manually apply the patch (there are 2 listed there) then the "correct" one would be https://issues.asterisk.org/jira/secure/attachment/41410/ast_check_digits.patch.txt yes? |
| 02:59.58 | elguero | luckman212: 1.8.9.0-rc1 was just tagged today... so that patch would be in there |
| 03:01.16 | elguero | luckman212: 1.8.8.0-rc1 was tagged on Oct 5th... the patch wasn't committed until Oct 18th... therefore, it was not in that release |
| 03:02.09 | luckman212 | elguero: ah, I see. so once a branch reaches rc status, no new patches can be included? |
| 03:02.15 | luckman212 | I didn't realize that |
| 03:05.08 | elguero | only patches for regresssions / security once a tag has been created... I am not an authority on that but I beleive that is the case |
| 03:05.36 | elguero | tags are like taking a snapshot of the code at that point in time |
| 03:05.57 | luckman212 | elguero: do you know the correct place (or does such a place exist) where the commit logs can be browsed or searched? I know about the asterisk-commits mailing list but searching is difficult |
| 03:08.59 | elguero | luckman212: This might be what you are looking for, https://code.asterisk.org/code/changelog/asterisk/branches/1.8 |
| 03:10.01 | luckman212 | hmm I am looking at http://svnview.digium.com/svn/asterisk/tags/?sortby=rev&sortdir=down#dirlist |
| 03:11.45 | elguero | there is a changelog in the release too... http://svnview.digium.com/svn/asterisk/tags/1.8.9.0-rc1/ChangeLog?view=markup&sortby=rev&sortdir=down |
| 03:14.46 | luckman212 | ok thanks, I am looking around |
| 03:22.12 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 07:39.58 | *** join/#asterisk-dev asterisk-Tester (~Ramyt@193.227.170.247) |
| 07:40.16 | asterisk-Tester | hello |
| 08:34.04 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:2484:e8a9:1c30:113a) |
| 08:50.13 | *** join/#asterisk-dev p3nguin (~xwQ5kwYl6@cobalt.esxi.hosts.a2infotech.com) |
| 09:32.18 | *** join/#asterisk-dev irroot (~gregory@197.110.170.161) |
| 09:32.36 | *** part/#asterisk-dev irroot (~gregory@197.110.170.161) |
| 10:12.23 | *** join/#asterisk-dev tzafrir (~tzafrir@212.179.75.202) |
| 10:12.23 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:31.51 | *** join/#asterisk-dev jacc0 (~jacc0@D522448D.static.ziggozakelijk.nl) |
| 11:31.55 | jacc0 | I want to send you all the best wishes for 2012. The asterisk dev team realy did a great job in 2011 making 1.8 stable as it is now |
| 11:43.25 | *** join/#asterisk-dev tamiel (~tamiel@ip-183.net-81-220-86.toulouse.rev.numericable.fr) |
| 12:05.41 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 12:05.41 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:44.38 | *** join/#asterisk-dev DagMoller (~aguirre@unaffiliated/dagmoller) |
| 12:44.41 | DagMoller | hi |
| 12:45.11 | DagMoller | there is a way to show DAHDI channel number instead of DAHDI Span on asterisk 1.8.X? |
| 12:45.44 | DagMoller | at asterisk 1.6: DAHDI/<channel number>-<ID> |
| 12:45.55 | DagMoller | at asterisk 1.8: DAHDI/i<span>/<dialed or dialing number>-<id> |
| 12:49.03 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:49.03 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 13:01.27 | *** part/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 13:06.38 | *** join/#asterisk-dev ccesario (~ccesario@187.17.166.162) |
| 13:19.11 | DagMoller | anyone? |
| 13:19.46 | tzafrir | DagMoller, not that I know. And yes, it is plain annoying |
| 13:20.42 | tzafrir | Makes debugging on the asterisk CLI painful as well |
| 13:20.49 | tzafrir | (unless you enable PRI trace) |
| 13:22.07 | DagMoller | i need that info on AMI Status command |
| 13:23.12 | DagMoller | i see about new DAHDIChannel event, but i really need it on Status Command |
| 13:28.21 | WIMPy | tzafrir: Why do you want the channel number? |
| 13:29.05 | tzafrir | dahdi_monitor , for once |
| 13:30.18 | WIMPy | I guess I'd see the issue on the dahdi_monitor side. |
| 13:30.31 | tzafrir | WIMPy, it works on the dahdi level |
| 13:30.44 | tzafrir | You wouldn't want to inject ISDN logic into it |
| 13:31.11 | tzafrir | let alone that this state information is not available if you start listening in the middle |
| 13:31.26 | WIMPy | I wouldn;t want to mix completely different technologies in the same driver. |
| 13:32.47 | WIMPy | BTW: Is it possible to get a copy of the D-channel that way as well? |
| 13:32.54 | tzafrir | WIMPy, I have two running calls in the same span. How do I identify which of them is which? |
| 13:33.38 | tzafrir | Right now chan_dahdi knows this, but the sig_pri part of it doesn't. |
| 13:34.32 | WIMPy | I guess as dahdi doesn't handle the calls it makes sense the way it is. |
| 13:35.23 | tzafrir | Right. And you should not mess with SIP headers from the dialplan. |
| 13:35.35 | tzafrir | That's also the same breakage of layering |
| 13:36.14 | WIMPy | I guess that makes sense as well. |
| 13:43.06 | *** join/#asterisk-dev irroot (~gregory@41-135-187-47.dsl.mweb.co.za) |
| 13:43.47 | *** part/#asterisk-dev irroot (~gregory@41-135-187-47.dsl.mweb.co.za) |
| 14:05.24 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-kzjirmbbtsujdpxk) |
| 14:07.24 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-kxngjowohylfmjxw) |
| 14:07.25 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:12.28 | *** part/#asterisk-dev jacc0 (~jacc0@D522448D.static.ziggozakelijk.nl) |
| 14:46.53 | DagMoller | well |
| 14:47.14 | DagMoller | my problem must be solved with "channelvars" parameter of manager.conf |
| 14:47.25 | DagMoller | but asterisk quit |
| 14:47.28 | DagMoller | :( |
| 14:58.25 | asterisk-Tester | hello, concerning this macro : #define DO_THREAD_CRASH do { *((int *)(0)) = 1; } while(0) , 1-is the do{}while(0) used because a compiler might remove it when optimizing ? 2-why is it used on purpose in ast code ? to have a single exit point thru signals and stuff ? |
| 14:58.57 | mjordan | http://stackoverflow.com/questions/1067226/c-multi-line-macro-do-while0-vs-scope-block |
| 15:01.01 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 15:01.01 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 15:02.21 | asterisk-Tester | mjordan: thx, that answers my qeustion number 1, but how about number 2 ? |
| 15:02.49 | mjordan | that answers number 2 as well. We use that pattern extensively in Asterisk code for the reason outlined in that SO answer. |
| 15:07.32 | asterisk-Tester | mjordan: I dont understand, but what is the point of crashing the app/thread on purpose ? |
| 15:08.10 | DagMoller | manager parameter channelvars=CHANNEL(dahdi_channel) causes segmentation fault |
| 15:12.33 | mjordan | asterisk-Tester: sorry, misinterpreted what your #2 meant. The reason DO_THREAD_CRASH exists is to force a thread to exit in the case of a catastrophic error - you'll note that its used where we fail to obtain a mutex, etc. Say for example we attempt to lock a mutex, and we get back an error from the pthread library. How is the caller of the mutex lock supposed to handle that? Its impossible for them to anticipate those scenarios - |
| 15:12.39 | mjordan | So, we kill the thread. |
| 15:13.33 | mjordan | In general, if that ever does get executed, something has gone horrifically wrong and you don't want to be proceeding any further. |
| 15:13.59 | asterisk-Tester | mjordan: mmm couldnt u have used a return or so instead of killing it ? |
| 15:14.03 | mjordan | no |
| 15:14.07 | mjordan | what would a return do? |
| 15:14.16 | mjordan | you asked something to lock a mutex, it failed, and it returns...? |
| 15:14.36 | mjordan | what is the caller of the lock supposed to do? For all it knows, you locked the mutex, except that... you didn't. |
| 15:16.36 | asterisk-Tester | mjordan: right |
| 15:18.16 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 15:18.16 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 15:19.55 | asterisk-Tester | and this will raise a signal 11, Segmentation fault one that we can catch in a signal handler, right ? to display some error msg in log or so ? |
| 15:20.07 | mjordan | I think you're missing my point. |
| 15:20.29 | mjordan | If you ever get to a point where DO_THREAD_CRASH has been hit, then you are most likely in a situation that you shouldn't try to handle. |
| 15:21.05 | *** join/#asterisk-dev irroot (~gregory@41-135-187-47.dsl.mweb.co.za) |
| 15:22.10 | mjordan | As far as logging is concerned, if you look through the code, you'll note that where its used, the mutex logger typically dumps out what went wrong before it kills itself. |
| 15:22.41 | asterisk-Tester | mjordan: ok, fair enough |
| 15:22.47 | mjordan | Beyond that, if you find yourself in that situation, either there is something very bad going on in your system, or you've made a significant coding error somewhere :-) |
| 15:22.48 | *** join/#asterisk-dev zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 15:23.40 | asterisk-Tester | mjordan: :-D |
| 15:24.17 | asterisk-Tester | thx for the info, but got to leave now .... happy new year and catch u next year ;-) |
| 15:24.23 | mjordan | np |
| 15:24.51 | kpfleming | next year? auuuaahhhghghghgh! |
| 15:27.16 | *** part/#asterisk-dev asterisk-Tester (~Ramyt@193.227.170.247) |
| 15:27.32 | mjordan | its a scary thought |
| 15:28.08 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 15:28.08 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by ChanServ |
| 15:32.50 | *** join/#asterisk-dev irroot (~gregory@41-135-187-47.dsl.mweb.co.za) |
| 15:44.01 | *** part/#asterisk-dev irroot (~gregory@41-135-187-47.dsl.mweb.co.za) |
| 16:07.30 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:11.24 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 16:11.24 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 16:15.41 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:39.34 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 16:39.34 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 16:39.45 | DagMoller | tzafrir_laptop, https://issues.asterisk.org/jira/browse/ASTERISK-19142 |
| 16:50.52 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:50.54 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 16:53.43 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@212.179.75.202) |
| 16:53.44 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 16:54.37 | DagMoller | tzafrir_laptop, you see my last message? |
| 16:57.14 | tzafrir_laptop | yes |
| 17:54.26 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 17:55.46 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 18:29.05 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 19:12.47 | *** join/#asterisk-dev The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
| 19:12.47 | *** join/#asterisk-dev kenhunt (~kenhunt@nat/digium/x-idqdekuewigouupp) |
| 19:12.47 | *** mode/#asterisk-dev [+o The_Boy_Wonder] by bartol.freenode.net |
| 19:21.58 | *** join/#asterisk-dev chazzam (~chazz@50-81-150-34.client.mchsi.com) |
| 19:21.58 | *** join/#asterisk-dev wedhorn (~wedhorn@123-243-209-34.static.tpgi.com.au) |
| 19:21.58 | *** join/#asterisk-dev Freeaqingme (~Freeaqing@91.214.168.110) |
| 19:24.05 | *** join/#asterisk-dev Dag[Away] (~aguirre@unaffiliated/dagmoller) |
| 19:24.05 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 19:24.05 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@mail.redfish-solutions.com) |
| 19:24.05 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.82.197) |
| 19:24.05 | *** join/#asterisk-dev Netgeeks (~chris@173.11.68.156) |
| 19:24.05 | *** join/#asterisk-dev elred_ (~elred_@unaffiliated/elred-/x-5010831) |
| 19:24.05 | *** join/#asterisk-dev opticron (~opticron@pianoben.ch) |
| 19:24.05 | *** join/#asterisk-dev jdoe (jdoe@falseprophet.ca) |
| 19:24.05 | *** join/#asterisk-dev acidfoo (~nib@modemcable094.94-70-69.static.videotron.ca) |
| 19:24.05 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 19:24.05 | *** mode/#asterisk-dev [+oooo russellb snuff-work opticron ChanServ] by bartol.freenode.net |
| 19:24.05 | *** join/#asterisk-dev tzanger (tzanger@wallace.mixdown.ca) |
| 19:31.28 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 20:56.34 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 20:56.35 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 21:26.29 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 21:26.30 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 22:03.55 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 22:03.55 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 22:49.40 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 22:49.41 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 23:12.38 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-kxngjowohylfmjxw) |