| 00:19.29 | *** join/#asterisk-dev chazzam (~chazz@50-81-150-34.client.mchsi.com) |
| 00:42.02 | *** join/#asterisk-dev wudles (~wudles@gateway.secureinstrument.com) |
| 00:44.52 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 00:44.52 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 01:02.45 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 01:02.45 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 01:37.25 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 01:37.25 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 01:44.54 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 01:44.54 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 02:54.53 | *** join/#asterisk-dev wudles (~wudles@gateway.secureinstrument.com) |
| 03:12.36 | *** join/#asterisk-dev luckman212_phone (~luckman21@2001:470:8abb:0:358d:eb41:5927:15c4) |
| 03:15.07 | *** join/#asterisk-dev luckman212_phone (~luckman21@2001:470:8abb:0:358d:eb41:5927:15c4) |
| 03:17.32 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@50-76-98-170-static.hfc.comcastbusiness.net) |
| 04:44.29 | *** join/#asterisk-dev Corydon76-home (one@c-69-137-80-31.hsd1.tn.comcast.net) |
| 04:44.30 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 06:26.29 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 06:26.29 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:37.23 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 06:59.01 | oej | Good morning, folks |
| 07:36.35 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:fd7c:ef24:7f8f:bff9) |
| 09:06.52 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:4545:a030:d005:4b96) |
| 09:35.50 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 09:35.51 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 10:08.42 | *** join/#asterisk-dev hehol (~hehol@217.9.101.222) |
| 11:37.00 | *** join/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 11:37.01 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:00.29 | *** part/#asterisk-dev mjordan (~mjordan@user-69-1-6-49.knology.net) |
| 12:15.20 | leifmadsen | morning all |
| 12:18.26 | Marquis42 | Morning leifmadsen |
| 12:18.38 | leifmadsen | howdy! |
| 12:18.50 | Marquis42 | What's the good word? |
| 12:21.44 | leifmadsen | not too much... need the coffees soon |
| 12:22.02 | Marquis42 | You definitely do! I'm on my 2nd cup already. |
| 12:23.32 | leifmadsen | you so crazy |
| 12:27.34 | Marquis42 | Heh... I'm crazy for being awake and at work long enough to have had 2 cups... |
| 12:29.25 | leifmadsen | indeed |
| 12:57.47 | *** join/#asterisk-dev ccesario_ (~ccesario@187.17.166.162) |
| 13:01.15 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 13:01.16 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 13:04.05 | *** join/#asterisk-dev Victor_Yure (~IceChat77@unaffiliated/victoryure/x-837844) |
| 13:05.44 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 13:05.44 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 13:16.17 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-adgfdywadygzuryu) |
| 13:16.17 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:16.27 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-cxgfxffafmcadcup) |
| 13:33.17 | *** join/#asterisk-dev jeffg (~jeffg@pdpc/supporter/professional/jeffg) |
| 14:25.49 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:25.49 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:31.32 | *** join/#asterisk-dev zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 14:35.07 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 14:35.08 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:39.27 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 14:39.28 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:57.29 | *** join/#asterisk-dev GameGamer43 (u5533@gateway/web/irccloud.com/x-uluuzlgyatpdmgio) |
| 15:36.49 | opticron | pokes Kobaz about closing review 1827 again |
| 16:00.18 | *** join/#asterisk-dev philipp64|laptop (~chatzilla@38.100.211.103) |
| 16:21.03 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.79) |
| 16:22.02 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.79) |
| 16:23.56 | otherwiseguy | seanbright: a long while back, I remember everyone deciding not to use nested functions anywhere because of "security concerns" related to an executable stack. If I'm reading things correctly, the only way that ever is a problem is if one passes the address of the nested function to an external function. Do you remember much about all of that? |
| 16:24.37 | seanbright | otherwiseguy: the only thing i recall about the discussion is: "executable stack is bad" |
| 16:24.49 | otherwiseguy | :-) |
| 16:25.00 | seanbright | and something about openbsd maybe not even supporting it |
| 16:25.23 | seanbright | it may be on the -dev list somewhere |
| 16:25.32 | otherwiseguy | So I'm going to assume that as long as we don't require an executable stack, we don't have a problem. |
| 16:25.35 | seanbright | mvanbaak posted something about it i believe |
| 16:26.08 | seanbright | i'm fairly confident that nested functions mandate an executable stack |
| 16:26.16 | otherwiseguy | http://gcc.gnu.org/ml/gcc-help/2005-12/msg00174.html is the link in the review you posted removing the nested functions we had. |
| 16:27.32 | seanbright | otherwiseguy: http://gcc.gnu.org/ml/gcc-help/2008-11/msg00049.html |
| 16:29.50 | otherwiseguy | Hmm, it looks like we just kind of threw the baby out with the bathwater on that. If taking the address of nested functions is the problem, just don't do that. |
| 16:31.15 | seanbright | the use case was passing a callback to the ao2 infrastructure |
| 16:31.25 | seanbright | which obviously requires a function pointer |
| 16:31.27 | otherwiseguy | The reason I ask is I've been looking at the gcc cleanup attribute, and a macro that creates a nested function would be useful. It is just called in the scope of the function, so it shouldn't be an issue. |
| 16:32.10 | seanbright | true |
| 16:32.16 | seanbright | i am far from an authority on the topic, however. |
| 16:32.18 | seanbright | i just work here. |
| 16:32.28 | otherwiseguy | And I tested it with the execstack app just to be sure that it didn't create an executable stack. |
| 16:32.34 | file | seanbright, what are you an authority on? |
| 16:32.53 | seanbright | file: kicking your ass? |
| 16:32.54 | otherwiseguy | seanbright: thanks! just thought I'd try to brush up on the situation before doing something silly. |
| 16:33.03 | file | well played |
| 16:33.14 | russellb | i think trying to use embedded functions in C is just trying to be a bit too clever :-) |
| 16:33.32 | russellb | and will likely end up wasting more time than necessary on the problem you want to solve |
| 16:33.36 | russellb | such as this discussion |
| 16:33.45 | otherwiseguy | russellb: http://en.wikipedia.org/wiki/Resource_Acquisition_Is_Initialization#C_example_using_GCC_extensions |
| 16:33.49 | russellb | i believe it blew up the build on some platforms, too (OpenBSD maybe?) |
| 16:34.05 | otherwiseguy | Only because what we were trying to do required an executable stack. |
| 16:34.09 | seanbright | that may have just been because of the executable stack though |
| 16:34.17 | seanbright | might be fine for what otherwiseguy is doing |
| 16:34.19 | otherwiseguy | It isn't nested functions themselves that require an executable stack. |
| 16:34.36 | russellb | it's passing around the address? |
| 16:35.31 | seanbright | aye |
| 16:35.34 | otherwiseguy | I can do it without a macro like the one listed on wikipedia, but then you end up having to manually create a destructor for all ao2 objects instead of just sharing one for all of them. |
| 16:35.38 | russellb | why not just work on switching to C++ if this is important? |
| 16:35.48 | otherwiseguy | stabs russellb |
| 16:35.55 | otherwiseguy | (with kittens) |
| 16:35.56 | russellb | instead of obfuscating the code even further with craziness |
| 16:36.14 | russellb | armchari codes |
| 16:36.31 | otherwiseguy | There is no obfuscation, though. Far less than trying to figure out what a piece of C++ code is doing. :-p |
| 16:36.51 | seanbright | yeah, c++ is awful |
| 16:37.18 | Qwell | otherwiseguy: c++ is supposed to be write-only |
| 16:37.44 | russellb | k, then just write good readable C :-) |
| 16:38.06 | otherwiseguy | The only reason I like the cleanup attribute is because it helps to avoid leaks and would eliminate some of the crazy goto usage we have. |
| 16:38.29 | russellb | i think using goto to centralize cleanup is a very reasonable usage of goto |
| 16:38.35 | russellb | and is used quite commonly |
| 16:39.09 | seanbright | well then we should drop ao2 |
| 16:39.11 | otherwiseguy | Yes, but we have some code where we are jumping out of crazy nested loops with gotos and it gets a little hairy sometimes. |
| 16:39.23 | Qwell | don't do that then ;p |
| 16:39.28 | seanbright | heh |
| 16:39.31 | russellb | well right, that's different |
| 16:39.53 | otherwiseguy | Just looking for tools to make the code more readable and safer. |
| 16:41.17 | seanbright | otherwiseguy: go for it |
| 16:41.20 | seanbright | russellb will get over it |
| 16:41.29 | otherwiseguy | <3s russellb |
| 16:41.46 | seanbright | well he's been holding us back for too damn long |
| 16:41.54 | seanbright | this is the post-russellb era |
| 16:41.56 | seanbright | heh |
| 16:42.10 | otherwiseguy | russellb is a timeless classic. |
| 16:42.18 | file | alcohol for all? |
| 16:42.24 | russellb | seanbright: always such a dick |
| 16:42.29 | seanbright | yay! |
| 16:47.28 | russellb | otherwiseguy: if you add it and use it in a few places and post a patch, ping me, i'd be curious to see how it looks in action ... |
| 16:49.23 | otherwiseguy | russellb: will do. I'm looking at using it in my new config parsing stuff, so I'll have a good example soon. I've got this one function where I've got about 5 different things I have to tear down on error, and it looked like it might make the code much prettier. We'll see. Just wanted to get a feel for people's reactions before spending too much time on that part. |
| 16:53.00 | otherwiseguy | I honestly like it better without the macro/nested function…but having my destructor function void ** results in an incompatible pointer error when the cleanup attribute is set on the ao2_container * var. |
| 16:54.01 | otherwiseguy | and manually defining a bunch of functions that are just wrappers of ao2_ref(*obj, -1) irritates me. |
| 16:59.29 | otherwiseguy | and the RAII thing doesn't really help in situations where you are allocating something that you plan on returning, but have to destroy on error. But it would be very nice for some locking cases. We'll see. After using it a bit, I may hate it. |
| 17:06.02 | russellb | i need to report a bug at some point on behalf of a fedora user ... using latest versions, outbound mwi subscriptions crash pretty much immediately |
| 17:06.24 | russellb | in case that sounds familiar to anyone ... i haven't had enough time to dig into the code |
| 17:07.35 | jsmith | russellb: Doesn't sound familiar to me |
| 18:28.17 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 18:28.17 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:45.48 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 18:45.49 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:46.28 | *** join/#asterisk-dev oej_ (~olle@95.209.35.151.bredband.tre.se) |
| 18:46.28 | *** mode/#asterisk-dev [+o oej_] by ChanServ |
| 19:51.46 | *** join/#asterisk-dev zerohalo (~zerohalo@74-94-141-204-ma.hfc.comcastbusiness.net) |
| 19:59.24 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 19:59.24 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 20:29.28 | *** join/#asterisk-dev citywok (~citywok@67-134-194-33.dia.static.qwest.net) |
| 20:36.40 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 21:18.09 | *** join/#asterisk-dev snuff-work (~snuffy@210.9.82.197) |
| 21:18.09 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:23.50 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-adgfdywadygzuryu) |
| 23:10.34 | *** join/#asterisk-dev snuff-work (~snuffy@210.9.82.197) |
| 23:10.34 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 23:33.34 | *** join/#asterisk-dev wudles (~wudles@gateway.secureinstrument.com) |