| 00:42.48 | russellb | i have fedora 17 installed ... now i get to find the new warnings from gcc 4.7.0 |
| 00:42.51 | russellb | weeee |
| 00:48.05 | sruffell | should just bite the bullet and build with clang |
| 00:49.24 | sruffell | I remember reading somewhere recently how google (I think) builds it's projects in with both gcc (for code generation) and clang (for warning messages) |
| 00:54.11 | Kobaz | do de do |
| 01:00.26 | *** join/#asterisk-dev snuff-home (~snuffy@203-219-29-182.tpgi.com.au) |
| 01:00.28 | *** mode/#asterisk-dev [+o snuff-home] by ChanServ |
| 02:52.06 | *** join/#asterisk-dev Agro (~Agro@108-79-20-223.lightspeed.hstntx.sbcglobal.net) |
| 07:10.54 | *** join/#asterisk-dev jploh (~jploh@119.123.48.52) |
| 07:34.38 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 07:34.39 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:20.06 | *** join/#asterisk-dev oej (~olle@h87-96-134-129.dynamic.se.alltele.net) |
| 09:20.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:32.44 | *** join/#asterisk-dev kpfleming (~kpfleming@asterisk/digium-director-of-software-tech/kpfleming) |
| 12:32.45 | *** mode/#asterisk-dev [+o kpfleming] by ChanServ |
| 14:36.44 | *** join/#asterisk-dev sruffell (~Adium@asterisk/the-kernel-guy/sruffell) |
| 14:36.44 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:01.29 | *** join/#asterisk-dev Agro (~Agro@108-79-20-223.lightspeed.hstntx.sbcglobal.net) |
| 15:17.24 | Agro | To achieve tone detection through dsp.h, do I have to use the ast_tone_detection object, because the goertzel object isn't a global object |
| 15:31.41 | kpfleming | umm... yes? why wouldn't you use a tone detector to detect tones? |
| 15:32.15 | Agro | Well, you told me to use goertzel, so I thought use it directly last time |
| 15:32.18 | Agro | thanks |
| 15:33.48 | kpfleming | no, i told you to look in dsp.h for the functions that it makes available. you mentioned goertzel :-) |
| 15:34.21 | Agro | oh |
| 15:34.26 | Agro | so I have to use the ast_dsp object then? |
| 15:35.07 | kpfleming | you don't *have* to do anything. you have all the source code, you can do anything you like. if you want to use the simplest route to solving your problem, then using the existing tone detection functions is probably the right choice. |
| 15:35.35 | Agro | existing? |
| 15:35.45 | kpfleming | the functions documented in dsp.h. |
| 15:35.48 | Agro | oh right |
| 15:36.01 | Agro | i was going to use that anyway :/ |
| 15:38.16 | Agro | kpfleming, which functions would I actually use in dsp.h? I think what I'm looking for is in dsp.c |
| 15:39.14 | kpfleming | are you familiar with writing code in C? the dsp.h header file documents the functions and provides the prototypes for the functions that appear in dsp.c. |
| 15:39.39 | Agro | I've been using C, but things like goertzel_init and ast_tone_detection_init, those aren't in dsp.h |
| 15:40.01 | kpfleming | you can only call the functions listed in dsp.h. everything you need should be there. |
| 15:40.18 | Agro | Okay. |
| 15:42.19 | kpfleming | well, actually that may not be true. it doesn't appear that the API functions there allow you to define your own tones. |
| 15:42.34 | Agro | Yeah, that's what I was looking at :| |
| 15:42.49 | Agro | So do I have to move the ast_tone_detection and goertzel functions to a serparte file? |
| 15:42.51 | Agro | copy( |
| 15:42.53 | Agro | copy* |
| 15:43.25 | kpfleming | no |
| 15:43.41 | Agro | How would I use it then :/ |
| 15:43.48 | kpfleming | the right way to do this would be to enhance the code in dsp.c to have a way to be able to specify a tone frequency to listen for |
| 15:44.16 | Agro | so, time to write my own function ;) |
| 15:46.51 | kpfleming | actually, it looks like you could convert the SPECIAL1 handling in dsp.c over to the frequency you want to check for, since nothing in Asterisk is actually using that |
| 15:47.26 | kpfleming | and then use ast_dsp_get_tstate() after processing a frame to see if that tone was detected |
| 15:47.40 | Agro | wait what is special1? |
| 15:47.51 | kpfleming | wait... no, that won't work either. never mind. |
| 15:48.06 | Agro | so im just writing a function now |
| 15:49.28 | Agro | since im doing this, i think i can get rid of using ast_dsp |
| 15:51.30 | otherwiseguy | kpfleming: I managed to convince rmudgett on the config thing by saying that iff the exiting behavior causes problems for developers who frequently change between versions of Asterisk for development, then someone could add a DEV_MODE only option in asteriskk.conf like "ignore_config_warnings=sip.conf,whatever.conf" etc. |
| 15:51.44 | kpfleming | interesting |
| 15:51.57 | otherwiseguy | or asterisk.conf. whatever. :-) |
| 15:52.21 | otherwiseguy | I still don't think it should even be an option for production systems. |
| 15:52.23 | kpfleming | although would be better named something that indicated that errors won't abort the loading... not warnings |
| 15:52.28 | Agro | what is amp? |
| 15:52.44 | kpfleming | Agro: no idea. you need to provide some context. |
| 15:52.59 | Agro | static int tone_detect(struct ast_dsp *dsp, tone_detect_state_t *s, int16_t *amp, int samples) |
| 15:53.29 | kpfleming | it's a parameter to the function. that's all i know. none of us here are experts on the dsp.c code. |
| 15:53.31 | otherwiseguy | config_errors_dont_cause_loads_or_reloads_to_fail_in=sip.conf |
| 15:53.39 | Agro | oh |
| 15:53.40 | kpfleming | otherwiseguy: lol |
| 15:54.00 | kpfleming | based on what i've seen, it's probably short for 'amplitude' |
| 15:54.38 | Agro | wait, kpfleming, if I add onto dsp.h that means I have to recompile entire asterisk |
| 15:54.54 | otherwiseguy | Even if downgrading from a previous asterisk version happens, it isn't really a big deal anyway since you can just s/newoption/;newoption/ in your config file. |
| 15:55.12 | kpfleming | Agro: yes, that's true |
| 15:55.25 | kpfleming | otherwiseguy: but that's work. developers are lazy. |
| 15:55.32 | Agro | I don't want to do that at all, so is my next option moving all the functions somewhere else? |
| 15:55.51 | kpfleming | Agro: you can do whatever you want. what is the best thing for you to do we cannot speculate. |
| 15:55.59 | Agro | alright |
| 15:56.18 | otherwiseguy | kpfleming: Developers shouldn't use things that ignore possible errors. :-) |
| 15:56.46 | otherwiseguy | It is kind of amusing the idea of adding something to dev mode to specifically ignore errors. |
| 15:57.29 | otherwiseguy | I think it is a pretty decent compromise, though. |
| 15:58.00 | otherwiseguy | As someone who has taken down thousands of users with a broken config, I'm pretty passionate about not letting end users do that to themselves if we can help it. |
| 15:58.10 | kpfleming | me too |
| 15:58.12 | otherwiseguy | Stupid commas. |
| 15:58.24 | otherwiseguy | I missed one once, and totally screwed things up. :-) |
| 15:59.19 | otherwiseguy | Always fun when you do a reload, and then within a minute you start hearing all of the phones in support start ringing. :-p |
| 16:00.07 | otherwiseguy | and then you have to deal with people saying "oops, I forgot a comma" every time they see you for the next couple of years... |
| 16:09.37 | Agro | sucessfully transferred all the functiosn i need :) |
| 16:26.31 | Agro | in the DSP, what is the difference between CED tone detection state and CNG tone detection state? |
| 17:46.51 | *** join/#asterisk-dev otherwiseguy (~otherwise@cpe-69-76-221-79.kc.res.rr.com) |
| 17:52.40 | Agro | I'm trying to use ast_dsp* functions, but Asterisk is telling me the module I am making has an error with undefined symbol ast_dsp* other than ast_dsp_new |
| 19:10.52 | *** join/#asterisk-dev Agro (~Agro@108-79-20-223.lightspeed.hstntx.sbcglobal.net) |
| 19:13.14 | Agro | Would this code example work to get the data needed for tone detection over a 10 second period? http://pastebin.com/Hu4LwLZh |
| 20:38.32 | *** part/#asterisk-dev coreyf1513 (~cfarrell@68-118-184-231.dhcp.asfd.ct.charter.com) |
| 21:40.48 | *** join/#asterisk-dev Agro (~Agro@108-79-20-223.lightspeed.hstntx.sbcglobal.net) |
| 21:44.44 | Agro | Can anyone tell me why this is happening: [Apr 28 16:44:07] WARNING[44250]: loader.c:460 load_dynamic_module: Error loading module 'tonedetect.so': /usr/local/lib/asterisk/modules/tonedetect.so: Undefined symbol "ast_dsp_digitdetect" |
| 21:55.23 | Agro | Apparently, all functions involving ast_frame* are messing up |
| 21:56.16 | *** part/#asterisk-dev mbrevda (u5500@gateway/web/irccloud.com/x-bpqjcvrxzbmpcyzg) |
| 22:06.15 | eZz | it seems you do something wrong |
| 22:07.01 | eZz | because all of my patches involving ast_frame* are working |
| 22:07.34 | Agro | Can I show you the code eZz |
| 22:08.22 | eZz | sure |
| 22:08.29 | Agro | eZz, http://pastebin.com/d0hf85Y8 |
| 22:09.31 | eZz | ok will look at them in 4-5 min |
| 22:09.37 | Agro | Okay, thanks :) |
| 22:15.40 | eZz | could you shall a full source of tonedetect.c ? |
| 22:16.00 | eZz | *share |
| 22:16.01 | Agro | yes |
| 22:16.17 | Agro | eZz, http://pastebin.com/pmzp92F5 |
| 22:16.36 | eZz | ok |
| 22:23.23 | Agro | eZz, any ideas? |
| 22:23.30 | eZz | onesec |
| 22:23.34 | Agro | ok |
| 22:32.12 | Agro | :| |
| 22:34.06 | eZz | <PROTECTED> |
| 22:34.07 | eZz | <PROTECTED> |
| 22:34.27 | eZz | :-] |
| 22:35.27 | Agro | it worked ok? |
| 22:35.34 | Agro | how come its giving me that error |
| 22:42.29 | Agro | eZz, what asterisk vversion are you running? |
| 22:43.49 | eZz | 1.8.7.1 |
| 22:45.55 | Agro | so would it be a problem if its on 1.8.11.1 eZz ? |
| 22:46.22 | eZz | looks like you missed ast_dsp_digitdetect in dsp.c |
| 22:47.10 | Agro | I checked the 1.8.11.1 source code dsp.c and dsp.h its as it was there |
| 22:47.12 | Agro | or am i wrong? |
| 22:47.58 | eZz | don't know i didn't tested 1.8.11.1 |
| 23:03.50 | Agro | oh |
| 23:04.14 | Agro | eZz, i tested it again and it only misses the ones ast_dsp having to do with digits |
| 23:05.30 | eZz | search for dependances, maybe you've missed something else |
| 23:05.37 | eZz | it should work I'm sure |