| 02:33.57 | *** join/#asterisk-dev moy (~moy@unvlon55-1176057127.sdsl.bell.ca) |
| 04:42.10 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 04:42.11 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 05:40.43 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 06:11.28 | *** join/#asterisk-dev oej (~olle@2001:16d8:cc57:1000::42:1003) |
| 06:11.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:25.51 | wedhorn | Anyone that was at DevCon able to shed some light on Avencall's ideas with chan_skinny? |
| 07:04.44 | *** join/#asterisk-dev jrose_atDigium (~jrose_atD@nat/digium/x-vcauydmwgnoejjud) |
| 07:24.08 | *** join/#asterisk-dev oej (~olle@2001:16d8:cc57:1000::42:1004) |
| 07:24.08 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:08.44 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 08:36.43 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:9cf4:373c:9ef0:638f) |
| 11:09.52 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 11:09.52 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:13.50 | file | wedhorn, moo |
| 11:50.34 | *** join/#asterisk-dev attila_lendvai (~attila_le@unaffiliated/attila-lendvai/x-3126965) |
| 11:54.46 | attila_lendvai | hi! cdr_csv seems to be not thread safe, we have two entries overlapping in one line, screwing up the quotes. but looking at the code there's a lock there... any ideas? |
| 11:59.11 | attila_lendvai | although it's on an openwrt router, maybe some fs bugs or something weird |
| 12:33.31 | *** join/#asterisk-dev droemel (~droemel@p4FCAD797.dip.t-dialin.net) |
| 12:37.29 | *** join/#asterisk-dev oron_laptop (~oron_lapt@local.xorcom.com) |
| 13:57.59 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 13:57.59 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 13:59.47 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 13:59.47 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 14:00.15 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-vvjqnupvgqvtifch) |
| 14:15.30 | russellb | small feature request in case anyone is bored: CLI tab completion for "agi show commands topic <tab>" |
| 14:16.04 | russellb | hrm, i should just write it |
| 14:16.21 | russellb | improve my signal to noise ratio a bit for the month :-) |
| 14:18.41 | russellb | newtonr: that commit message for revision 376282 ... doesn't have a commit message. it's just the meta-data tags :-) |
| 14:19.56 | opticron | I already alerted him last night :) |
| 14:20.12 | WIMPy | Oh, BTW: It would be nice if the commit messages contained a clear indication of what file(s)/modules(s) are affected. Usually it's implicitly clear, but sometime it's not. |
| 14:22.22 | *** join/#asterisk-dev asterisk-Tester (~ramy@80.79.159.158) |
| 14:22.23 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 14:22.23 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 14:26.15 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-yzumopwuitaefykc) |
| 14:26.15 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:28.38 | russellb | sees why this wasn't implemented before ... not a trivial tab completion addition :-) |
| 14:28.49 | leifmadsen | russellb: :) |
| 14:29.02 | leifmadsen | WIMPy: isn't that what the commit information is for? |
| 14:29.11 | leifmadsen | I'm not sure why it should be duplicated in the commit message |
| 14:29.45 | WIMPy | You can look at the diffs, off course. But if you do a svn log there are a few entries where it's not clear. |
| 14:30.00 | leifmadsen | then you use the other svn tools available to you to figure that out |
| 14:30.13 | leifmadsen | duplicating that information in the commit message is not DRY |
| 14:31.59 | russellb | there is value in doing it when the commit volume is really high |
| 14:32.12 | russellb | quickly looking through a list of commits trying to find the ones that affect the bit you care about |
| 14:32.50 | WIMPy | Yes, I like to look at the log to see if there's anything I should have an eye on. |
| 14:32.58 | mjordan | file: remember my mutex shenanigans? |
| 14:33.04 | file | mjordan, yessir |
| 14:33.35 | mjordan | file: re-organized main a bit to push the call to daemon higher up in the processing and removed most of the ways in which a message can go through logger before that happens. No deadlocks. |
| 14:33.51 | mjordan | no errors is probably a bit more appropriate, sometimes it wouldn't deadlock. |
| 14:33.59 | file | well then |
| 14:34.03 | mjordan | indeed. |
| 14:34.06 | leifmadsen | I just think it's unrealistic to consistently expect people to remember to add the files they modified to a commit message |
| 14:34.19 | mjordan | don't like not knowing exactly why something happens |
| 14:34.20 | leifmadsen | if it was automated.. then sure it makes sense; otherwise it's totally unreliable |
| 14:34.26 | WIMPy | It probably is. |
| 14:34.36 | mjordan | leifmadsen: sometimes its a bit overkill as well |
| 14:35.00 | mjordan | (and my diff viewer shows which ones were modified in a commit history, so there's that) |
| 14:35.09 | leifmadsen | mjordan: +1 |
| 14:35.27 | russellb | leifmadsen: not the files, something higher level, like the general subsystem you're touching. "sip, iax, logger, ..." |
| 14:35.57 | russellb | "sip: Fix a deadlock in DTMF handling" or something like that |
| 14:36.26 | russellb | always likes that idea but fails to do it regularly |
| 14:36.34 | mjordan | agrees with russellb |
| 14:36.36 | WIMPy | Good example how a "sip:" is really helping. |
| 14:36.41 | mjordan | not sure I've ever remembered :-P |
| 14:37.09 | russellb | at least we're all on the same page then |
| 14:37.12 | WIMPy | As I said: Usually it's clear, but for sometimes theres a but that might be one channel or another. |
| 14:37.23 | file | dejavu. |
| 14:37.23 | russellb | nods |
| 14:37.41 | russellb | file: yes we've had this conversation multiple times :) |
| 14:37.45 | WIMPy | s/a but/something/ |
| 14:38.05 | file | we should replace some of the words with other words and see if everyone still understands next time |
| 14:38.06 | mjordan | this is one of those things thats hard to lock into a policy. "Please put a category as the first word in a commit summary. Except that the categories are not written down. And if your commit touches multiple categories, you may not to want to put them all" |
| 14:38.12 | file | a nice experiment to see if our brains automatically replace 'em |
| 14:38.36 | russellb | mjordan: it's a general guideline for the category of things you apply based on your general common sense |
| 14:38.45 | russellb | and if you don't have good sense, you shouldn't have commit access |
| 14:38.45 | mjordan | russellb: agreed |
| 14:38.50 | mjordan | heh |
| 14:39.20 | russellb | omg everywhere: convert ast_channel to a wizzbang object thing |
| 14:39.35 | mjordan | russellb: except people already have a hard time following the simple rules we have for commit messages now |
| 14:39.43 | russellb | :) |
| 14:39.45 | mjordan | (And yes, I agree, they shouldn't have a hard time) |
| 14:39.46 | russellb | good times. |
| 14:40.13 | russellb | you know, with git, you could have patch submitters doing the commit message authoring part of the work, too |
| 14:40.16 | russellb | :-p |
| 14:40.24 | mjordan | russellb: yet another reason to go to git |
| 14:40.29 | russellb | yesssss |
| 14:40.34 | mjordan | believe me, I'm sold |
| 14:40.45 | file | for the love of cheese can we stop finding reasons to switch to git? we are going to switch :P |
| 14:41.17 | russellb | file: k so do it already |
| 14:41.52 | file | DONE! |
| 14:41.56 | russellb | yay |
| 14:42.10 | file | russellb, now you just have to change all of the policies/procedures/tools |
| 14:42.10 | russellb | yes i know i'm just making noise and not helping toward the solution |
| 14:42.26 | russellb | i really need to write some patches to improve my S/N ratio |
| 14:42.46 | russellb | file: i need a sponsor. |
| 14:43.30 | mjordan | k, I'll sponsor you |
| 14:43.39 | mjordan | you can wear my name as a logo? |
| 14:43.44 | russellb | wears a mjordan t-shirt and baseball cap |
| 14:43.46 | mjordan | SWEET |
| 14:43.49 | russellb | aw, you beat me to the joke. |
| 14:44.32 | file | mjordan, you should have gotten a tattoo as well |
| 14:44.47 | mjordan | adds that to the sprint retrospective |
| 14:47.57 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 14:53.31 | WIMPy | The last commit message is a good example. It just references a jira issue, but no mention at all whet it's about. |
| 14:54.06 | russellb | that commit message doesn't have a commit message in it :-) |
| 14:56.28 | mjordan | ...and today is 1 month until Asterisk 10 bug fix EOL... |
| 14:56.33 | mjordan | goes back to typing |
| 14:57.07 | russellb | <insert obligatory YOU SHOULD FIX BUGS FOREVER flame here> |
| 14:57.13 | russellb | omg asterisk 1.4 for life! |
| 14:58.06 | file | russellb, Asterisk 1.0 for life!!! |
| 14:58.21 | leifmadsen | russellb: don't you have things to backport and merge?! |
| 14:58.44 | russellb | leifmadsen: no. |
| 14:59.11 | file | russellb, don't you have python to write or review? |
| 14:59.22 | russellb | file: yes |
| 14:59.42 | file | monkeypatches russellb so he sees the world in orange |
| 15:00.05 | russellb | potatopatches file and deep fries him in peanut oil |
| 15:00.18 | file | deep fry the plate too |
| 15:05.39 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 15:05.39 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 15:07.17 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:07.17 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:11.45 | *** join/#asterisk-dev leedm777 (~leedm777@nat/digium/x-ihakgcvaardepeiz) |
| 15:32.13 | *** join/#asterisk-dev Qwell (~north@pdpc/sponsor/digium/Qwell) |
| 15:32.13 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 16:12.16 | *** join/#asterisk-dev rhamnett (~rick@109.111.202.18) |
| 16:36.11 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 16:36.11 | *** mode/#asterisk-dev [+o file] by ChanServ |
| 17:01.46 | *** join/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 17:19.31 | *** join/#asterisk-dev oej_ (~olle@2001:16d8:cc57:1000::42:1003) |
| 17:19.31 | *** mode/#asterisk-dev [+o oej_] by ChanServ |
| 17:36.12 | rhamnett | Hi guys on asterisk 1.8 using odbc mysql cdr, I am getting an error "res_odbc.c: SQL Execute returned an error -1: HY000: [MySQL][ODBC 5.1 Driver][mysqld-5.5.25-1~ppa1~oneiric-log]Cannot execute statement: impossible to write to binary log since BINLOG_FORMAT = STATEMENT and at least one table uses a storage engine limited to row-based logging. InnoDB is limited to row-loggi (329)" |
| 17:36.24 | rhamnett | however my table is an innodb table so I don't understand why |
| 17:37.17 | jsmith | Sounds like a MySQL integration question, not an Asterisk development question |
| 17:37.41 | jsmith | (in other words -- if you get the same error while trying to send queries from the isql command-line client, it's not really an Asterisk issue) |
| 17:39.00 | *** part/#asterisk-dev rgagnon (~rgagnon@rrcs-71-42-183-54.sw.biz.rr.com) |
| 17:39.06 | jsmith | That being said, there's plenty of information on binlog formats at http://dev.mysql.com/doc/refman/5.5/en/binary-log-mixed.html |
| 17:42.25 | rhamnett | jsmith, if i go into mysql using the mysql client and do the insert it works |
| 17:42.35 | *** join/#asterisk-dev oej (~olle@2001:16d8:cc57:1000::42:1003) |
| 17:42.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:42.38 | rhamnett | that's the issue |
| 17:42.54 | jsmith | rhamnett: Did you try doing it from the isql client (the command-line client that comes with ODBC)? |
| 17:43.35 | rhamnett | jsmith, no I did not to be honest this is the first time I have played with linux odbc, I am trying to migrate from the old skool 1.6 cdr_mysql.conf |
| 17:43.39 | rhamnett | jsmith, I will look into isql |
| 17:48.30 | jsmith | That'll tell you whether it's a problem with your ODBC -> MySQL configuration (which I very strongly suspect) or with Asterisk (which I highly doubt) |
| 17:49.20 | jsmith | For the record, I'm an unashamed MySQL detractor, so I may not be the very best person to ask for help with MySQL |
| 18:27.55 | rhamnett | jsmith, the isql console allowed me to insert the record fine |
| 18:27.58 | rhamnett | no complaints |
| 18:30.52 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:30.52 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:34.17 | *** join/#asterisk-dev n8ideas (~joshua@65.112.207.3) |
| 18:34.34 | n8ideas | can anyone possibly give me a little insight on the reason for the msg_id addition to voicemail messages in ODBC voicemail in Asterisk 11? |
| 18:37.48 | n8ideas | seeing some really nasty behavior with ODBC Voicemail in 10 locking up the entire SIP stack at various points, causing mass peer timeouts, etc... curious if msg_id was a recognition of a structural issue here |
| 18:38.08 | putnopvut | n8ideas: a couple of reasons |
| 18:38.12 | Qwell | ugh |
| 18:38.22 | Qwell | I wish people would stop asking questions in multiple channels. |
| 18:38.25 | putnopvut | One is that there was no way to uniquely identify a voicemail prior to their addition. |
| 18:38.31 | putnopvut | heh |
| 18:38.37 | Qwell | glares at n8ideas |
| 18:38.48 | leifmadsen | also glares |
| 18:39.11 | n8ideas | Sorry, that's my bad. Meant to ask in dev |
| 18:39.48 | putnopvut | The reason it got added in 11 is to satisfy API requirements for manipulating voicemails outside of Asterisk. |
| 18:40.13 | n8ideas | Nothing performance-wise that might change, however? |
| 18:40.35 | putnopvut | Nothing massive, to my knowledge. |
| 18:41.54 | n8ideas | Alright... seeing some really ugly locking, where at some points in app_voicemail, we are locking up the entire SIP stack on what appear to be DB calls that are long |
| 18:42.21 | n8ideas | I've seen it exceed 3-5 seconds, even on a system with relatively moderate load |
| 18:42.31 | putnopvut | ouch |
| 18:42.37 | n8ideas | the entire SIP channel stops responding until we return |
| 18:42.54 | n8ideas | so bunches of peers timeout, and all the other usual badness that accompanies |
| 18:44.22 | jsmith | n8ideas: Are you use it's not DNS lookup timeouts that are causing that? |
| 18:44.40 | n8ideas | I am not 100% positive on that, but I haven't seen any DNS errors |
| 18:44.57 | n8ideas | are you suggesting DNS lookups on peers? I did see that issue raised somewhere recently |
| 18:45.14 | jsmith | I've seen two causes for chan_sip to hang like that -- DNS timeouts, and a funny race condition related to Asterisk receiving RTCP packets |
| 18:45.33 | jsmith | (but the RTCP thing would only hang the outbound RTP on that one channel) |
| 18:45.44 | oej | What? |
| 18:45.49 | oej | RTCP hanging? |
| 18:45.52 | n8ideas | interesting... I did fairly recently insert a SRV-based static peer on the servers that's having the issue |
| 18:46.08 | n8ideas | I could certainly switch to a static IP and see if that addressed the issue |
| 18:47.19 | jsmith | oej: Yeah... friend of mine asked me to help him debug an issue. Every once in a while, Asterisk will stop sending outbound RTP on a channel for three or four seconds after receipt of an RTCP packet |
| 18:47.58 | jsmith | oej: No gaps in the sequence number, just gaps in the audio and in the RTP timestamps |
| 18:48.09 | jsmith | seems to find all the nasty issues, it seems |
| 18:48.44 | leifmadsen | jsmith: :\ |
| 18:52.29 | pabelanger | jsmith: what version you running now? |
| 18:53.30 | jsmith | pabelanger: On which box? |
| 18:53.47 | pabelanger | the one with all the problems? |
| 18:53.49 | jsmith | pabelanger: 11 on my laptop, 10 on one lab machine, 1.8 on another lab machine, and 1.8 in production |
| 18:54.01 | jsmith | pabelanger: The RTCP thing was on 10, the other issues are in 1.8 |
| 18:57.57 | oej | Hmm. That reminds me that I've seen this while testing. |
| 18:58.18 | oej | And I saw it 1.4 |
| 19:00.42 | wedhorn | file, you were saying... |
| 19:00.53 | file | what? |
| 19:01.18 | file | oh - Avencall? |
| 19:01.18 | wedhorn | you said moo, I was hoping it was in respect of my devcon question |
| 19:01.22 | wedhorn | yeah |
| 19:01.51 | file | oh! they have a lot of Skinny users, weren't happy with chan_skinny, wrote their own thing, and want to get it into the tree |
| 19:02.49 | wedhorn | I got that much, but it looks like there using 1.8 |
| 19:03.03 | file | yeah no idea for further details |
| 19:03.18 | wedhorn | okay |
| 19:03.56 | wedhorn | mjordan, can you shed some light on Avencall's plans |
| 19:36.10 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 19:36.10 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 21:13.25 | pabelanger | wedhorn: acidfoo is the man you want to talk too. I think he wants to push his changes upstream |
| 21:21.10 | wedhorn | pabelanger, thanks. I'm more interested in the whole development cycle. I would guess that many of the things he wants is in later versions and weren't included in 1.8 because we weren't allowed to include them |
| 21:21.25 | wedhorn | A bit worried we will end up reinventing the wheel |
| 21:22.01 | wedhorn | Basically, I wouldn't touch 1.8 or ast10 skinny with a 10ft pole |
| 21:22.14 | wedhorn | ast11 however works well |
| 21:22.21 | pabelanger | wedhorn: my understanding is they wrote their own channel driver and have it in production now |
| 21:23.23 | wedhorn | yep, but at a cursory glance it appears to be a copy of 1.8 with some fixes, some backports and a bit of their own code |
| 22:11.15 | mjordan | wedhorn: definitely talk to acidfoo. I recommended at devcon that they talk to you about the effort as well. Other than what pabelanger already mentioned, I'm unaware of what is in their channel driver versus chan_skinny |
| 22:14.24 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 22:14.24 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 22:17.01 | *** join/#asterisk-dev snuff-work (~snuffy@210.8.167.13) |
| 22:17.01 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:56.48 | *** join/#asterisk-dev oron_laptop (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 23:34.30 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-yzumopwuitaefykc) |