| 00:15.01 | *** join/#asterisk-dev coreyf1513 (~cfarrell@ws2.cfware.com) |
| 02:22.02 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 02:22.03 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 04:25.24 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 04:25.25 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |
| 05:43.06 | *** join/#asterisk-dev pnlarsson (~niklas@fw1.gml.g.icnet.infracom.se) |
| 06:21.05 | wedhorn | snuff-work: any joy with the skinny stuff or your skinny rollout? |
| 06:21.14 | wedhorn | or you too busy with other stuff? |
| 06:22.23 | *** join/#asterisk-dev jmls (~somefake@77.107.171.82) |
| 06:23.12 | snuff-work | nope.. might be able to roll the change out before i leave tonight |
| 06:24.07 | wedhorn | cool, that way you can come into crashing phones in the morning ;) |
| 06:28.33 | snuff-work | well kinda hard to crash 1-2 phones that don't do anything.. |
| 06:29.00 | wedhorn | yeah well, we can try |
| 06:29.26 | snuff-work | rest of * does is just back to back sip to ccm.. until i get the courage later to off it.. which has to be soon.. can't keep putting it off ;) |
| 06:30.37 | snuff-work | so in terms of patches which do we want to test out again atm.. |
| 06:30.54 | wedhorn | um, mostly yours |
| 06:30.57 | snuff-work | u had some reload 1.. the big packet thing.. |
| 06:31.16 | wedhorn | yep, both those, they're on jira |
| 06:31.24 | snuff-work | i know the fixup for immed dial / global vmexten works |
| 06:31.37 | snuff-work | guess i should post the jira issue for that |
| 06:32.04 | wedhorn | would be good |
| 06:32.54 | *** join/#asterisk-dev zerohalo (~zerohalo@74.61.196.236) |
| 06:34.14 | wedhorn | has the dialplan parser changed recently or some deprecated syntax been removed? I'm getting errors in my old dialplan comparison expressions. |
| 06:37.14 | snuff-work | pastebin ? |
| 06:39.12 | wedhorn | http://pastebin.ca/2310820 |
| 06:39.14 | snuff-work | https://issues.asterisk.org/jira/browse/ASTERISK-21037 |
| 06:39.59 | wedhorn | cool |
| 06:41.24 | snuff-work | i didn't get an error with that line in my dp reload |
| 06:41.36 | snuff-work | (only changed the '2' to a '1') |
| 06:44.20 | wedhorn | it loads, just doesn't work when it's run |
| 06:44.53 | snuff-work | oh |
| 06:45.29 | wedhorn | ah hangon, new server, no db vars set |
| 06:46.27 | snuff-work | mm but db func should be able to account.. |
| 06:47.02 | snuff-work | mm.. i think i get it now.. |
| 06:47.15 | snuff-work | db will return '' on non-exist.. |
| 06:47.26 | snuff-work | so comparing '' <= 0 == fail |
| 06:47.44 | wedhorn | yep, probably that simple |
| 06:48.22 | wedhorn | damn unfriendly way of saying database item doesn't exist |
| 06:49.08 | snuff-work | well they should exist if u query for it.. :) |
| 06:49.22 | snuff-work | if ur unsure if its there.. then use DB_EXISTS :) |
| 06:49.53 | wedhorn | yeah, but it's usually there, only disappears when I move to a new server .... |
| 06:50.14 | wedhorn | anyway, setting a value fixed it up |
| 06:50.40 | snuff-work | ok.. so i have 3 patches against my skinny atm.. ur 'dont kill active call when reload'.. the vmexten/immed fix ... fragment fix |
| 06:50.49 | snuff-work | nothing else.. |
| 06:51.04 | wedhorn | can't think of anything |
| 06:51.08 | snuff-work | i guess why i'm about might as well post my const skinny to reviewboard |
| 06:51.28 | wedhorn | yep, sounds like a plan |
| 06:52.30 | snuff-work | find it interesting that const char {} then assigning vals in func is allowed.. kinda makes sense.. if u can't change it within its own func why make it |
| 06:54.29 | snuff-work | now i'm confused.. thought i sent u a patch with change to the callinfo funcs.. |
| 06:54.53 | wedhorn | can't remember that one |
| 06:55.22 | snuff-work | oh.. that 'standardise camelcase..' review board it? or just JIRA |
| 06:55.55 | wedhorn | camelcase? |
| 06:56.11 | snuff-work | the only thing that bugs me.. is our main structs use 'callid' and packets use 'callReference' |
| 06:56.20 | snuff-work | camelcase = camelCase |
| 06:56.26 | snuff-work | aka hump :) |
| 06:56.38 | wedhorn | ah, actually yeah, I think I remember that one |
| 06:57.06 | wedhorn | I was actually thinking we may as well do a bit more and be consistent in some of the vars as well |
| 06:57.57 | snuff-work | aka subchannel has 'callid' (from memory) and with my change.. all have 'callReference' in structs sent to phones |
| 06:58.48 | wedhorn | okay, that one was std-refinst_skinny.diff |
| 06:59.46 | wedhorn | my thing was some functions use reference as their var and some use callreference |
| 06:59.59 | wedhorn | be nice to clean that up while we're at it |
| 07:00.08 | snuff-work | i thought i fixed some of that too ? |
| 07:00.36 | wedhorn | in your patch, compare the blocks at 6225 and 6572 |
| 07:00.42 | snuff-work | basically i'd want to do it as 2 patches or more.. give ppl chance of surviving the svn mrge |
| 07:01.15 | snuff-work | yer i see |
| 07:01.38 | snuff-work | i could do it in 1.. |
| 07:01.39 | wedhorn | merge from where? 11? we're really starting to break mergability anyway |
| 07:02.31 | snuff-work | mm guess u'll have a larger patch tomorrow with the fixing of standardising more of those |
| 07:02.37 | wedhorn | The whitespace fix I did a couple weeks ago basically put paid to clean merging |
| 07:02.59 | snuff-work | but what u think about even touching the main structs.. aka device / line / subchannel ? |
| 07:05.23 | wedhorn | Just added a testing note to your immeddial bug |
| 07:05.47 | wedhorn | depends what you mean by touching |
| 07:06.22 | snuff-work | i guess we could leave it.. aka instance becomes lineInstance |
| 07:07.43 | snuff-work | and callid = callReference |
| 07:07.45 | wedhorn | ah, I see what you mean |
| 07:08.08 | wedhorn | I reckon we just do a mass change |
| 07:08.26 | snuff-work | i think we leave that alone.. keep camelcase for packets.. leave internal structs all lower |
| 07:08.28 | wedhorn | The reviewboard folk can let us know if they think it's too heavy handed |
| 07:08.46 | wedhorn | honestly I think consistency is the best way |
| 07:08.57 | wedhorn | any issue with using camelcase |
| 07:09.10 | wedhorn | in the coding guidelines? |
| 07:09.27 | snuff-work | mm one thing though shalt never be able to merge patch after this back a version :) |
| 07:09.33 | snuff-work | if we did that much change |
| 07:09.34 | wedhorn | I wouldn't necessarily change everything to camel case |
| 07:10.06 | wedhorn | but seeing as, for example, we have a callRef, it'd make sense to have sub->callid changed to sub->callRef |
| 07:11.03 | wedhorn | I think about a quarter to a third of the lines in skinny don't match already (whitespace changes) |
| 07:15.46 | snuff-work | can certainly do it.. |
| 07:15.49 | snuff-work | might take it on tonight |
| 07:16.26 | snuff-work | that mean we change our struct defs for buttons/msgs to be 'lineInst' and 'callRef' ? |
| 07:17.10 | wedhorn | it'd be nice to have some common name rather than "callid==reference" and the like |
| 07:17.21 | snuff-work | aka rehash part of my already done patch |
| 07:17.44 | wedhorn | sounds good, short is nice |
| 07:18.34 | snuff-work | k will alter my patch accordingly.. |
| 07:21.04 | snuff-work | well i'm off :) |
| 07:21.17 | snuff-work | will test ur stuff tomorrow for sure |
| 07:54.09 | *** join/#asterisk-dev bulkorok (~bulkorok@85.183.36.36) |
| 08:24.26 | *** join/#asterisk-dev leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
| 08:24.26 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 10:37.58 | *** join/#asterisk-dev sgimeno (~sgimeno@163.117.206.10) |
| 10:52.23 | snuff-home | wedhorn: callref/lineinst change.. 2500 line diff |
| 10:57.57 | snuff-home | found 1 other compiler 'warning' in utils.h... static void force_inline _ast_assert ... should be static force_inline void _ast_assert |
| 11:44.24 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 11:44.24 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 12:22.26 | *** join/#asterisk-dev w9sh (~chatzilla@64.238.96.125) |
| 12:25.45 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-136-163.user.veloxzone.com.br) |
| 12:27.53 | *** join/#asterisk-dev tzafrir_laptop (~tzafrir@local.xorcom.com) |
| 12:27.53 | *** mode/#asterisk-dev [+o tzafrir_laptop] by ChanServ |
| 12:47.57 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 12:55.28 | *** join/#asterisk-dev w9sh (~chatzilla@64.238.96.125) |
| 13:24.19 | *** join/#asterisk-dev felipe_ (~felipe@unaffiliated/felipe) |
| 13:34.01 | *** join/#asterisk-dev alsuren_ (~dlaban@80.169.133.251) |
| 13:51.49 | *** join/#asterisk-dev alsuren (alsuren@60e-007.static.bnc4free.com) |
| 13:55.36 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-grqhkjczmntlgazb) |
| 14:05.44 | leifmadsen | ATDG 4e is now done. Thanks to everyone for playing along! |
| 14:44.02 | JunK-Y | yay! |
| 15:02.44 | seanbright | hooray |
| 15:20.28 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-vrvgdpacevppgxcx) |
| 15:20.28 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:23.50 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:23.50 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 15:24.02 | WIMPy | Is it just because I so too many other shith or was that a lot quicker than the last one? |
| 15:26.42 | *** part/#asterisk-dev hurdman (~ygcheny@c3p0.r0b0t.fr) |
| 16:08.22 | *** join/#asterisk-dev dwayne (~dwayne@c-71-207-208-112.hsd1.al.comcast.net) |
| 16:30.43 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 16:30.43 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk |
| 17:13.35 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-vrvgdpacevppgxcx) |
| 17:24.13 | seanbright | putnopvut: ping |
| 17:26.00 | file | he's away |
| 17:26.22 | seanbright | got it |
| 17:59.20 | putnopvut | seanbright: pong! |
| 18:01.16 | seanbright | putnopvut: design question... |
| 18:01.38 | seanbright | i have a new approach for this threadpool min_size thing, which i think is better than what i have |
| 18:01.54 | putnopvut | Better is good. |
| 18:02.14 | seanbright | what are your thoughts about set_size() and min_size? |
| 18:02.23 | seanbright | so min_size = 10, set_size(8) |
| 18:02.35 | seanbright | max_size silently ignores anything > max_size |
| 18:03.19 | seanbright | trying to decide if calling set_size(< max_size) will actually reap idle threads |
| 18:03.22 | seanbright | err |
| 18:03.26 | seanbright | set_size(< min_size) |
| 18:04.04 | putnopvut | RIght now, the max size thing will end up capping at the max size. I'd expect the same from min_size. If someone does set_size(8) and the min_size is 10, then we should not go below 10. |
| 18:04.27 | putnopvut | But if there are currently 15 threads, then we will shrink down to the min_size in that case. |
| 18:05.09 | seanbright | right |
| 18:05.30 | seanbright | as an aside, do you think calling set_size(> max_size) should log some kind of message? |
| 18:07.03 | seanbright | at least a debug, for diagnostics? |
| 18:09.28 | putnopvut | I wouldn't be against it. |
| 18:41.18 | *** join/#asterisk-dev Devon_ (~Devon_@63.214.236.169) |
| 18:45.44 | *** join/#asterisk-dev Devon_ (~Devon_@63.214.236.169) |
| 18:49.26 | *** join/#asterisk-dev Devon_ (~Devon_@63.214.236.169) |
| 19:00.26 | *** join/#asterisk-dev zhando (~user@c-67-161-122-77.hsd1.wa.comcast.net) |
| 19:08.34 | zhando | trying to get chan_console to work on my laptop.. I bring up * with -ddddd and after console.conf is parsed i see a bunch of alsalib errors.. I think this is port audio doing this when finding the default device.. And I've replaced alsa with oss just to see if it goes away.. it doesn't.. |
| 19:09.39 | zhando | anyway I trying dialing the 8500 ext in the demo from the console and I get Expression 'GetAvailableFormats( component, &availableFormats )' failed in 'src/hostapi/oss/pa_unix_oss.c', line: 1007 |
| 19:13.50 | *** join/#asterisk-dev Corydon76-home (eleven@c-69-137-80-31.hsd1.tn.comcast.net) |
| 19:13.50 | *** mode/#asterisk-dev [+o Corydon76-home] by ChanServ |
| 20:30.36 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 20:30.36 | *** mode/#asterisk-dev [+o ChanServ] by moorcock.freenode.net |
| 20:37.58 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 20:37.58 | *** mode/#asterisk-dev [+o ChanServ] by moorcock.freenode.net |
| 20:39.49 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 20:39.49 | *** mode/#asterisk-dev [+o ChanServ] by moorcock.freenode.net |
| 21:17.22 | *** join/#asterisk-dev serafie (~erin@nat/digium/x-onnzemjqkhlwgyil) |
| 21:46.33 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 21:46.33 | *** mode/#asterisk-dev [+o ChanServ] by moorcock.freenode.net |
| 21:50.55 | *** part/#asterisk-dev rustlebee (~russellb@redhat/russellb) |
| 22:44.33 | *** join/#asterisk-dev pabelanger (~pabelange@asterisk/contributor-and-bug-marshal/pabelanger) |
| 22:44.33 | *** mode/#asterisk-dev [+o pabelanger] by ChanServ |