| 00:19.08 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.2) |
| 00:19.54 | *** join/#asterisk-dev zerohalo (~zerohalo@c-174-62-142-83.hsd1.ma.comcast.net) |
| 00:34.06 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 00:34.06 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 00:51.53 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.23) |
| 01:14.12 | JunK-Y | mjordan: alive? |
| 01:15.48 | JunK-Y | when using: aco_option_register(&cfg_info, "language", ACO_EXACT, bridge_types, "en", OPT_CHAR_ARRAY_T, 0, CHARFLDSET(struct bridge_profile, language)); i thought the default value was going to be "en", no? |
| 01:43.46 | *** join/#asterisk-dev Devon_ (~Devon_@adsl-65-9-109-236.mia.bellsouth.net) |
| 01:57.58 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.44) |
| 02:13.31 | *** join/#asterisk-dev wedhorn (~wedhorn@27-33-41-99.static.tpgi.com.au) |
| 03:25.54 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 05:15.23 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 05:15.24 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:31.50 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 06:31.51 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:03.13 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 07:03.14 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:23.33 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.124.41) |
| 07:36.45 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-ftytkwzbdfnniblj) |
| 08:36.34 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 08:36.34 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:15.17 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.124.38) |
| 09:36.01 | *** join/#asterisk-dev GameGamer43 (uid5533@gateway/web/irccloud.com/x-qrgfbcnirqqlaoml) |
| 10:29.44 | *** join/#asterisk-dev vlad_starkov (~vlad_star@194.186.53.81) |
| 10:45.01 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.127.157) |
| 10:51.01 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@109.188.127.157) |
| 11:20.44 | *** join/#asterisk-dev ivan` (~ivan@unaffiliated/ivan/x-000001) |
| 12:14.20 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.127.96) |
| 12:19.36 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.127.96) |
| 12:21.14 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.127.96) |
| 12:39.02 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.127.96) |
| 12:40.36 | *** join/#asterisk-dev protocoldoug (~doug@unaffiliated/protocoldoug) |
| 12:53.48 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 13:04.05 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 13:04.13 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:09.35 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 13:25.25 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 13:35.29 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 13:36.08 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 14:00.15 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 14:02.12 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 14:07.39 | *** join/#asterisk-dev spditner (~simon@206-248-134-104.dsl.teksavvy.com) |
| 14:12.24 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@217.67.113.99) |
| 14:16.53 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 14:18.14 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 14:41.33 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 15:43.53 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 15:45.08 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 15:47.08 | *** join/#asterisk-dev vlad_sta_ (~vlad_star@217.67.113.99) |
| 15:49.10 | *** join/#asterisk-dev vlad_st__ (~vlad_star@217.67.113.99) |
| 15:58.38 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 16:01.57 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 16:17.42 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 16:28.34 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 16:53.29 | *** join/#asterisk-dev danjenkins (~danjenkin@cpc3-folk2-2-0-cust34.1-2.cable.virginmedia.com) |
| 17:22.39 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 17:34.30 | pabelanger | file, firing up the patch now, will know more in the next hour |
| 17:49.33 | *** join/#asterisk-dev vlad_starkov (~vlad_star@217.67.113.99) |
| 18:08.12 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 18:57.52 | pabelanger | file, looks to be issues |
| 18:57.58 | pabelanger | posting findings on the review |
| 19:03.12 | pabelanger | comments added |
| 19:07.24 | file | I'm confused |
| 19:07.48 | file | the entire issue is about not resolving hosts when an outbound proxy is specified |
| 19:08.33 | file | so, it's not resolving them... and thus isn't matching |
| 19:09.52 | pabelanger | so, the original issue I reported was when asterisk did a dial, it was resolving dns before the dial, which would fail because asterisk didn't know the domain, but the proxy did |
| 19:10.03 | pabelanger | however, applying the patch now fail to even accept an incoming call |
| 19:10.20 | file | because it's not resolving the host |
| 19:11.10 | pabelanger | So, if I understand, after applying the patch all DNS lookups are gone? |
| 19:11.26 | file | if you specify an outbound proxy then the host will not be resolved |
| 19:11.36 | file | now, you can specify an outbound proxy at peer level and not just global |
| 19:12.03 | pabelanger | Hmm |
| 19:13.03 | pabelanger | still confused about the outbound proxy setting affecting inbound |
| 19:13.09 | pabelanger | but going to move around some configs |
| 19:13.10 | pabelanger | 1 sec |
| 19:13.23 | file | in order to match inbound it has to resolve to the IP address and port |
| 19:13.32 | file | I did find a bug though, so there's that |
| 19:15.41 | pabelanger | I think what is confusing me is I was always under the impression outboundproxy was only used when Dial was invoked, but I think you are saying different? |
| 19:17.10 | file | so - if you have an outbound proxy specified and you provide a host in a peer... |
| 19:17.13 | file | you aren't supposed to resolve that host |
| 19:17.26 | file | because it's going to be given to the outbound proxy |
| 19:28.30 | pabelanger | okay, so I can see the issue |
| 19:28.54 | pabelanger | I setup a global outboundproxy, because I need to. I use Dial(sip/100@belanger.home) |
| 19:29.02 | pabelanger | which should be passed up to the proxy |
| 19:29.22 | pabelanger | if I understand you now I need to create a [proxy] peer in sip.conf |
| 19:29.23 | pabelanger | something like |
| 19:29.27 | pabelanger | [proxy] |
| 19:29.39 | pabelanger | outboundproxy=kamailio-01-prod.polybeacon.com |
| 19:29.42 | pabelanger | type=peer |
| 19:30.01 | pabelanger | then, I change my dial to Dial(SIP/proxy/100@belanger.home) |
| 19:30.12 | pabelanger | however, that fails to generate an invite correctly |
| 19:30.48 | pabelanger | http://pastebin.com/1yppExu1 |
| 19:31.12 | file | [proxy] |
| 19:31.21 | file | outboundproxy=kamailio-01-prod.polybeacon.com |
| 19:31.22 | file | type=peer |
| 19:31.26 | file | fromdomain=belanger.home |
| 19:31.30 | file | SIP/100@proxy |
| 19:31.43 | pabelanger | issue is I have more then 1 domain in my proxy |
| 19:32.35 | file | there may be a way to do it, I don't know |
| 19:33.13 | pabelanger | I had something working that I took from a branch oej had, it worked great, except I broke acls :) |
| 19:33.55 | pabelanger | I believe the code change was only when the dial command was invoked and it was trying to resolve the domain locally |
| 19:34.26 | file | I just updated the diff which covers that scenario |
| 19:35.28 | file | Only if a global outbound proxy exists mind you |
| 19:35.51 | pabelanger | okay, let me import the patch and retry. Will take 30mins or so to upgrade |
| 19:37.21 | file | the patch does not fundamentally change what it does |
| 19:37.52 | file | ie: it still does not resolve hosts |
| 19:38.25 | pabelanger | okay, rebuilding now |
| 19:38.30 | pabelanger | let me test and see what happens |
| 19:38.57 | pabelanger | but I can still see a use case for resolving hosts for incoming calls |
| 19:40.05 | file | I can't have it both ways, without introducing yet another configuration option and mucking with the code some more |
| 19:40.28 | pabelanger | unless type=user can do a match on hostname |
| 19:40.35 | file | nope. |
| 19:40.39 | pabelanger | I have to use peer |
| 19:40.47 | pabelanger | because my proxy does not authenticate to asterisk |
| 19:41.12 | file | then as-is per-peer outbound proxy is the only way |
| 19:41.44 | pabelanger | ya, that's not going to work for my setup |
| 19:41.49 | file | using the variable you were doing before but NOT putting it in the Dial line may work |
| 19:41.50 | pabelanger | means redundant configuration |
| 19:42.52 | file | otherwise *shrug* nothing springs to mind |
| 19:44.01 | pabelanger | np, I'll test and report results |
| 19:44.21 | pabelanger | will also see if I can get my patch working properly and see about a discussion around it |
| 19:44.52 | file | if this becomes a "outbound proxy is totally screwed in certain scenarios" issue then that's outside the scope of my stuff |
| 19:45.11 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 19:45.11 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:48.21 | pabelanger | file, understood. But, on the opposite site, it might break some configurations |
| 19:48.40 | pabelanger | at the end of the day, we should get up some unit tests into the testsuite for outboundproxy |
| 19:48.47 | pabelanger | just to have anybody agree what it does |
| 19:49.56 | file | Unit tests don't cover this, but tests are coming |
| 19:50.37 | pabelanger | s/unit/integration |
| 19:50.51 | pabelanger | time to check the testsuite again |
| 19:50.58 | pabelanger | been a while |
| 19:55.49 | pabelanger | updating packages now |
| 20:01.05 | pabelanger | file: So, host = 209.87.247.153 with global outboundproxy would also fail? |
| 20:01.26 | file | Yes, the host is treated as a string |
| 20:05.32 | pabelanger | okay |
| 20:05.38 | pabelanger | I might have worked around the patch |
| 20:23.36 | *** join/#asterisk-dev oej (~oej@h87-96-134-126.dynamic.se.alltele.net) |
| 20:23.37 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:26.49 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 20:53.34 | pabelanger | file, okay got it working, but had to to a major rework of configs |
| 20:53.45 | pabelanger | basically: |
| 20:53.54 | pabelanger | <file> [proxy] |
| 20:53.55 | pabelanger | <file> outboundproxy=kamailio-01-prod.polybeacon.com |
| 20:53.55 | pabelanger | <file> type=peer |
| 20:53.58 | pabelanger | but |
| 20:54.10 | pabelanger | Dial(SIP/102@proxy!102@belanger.home) |
| 20:54.26 | pabelanger | ugly dial string but passed the info to my proxy |
| 21:04.57 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.251) |
| 21:45.43 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 22:36.39 | *** join/#asterisk-dev vlad_starkov (~vlad_star@109.188.125.251) |
| 22:57.45 | *** join/#asterisk-dev serafie (~erin@24.96.64.240) |
| 23:41.57 | *** join/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |