| 00:40.12 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 01:16.32 | *** join/#asterisk-dev Qwell (~north@pdpc/sponsor/digium/Qwell) |
| 01:16.32 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 01:41.06 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 02:41.46 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 03:40.19 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-nadlnieyxkdqvump) |
| 03:42.41 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 04:43.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 05:44.22 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 06:44.59 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 07:45.52 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 07:51.40 | *** join/#asterisk-dev oej (~Adium@h87-96-134-129.dynamic.se.alltele.net) |
| 07:51.42 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:25.16 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:40.19 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 08:42.12 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 08:46.34 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 09:31.13 | *** join/#asterisk-dev vlad_starkov (~vlad_star@195.218.175.34) |
| 09:47.27 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 10:48.11 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 11:49.04 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 12:20.46 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216.191.106.163) |
| 12:30.52 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 12:49.44 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 12:54.46 | *** join/#asterisk-dev roderickm (~roderickm@67.63.143.254) |
| 13:53.52 | *** join/#asterisk-dev malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
| 13:53.52 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 13:56.38 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-lrgdempgcskujqjv) |
| 13:56.39 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:58.56 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:58.56 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:00.56 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:01.46 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-fhilwbinbpcxdzru) |
| 14:01.47 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:01.47 | *** join/#asterisk-dev sliske_- (~sliske_@2001:4800:780e:510:6c33:9987:ff05:245f) |
| 14:02.54 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:05.49 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:13.15 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 14:13.31 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:13.31 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:29.43 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-jtvtqfjxpnzdtnwy) |
| 14:47.03 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 14:47.03 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:49.09 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 15:13.35 | file | putnopvut, did you find the answer to your hiding question from last week? |
| 15:17.43 | putnopvut | file: what hiding question? Last week is kind of a blur. |
| 15:18.14 | file | putnopvut, marking message queue channel as internal to hide it |
| 15:18.47 | putnopvut | Oh that, yeah. No, I never got an answer. My hunch is that it won't help. |
| 15:18.51 | mjordan | hm. We could do that, unless someone is actually trying to use CDRs to bill for text messages |
| 15:19.01 | mjordan | putnopvut: trying to help with...? |
| 15:19.52 | putnopvut | David Blood in SD sent me an e-mail since he was confused since the ast_msg_queue channel was showing up in "core show channels concise" and "core show channels verbose" . I had to explain what the channel is and why he can ignore it even though there are no calls happening. |
| 15:20.10 | putnopvut | So I was wondering if that could be hidden since most people aren't going to know what the heck that channel is. |
| 15:20.12 | mjordan | ah |
| 15:20.23 | mjordan | well... we could hide internal implementation channels from the CLI commands |
| 15:20.47 | mjordan | which probably wouldn't be a bad idea. |
| 15:21.47 | file | I don't know if I like that... |
| 15:22.06 | file | if we provided a way to allow you to list them as well with it being default off yes |
| 15:22.14 | file | but having no way to know if internal impl channels are around... is bad |
| 15:22.25 | mjordan | yeah. Actually... I'd probably go with having hiding them be the non-default |
| 15:22.37 | mjordan | might as well not introduce breaking changes |
| 15:22.53 | mjordan | core show channels that happen to be talking to actual people plz kkthnx |
| 15:23.17 | file | mjordan, actual people is relative :P |
| 15:23.39 | file | connects mjordan to an answering machine (a physical machine even!) |
| 15:26.04 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 15:31.18 | putnopvut | btw, note that "core show channels" CLI command does *not* show the ast_msg_queue channel. |
| 15:31.31 | putnopvut | However, AMI CoreShowChannels does show it. |
| 15:31.41 | file | huh |
| 15:32.09 | putnopvut | For CLI, you have to be doing "concise" or "verbose" |
| 15:34.17 | mjordan | is unsure of why |
| 15:34.32 | file | ditto |
| 15:35.04 | mjordan | \o/ for consistency |
| 15:39.24 | *** join/#asterisk-dev vlad_starkov (~vlad_star@79.104.6.47) |
| 15:50.54 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 16:18.17 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 16:21.25 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 16:24.43 | *** join/#asterisk-dev kannan (~chatzilla@123.238.235.11) |
| 16:56.07 | *** join/#asterisk-dev vlad_starkov (~vlad_star@79.104.6.47) |
| 17:26.08 | mjordan | jrose_atDigium: Your CHANGES note is a bit confusing still |
| 17:26.42 | mjordan | jrose_atDigium: " trust_id_outbound=legacy: behavior remains the same as 1.8.26.1 - When dealing with prohibited callingpres, RPID/PAI headers are created for both sendrpid=pai and sendrpid=rpid are appended, but the data is anonymized." |
| 17:27.09 | mjordan | that sentence isn't grammatically correct, and I'm not sure what is appended. |
| 17:28.10 | mjordan | jrose_atDigium: Also, when fixing small things in a CHANGES or UPGRADE file that is tied to an issue, please still put the issue in the commit message |
| 17:28.23 | mjordan | jrose_atDigium: People who want to patch for that issue need to know what all diffs they have to pull |
| 17:28.29 | mjordan | i.e., me, as I'm making releases |
| 17:31.17 | jrose_atDigium | I meant to say that the headers (Remote-Party-ID/P-Asserted-Identity) are still appended when the callingpres is prohibited. 'are created' is extraneous, sorry. |
| 17:32.47 | jrose_atDigium | mjordan: Should I go ahead and fix that? |
| 17:36.09 | mjordan | jrose_atDigium: yes please. |
| 17:40.56 | mjordan | jrose_atDigium: let me know when the commit goes |
| 17:41.02 | mjordan | waiting for it on the build machine :-P |
| 17:41.39 | jrose_atDigium | mjordan: Let me run by the revised CHANGES message with you real quick first... |
| 17:42.52 | jrose_atDigium | 'trust_id_outbound=legacy: behavior remains the same as 1.8.26.1 - When dealing with 'prohib' callingpres and sendrpid=pai/rpid, RPID/PAI headers are appended to outbound SIP messages just as they are with allowed callingpres values, but data about the remote party's identity is anonymized |
| 17:43.03 | jrose_atDigium | ' |
| 17:43.10 | jrose_atDigium | Does that seem clear? |
| 17:44.20 | mjordan | from a formatting perspective, do the following |
| 17:44.23 | mjordan | don't use a ':' |
| 17:44.42 | mjordan | use a hyphen there. Don't use a hyphen in the middle of a paragraph block, and definitely not to start a new sentence |
| 17:44.56 | mjordan | indent the paragraph block slightly so that it's more readable. That way people can tell you're discussing three different options. |
| 17:45.08 | mjordan | that is, each option should have a slight indent for its description |
| 17:47.18 | jrose_atDigium | K, all set with that. |
| 17:48.25 | jrose_atDigium | I'll pastebin what the message looks like |
| 17:49.09 | jrose_atDigium | mjordan: http://pastebin.com/EbiQrSxB |
| 17:49.12 | jrose_atDigium | oh wait |
| 17:49.17 | jrose_atDigium | let me do that over |
| 17:49.27 | jrose_atDigium | didn't save |
| 17:49.47 | jrose_atDigium | http://pastebin.com/WHMt28V2 |
| 17:49.55 | jrose_atDigium | mjordan: ^ |
| 17:50.19 | mjordan | jrose_atDigium: looks good |
| 17:50.24 | jrose_atDigium | kk, I'll commit it then. |
| 17:56.34 | jrose_atDigium | mjordan: All clear |
| 19:18.43 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.219.179) |
| 19:22.11 | *** join/#asterisk-dev jemidy (~jemidy@nat/digium/x-qaxfgmrmmiayqdyx) |
| 19:45.09 | *** join/#asterisk-dev danjenkins (~dan@cpc65687-folk2-2-0-cust207.1-2.cable.virginm.net) |
| 19:46.15 | *** join/#asterisk-dev opticron (~opticron@pianoben.ch) |
| 19:46.18 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 19:53.15 | *** join/#asterisk-dev opticron (~opticron@pianoben.ch) |
| 19:53.16 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:04.12 | *** join/#asterisk-dev opticron (~opticron@pianoben.ch) |
| 20:04.12 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:20.45 | *** join/#asterisk-dev protocoldoug (~quassel@unaffiliated/protocoldoug) |
| 20:27.56 | *** join/#asterisk-dev wedhorn (~wedhorn@110-175-181-222.static.tpgi.com.au) |
| 20:35.17 | *** join/#asterisk-dev roderickm (~roderickm@99-124-89-102.lightspeed.dctral.sbcglobal.net) |
| 20:55.55 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.219.179) |
| 22:09.53 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 22:49.39 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-jtvtqfjxpnzdtnwy) |