| 01:26.08 | *** join/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 01:26.45 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 04:21.28 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 05:46.11 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 06:56.39 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 07:05.11 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 07:16.11 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:5d68:b35f:207f:d46f) |
| 07:33.50 | *** join/#asterisk-dev oej (~Adium@h217-27-188-82.cust.tyfon.se) |
| 07:33.50 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:38.43 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 07:38.47 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 07:39.48 | oej | Morning folks |
| 07:41.47 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 08:00.22 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 08:21.03 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 08:21.50 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 08:33.11 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 08:44.51 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 08:49.29 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:49.29 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:49.36 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 09:27.03 | wdoekes | what's ao2_ref(p, -1); doing on line 596 in 12:main/taskprocessor.c ? |
| 09:27.20 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 09:32.52 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 09:42.11 | oej | Why do we do DNS lookup twice on registrations? |
| 09:42.17 | oej | The questions are endless. |
| 09:59.05 | oej | â¦just compiling ⦠;-) |
| 10:00.04 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 10:00.40 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 11:45.01 | *** join/#asterisk-dev dms1 (~dms1@2601:0:5480:e4::1008) |
| 12:05.07 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:17.06 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 12:17.06 | *** mode/#asterisk-dev [+o jsmith] by ChanServ |
| 12:19.56 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-aosyshvauykdocnb) |
| 12:51.25 | *** join/#asterisk-dev leifmadsen (~free-mads@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:51.26 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 13:37.38 | *** join/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 13:48.57 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-kxbwguifpsjubgvx) |
| 13:48.57 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:09.35 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-whxokblkrxkamnls) |
| 14:13.48 | *** join/#asterisk-dev vassilux (~vassilux@LMontsouris-656-01-80-156.w82-127.abo.wanadoo.fr) |
| 14:16.33 | vassilux | hi I want to get T2 spans states from my C module(asterisk 11). May be the function sig_pri_cli_show_spans can be used or is there a other possibility to do it ? |
| 14:17.00 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:17.00 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:19.02 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-muluplplcmnlvkpm) |
| 14:19.02 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:35.35 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.33) |
| 14:59.09 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-qkirtgkncqhbiioy) |
| 15:32.42 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.33) |
| 15:59.00 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 16:00.05 | *** join/#asterisk-dev dwayne (~dwayne@c-71-207-208-112.hsd1.al.comcast.net) |
| 16:01.10 | jrose_atDigium | https://reviewboard.asterisk.org/r/3918/ This test could use a second pass if someone has an opportunity to do so. |
| 16:04.49 | *** join/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 17:20.43 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 17:47.06 | *** join/#asterisk-dev dms1 (~dms1@c-50-168-154-89.hsd1.sc.comcast.net) |
| 17:48.35 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.33) |
| 18:00.38 | putnopvut | I could use a ruling on https://reviewboard.asterisk.org/r/3920/ . Should I go with the ast_softhangup() function over ast_softhangup_nolock()? If so, should I do it for both circumstances? |
| 18:01.55 | opticron | ehh, you can drop the issue |
| 18:03.19 | mjordan | clicks the Ship It button like a good trained monkey |
| 18:07.05 | opticron | is slightly annoyed that ast_softhangup() does significantly more than just locking around ast_softhangup_nolock() |
| 18:07.51 | mjordan | FTFY: opticron is slightly annoyed at softhangup |
| 18:07.57 | mjordan | That's all you need. |
| 18:08.13 | opticron | fair |
| 18:10.48 | mjordan | opticron: For review 3922, why did you drop a PJSUA client instance? |
| 18:11.06 | opticron | it was unnecessary to the functioning of the test |
| 18:11.28 | mjordan | how so? |
| 18:11.48 | opticron | basically, the test is started by a channel being originated, that channel is hungup and then two pjsua clients are stuck into stasis |
| 18:11.59 | opticron | one of the pjsua clients performs a blind transfer |
| 18:12.06 | mjordan | ah, so you put the originated channel in the bridge? |
| 18:12.07 | opticron | the other just sits and looks not so pretty |
| 18:12.09 | opticron | yep |
| 18:12.21 | mjordan | k, as long as we've got two channels and a blind transfer, I'm sold |
| 18:12.33 | mjordan | much like my two turn tables and a microphone |
| 18:12.51 | opticron | MC Jordan in da hizzy |
| 18:12.56 | mjordan | there is an issue for that someplace... |
| 18:13.35 | mjordan | maybe not. |
| 18:13.37 | mjordan | Oh wellz! |
| 18:14.38 | mjordan | elguero: going through reviews today, do you want me to commit r3856 or do you want to do it sometime? I think we've got awhile before we make another release so no hurry |
| 18:15.14 | putnopvut | mjordan: trying to fix that test you assigned to me is going badly since for some reason all IPv6 addresses in transport sections are failing to parse, leading to test failure every run. |
| 18:15.24 | mjordan | huh |
| 18:15.28 | mjordan | that's sub-optimal |
| 18:15.41 | mjordan | er |
| 18:15.45 | mjordan | want to take a build agent offline? |
| 18:15.51 | mjordan | the 64-bit one is usually especially crashy |
| 18:16.37 | putnopvut | I figured I'd try to figure out what's going wrong with me first, and if I can't figure it out, I'll go that route. If I don't have it figured out in a half hour, I'll go with the build agent method. |
| 18:17.02 | mjordan | nifty. The current build on the 64-bit build agent has 30 minutes to go |
| 18:17.12 | mjordan | I'll tell it to disable at the end of the run and if you need it, it will be there |
| 18:19.29 | putnopvut | Excellent, thanks |
| 18:23.35 | file | do you have a non-IPv6 pjproject? |
| 18:23.41 | putnopvut | file: that was exactly it |
| 18:23.56 | putnopvut | I had reinstalled from git and forgot to edit pjlib/include/pj/config_site.h |
| 18:24.06 | putnopvut | And was just about to type that in here when you asked your question :) |
| 18:24.48 | opticron | yeah, I've had that problem before, too |
| 18:27.53 | putnopvut | Yep, test passes now. Running it in a loop on my box and hoping for a crash. Will do code reviews while waiting. |
| 18:53.13 | jrose_atDigium | rmudgett: ping |
| 18:53.33 | rmudgett | jrose_atDigium: pong |
| 18:53.45 | jrose_atDigium | With regards to the bit you tagged around "A ref is kept in the plabacks container; no need to bump" |
| 18:53.51 | jrose_atDigium | in r3908 that is |
| 18:54.21 | jrose_atDigium | I'm cleaning that up a bit right now, and I'm wondering whether it would be better to just dispose of that comment and bump anyway. |
| 18:54.48 | jrose_atDigium | Basically, if there are no negative repucussions to bumping the ref count, why not just do it so that the clarification isn't necessary. |
| 18:55.07 | rmudgett | Dispose of that comment and pass a reference to it. If the ao2_link failed to put the playback into the container then there would be problems. |
| 18:55.27 | jrose_atDigium | I also added failure checking to the ao2_link, so that won't be a problem anymore. |
| 18:55.37 | rmudgett | Depending upon how the container is setup ao2_link not putting an object into the container is not an error. |
| 18:55.59 | jrose_atDigium | Well, by error checking... |
| 18:56.14 | jrose_atDigium | I mean I am just checking the return value to see if it successfully added the object |
| 18:56.32 | rmudgett | You don't really need to check the ao2_link return value in this case. |
| 18:56.38 | jrose_atDigium | ok then |
| 18:57.14 | rmudgett | Passing a ref to the command makes checking the ao2_link return value unnecessary. |
| 18:57.26 | jrose_atDigium | Well... |
| 18:57.33 | jrose_atDigium | for executing the command, yes |
| 18:57.44 | jrose_atDigium | but if the command doesn't make it into the container we won't be able to control the playback |
| 18:57.49 | jrose_atDigium | at least I think that's the case |
| 18:57.58 | jrose_atDigium | since we would no longer be able to find the playback by ID |
| 18:58.17 | rmudgett | This is also getting into the highly unlikely to happen category. :) |
| 18:58.22 | jrose_atDigium | Yes |
| 20:47.07 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 20:57.28 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:15.37 | *** join/#asterisk-dev bulkorok (~Benjamin@gw1.pinguin.ag) |
| 21:23.07 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:38.33 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 22:53.21 | putnopvut | That annoying situation where you can make a crash happen, but when you add debugging in, the crash no longer happens... |
| 22:53.42 | jrose_atDigium | putnopvut: You changed the outcome by attempting to measure it |
| 22:54.13 | putnopvut | Yep :( |
| 22:59.43 | putnopvut | Yay, it crashed! And it confirmed what I thought was happening! |
| 23:00.25 | file | yay |
| 23:11.48 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-whxokblkrxkamnls) |
| 23:15.42 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 23:20.00 | *** join/#asterisk-dev dms1 (~dms1@c-50-168-154-89.hsd1.sc.comcast.net) |