| 00:25.59 | *** join/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 00:27.55 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 00:27.55 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 00:56.13 | *** join/#asterisk-dev oron (~oron_lapt@line25-214.adsl.actcom.co.il) |
| 01:28.35 | *** part/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 02:07.43 | Marquis42 | Hrm, is it a feature or a bug that you can't stop an ARI playback that uses a "digits" uri? |
| 02:21.05 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 02:35.53 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 02:35.53 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:42.10 | tm1000 | Marquis42: I think many bugs could be considered features by the right people :-D |
| 03:12.18 | *** part/#asterisk-dev tm1000 (tm1000@2600:3c00::f03c:91ff:fe6e:6894) |
| 03:43.27 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 04:11.05 | *** join/#asterisk-dev moy (~moy@198.199.91.192) |
| 04:33.43 | *** join/#asterisk-dev terryw (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 06:05.51 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 07:14.37 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:f461:59b3:b437:3d1d) |
| 08:16.12 | *** join/#asterisk-dev fish9370 (~Miranda@mbox.fpg.ru) |
| 08:18.46 | fish9370 | hello, please add somebody ip address in this code (ast:certified-asterisk-1.8.28-cert1:chan_sip.c:17165) ==> ast_log(LOG_NOTICE, "Failed to authenticate device %s\n", get_header(req, "From")); |
| 08:20.45 | fish9370 | my log analyzer can not see who is trying to hack me |
| 08:21.53 | fish9370 | who should I contact? |
| 08:52.07 | wdoekes | fish9370: you can hack it in. but it won't get "fixed". |
| 08:52.18 | wdoekes | there are a few bug reports about that, with possible fixes |
| 08:53.11 | fish9370 | where? please give me link |
| 08:54.21 | wdoekes | https://issues.asterisk.org/jira/browse/ASTERISK-21908?jql=text%20~%20%22fail2ban%22 |
| 10:11.35 | fish9370 | this bug is "Wan't fixed" why? |
| 10:21.12 | wdoekes | fish9370: did you read the report and the comments? |
| 10:26.06 | fish9370 | wdoekes: yes, of course, that is not the correct version, and that there is a patch. But I have the newest version, and the problem still there. Why just can not be added to the log address? |
| 10:30.16 | wdoekes | the fact that there is a patch does not mean that the patch should be applied. did you check the other search results? |
| 10:35.35 | *** join/#asterisk-dev dms1 (~dms1@c-50-168-154-89.hsd1.sc.comcast.net) |
| 10:45.11 | fish9370 | wdoekes: I look |
| 10:46.21 | fish9370 | wdoekes: but I do not understand why this is so difficult. Just add ip |
| 10:55.07 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 10:55.07 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 11:11.23 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 11:11.42 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 11:11.54 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:c196:a60d:a129:8716) |
| 11:12.08 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-frisiulwiqkofiec) |
| 11:12.25 | *** join/#asterisk-dev Sjors (~sgielen@foo.kassala.de) |
| 12:19.03 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:25.54 | *** join/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 12:28.08 | *** join/#asterisk-dev Marquis42 (~mrbmw@d149-67-95-208.try.wideopenwest.com) |
| 12:31.40 | *** join/#asterisk-dev leifmadsen (~free-mads@asterisk/documenteur-extraordinaire/blitzrage) |
| 12:31.40 | *** mode/#asterisk-dev [+o leifmadsen] by ChanServ |
| 12:44.38 | *** part/#asterisk-dev stevePearPear (~stevePear@cm244.epsilon47.maxonline.com.sg) |
| 12:54.17 | *** join/#asterisk-dev mjordan (~mjordan@nat/digium/x-qpuwuilallgfzzhc) |
| 12:54.17 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:05.33 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-uvspznuysdmqtebi) |
| 13:40.09 | Marquis42 | so I asked this last night, but I'll repeat since there's likely a lot more people around now: Is it a feature or a bug that you can't stop an ARI playback that used a "digits" URI? |
| 13:43.38 | file | it's an annoyance - not all schemes support it |
| 13:43.57 | Marquis42 | heh, ok |
| 13:44.12 | Marquis42 | but it's a "by design" sort of thing, not a "that's a bug" thing right? |
| 13:44.46 | Marquis42 | And presumabling the workaround is to just play the individual digits and stop them if, for example, you receive some DTMF you're expecting? |
| 13:44.48 | file | I'm not sure if it's anything, the underlying stuff in use for digits doesn't support it - so you could call lack of that a bug |
| 13:45.30 | Marquis42 | presumabling? WTF is that? Presumably... anyway, gotcha. |
| 13:45.51 | file | preamble! |
| 13:46.03 | Marquis42 | haha |
| 13:46.12 | file | mjordan, ^^^ |
| 13:56.00 | mjordan | it should be doable. |
| 13:56.09 | mjordan | the 'stop this thing' is just a control fram.e |
| 13:56.11 | mjordan | er, frame. |
| 13:56.34 | mjordan | So long as we are processing frames when we are queuing up digits during that particular media type, we should be able to intercept it and bail out. |
| 13:56.37 | mjordan | bug! |
| 13:56.57 | Marquis42 | OK, well I'll log it then. Thanks for the info gents! |
| 13:57.24 | Marquis42 | mjordan: BTW, no worries on the accidental closure of that one issue. This is why it's possible to re-open. ;) |
| 13:59.28 | mjordan | yup - thanks for not cloning it :-) |
| 13:59.43 | Marquis42 | haha, I know better than that. :) |
| 14:15.40 | *** join/#asterisk-dev newtonr (~newtonr@nat/digium/x-tdtwbostguhtbojs) |
| 14:15.40 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:17.38 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 14:19.30 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:19.30 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:22.01 | *** join/#asterisk-dev kharwell (~kharwell@nat/digium/x-badjktjyfydjzdrt) |
| 14:31.58 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:33.19 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-umxaywlxpweaurth) |
| 14:35.13 | *** join/#asterisk-dev sgriepentrog (~sgriepent@nat/digium/x-xakrkbcuuzyxoert) |
| 14:41.06 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-lljhtvforuqfuknt) |
| 14:44.58 | *** join/#asterisk-dev rmudgett (~rmudgett@nat/digium/x-caonjbxgdwgiursy) |
| 14:49.43 | *** join/#asterisk-dev terryw (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 15:16.43 | gtjoseph | when the testsuite is run by bamboo how does it resolve minversion and maxversion given that the asterisk version is SVN-branch-commit? |
| 15:21.19 | Qwell | gtjoseph: about 10,000 lines of mind-melting version parsing code. |
| 15:21.34 | gtjoseph | Ha! |
| 15:21.56 | Qwell | http://svn.asterisk.org/svn/testsuite/asterisk/trunk/lib/python/asterisk/version.py |
| 15:22.01 | Qwell | it's some scary shit |
| 15:22.52 | gtjoseph | So if I set my minversion to 12.7.0 will bamboo run it before 12.7.0 is released? |
| 15:24.04 | Qwell | iirc, branches are always higher than any release from that branch can be |
| 15:24.58 | Qwell | Looking at the comparison here, it looks like branch-12.0 ~= 12.99.0 |
| 15:26.39 | Qwell | This __int__ function is really inconsistent though... |
| 15:26.54 | gtjoseph | yeah, i'm scanning now |
| 15:27.24 | Qwell | It's either 9.9, 99, or 999, depending on how many dots you've already got O.o |
| 15:28.01 | *** join/#asterisk-dev otherwiseguy (~otherwise@69.76.221.33) |
| 15:29.45 | gtjoseph | i think i'll just take the 'set it and see what happens" approach. |
| 15:30.17 | Qwell | The short answer is if you set minversion to 12.7.0, it'll run against the 12 branch. |
| 15:30.31 | gtjoseph | got it |
| 15:31.39 | Qwell | mjordan: It really feels like there are a couple missing 0's, and a random extra 9 in this function though. |
| 15:32.51 | Qwell | or, really, not enough 9s (not that we'll ever have a x.100.y) |
| 15:39.40 | leifmadsen | needs more 7. |
| 15:39.58 | Qwell | leifmadsen: You'll get a couple 7s if you have a team branch. |
| 15:40.04 | leifmadsen | oic |
| 15:50.49 | Qwell | http://pastebin.com/iaMtKWUy |
| 15:53.08 | Qwell | If that blows up, then there are going to be some fun problems to solve when Asterisk 21 gets released... |
| 15:56.45 | Qwell | and it will. >.> |
| 16:10.11 | *** join/#asterisk-dev tm1000 (tm1000@2600:3c00::f03c:91ff:fe6e:6894) |
| 16:16.41 | *** join/#asterisk-dev otherwiseguy (~otherwise@cpe-69-76-221-33.kc.res.rr.com) |
| 16:20.02 | mjordan | I blocked that file out of my memory. |
| 16:20.34 | mjordan | gtjoseph: the version parsing code "works" within a branch. So a minversion of 12.7.0 will run against 12-branch, but not a tag of 12.6.0. |
| 16:20.39 | mjordan | It breaks down across branches, however |
| 16:20.41 | tm1000 | mjordan: I block file out of my memory too |
| 16:20.48 | file | tm1000, wise |
| 16:20.50 | Qwell | tm1000: harsh |
| 16:21.12 | mjordan | so if I set a minversion of 1.8.31.0 (which coincides with 11.13/12.6), then a checkout of 12.5 *will* run the test (and probably fail) |
| 16:21.27 | gtjoseph | hmmmm |
| 16:21.31 | mjordan | Right now, we haven't yet added the ability for a test to have multiple minversion, which is really what is needed |
| 16:21.49 | mjordan | versioning: it sucks. |
| 16:22.02 | gtjoseph | but if I do a minversion of 12.7.0, a test of the 13 branch will run it right? |
| 16:22.09 | mjordan | yes |
| 16:22.15 | gtjoseph | ok, cool |
| 16:42.51 | file | mjordan, I'm not sure how to fix your bridge issue after doing mine... |
| 16:47.05 | opticron | we don't have module dependency verification in the module loader, do we? |
| 16:48.06 | file | opticron, hahahahahaha |
| 16:48.20 | opticron | thought not |
| 16:48.44 | file | what are you aiming to do? |
| 16:49.42 | opticron | with a borked realtime config (nothing in extconfig) with realtime configured in sorcery, res_pjsip refuses to load (understandably) but later res_pjsip_pubsub tries to load |
| 16:49.57 | opticron | and blows up when it lobs a NULL pjsip endpoint into pjsip |
| 16:50.03 | file | ah yeah |
| 16:51.10 | opticron | bad times were had by all |
| 16:52.22 | opticron | but realistically, I can't even guarantee that ast_sip_get_pjsip_endpoint() is a valid function call since that module declined to load |
| 16:53.13 | mjordan | opticron: my thought - during module load, pjsip modules who need the pjsip endpoint need to check that it is non-null. |
| 16:53.23 | mjordan | I don't see any way around that. |
| 16:54.01 | opticron | but the function they need to call to check that exists in a module that declined to load and may not even be in memory anymore |
| 16:54.17 | gtjoseph | isn't there an is_module_loaded api? |
| 16:54.29 | file | you can use ast_module_check to see if the module is loaded |
| 16:54.29 | gtjoseph | i think so |
| 16:54.39 | gtjoseph | that was it |
| 16:54.42 | opticron | that's the path I was thinking about going down |
| 16:55.12 | mjordan | ah |
| 16:55.20 | mjordan | yeah, that would work better :-) |
| 16:55.33 | opticron | still need to check the endpoint is non-NULL, but have to verify the function call is even valid, first |
| 16:56.07 | file | add it to a header file so everything can use common |
| 16:58.48 | opticron | if only the loader was capable of using the information in .nonoptreq of the modinfo |
| 16:59.28 | file | dream the dream |
| 17:00.25 | opticron | schemes and plots |
| 17:01.03 | opticron | should I assume there's an implicit "don't touch the loader"? |
| 17:02.16 | file | yes. |
| 17:02.31 | opticron | :) |
| 17:09.57 | mjordan | in fact, I would go so far as to say do not open that file. |
| 17:10.21 | mjordan | and any time spent looking at that code is a waste |
| 17:10.29 | opticron | fair enough |
| 17:11.30 | file | radio video, boogie with a suitcase, you're living in a disco, forget about the rat race |
| 17:17.51 | coreyfarrell | I looked at loader.c once... what a nightmare |
| 17:18.03 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-bhiloyhxmkqbnosj) |
| 17:35.38 | gtjoseph | testsuite question... I've got a few config files that need to be overridden. They're copied to the <tmp>/etc/asterisk dir but when I run the test it's using the /etc/asterisk ones. What should I look at? |
| 17:39.56 | mjordan | So, the asterisk.py module manages that process. It symlinks the existing /etc/asterisk/ config files to the tmp/... directory, then copies the explicit test ones over it |
| 17:40.11 | gtjoseph | yep, i see that |
| 17:40.18 | gtjoseph | and my custom ones are there |
| 17:40.35 | mjordan | when a test runs, it tells it to use the asterisk.conf in the /tmp location, which *should* tell it to use the /tmp/.../etc/asterisk for all of its configs |
| 17:40.45 | mjordan | er |
| 17:40.46 | gtjoseph | yep it does. maybe i've got something else wrong |
| 17:40.51 | mjordan | hm. |
| 17:40.59 | mjordan | there's a few exceptions - which config files? |
| 17:41.09 | gtjoseph | users.conf and phoneprov.conmf |
| 17:41.50 | mjordan | hm. That's weird. Those two definitely don't fall under any 'exceptions' |
| 17:42.19 | mjordan | If they've been copied to the /tmp location, then you have them in the correct spot in the testsuite |
| 17:42.35 | mjordan | unless those modules are not looking at the right things to find their config files... |
| 17:43.02 | gtjoseph | i just looked in the logs and there getting loaded correctly. i have something else wrong and i think i know what it is |
| 17:43.09 | gtjoseph | never mind |
| 17:43.10 | mjordan | ah k |
| 17:43.12 | gtjoseph | :) |
| 17:45.05 | gtjoseph | mjordan: while i've got you.. i'm creating a tests/phoneprov directory for the phoneprov tests. i didn't see any better existing place to put them. That ok? |
| 17:45.56 | mjordan | sounds good to me |
| 17:46.15 | mjordan | any particular tests you want help on? |
| 17:46.37 | gtjoseph | nope. i've got em running |
| 17:46.39 | gtjoseph | thanks |
| 17:46.51 | gtjoseph | the skeleton test needs to be updated though :) |
| 17:48.32 | mjordan | heh |
| 17:48.35 | mjordan | yeah, that was written a bit ago |
| 17:48.59 | mjordan | it _should_ still work |
| 17:49.20 | mjordan | holy crap, 2011. |
| 17:49.53 | gtjoseph | :) what bit me was dependencies. apparently it's not 'module' anymore, it's 'asterisk' |
| 17:50.03 | mjordan | eek |
| 17:50.15 | mjordan | I suspect that was wrong when it was written |
| 17:50.29 | gtjoseph | ha |
| 17:55.19 | opticron | mjordan, https://reviewboard.asterisk.org/r/4054/ |
| 17:56.08 | opticron | the error message is still useful for debugging module load order problems and when developing |
| 18:01.33 | datachomper | lol whale client guy |
| 18:07.52 | mjordan | opticron: er... ew. |
| 18:08.04 | mjordan | opticron: why not just make the message only show up with DEV_MODE? |
| 18:08.25 | mjordan | generation of Stasis messages needs to be fast. Damned fast. As fast as we can make 'em. |
| 18:10.53 | opticron | dev-mode it is |
| 18:51.44 | *** join/#asterisk-dev Corydon76 (~quassel@c-69-137-93-158.hsd1.tn.comcast.net) |
| 18:51.45 | *** mode/#asterisk-dev [+o Corydon76] by ChanServ |
| 21:01.58 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:18.19 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 21:30.20 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-84-109-18-138.red.bezeqint.net) |
| 21:30.20 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:46.23 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 21:46.23 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 21:47.45 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |
| 22:15.50 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@64.235.216.2) |
| 22:28.13 | *** part/#asterisk-dev mjordan (~mjordan@nat/digium/x-qpuwuilallgfzzhc) |
| 22:38.23 | *** join/#asterisk-dev maczor (6e8f08aa@gateway/web/cgi-irc/kiwiirc.com/ip.110.143.8.170) |
| 22:39.34 | maczor | Hi I was wondering whether it is possible to contribute patches without signing the Digium licence (an alternate licence would be ok)? The legal department at the company I work for is a bit hesitant about the clause about assigning all future patent rights across on a submission? |
| 22:40.07 | maczor | They feel that it is broad/vague and could be extended beyond the submission. The submission itself is pretty trivial |
| 22:45.04 | putnopvut | (not a lawyer) As far as I know, the license agreement from Digium is required for any submissions to the Asterisk project. |
| 22:53.13 | maczor | Thanks for the response. Do you know of any big companies that have contributed code under the licence agreement that I might be able to use as a reference to explain that it is a standard agreement? |
| 22:59.57 | putnopvut | Not personally, unfortunately. I tend to see contributors as individuals more than as representatives of companies. I'm not sure who most of our contributors work for. :-/ |
| 23:04.16 | maczor | Thanks |
| 23:14.48 | *** part/#asterisk-dev kharwell (~kharwell@nat/digium/x-badjktjyfydjzdrt) |
| 23:38.51 | *** join/#asterisk-dev otherwiseguy (~otherwise@23-228-175-118.mci.googlefiber.net) |