| 00:55.36 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-qdtapukmxmokpzgm) |
| 00:55.36 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 05:00.15 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-qdtapukmxmokpzgm) |
| 05:23.08 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 05:23.08 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 07:02.05 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 07:03.29 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 07:39.27 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 08:12.58 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:34e3:4862:34cd:759) |
| 09:10.14 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 09:37.53 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 09:53.27 | *** join/#asterisk-dev ayrjola (~ayrjola@89.18.237.137) |
| 09:55.05 | *** join/#asterisk-dev ayrjola (~ayrjola@89.18.237.137) |
| 10:02.09 | *** join/#asterisk-dev oej (~Adium@194.183.244.5) |
| 10:02.09 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:06.10 | *** join/#asterisk-dev Jacke (jacke@valhalla.bofh.org) |
| 11:54.39 | *** join/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 12:16.51 | *** join/#asterisk-dev ayrjola (~ayrjola@89.18.237.137) |
| 12:44.00 | *** join/#asterisk-dev oej (~Adium@194.183.244.5) |
| 12:44.00 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:47.48 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 12:47.48 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:49.50 | *** join/#asterisk-dev Marquis42 (~mrbmw@d14-69-246-193.try.wideopenwest.com) |
| 13:12.37 | *** part/#asterisk-dev oej (~Adium@194.183.244.5) |
| 13:34.15 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:36.17 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:36.47 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:40.24 | *** part/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 13:46.54 | skrusty | sorry, maybe i should bring this in here |
| 13:54.42 | *** join/#asterisk-dev sruffell (sruffell@asterisk/the-kernel-guy/sruffell) |
| 13:54.43 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 14:24.59 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-gjhijcjlvxidmrwj) |
| 14:34.40 | *** join/#asterisk-dev Corydon76 (~quassel@c-69-137-93-158.hsd1.tn.comcast.net) |
| 14:34.40 | *** mode/#asterisk-dev [+o Corydon76] by ChanServ |
| 14:36.13 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-wmeccksmoonqpqgp) |
| 14:38.45 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 14:44.15 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-vvtfeqafjxurknzs) |
| 14:44.15 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:54.49 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-wvclarghwhpzrwkj) |
| 14:59.40 | skrusty | for hangup cause, "noanswer" or "no_answer" ? |
| 14:59.47 | skrusty | i.e. for the one i am adding |
| 15:00.07 | skrusty | no_answer seems to follow bridge tech format, there is no two word cause currenty in ari hangup |
| 15:00.20 | file | I'd go for no_answer |
| 15:00.32 | skrusty | it follow the format of AST_CAUSE too |
| 15:00.51 | skrusty | (well, the non alias anyway) |
| 15:05.38 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-xoclnhbcpzmrosbm) |
| 15:06.34 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-mwjhbzhdpgpufhwe) |
| 15:06.34 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 15:14.28 | *** join/#asterisk-dev ayrjola (~ayrjola@80.248.109.192) |
| 15:16.33 | skrusty | well, code updated, swagger definition updated, builds - so about to test :) |
| 15:18.35 | mjordan | yayz |
| 15:23.39 | skrusty | so, that seems to work. |
| 15:24.00 | skrusty | does another test to be sure :) |
| 15:34.37 | skrusty | whoop :) |
| 15:34.43 | skrusty | (sorry, small things etc) |
| 15:35.06 | skrusty | before i go any further, does the patch look right, am i missing anything obvs? https://gist.github.com/skrusty/860a527146838dafe214 |
| 15:36.36 | file | looks correct |
| 15:41.18 | skrusty | eek :) |
| 15:42.05 | skrusty | so, create an issue in jira now, and attach the diff i guess |
| 15:43.30 | skrusty | what severity do it give it? :/ minor? |
| 15:49.08 | leifmadsen | skrusty: Blocking because you want it done quickly right? |
| 15:49.09 | leifmadsen | :D |
| 15:49.20 | skrusty | hehe ;) |
| 15:49.27 | leifmadsen | I'd say minor or just leave as default |
| 15:49.33 | leifmadsen | the bug marshal will change it as necessary |
| 15:50.42 | skrusty | i assume you add the pactch after submitting |
| 15:50.49 | leifmadsen | yea |
| 15:50.49 | skrusty | can't see any way of adding it on the create issue page |
| 15:50.52 | leifmadsen | jira is annoying that way |
| 15:50.58 | leifmadsen | you have to create the issue then go back to it and attach the file |
| 15:51.03 | leifmadsen | can't do it at creation time |
| 15:51.05 | skrusty | :] |
| 15:52.31 | skrusty | ah... |
| 15:52.36 | skrusty | You dont appear to have a current, signed submission license agreement on file. Please sign one before attempting to upload a code or documentation contribution. |
| 15:53.41 | leifmadsen | neat! |
| 15:53.48 | leifmadsen | link in the top bar |
| 15:54.43 | skrusty | yup |
| 15:54.45 | skrusty | doing it now :) |
| 15:55.02 | *** part/#asterisk-dev bulkorok (~Benjamin@85.183.61.47) |
| 15:55.40 | skrusty | now to wait for it to be accepted. |
| 15:56.58 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-jjlafmwvbgnexhcf) |
| 15:57.17 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-pcorsekqpojaushe) |
| 15:57.17 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:58.36 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-ertltywgtjruahlv) |
| 16:14.46 | *** join/#asterisk-dev volga629 (~bendersky@CPE4c5e0cb3c2a0-CM0c473dd46e50.cpe.net.cable.rogers.com) |
| 16:15.01 | volga629 | <PROTECTED> |
| 16:19.11 | mjordan | volga629: which branch of Asterisk are you filing it against? And are you using post-review (or its equivalents) or creating it manually? |
| 16:20.12 | volga629 | I am trying open review board for issue 24294 |
| 16:20.52 | volga629 | which I don't have any clue which tree it suppose to be |
| 16:21.12 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-nlscrsvvitmnboro) |
| 16:23.13 | newtonr | trunk |
| 16:24.20 | newtonr | mjordan, or can completely new contrib scripts go to current supported versions? I'm not sure I've thought about that before. It isn't really a new feature with Asterisk source. |
| 16:24.41 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 16:27.50 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-bmuzdsrotvmafntx) |
| 16:28.14 | mjordan | I'd do trunk |
| 16:28.43 | mjordan | volga629: are you using the post-review tool, or are you creating the review request manually in review board? |
| 16:29.02 | volga629 | in review board site |
| 16:29.23 | skrusty | mjordan: any idea what the turn around is on agreement approval? |
| 16:29.59 | file | 24 hours at the most |
| 16:30.03 | skrusty | cool |
| 16:34.41 | mjordan | volga629: use ./trunk |
| 16:34.54 | volga629 | ok |
| 16:44.14 | volga629 | right now having issue with header of diff I think it requires svn one |
| 16:44.20 | volga629 | Unable to parse diff revision header |
| 16:44.34 | volga629 | because is no revisions yet |
| 16:46.16 | volga629 | I can try --- cert-mng(revision 0001) not sure if it correct way |
| 16:49.04 | file | yes, reviewboard will get upset without an SVN based diff |
| 16:54.56 | volga629 | yes but what to do if it first upload there no revision number yet |
| 16:55.03 | volga629 | The file './trunk/cert-mng' (r000001) could not be found in the repository |
| 16:55.44 | volga629 | and it will be like this for any revision number |
| 17:19.56 | mjordan | er |
| 17:20.03 | mjordan | you need to make an SVN diff |
| 17:20.15 | mjordan | you should have a revision number if you based it on an SVN checkout |
| 17:24.34 | volga629 | so I need checkout all svn asterisk tree ? |
| 17:30.25 | newtonr | volga629, you need to checkout trunk, make your patch in that working copy and then use the output of "svn diff" for your diff |
| 17:31.04 | volga629 | :-) that sound really easy |
| 17:54.27 | volga629 | I never worked with svn staff |
| 18:46.34 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 18:49.37 | *** join/#asterisk-dev ibercom (5320c26f@gateway/web/freenode/ip.83.32.194.111) |
| 18:59.29 | *** join/#asterisk-dev ayrjola (~ayrjola@80.248.109.192) |
| 19:09.38 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 19:12.11 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:22.36 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 19:22.55 | ibercom | Asterisk Realtime: When I make a call, chan_sip looks for the destination number in the sippeers table, even before asterisk starts dialplan. Why ? |
| 19:30.49 | mjordan | ibercom: that's not really a question for #asterisk-dev. |
| 19:31.03 | mjordan | "Tier 2 and 3.14159265 support is in #asterisk" |
| 19:33.20 | ibercom | I tried to understand the behavior of chan_sip asterisk. I'm sorry. |
| 19:33.22 | skrusty | evening |
| 19:37.03 | mjordan | ibercom: that's not a problem, just ask in #asterisk :-) |
| 19:37.08 | mjordan | 99% of the folks in here are in there as well |
| 19:48.00 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:56.55 | *** join/#asterisk-dev sruffell (sruffell@asterisk/the-kernel-guy/sruffell) |
| 19:56.55 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 21:05.48 | *** join/#asterisk-dev sruffell (~sruffell@asterisk/the-kernel-guy/sruffell) |
| 21:05.48 | *** mode/#asterisk-dev [+o sruffell] by ChanServ |
| 21:07.58 | skrusty | mjordan/file: https://issues.asterisk.org/jira/browse/ASTERISK-24745 |
| 21:11.01 | file | yessssss? |
| 21:19.14 | skrusty | posted my first codecontrib :) |
| 21:25.21 | file | skrusty, you'll need to put it up for code review |
| 21:26.38 | skrusty | ok |
| 21:26.45 | skrusty | looks back at the guide |
| 21:27.28 | skrusty | guide says "core team" willput it on review board, or am i missing something? |
| 21:28.20 | file | does it? |
| 21:28.50 | skrusty | "Once submitted, the issue will be triaged by the core team and then, depending on the specifics of the patch, it may be put up for review on reviewboard ." |
| 21:29.19 | file | where's that? I looked at https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process |
| 21:29.36 | skrusty | http://www.asterisk.org/community/developers |
| 21:29.45 | file | oh, asterisk.org |
| 21:30.26 | skrusty | "In short, no. Attaching your patch as a code contribution to an issue in JIRA is all that is required." |
| 21:30.46 | file | yeah - that's the bare minimum required |
| 21:30.55 | skrusty | ok |
| 21:30.57 | file | stuff just gets done faster if you put it up on review board |
| 21:31.00 | skrusty | :) |
| 21:47.03 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 22:01.53 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 22:21.28 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 22:36.23 | *** join/#asterisk-dev ipengineer_ (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 22:43.22 | mjordan | blech |
| 22:43.28 | mjordan | I'm going to go nuke that page |
| 22:45.04 | mjordan | well, actually, I think that's mostly just poor phrasing. |
| 23:31.15 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 23:43.08 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-nfclvojfbotfmuce) |
| 23:54.38 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-mwjhbzhdpgpufhwe) |