| 00:54.48 | *** join/#asterisk-dev sgriepentrog (~sgriepent@107-220-72-223.lightspeed.brhmal.sbcglobal.net) |
| 01:21.36 | *** join/#asterisk-dev sgriepentrog (~sgriepent@107-220-72-223.lightspeed.brhmal.sbcglobal.net) |
| 01:22.43 | *** join/#asterisk-dev sgriepentrog (~sgriepent@107-220-72-223.lightspeed.brhmal.sbcglobal.net) |
| 01:47.49 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 01:47.49 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 02:10.25 | *** join/#asterisk-dev sgriepentrog (~sgriepent@107-220-72-223.lightspeed.brhmal.sbcglobal.net) |
| 02:42.28 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-yslzngjrfeprqyxe) |
| 02:42.28 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 03:03.55 | coreyfarrell | mjordan: the change I just did for digium_commits.py is completely untested |
| 04:07.36 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:07.45 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:39.53 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:39.58 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:40.28 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:41.26 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 06:28.14 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-vubfcymiwepzpham) |
| 07:01.28 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:01.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:50.56 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.135.186) |
| 08:00.46 | *** join/#asterisk-dev oej (~oej@87.96.134.129) |
| 08:00.46 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:09.49 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 08:09.49 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:24.36 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:57.22 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 09:16.05 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 09:16.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:30.21 | *** join/#asterisk-dev eremitah (~int@unaffiliated/eremitah) |
| 10:08.32 | *** join/#asterisk-dev danjenkins_ (anonymous@nat/digium/x-zczxrwnyifiyjwip) |
| 10:18.03 | *** join/#asterisk-dev xytis (~xytis@5.20.223.100) |
| 10:58.40 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:419b:b631:1fcd:3362) |
| 11:10.58 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 11:29.17 | *** join/#asterisk-dev jvhester (~root@104.131.198.181) |
| 11:29.17 | *** join/#asterisk-dev blitzrage (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 11:29.17 | *** mode/#asterisk-dev [+o blitzrage] by sendak.freenode.net |
| 11:33.42 | *** join/#asterisk-dev xytis (~xytis@5.20.223.100) |
| 11:33.42 | *** join/#asterisk-dev Marquis42 (~mrbmw@d14-69-246-193.try.wideopenwest.com) |
| 11:33.42 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 11:48.29 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/session) |
| 11:48.31 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-vcclpwaribigpjvg) |
| 11:53.58 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 11:53.59 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:18.09 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:18.16 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 12:18.20 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 12:27.55 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-kfyhovnvrvplljif) |
| 12:29.39 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:06.51 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 13:06.51 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 13:16.07 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 13:45.28 | *** part/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 13:46.20 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 13:46.20 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 14:05.21 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-yortsdsrpfswkojk) |
| 14:05.21 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:05.45 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-tpuxdequiiybimjq) |
| 14:05.46 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:05.46 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:29.46 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:31.57 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-zmuxikeoubdnmpke) |
| 14:31.57 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:37.24 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-cuxnusmiubdmkeru) |
| 14:41.56 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 14:52.32 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 15:17.12 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hxxtwrxsjzlnlioz) |
| 15:35.26 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 16:58.52 | gtjoseph | mjordan: so when we push a review to gerrit, do we need to explicitly add reviewers list 'asterisk-dev' ? |
| 16:59.08 | gtjoseph | s/list/like/ |
| 16:59.33 | mjordan | gtjoseph: nope |
| 16:59.43 | gtjoseph | cool. |
| 16:59.43 | mjordan | gtjoseph: it will automagically send out to the asterisk-dev list |
| 16:59.55 | mjordan | I should update the wiki to note the '-D' option for git review |
| 17:00.06 | mjordan | that publishes your change as a draft |
| 17:00.12 | gtjoseph | yeah. :) |
| 17:00.12 | mjordan | otherwise, 'git review' will automatically publish |
| 17:02.13 | mjordan | just as an FYI, I'm currently still tweaking replication settings on gerrit.asterisk.org, so if it goes down for a little bit, that's expected |
| 17:02.17 | mjordan | still a work in progress! |
| 17:02.34 | mjordan | I wouldn't expect much of a hiccup, as I (mostly) have it all worked out |
| 17:02.35 | gtjoseph | mjordan: I just got 2 emails, once on the draft submit and one on the publish. Did the list see both? |
| 17:03.01 | mjordan | weird |
| 17:03.05 | mjordan | looks like it did |
| 17:03.10 | mjordan | Corey noted that the same thing happened yesterday |
| 17:03.24 | file | quite |
| 17:07.55 | mjordan | and of course, nothing in the logs about that :-( |
| 17:08.30 | mjordan | hm |
| 17:08.37 | mjordan | gtjoseph: how did you push the draft up? |
| 17:08.50 | gtjoseph | git review -D |
| 17:09.08 | mjordan | hum |
| 17:09.30 | mjordan | so, the way it knows something is a 'draft' is if it is pushed to refs/drafts/, as opposed to refs/for/master |
| 17:09.36 | mjordan | I wonder if git review mucked up |
| 17:10.05 | gtjoseph | I first did a git review -D -n and got the output "git push gerrit HEAD:refs/drafts/master" |
| 17:10.34 | gtjoseph | so it looks like that part is correct unless git review is messing up without the -n option |
| 17:15.54 | gtjoseph | mjordan: BTW, gerrit did show the review as Draft when I logged in, then I pushed Publish. |
| 17:19.33 | mjordan | I'll see if I can find anything about that |
| 17:19.41 | mjordan | right now, it's a lot of Google searches :-P |
| 17:20.07 | file | I find your use of Google most disturbing. |
| 17:20.24 | mjordan | Bing? |
| 17:20.34 | file | that is an alternative, yes |
| 17:21.06 | coreyfarrell | I find the existence of Bing most disturbing |
| 17:21.24 | file | there are worse things - see above, Google |
| 17:23.00 | mjordan | we may be on a small Google-hate trip :-P |
| 17:24.13 | file | I'm always on a Google-hate trip. |
| 17:24.28 | coreyfarrell | I can understand hating Google. personally I've just hated Microsoft for a longer time... |
| 17:37.57 | gtjoseph | I've apparently discovered time travel. I just published a review on coreyfarrell's fixes and saw "Updated: in the future" on the summary page. :) |
| 17:38.26 | coreyfarrell | yeah I noticed that too, I think the time on gerrit is a little off |
| 17:40.58 | coreyfarrell | I just noticed a trivial issue with my patch to commit_msg.py. apparently files that are submitted to JIRA as 'not patches' are given license #2. I assume I should have it ignore all patches with license #2? |
| 17:51.02 | mjordan | I guess so; I wasn't aware of that |
| 17:51.06 | mjordan | coreyfarrell: and woot on 433469 |
| 17:51.57 | coreyfarrell | yup, I think we're ready to enable res_pjsip on the reference checking bamboo job |
| 17:54.53 | mjordan | gtjoseph: looks I didn't have NTP installed on the server; fixing that |
| 17:55.26 | gtjoseph | :) |
| 18:13.24 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 19:28.38 | coreyfarrell | what is the correct way to reference multiple reporters and multiple reviews from a single commit? Do I want comma separated values, or a new header per value? |
| 19:48.05 | rmudgett | file: The code pointed out by ASTERISK-24910 looks wrong in its handling of the bit fields. timers_handler() and also prack_handler() |
| 19:48.24 | rmudgett | The bits don't get cleared when the option is set to no. |
| 19:50.25 | file | ah, we fixed it for 100rel only |
| 19:51.27 | rmudgett | PJSIP_INV_SUPPORT_100REL != PJSIP_INV_REQUIRE_100REL |
| 19:51.46 | rmudgett | PJSIP_INV_SUPPORT_TIMER != PJSIP_INV_REQUIRE_TIMER != PJSIP_INV_ALWAYS_USE_TIMER |
| 19:52.20 | rmudgett | For 100rel there are two bits. For timers there are three bits. |
| 19:53.53 | file | okay? |
| 19:58.03 | rmudgett | for 100rel no=neither bit set, yes=support bit set, required=required bit set |
| 19:58.53 | file | I'm not quite sure why you are saying this, I don't intend on touching that anytime soon. :P I just saw the mention of the endpoint not getting created. |
| 19:58.55 | rmudgett | for timers no=none of the three bits set, yes=support bit set, required=require bit set, always=always-use bit set |
| 19:59.18 | file | the JIRA issue would be the best place for it |
| 19:59.24 | rmudgett | k |
| 19:59.32 | file | for when someone does get to it |
| 20:09.45 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 20:09.45 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:11.24 | rmudgett | file: I thought you were getting to it. |
| 20:11.34 | file | nope! |
| 20:12.04 | file | unless I do it on the weekend |
| 20:19.28 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 20:47.47 | gtjoseph | Is there a way to get the parent aor of a contact without searching the aors? Doesn't look like it. |
| 20:55.12 | coreyfarrell | gtjoseph: looks like it (see struct ast_sip_contact_wrapper). I'm guessing this is either avoiding a circular reference or for if the aor structure is ever replaced with a new one |
| 20:55.45 | gtjoseph | Yeah, I don't have the wrapper at that point. |
| 20:57.06 | gtjoseph | Man If you're not in the guts of pjsip even for a short time, you forget how complex it is. |
| 21:04.19 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 21:04.19 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:08.00 | *** join/#asterisk-dev mjordan (~mjordan@75.76.28.27) |
| 21:08.00 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 21:08.07 | *** part/#asterisk-dev mjordan (~mjordan@75.76.28.27) |
| 21:08.49 | *** join/#asterisk-dev mjordan (~mjordan@75.76.28.27) |
| 21:08.49 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 21:18.31 | coreyfarrell | I reread the wiki on commit msgs, now I know how to format the reporters of multiple tickets. still not sure how I should reference the reviews for different branches. should I list both reviews for commits to all branches, or change the commit msg so each branch only references it's own review? or does it matter? |
| 21:40.44 | mjordan | coreyfarrell: personally, I don't think it matters |
| 21:40.54 | mjordan | the scripts look for unique contributors to the patch |
| 21:41.00 | mjordan | so if they show up 3 times, it really only counts once |
| 21:43.22 | putnopvut | I'm having gerrit probs |
| 21:44.20 | putnopvut | I uploaded my ssh public key, but I'm unable to git clone |
| 21:44.42 | putnopvut | Permission denied (publickey).fatal: The remote end hung up unexpectedly |
| 21:46.02 | gtjoseph | Extraneous newlines in the key when pasted? |
| 21:47.33 | putnopvut | Not sure, but I can check. |
| 21:48.19 | putnopvut | Well, I don't think so. My id_rsa.pub file is just a single line. |
| 21:49.13 | gtjoseph | How did you copy it to the clipboard? |
| 21:50.23 | coreyfarrell | putnopvut: I had a problem like that when I first forgot to create my gerrit username |
| 21:50.46 | gtjoseph | Yeah, could be that as well. |
| 21:51.02 | putnopvut | That's a separate step than logging in with OpenID? |
| 21:51.40 | coreyfarrell | yes |
| 21:51.48 | putnopvut | Okay, found that, set it, and things appear better now. Thanks! |
| 21:51.53 | putnopvut | updates the wiki |
| 21:52.03 | coreyfarrell | no problem.. I breezed over that part of the wiki too |
| 21:54.27 | putnopvut | Now there are steps on how to actually do it :) |
| 21:56.12 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 21:56.40 | putnopvut | Well I spoke too soon. I thought things were better since gerrit was offering me an SSH option for cloning the testsuite. But attempting the operation is still failing. I'll try re-uploading my public key, being extra careful not to include new-lines. |
| 21:57.31 | coreyfarrell | I did remove and re-add my ssh key after creating the username. not sure if that was a required step.. |
| 21:58.36 | putnopvut | Just tried and it didn't help. I'll play around with this some more... |
| 21:59.51 | gtjoseph | Don't use 'more' to a terminal to copy. It adds newlines. USe 'cat'. |
| 22:00.09 | putnopvut | Ah, I see what I did. I copied the wrong public key. |
| 22:00.15 | coreyfarrell | doh |
| 22:00.55 | putnopvut | And now everything's gravy |
| 22:01.05 | putnopvut | gtjoseph: yeah, I had been using cat. |
| 22:01.11 | gtjoseph | :) |
| 22:09.25 | *** part/#asterisk-dev mjordan (~mjordan@75.76.28.27) |
| 22:15.33 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 22:23.36 | coreyfarrell | damn utils dir |
| 22:29.40 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-dejovxxtiyylffou) |
| 22:29.40 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 22:29.55 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-dejovxxtiyylffou) |
| 22:32.19 | *** join/#asterisk-dev superscrat (~asanders@173.17.133.2) |
| 22:32.37 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 22:32.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:36.23 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 22:40.18 | putnopvut | I'm attempting to push a review to gerrit but getting this: http://ur1.ca/jzr1x |
| 22:40.35 | putnopvut | Not really sure what's going wrong here. |
| 22:43.38 | coreyfarrell | looks like something got weird in the git-review install |
| 22:48.45 | putnopvut | Fixed it. I needed to `pip install --upgrade setuptools` |
| 22:50.23 | putnopvut | adds more to the wiki |
| 22:58.41 | coreyfarrell | anyone have a minute for a very quick review? I broke Asterisk and I want to make it compile again. https://reviewboard.asterisk.org/r/4534/ |
| 23:00.41 | gtjoseph | Ok with me FWIW. |
| 23:01.39 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:03.10 | coreyfarrell | gtjoseph: thanks, I'm not going to wait to commit this one if that's ok with you. |
| 23:03.18 | gtjoseph | agreed |
| 23:04.26 | coreyfarrell | really hate when I do dumb stuff |
| 23:08.20 | gtjoseph | I say that to myself almost every day. |
| 23:13.33 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-tpuxdequiiybimjq) |
| 23:18.49 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 23:29.00 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:35.23 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:38.06 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:53.34 | *** join/#asterisk-dev sgriepentrog (~sgriepent@2602:30a:2ef2:840:20c:29ff:fe4f:cac8) |