| 01:44.23 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 04:06.20 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 04:06.25 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 05:18.15 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 05:18.19 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 05:41.31 | *** join/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 05:41.55 | *** part/#asterisk-dev jagruti_ (~root@182.70.116.47) |
| 06:38.00 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:38.00 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:44.57 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:44.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:11.35 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:11.36 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:42.33 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:42.33 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:01.08 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 09:01.08 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:55.36 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 10:55.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:21.31 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-66-28.user.veloxzone.com.br) |
| 12:54.44 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:26.20 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-weenffyjbdpxlkll) |
| 13:50.57 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 13:50.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:54.08 | *** join/#asterisk-dev dustinm (~dustinm@105.ip-167-114-152.net) |
| 13:55.31 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:6:f80:224:3080:c239:be41:f3e3) |
| 13:55.31 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-idsmymjgkxkdwgwg) |
| 13:55.31 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 13:56.35 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-weenffyjbdpxlkll) |
| 13:57.58 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:58.17 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 13:58.17 | *** join/#asterisk-dev mbowie (~mbowie@162.212.36.9) |
| 13:58.17 | *** join/#asterisk-dev Jacke (jacke@valhalla.bofh.org) |
| 13:58.37 | *** join/#asterisk-dev snuff-home (~brad@203-219-29-182.tpgi.com.au) |
| 13:58.37 | *** mode/#asterisk-dev [+o snuff-home] by hitchcock.freenode.net |
| 13:58.58 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 13:59.06 | *** join/#asterisk-dev opticron (~opticron@75.76.209.84) |
| 13:59.06 | *** join/#asterisk-dev file (~file@asterisk/developer-and-muffin-lover/file) |
| 13:59.06 | *** mode/#asterisk-dev [+ooo jsmith opticron file] by hitchcock.freenode.net |
| 14:01.04 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 14:06.36 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-nrpfjrrossftyqxi) |
| 14:10.00 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-hvgifuathigfuesk) |
| 14:10.00 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:19.33 | mjordan | coreyfarrell: looks like the commits for r433997 caused res_phoneprov_pjsip to frack: https://bamboo.asterisk.org/bamboo/browse/AST-ATSF-552 |
| 14:28.18 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:28.18 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:36.45 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:42.50 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-pebowuzpwqpaxcpl) |
| 14:43.57 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 14:43.57 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 14:51.34 | coreyfarrell | mjordan: which means something else is removing too many refs or not grabbing a ref in the first place :( |
| 15:14.51 | coreyfarrell | mjordan: I don't have time to look into right now so I'm going to have to just revert it and reopen the ticket. when you get a chance please disable res_pjsip_phoneprov_provider on the bamboo ref check job |
| 15:17.17 | gtjoseph | coreyfarrell: since anything goofed up in res_pjsip_phoneprov_provider was probably my fault to begin with, can I help? |
| 15:18.13 | coreyfarrell | gtjoseph: if you have time that would be cool, especially since I'm really not familiar with the phoneprov modules. |
| 15:18.31 | gtjoseph | absolutely, what's the issue? |
| 15:20.11 | coreyfarrell | gtjoseph: https://issues.asterisk.org/jira/browse/ASTERISK-24935 |
| 15:20.26 | coreyfarrell | I just reopened and attached the backtrace from bamboo |
| 15:20.46 | gtjoseph | got it, i'll handle. |
| 15:21.14 | coreyfarrell | gtjoseph: thanks! |
| 15:23.22 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 15:23.22 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:29.34 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-pneplapsimpfsmfi) |
| 15:35.49 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 16:11.28 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-ytrjnartepmsfbsg) |
| 16:21.24 | gtjoseph | coreyfarrell: it was a module unload order issue. res_phoneprov was unloading before res_pjsip_phoneprov_provider. patch forthcoming. |
| 16:22.07 | coreyfarrell | ahh no module refs against res_phoneprov |
| 16:22.42 | gtjoseph | correct. the fix was to add the module_ref/unref in res_phoneprov register_provider |
| 16:22.57 | gtjoseph | so it doesn't go away before the providers |
| 16:25.42 | mjordan | kharwell: looks your testsuite review on gerrit is waiting on an update from you |
| 16:25.42 | mjordan | https://gerrit.asterisk.org/#/c/25/ |
| 16:25.52 | mjordan | kharwell: do you have a draft pending on it? |
| 16:26.05 | mjordan | gtjoseph: thanks for the fix :-) |
| 16:26.19 | gtjoseph | no problem. my fault to begin with. |
| 16:26.38 | mjordan | or the fault of the reviewers ;-) |
| 16:34.46 | gtjoseph | mjordan: coreyfarrell: spoke too soon, there's another unload order issue. res_pjsip_phoneprov_provider and res_phoneprov are now unloading before res_pjsip_config_wizard. |
| 16:35.00 | gtjoseph | which is causing another set of fracks |
| 16:35.06 | file | module unloading is the gift that keeps on giving |
| 16:35.14 | gtjoseph | no kidding |
| 16:35.59 | gtjoseph | the only way to solve this is to set res_phoneprov to shutdown ref. |
| 16:36.14 | gtjoseph | or womehow to force res_pjsip_config_wizard to unbload first |
| 16:36.33 | gtjoseph | s/womehow/somehow/ |
| 16:39.18 | gtjoseph | rats shutdown ref didn;t work |
| 16:46.29 | gtjoseph | mjordan: so the only way for me to plug the original ref leak is to have res_phoneprov self-ref so it doesn't unload. is that acceptable for now? |
| 16:48.12 | mjordan | hum. |
| 16:48.27 | mjordan | that stinks :-P |
| 16:48.29 | coreyfarrell | gtjoseph: I can't speak for if that is better or worse than leaking from res_pjsip_phoneprov_provider, but for testing it would mean we'd have to disable res_phoneprov for bamboo ref checks |
| 16:48.57 | mjordan | why isn't res_pjsip_config_wizard shutting down first? |
| 16:49.05 | gtjoseph | bamboo is testing for module unloads? |
| 16:49.14 | gtjoseph | no way to tellit to |
| 16:49.51 | coreyfarrell | modules have an AO2 object when REF_DEBUG is enabled, if a module leaks refs it shows up as an AO2 leak |
| 16:50.25 | gtjoseph | coreyfarrell: gotcha |
| 16:54.14 | gtjoseph | let me see if playing with load order will do something. |
| 16:56.25 | coreyfarrell | gtjoseph: Is it possible that res_pjsip_config_wizard isn't the actual problem? if another module does an extra unref to something, res_pjsip_config_wizard could be dealing with an object that was wrongly destroyed by another module |
| 16:57.50 | gtjoseph | possibly but res_pjsip_config_wizard SHOULD be the first thing to unload. It's a consumer of both phoneprov modules. |
| 16:58.20 | gtjoseph | and the rest of pjsip for that matter. |
| 17:00.52 | coreyfarrell | sounds like we need res_pjsip_config_wizard to add references to other modules? |
| 17:01.16 | gtjoseph | yep but we don't have an easy way to do that. |
| 17:01.34 | gtjoseph | you can't ref by module name. |
| 17:02.09 | gtjoseph | although i suppose that would be easy enough to create |
| 17:05.51 | coreyfarrell | yeah I'm not very familiar with the pjsip modules, I guess I was thinking that if res_pjsip_config_wizard consumes res_pjsip_phoneprov, then it could ask that module to bump it's ref |
| 17:06.51 | gtjoseph | you have to have the ast_module structure to ref/unref |
| 17:08.02 | coreyfarrell | oh right res_pjsip_phoneprov_provider doesn't export global symbols |
| 17:08.24 | gtjoseph | correct |
| 17:08.34 | coreyfarrell | but res_pjsip_config_wizard does export globals, even though it doesn't appear to have any |
| 17:08.56 | gtjoseph | GLOBAL_SYMBOLS is a way to force early loading |
| 17:09.07 | gtjoseph | that's what I'm playing with now. |
| 17:09.37 | coreyfarrell | why doesn't load_pri take care of load order? |
| 17:10.06 | gtjoseph | :) |
| 17:10.10 | gtjoseph | why indeed |
| 17:26.26 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 17:41.42 | kharwell | mjordan: yes I still had the draft pending. It has now been published. |
| 18:31.34 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 18:31.35 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:55.17 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 18:55.17 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 18:56.25 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 18:56.25 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:49.18 | putnopvut | Can I get a little help from someone regarding an undefined symbol error? If someone could check out http://svn.digium.com/svn/asterisk/team/group/dns, you'll find that when you start up Asterisk, test_dns_srv.so fails to load because of ast_dns_test_write_domain being an undefined symbol. |
| 19:50.11 | putnopvut | However, I'm not sure how to debug why that is the case. I'm #including the file where the function is declared. The test_dns.c file is being linked when Asterisk is built, and all functions that start with ast_* are exported according to main/asterisk.exports.in |
| 19:55.23 | file | hrm |
| 19:55.57 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 20:03.34 | putnopvut | Interesting: if I remove the giant #ifdef TEST_FRAMEWORK guard that surrounds the content of dns_test.c, I don't have the problem any longer. |
| 20:16.39 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-mkrmawuyxkmxlmxp) |
| 20:16.39 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 20:35.48 | coreyfarrell | putnopvut: I haven't looked at that code, but it sounds like test_dns_srv is missing the <depend>TEST_FRAMEWORK</depend>, and it shouldn't have been allowed to build without it |
| 20:36.29 | putnopvut | coreyfarrell: The thing is, I had TEST_FRAMEWORK defined when I built Asterisk. |
| 20:37.51 | coreyfarrell | very weird |
| 20:39.09 | coreyfarrell | gtjoseph: so I'm about done for the day I'll take a look at that review when I wake up in the morning. thanks for dealing with it! |
| 20:39.20 | gtjoseph | no worries! |
| 20:52.28 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 21:48.58 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-mkrmawuyxkmxlmxp) |
| 22:03.44 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-lxpkprdogojzlvmm) |
| 23:03.23 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-nrpfjrrossftyqxi) |
| 23:29.03 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:37.15 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:38.04 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 23:38.04 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |