| 00:46.47 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 00:54.16 | *** join/#asterisk-dev sgriepentrog (~sgriepent@162-239-32-132.lightspeed.brhmal.sbcglobal.net) |
| 00:55.46 | *** join/#asterisk-dev sgriepentrog (~sgriepent@162-239-32-132.lightspeed.brhmal.sbcglobal.net) |
| 02:37.06 | *** join/#asterisk-dev sgriepentrog (~sgriepent@162-239-32-132.lightspeed.brhmal.sbcglobal.net) |
| 02:54.43 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-isscvrtmwurubwwt) |
| 02:54.43 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 02:54.57 | mjordan | coreyfarrell: sorry about the zuul -1's |
| 02:55.02 | mjordan | I'm working on fixing that... |
| 02:55.09 | mjordan | I should have it worked out tomorrow for sure |
| 02:55.27 | coreyfarrell | it's cool |
| 02:56.19 | coreyfarrell | so question, in the testsuite python code, what maximum line length do we want? pep8 says 79, but then says projects can choose to increase to 80-100. |
| 02:57.48 | coreyfarrell | I ask because wrapping at 79 REALLY sucks.. either way we should probably add a note about python in the wiki coding guidelines or something |
| 02:58.31 | mjordan | Yeah |
| 02:58.33 | mjordan | I hate 79 |
| 02:58.35 | mjordan | but I try to hold to it |
| 02:58.41 | coreyfarrell | my monitor is wide, not tall |
| 02:58.45 | mjordan | heh, mine too |
| 02:58.53 | mjordan | I think 90 is what the Asterisk project uses for that reason |
| 02:59.00 | mjordan | goes to take the dog out |
| 02:59.25 | coreyfarrell | I think it would be nice if we also use 90 in python |
| 03:02.19 | mjordan | I wonder if there's a way to get pylint or pep8 to ignore that... |
| 03:07.07 | coreyfarrell | pep8 --help: The project options are read from the [pep8] section of the tox.ini file or the setup.cfg file located in any parent folder of the path(s) being processed. |
| 03:10.35 | coreyfarrell | yup that worked, just put tox.ini in the root of testsuite |
| 03:14.44 | coreyfarrell | for pylint not so easy.. looks like it uses an rcfile, you have to pass it as a parameter to pylint or set env PYLINTRC |
| 03:15.56 | mjordan | hm. Something to think about, as I'm working (slowly) on scripts that will run those |
| 03:15.59 | mjordan | anywho, off to be |
| 03:16.01 | mjordan | er, bed, even |
| 03:16.08 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-isscvrtmwurubwwt) |
| 03:28.36 | *** part/#asterisk-dev w9sh (~sph@50-79-224-193-static.hfc.comcastbusiness.net) |
| 04:29.16 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 05:06.04 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 05:27.01 | *** join/#asterisk-dev justsomedood (~warren@mail.serverplus.com) |
| 06:50.49 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:a8b8:f8ba:bcf2:cff7) |
| 11:29.09 | *** join/#asterisk-dev danjenkins (anonymous@nat/digium/x-dzbhkeapkhltgcrr) |
| 11:33.00 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-lytrrdcgcibdybio) |
| 11:33.00 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 12:23.17 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 12:23.29 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 12:23.33 | *** join/#asterisk-dev anonymouz666 (~anonymouz@189-25-66-28.user.veloxzone.com.br) |
| 12:30.01 | *** join/#asterisk-dev Demon_VoIP (~demon@eoks.ivanovo.ru) |
| 12:34.29 | Demon_VoIP | Good day. Tell me the possible fate of the next review https://reviewboard.asterisk.org/r/4476/ Have to wait until someone from the team would not be interested in? Thanks |
| 12:36.13 | file | the path forward there would be back porting the line functionality from trunk |
| 12:39.56 | Demon_VoIP | file, sorry, it was a response to me? |
| 12:40.00 | file | yes |
| 12:40.50 | Demon_VoIP | file, this patch applies to version 13. I'm there now and I use. You can learn more what port it? |
| 12:41.26 | file | your patch applies to version 13, but I agree with Mark that it's not a good solution - trunk has a solution, but it needs to be put into 13 |
| 12:42.44 | Demon_VoIP | file, Where you can read about the implementation of the decision in trank? |
| 12:43.27 | Demon_VoIP | file, sorry. re-read the comment carefully. Already forgot. |
| 12:43.34 | file | the implementation isn't docmented outside of the code, the support is mentioned in the sample configuration file |
| 12:44.20 | file | oh it is documented what it does in the option |
| 12:57.35 | Demon_VoIP | file, Carefully examined. If understood correctly, this is exactly what I need. Apparently I was "very drunk" when I did not understand this truth. |
| 12:57.41 | Demon_VoIP | file, version 14 will not LTS. I would like to port in LTS. The code in the patch is not much, but "easy" it does not apply to the 13-th version :( |
| 12:57.57 | file | the functionality can be ported back into 13 |
| 12:58.55 | Demon_VoIP | file, Then I only have two questions: 1. what to do with the review? To cancel? 2. Whether there will be willing to port if it's not me? |
| 12:59.16 | file | it needs a test, I don't believe anyone is currently working on one |
| 13:00.44 | Demon_VoIP | file, if there is a patch, I am ready to test it on version 13. |
| 13:00.56 | file | there is none as of this time for 13 |
| 13:04.33 | file | I have created https://issues.asterisk.org/jira/browse/ASTERISK-24949 |
| 13:06.45 | Demon_VoIP | Then you can mark as duplicate: https://issues.asterisk.org/jira/browse/ASTERISK-24852 |
| 13:08.44 | file | all done! |
| 13:08.50 | file | thanks |
| 13:09.13 | file | you can watch ASTERISK-24949 so you'll get an email if there are any updates |
| 13:10.56 | Demon_VoIP | Thank you. I have already signed up on this issue. Willing to test the patch when it appears. |
| 13:13.55 | Demon_VoIP | There is another problem :) It's the special characters in passwords. Long ago was the patch that fixes it: https://issues.asterisk.org/jira/browse/ASTERISK-13170 But it rolled back because of problems with the syntax of register lines. |
| 13:14.59 | Demon_VoIP | It would be great to bring back the possibility of escaping passwords in res_pjsip. |
| 13:15.36 | Demon_VoIP | Unlike chan_sip in pjsip.conf passwords are always single lines in the auth sections. |
| 13:18.09 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-lcgidatyfpskvzew) |
| 13:19.22 | Demon_VoIP | Maybe I'm wrong and in pjsip.conf in the text of the password, all characters are allowed? |
| 13:19.43 | file | we don't check |
| 13:19.46 | file | PJSIP might |
| 13:21.36 | Demon_VoIP | Thank you. So only practice will show. Not so long ago, for many years the first encounter with the special characters in the password chan_sip. And it broke the configs. Hope pjsip |
| 13:23.14 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 13:45.04 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-erbogmblanoisckq) |
| 13:45.04 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:15.52 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:15.52 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:16.50 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-uklazsedjigsixae) |
| 14:20.42 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-bwrrkfnlnzzszehl) |
| 14:26.11 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-gmdtasbwrdmrltew) |
| 14:52.26 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-xqbvtihtujanendx) |
| 14:52.26 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:59.22 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-jxgfmpxqcryazcuc) |
| 15:34.02 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-agudxgsozwlqrjmm) |
| 16:44.31 | stefan27 | I updated my ticket https://issues.asterisk.org/jira/browse/ASTERISK-24925 with the asterisk-pjnath-stun-crash but I still have no clean core-dump. It seems that when Asterisk 13 invites a 'webrtc chrome chan_sip-peer', then whenever asterisk receives the 'OK SDP Answer' it makes some call to pjproject which in turn produces an unexpected burst of 10-100 (identical) sendto(...,"<stun |
| 16:44.31 | stefan27 | request>",...)-systemcalls which is seen as https://issues.asterisk.org/jira/secure/attachment/52261/wiresharksnapshotstunburst.PNG . I don't know if that weird behavior is directly related to my stun-crash, but I'm trying to find out if that stun-burst is unique to my environment since I haven't found related issues on the internet. It always produces that weird burst, but it hardly ever |
| 16:44.31 | stefan27 | crashes |
| 16:45.52 | stefan27 | Anyone here capable of calling a chrome webrtc peer and see if they always get the same kind of stun-request-bursts as I got in that screenshot? |
| 16:48.05 | stefan27 | 100 packets within a milliseconds cant be good |
| 16:48.09 | *** join/#asterisk-dev oej (~oej@192.36.80.8) |
| 16:48.09 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:49.23 | stefan27 | Maybe it's a pjproject-bug only producable in my OS, does anyone know if pjprojects has has a #pj-dev like this channel? |
| 16:52.16 | stefan27 | hey oej :) |
| 16:54.32 | file | I do not believe there is one |
| 16:56.45 | stefan27 | that's a shame... Debugging pjnath-source-code by myself is even harder than debugging asterisk-source-code. It's hard to read and I'm not a C-developer |
| 16:58.19 | stefan27 | i guess i can try debugging by using different environments and different versions of pjnath, instead of digging into source |
| 16:59.53 | stefan27 | anyways, at least this crash seems to be ~10 times less freqeuent than the DTLS-bug i was whining about 1 month ago :) |
| 17:00.58 | stefan27 | but webrtc is the root of all problems |
| 17:09.28 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 17:30.38 | gtjoseph | file: doesn't ast_sorcery_retrieve_by_id bump the refcount on the returned object? |
| 17:30.48 | file | it does |
| 17:31.11 | gtjoseph | weird. i'm getting REF_DEBUG entries when I call ao2_cleanup on it. |
| 17:41.08 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 18:22.19 | coreyfarrell | gtjoseph: so what happened with r4596? |
| 18:33.23 | gtjoseph | coreyfarrell: i was disgusted with the solution. starting over without the config_wizard interaction. should be ready in an hour or so. |
| 18:33.44 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 18:35.37 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 18:35.37 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 18:47.17 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 19:01.54 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:01.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:09.58 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:09.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:18.22 | file | rmudgett, we really should have a define for the temp buffers for printing format cap contents |
| 19:20.48 | rmudgett | file: Hence https://issues.asterisk.org/jira/browse/ASTERISK-24732 |
| 19:21.03 | gtjoseph | coreyfarrell: r4608 is up. should fix the res_pjsip_phoneprov_provider issues. |
| 19:23.18 | file | gtjoseph, you made me lol |
| 19:23.34 | gtjoseph | I'm glad I amused you. |
| 19:24.27 | coreyfarrell | gtjoseph: what about a race condition with one thread trying to use users while another unloads res_phoneprov? not sure if this falls under "can't fix everything", just wanted to bring it up |
| 19:25.48 | gtjoseph | Yeah, I think that does fall into "can't fix everything". for now anyway. |
| 19:26.04 | gtjoseph | i've got a phoneprov revist on my list anyway |
| 19:30.25 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-tvreuhwogxcwausy) |
| 19:30.36 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:30.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:37.51 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-wamrcmirdjfqhruj) |
| 19:37.51 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 19:39.50 | coreyfarrell | gtjoseph: so one thing I don't see how using an ao2_iterator instead of ao2_callback in users_apply_handler makes it more straight forward.. |
| 19:40.50 | newtonr | User on the wiki asks "Can you confirm that Asterisk PJSIP supports TLS encryption using a 2048-bit certificate?" If someone has the answer, I'll convey it back to him. |
| 19:40.51 | coreyfarrell | I don't want to hold up the fix, but that change doesn't make much sense to me |
| 19:41.02 | gtjoseph | there's no worry about the callback return value, OBJ_NODATA, etc. Get the container and iterate over it. It also eliminates a lot of overhead in the ao2_traversal code. |
| 19:41.55 | gtjoseph | unless the callback is controlling the traversal with it's return code, there's no point. |
| 19:49.20 | coreyfarrell | gtjoseph: replied.. |
| 20:25.52 | rmudgett | You are going to pay for the ao2 traversal either way. Though the iterator has to figure out where you were before finding the next object. With the iterator, if you leave the container unlocked it could change over the iterator. |
| 20:26.09 | rmudgett | *iteration. |
| 20:32.49 | gtjoseph | the code path through internal_ao2_iterator_next is still a lot shorter than internal_ao2_traverse. plus for someone looking at the code for the firs time, it's a lot more obvious that you're iterating over the items in the container |
| 20:37.54 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 20:40.48 | coreyfarrell | if anyone has a chance I'd like opinions about https://reviewboard.asterisk.org/r/4391/ - specifically about using astman_send_error to respond when the command ran successfully but we failed to process output. |
| 20:45.28 | mjordan | ugh |
| 20:45.33 | mjordan | that's one of those nasty gray areas. |
| 20:46.09 | coreyfarrell | yeah... that's why I'm seeking other opinions to either back me up or tell me to back off |
| 20:48.12 | coreyfarrell | current behavior is to respond with success and provide no lines of output for the situations I'm concerned about.. |
| 20:48.58 | superscrat | coreyfarrell, you were in my queue for today. I am stuck on a pjsip problem atm. sigh. so, I have regressed to eating cake. |
| 20:57.43 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-ocgarnwubaqlduzt) |
| 20:57.49 | *** join/#asterisk-dev angler (angler@pdpc/sponsor/digium/angler) |
| 20:59.33 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 20:59.37 | coreyfarrell | superscrat: no worries.. none of the reviews I have open right now are really high priority, most of them are fixes for tickets that have been open 2 years or more. |
| 21:05.46 | superscrat | so, I guess that gives me a little bit of time to eat my cake. |
| 21:07.13 | coreyfarrell | mjordan: I assume that once r4391 is approved starpy will need to be updated to support the new format before we commit to trunk. is that done with a pull request to github? or is starpy going to move to gerrit? |
| 21:14.53 | mjordan | github |
| 21:15.03 | mjordan | I'm not sure we really "own" it, despite using it. |
| 21:23.06 | russellb | starpy? i think so, it's not maintained by anyone else |
| 21:23.14 | russellb | i pinged the maintainer about it long ago before putting it up on github |
| 21:23.16 | russellb | he was happy with it |
| 21:23.32 | russellb | original maintainer that is |
| 21:23.48 | russellb | importing into gerrit and mirroring to github makes sense to me |
| 21:23.51 | mjordan | ah. |
| 21:23.55 | mjordan | That's cool. |
| 21:24.05 | mjordan | ponders if the projects should start living in namespaces |
| 21:24.19 | russellb | it's kinda handy to mirror to github, since everyone looks for projects there |
| 21:26.25 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-npgubmuanfozypvw) |
| 21:31.12 | russellb | mjordan: there be dragons there |
| 21:31.35 | mjordan | russellb: orly |
| 21:31.46 | russellb | well, couple of things ... |
| 21:31.59 | russellb | it could lead to drama about what is "in" vs. "out" whatever the main namespace is |
| 21:32.23 | mjordan | ah. Yeah, I was mostly thinking of it in terms of "asterisk" and "apistuff" |
| 21:32.31 | mjordan | but a lot of times that is kind of obvious. |
| 21:32.37 | russellb | yeah, might not be a real issue |
| 21:32.51 | russellb | other thing is if it was set up such that things might need to move from one to the other, apparently that's a big pain |
| 21:33.01 | mjordan | I could see it being so. |
| 21:33.05 | mjordan | It's probably not worth it. |
| 21:33.14 | russellb | i don't know details, but it requires infrastructure downtime and admin action |
| 21:33.17 | mjordan | I can't see us getting over 100 projects or so, and I doubt we're going to have naming collisions. |
| 21:33.29 | russellb | (for the gerrit part that is) |
| 21:33.53 | mjordan | not to mention that if someone really wants to add 20 projects - such as for the voicemail replacement - they could just namespace/group their projects. |
| 21:34.07 | russellb | on the other hand, if the group is obvious and unlikely to ever change |
| 21:34.09 | russellb | it could work |
| 21:34.32 | russellb | like, maybe you want an asterisk namespace and a respoke namespace |
| 21:34.36 | mjordan | russellb: ah, btw, meant to ask you. I've had a lot of issues recently getting Zuul to stay connected to Gerrit, and Gearman to stay in sync with Jenkins. Once I get some concrete questions worked out and/or can pinpoint wtf is happening, where's the best place to ask questions? |
| 21:34.40 | russellb | which would line up with how you'd group them in github orgs |
| 21:34.44 | russellb | that seems kinda sane |
| 21:34.49 | mjordan | russellb: aye |
| 21:34.58 | russellb | the best place is either #openstack-infra, or the openstack-infra mailing list |
| 21:35.02 | mjordan | kk |
| 21:35.31 | mjordan | I'd prefer to have something patch-ish in hand if I can kind of pinpoint what is happening |
| 21:40.21 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 22:28.56 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 22:29.41 | *** join/#asterisk-dev danjenkins (~anonymous@cpc11-folk2-2-0-cust171.1-2.cable.virginm.net) |
| 22:35.08 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-xqbvtihtujanendx) |
| 22:37.33 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:03.40 | coreyfarrell | gtjoseph: you're pushing those two commits to trunk as well right? sorry to bug you if you're working on it, just wanted to catch you before you were done for the day. |
| 23:06.48 | gtjoseph | HA! I forgot. |
| 23:07.35 | coreyfarrell | well then I'm not sorry to bug you |
| 23:11.14 | gtjoseph | stupid svn. how do you get around the "no integration info available" after a failed merge? |
| 23:11.36 | gtjoseph | nevermind |
| 23:11.38 | coreyfarrell | svn revert . --recursive; try again |
| 23:12.31 | gtjoseph | yep, that was it. trunk merges done. |
| 23:12.37 | coreyfarrell | yeah I really hate SVN I can't wait until next week when I can 'apt-get remove subversion' |
| 23:12.44 | gtjoseph | no kidding |
| 23:20.32 | coreyfarrell | gtjoseph: looking at your description of load/unload order in r4610 kind of makes me wish that res_pjsip_config_wizard was replaced with 'res/res_pjsip/config_wizard.c' - and just linked into res_pjsip.so |
| 23:21.05 | gtjoseph | funny, i was thinking the same thing for some other 'core' pjsip modules as well. |
| 23:21.50 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-uklazsedjigsixae) |
| 23:22.42 | coreyfarrell | yeah... I mean I definitely like that pjsip is split up to multiple sources, and some of the auxiliary modules really make sense to be modules, but for other stuff I wish there were less modules |
| 23:23.00 | gtjoseph | +1000 |
| 23:26.37 | coreyfarrell | so what happens to pjsip if you noload=res_pjsip_config_wizard.so ? |
| 23:27.02 | gtjoseph | not a thing. |
| 23:27.36 | gtjoseph | no config_wizard means no sorcery wizards are inserted and res_pjsip is none the wiser |
| 23:28.04 | coreyfarrell | I really need to (eventually) learn sorcery |
| 23:28.46 | gtjoseph | run away! run away! |
| 23:33.02 | coreyfarrell | can't be as bad as pbx.c |
| 23:33.19 | gtjoseph | that is quite true. |
| 23:35.44 | coreyfarrell | yeah... last I looked at pbx.c was trying to solve ASTERISK-24774... no such luck, then I think I remembered that I don't hate myself so I stopped looking at it |
| 23:36.50 | file | it depends upon what layer you are mucking with things in sorcery |
| 23:37.29 | *** join/#asterisk-dev leedm777 (~leedm777@216.186.181.138) |
| 23:38.10 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 23:38.45 | gtjoseph | true. there's a big difference between working with sorcery and working in sorcery. :) |
| 23:38.56 | file | quite |
| 23:39.37 | coreyfarrell | understanding how it is consumed / interaction between multiple consumers would be enough for me I think |
