| 00:09.49 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 00:09.49 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 00:43.46 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 01:34.42 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 02:09.12 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-15-115.baf.movistar.cl) |
| 02:32.24 | *** join/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 02:32.35 | *** part/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 02:39.31 | *** join/#asterisk-dev tonyclewis (uid6025@gateway/web/irccloud.com/x-todmymkpuavzyymx) |
| 03:32.13 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 03:40.21 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 04:00.38 | *** join/#asterisk-dev leedm777 (~leedm777@50-81-28-152.client.mchsi.com) |
| 04:04.44 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 04:13.06 | *** join/#asterisk-dev superscrat (~asanders@173-17-133-2.client.mchsi.com) |
| 05:10.23 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 05:10.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:16.03 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 06:16.03 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:06.47 | *** join/#asterisk-dev hehol (~hehol@2001:1438:1009:200:1815:2aaf:bfe5:555c) |
| 07:07.31 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:07.31 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:07.28 | skrusty | morning |
| 08:13.58 | *** join/#asterisk-dev oej (~oej@217.142.152.52) |
| 08:13.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:37.41 | TazzNZ | morning |
| 08:51.43 | *** join/#asterisk-dev oej (~oej@217.142.152.52) |
| 08:51.43 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:13.25 | *** join/#asterisk-dev oej (~oej@217.142.152.52) |
| 09:13.25 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:01.20 | *** join/#asterisk-dev jrose_atDigium (jrose_atDi@nat/digium/x-godpuqenaaggccyy) |
| 10:53.21 | *** join/#asterisk-dev oej (~oej@217.142.152.52) |
| 10:53.21 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:12.40 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 11:14.50 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 11:14.58 | *** part/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 11:25.50 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 11:25.50 | *** mode/#asterisk-dev [+o jsmith] by ChanServ |
| 11:42.06 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 11:42.17 | *** part/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 12:33.03 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:19.15 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-15-115.baf.movistar.cl) |
| 13:22.45 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-zsstdqdrdrhfqwpr) |
| 13:49.12 | *** join/#asterisk-dev sgalarneau (sgalarneau@nat/digium/x-cjwcpzzekachafsx) |
| 14:01.01 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 14:08.37 | *** join/#asterisk-dev sgriepentrog (sgriepentr@nat/digium/x-tbtysjixoweuifgk) |
| 14:11.45 | *** join/#asterisk-dev roramirez (~rodrigo@190.54.225.167) |
| 14:18.56 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 14:19.27 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-nmzyuycdhkexuuih) |
| 14:19.27 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:19.50 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-vvdsvxvitzollcfq) |
| 14:28.37 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 14:28.38 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 14:29.29 | *** join/#asterisk-dev Corydon76 (~quassel@c-69-137-93-158.hsd1.tn.comcast.net) |
| 14:29.29 | *** mode/#asterisk-dev [+o Corydon76] by ChanServ |
| 14:33.34 | roramirez | Hello! |
| 14:33.47 | mjordan | hello |
| 14:34.57 | roramirez | i am playing with Asterisk with PostgreSQL this week. |
| 14:35.27 | roramirez | im confused about with a topic |
| 14:35.57 | jsmith | loves Asterisk and PostgreSQL |
| 14:36.28 | roramirez | me too jsmith |
| 14:38.56 | jsmith | roramirez: What topic are you confused about? |
| 14:39.16 | roramirez | my problem is the cdr_adaptive_odbc called a *find_table of res_config_pgsql when drivers is pgsql. But i dont know how identified the driver. All this is because a find a little bug the cdr_adaptive_odbc and PostgreSQL, i would like to solve |
| 14:48.25 | mjordan | roramirez: I'm not sure I understand the question. Are you saying cdr_adaptive_odbc calls into res_config_pgsql? |
| 14:50.28 | Corydon76 | Apparently I rejoined at the right moment |
| 14:50.30 | *** join/#asterisk-dev ipengineer_ (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 14:50.55 | roramirez | sorry mjordan, i try explain more details |
| 14:53.58 | roramirez | when i load the module cdr_adaptive_odbc with PostgreSQL, this get the columns of cdr table. The query to execute is on res/res_config_pgsql |
| 14:54.25 | roramirez | i dont know how identified this |
| 14:54.55 | Corydon76 | Those are two different subsystems |
| 14:55.29 | Corydon76 | All of the ODBC stuff descends into system libraries before it hits the Postgres database |
| 14:56.14 | Corydon76 | res_config_odbc is for realtime configs, and it hits the Postgres database directly |
| 14:56.37 | roramirez | the problem is the end is a reserved keyword on PostgreSQL, when is execute insert into is failed. Then i want add double quote the columns when i used odbc with PostgreSQL |
| 14:56.43 | Corydon76 | Err, sorry, res_config_pgsql |
| 14:57.35 | Corydon76 | Okay, where is the "end" fieldname? |
| 14:57.42 | roramirez | yep |
| 14:57.59 | Corydon76 | Is that a custom fieldname you've defined? |
| 14:58.20 | Corydon76 | Is there a reason why you can't just choose another fieldname? |
| 14:58.29 | roramirez | no is a custom field |
| 14:59.05 | roramirez | let me check please this |
| 14:59.06 | Corydon76 | How about if you rename the field "fin"? |
| 15:00.36 | roramirez | Corydon76: yep, is a good idea |
| 15:01.29 | Corydon76 | The problem with quoting field names, btw, is that there's no standard way of doing this. Postgres uses the double-quote. MySQL uses the backtick. MS SQL Server uses the square brackets. |
| 15:01.36 | roramirez | but is not possible add double quote on cdr_adaptive_odbc when driver is pgsql?, i thinks this can prevent this problem |
| 15:02.36 | roramirez | yep, i know that, but identified on log before what driver is used and apply respective case |
| 15:02.41 | Corydon76 | And while ODBC can do many things, trying to work through that problem is fraught with peril, just like the backslash_is_escape field value, which is just about impossible to work with. |
| 15:03.11 | Corydon76 | The driver used is all handled at a lower layer that we really don't have good visibility into |
| 15:03.43 | Corydon76 | And even when we do, there's no way we can predict how it should work for other databases unknown to us |
| 15:04.12 | Corydon76 | That's why the backslash_is_escape configuration value exists in res_odbc.conf |
| 15:05.09 | roramirez | okey i understand |
| 15:05.52 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 15:05.52 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:08.44 | roramirez | thanks Corydon76 |
| 15:09.04 | Corydon76 | yw |
| 15:17.34 | roramirez | with this parameter backslash_is_escape quote the columns, i dont have the failed. Sorry for yours time |
| 15:19.55 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-uwletrsupbdoxgrr) |
| 15:22.03 | roramirez | no, sorry, i have the sample problem :( |
| 15:22.27 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-eyedwejgnirxzkbz) |
| 15:22.28 | roramirez | http://pastebin.com/jj8qr3Na |
| 15:25.05 | roramirez | the problem is the quote on columns name of insert into |
| 15:25.46 | roramirez | for PostgreSQL must be " |
| 15:34.52 | Corydon76 | Yep, I would recommend that you read up on the "alias" definitions in the sample cdr_adaptive_odbc.conf file. |
| 15:35.16 | Corydon76 | and change your field name |
| 15:35.36 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 15:35.36 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 15:48.50 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 16:01.41 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 16:01.41 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 16:09.54 | *** join/#asterisk-dev newtonr (~RustyNewt@173-21-90-203.client.mchsi.com) |
| 16:09.54 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 16:31.46 | ipengineer | I came across an issue last night with 13.3.2 and PJSIP 2.4 where Asterisk crashes with a malformed SIP packet. I moved the device to chan_sip and it does not crash. Asterisk throws an error saying it is dropping the packet. https://gist.github.com/zconkle/46d73d36b8848c002aea |
| 16:36.00 | file | that's low level PJSIP parser... and I see no crash there... |
| 16:36.07 | file | I also sent the packet to my own and it did not crash |
| 16:38.41 | file | lunch! |
| 16:39.48 | ipengineer | Yea.. If I put this device back to chan_pjsip it will consistently crash, asterisk restarts and then after a minute once these packets start coming in it crashes again. It does this repeatedly.. I can get you the coredump files if that helps.. It does it when there are a chunk of them I guess not on the first packet. We had several phones doing this (bad network device). Once changed to chan_sip no longer an issue.. |
| 16:44.45 | ipengineer | file: Here is the coredump if it helps.. I am fixing to run to a meeting but will be back later.. Let me know if I can do anything to help. I can also create an issue if need be. Looks like the problem is here: res_pjsip/pjsip_distributor.c https://gist.github.com/zconkle/1a85cdb3b04b02298d95 |
| 16:47.18 | mjordan | ipengineer: you have asserts triggered in pjproject |
| 16:47.32 | mjordan | ipengineer: that's not surprising if you send it a malformed packet. Have you compiled pjproject without asserts? |
| 16:48.25 | ipengineer | mjordan: I passed these options: â./configure --libdir=/usr/lib64 --prefix=/usr --enable-shared --disable-sound --disable-resample --disable-video --disable-opencore-amrâ |
| 16:50.53 | ipengineer | mjordan: Basically followed what was in the wiki.. I see where it mentions asssertions on step two⦠I had not seen the âCFLAGSâ option before |
| 16:52.48 | ipengineer | Going to be late for the meeting.. Thanks for the heads up I will recompile and see what that does for us. |
| 16:55.58 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 16:56.48 | coreyfarrell | are we planning to keep using "Review: https://gerrit.asterisk.org/..." in the commit messages? Seems like the Change-Id does just fine to associate a commit with it's review. adding the gerrit URL requires committing, submitting review, changing the commit msg, then updating the review. commit messages would have to be modified for each cherry-pick since they will have different gerrit urls. |
| 16:57.22 | mjordan | coreyfarrell: I don't think the Review: header adds any value. |
| 16:57.36 | mjordan | as you said, ChangeId already provides that |
| 17:00.13 | *** join/#asterisk-dev russellb (~russellb@redhat/russellb) |
| 17:00.13 | *** mode/#asterisk-dev [+o russellb] by ChanServ |
| 17:09.12 | file | coreyfarrell, test failed. |
| 17:23.22 | newtonr | it is not a real test |
| 17:23.28 | newtonr | only a ruse |
| 17:23.48 | coreyfarrell | mjordan: mind if I edit the wiki Commit Messages page - planning to just remove the section that says to add Reviewboard url's. |
| 17:25.41 | gtjoseph | what about the "Tested-by" tag as well? |
| 17:28.59 | coreyfarrell | gtjoseph: I think that has a different use. if someone reports an issue for an odd platform, we post a patch to JIRA so they can test it, then post to gerrit even though we can't test it. |
| 17:29.28 | gtjoseph | hmmm. I thought we were supposed to use it for all issues. |
| 17:30.14 | gtjoseph | I need to spend a quiet day with the wiki. :) |
| 17:31.12 | coreyfarrell | it's entirely possible I've been doing it wrong the whole time. I've only ever used Tested-by to mention people who were not on reviewboard. |
| 17:44.54 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 17:44.54 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 17:47.17 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 17:47.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:49.15 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-15-115.baf.movistar.cl) |
| 18:05.35 | rmudgett | I'm not sure how useful the Tested-by header is. I haven't used it in quite a long time. |
| 18:07.02 | mjordan | rmudgett: it shows up in release summaries. |
| 18:07.19 | mjordan | which is nice to give props to the folks who helped test a patch |
| 18:07.49 | mjordan | coreyfarrell: and apologies that I missed your question earlier, but yes, feel free to edit away |
| 18:07.58 | mjordan | it is a wiki, so if I really hate it, I'll complain to you :-) |
| 18:08.28 | mjordan | and yes, the only purpose of tested by is to give props to people on the release summaries. Nothing else looks for it. |
| 18:08.40 | mjordan | And it does have to be done manually by the committer, and they can put anyone they want there |
| 18:15.21 | *** join/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 18:20.45 | *** part/#asterisk-dev italorossi (~Adium@187.60.66.11) |
| 18:29.32 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-nuftivynsfxahlvp) |
| 18:30.24 | coreyfarrell | mjordan: sounds great. I've actually gone a bit farther on the edit, removed other stuff that was SVN specific and added a reference to the Gerrit Usage page. |
| 18:31.31 | newtonr | coreyfarrell, I'm going to make a new jira component for Core/ACL as Core/General seems to be the only other that would fit, but is a bit vague. |
| 18:35.09 | coreyfarrell | sounds good to me. |
| 18:41.54 | mjordan | coreyfarrell: thanks - I missed that page in my SVN purging |
| 18:42.11 | coreyfarrell | np |
| 18:45.32 | *** join/#asterisk-dev TazzNZ (~TazzNZ@office-nat1.ytechops.co.nz) |
| 18:58.29 | *** join/#asterisk-dev roramirez (~rodrigo@186-78-18-119.baf.movistar.cl) |
| 19:06.20 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 19:06.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 19:09.39 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 19:30.28 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-ijppoegbeupnuppv) |
| 20:01.22 | *** join/#asterisk-dev ipengineer (~zconkle@static-71-252-134-63.dllstx.fios.verizon.net) |
| 20:21.38 | roramirez | hello |
| 20:24.12 | roramirez | i thinks there is a little problem on doc for to used PostgreSQL as backend on cdr |
| 20:25.58 | roramirez | for MySQL is set by default '' https://wiki.asterisk.org/wiki/display/AST/MySQL+CDR+Backend |
| 20:26.12 | roramirez | but not on PostgreSQL https://wiki.asterisk.org/wiki/display/AST/PostgreSQL+CDR+Backend |
| 20:27.06 | roramirez | if you make a call via "console dial" the values for peeraccount, linkedid and sequence are NULLs |
| 20:43.33 | mjordan | I wouldn't generally expect those values to be NULL |
| 20:43.41 | mjordan | well |
| 20:44.00 | mjordan | yeah... even peeraccount should get a "" written into it |
| 20:55.42 | roramirez | let me check, now i am using cdr_odbc |
| 20:56.59 | roramirez | + pgsql |
| 21:04.08 | roramirez | The log http://pastebin.com/u6cKpYkr |
| 21:04.30 | roramirez | is not include the new columns on cdr for into to the table |
| 21:06.17 | roramirez | i found the problem. The cdr/cdr_odbc.c execute_cb line 81 |
| 21:06.56 | mjordan | cdr_odbc is pretty much unsupported |
| 21:08.13 | mjordan | roramirez: yeah, that file probably wasn't updated to take into account changes in 1.8. cdr_adaptive_odbc is what is recommended for use. |
| 21:08.22 | coreyfarrell | mjordan: any ideas on what will replace the reviewboard security group? |
| 21:08.49 | mjordan | coreyfarrell: Nope. Drafts get published publicly. For now, we might have to use reviewboard for that. |
| 21:08.56 | mjordan | I was hoping to have some time to figure that part out :-) |
| 21:09.08 | mjordan | er, I should clarify: drafts on gerrit get published publicly |
| 21:09.19 | mjordan | there is an open issue in the gerrit issue tracker for that feature, and it is getting attention |
| 21:09.32 | coreyfarrell | ah cool |
| 21:09.41 | coreyfarrell | btw drafts are "half" published. |
| 21:09.47 | mjordan | https://bugs.launchpad.net/openstack-ci/+bug/902052 |
| 21:09.55 | mjordan | coreyfarrell: yeah, I think that's a bug |
| 21:10.10 | coreyfarrell | the code itself is not made available until the review is fully published |
| 21:10.23 | mjordan | coreyfarrell: due to SSH issues with Zuul, I'm probably going to update us to 2.10.3 this weekend, as that is supposed to fix some of the SSH issues. We might get lucky on the draft stuff :-P |
| 21:10.49 | roramirez | mjordan: not fixed cdr_odbc? i could will fix this error. Or later you will deprecated the module? |
| 21:10.57 | gtjoseph | mjordan: does/did bamboo manage trunk? |
| 21:11.16 | mjordan | roramirez: I can't recall why it isn't deprecated, actually. I vaguely recall there was one thing it did that cdr_adaptive_odbc did not do, but I can't recall. |
| 21:11.26 | mjordan | gtjoseph: what do you mean manage trunk? |
| 21:11.35 | mjordan | roramirez: you're more than welcome to fix it thought |
| 21:11.36 | mjordan | er, though |
| 21:11.38 | gtjoseph | i.e did it test trunk |
| 21:11.46 | mjordan | gtjoseph: yes, it should test master now |
| 21:11.55 | gtjoseph | thx |
| 21:11.59 | mjordan | roramirez: patches for extended, and even deprecated modules, are still accepted |
| 21:12.24 | mjordan | coreyfarrell: the actual review: https://review.openstack.org/#/c/47937 |
| 21:13.08 | mjordan | looks like it is kind of stalled out, and the 'set up a private gerrit instance' isn't what I was hoping for. |
| 21:13.11 | mjordan | Hm. |
| 21:13.30 | mjordan | Hopefully they do something more along the lines of review board w/ review groups; otherwise, we'll have to stick with review board for security reviews and/or JIRA |
| 21:13.56 | coreyfarrell | yeah seems like if it comes to something like that it would be better to setup a private mirror of the asterisk repo, setup that repo with restricted access in gerrit |
| 21:14.18 | mjordan | which might be what they decided to do |
| 21:14.41 | roramirez | thanks mjordan, i try fixed, i new on the code of Asterisk |
| 21:16.06 | mjordan | roramirez: no worries. Looks like you're also joining when we're in a bit of a state of flux, since we're in the process of moving to Git |
| 21:16.26 | mjordan | roramirez: if you haven't yet, do take a look at the Gerrit/Git docs on the wiki |
| 21:16.34 | mjordan | roramirez: as well as the coding guidelines |
| 21:17.01 | mjordan | https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines |
| 21:17.51 | coreyfarrell | there was talk on -dev about changing the subjects of gerrit emails, any chance we can remove the words "Change in "? I use my phone to read messages, example of what is shown for a subject: "[Asteri...] Change in asterisk[master]: B..." |
| 21:18.39 | mjordan | to just: |
| 21:18.42 | mjordan | asterisk[master] |
| 21:18.43 | mjordan | ? |
| 21:18.47 | gtjoseph | +1 |
| 21:18.50 | mjordan | kk |
| 21:18.53 | mjordan | I'll put it on the list :-D |
| 21:19.02 | gtjoseph | i've got some suggestions about the content as well |
| 21:19.05 | mjordan | that will probably require learning Gerrit's e-mail templates |
| 21:19.17 | gtjoseph | yeah, I just looked at them and it's not hard |
| 21:19.18 | mjordan | gtjoseph: coreyfarrell: how about putting together a wish list on the -dev list |
| 21:19.26 | mjordan | that way we can do it in one shot |
| 21:19.28 | gtjoseph | that's what I'm doing now :) |
| 21:19.30 | mjordan | lol |
| 21:19.32 | mjordan | perfect! |
| 21:19.33 | mjordan | thanks :-) |
| 21:19.55 | gtjoseph | Subject: A Week With Git/Gerrit |
| 21:21.39 | mjordan | the good! |
| 21:21.40 | mjordan | the bad! |
| 21:21.43 | mjordan | the horrible! |
| 21:22.46 | file | the only thing that's annoyed me is gerrit jumping around in some reviews if I move my scrollbar |
| 21:36.43 | file | Asterisk: Now with extra git! |
| 21:39.57 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-otwzcenjheekrdjk) |
| 22:02.49 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-218-28-58.cablep.bezeqint.net) |
| 22:02.49 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:10.54 | mjordan | gtjoseph: nice e-mail :-) |
| 22:18.22 | gtjoseph | thanks. i'm sure other things will come to mind shortly. :) |
| 22:18.45 | gtjoseph | as soon as you try to commit those 6 reviews. :) |
| 22:20.46 | *** join/#asterisk-dev newtonr (~RustyNewt@173-21-90-203.client.mchsi.com) |
| 22:20.46 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 22:25.17 | *** part/#asterisk-dev mjordan (mjordan@nat/digium/x-nmzyuycdhkexuuih) |
| 22:36.47 | gtjoseph | coreyfarrell: have you or will you create a wiki page on how to use the weakproxy objects? |
| 22:50.55 | coreyfarrell | gtjoseph: I was just about to give you the URL in doxygen.asterisk.org, but it looks like that is still working off svn |
| 22:51.07 | gtjoseph | :) |
| 22:51.55 | gtjoseph | are there actually usage scenarios in there though? |
| 22:52.40 | coreyfarrell | no. the only code that uses it at this point is tests/test_astobj2_weaken.c :( |
| 22:53.36 | gtjoseph | Gotcha. Might be nice to write something up for the wiki on how and when to use them |
| 22:59.20 | coreyfarrell | I have to think about it more, find a "simple" use case to explain. |
| 23:00.03 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-vvbpgrrxbmnszztr) |
| 23:07.32 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-vvdsvxvitzollcfq) |
| 23:25.27 | *** join/#asterisk-dev leedm777 (~leedm777@216.186.181.138) |
| 23:27.59 | coreyfarrell | gtjoseph: a long time ago you had something specific in mind for weak containers, do you remember what it was? |
| 23:28.51 | gtjoseph | yeah, it was any place we do an immediate ao2_ref(obj, -1) so when object was deleted from the container it would automatically get cleaned up |
| 23:44.00 | *** join/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 23:46.34 | *** part/#asterisk-dev italorossi (~Adium@179.211.186.236) |
| 23:48.51 | *** join/#asterisk-dev leedm777 (~leedm777@216.186.181.138) |