| 00:14.38 | *** join/#asterisk-dev mjordan_ (mjordan@nat/digium/x-wvteuujrndkssiqw) |
| 00:14.38 | *** mode/#asterisk-dev [+o mjordan_] by ChanServ |
| 00:14.44 | mjordan_ | file: GREETINGS COMRADE |
| 00:15.45 | file | mjordan_, HELLO |
| 00:16.05 | mjordan_ | so... |
| 00:16.11 | mjordan_ | I can't recall ye olde rules of IPv6 |
| 00:16.18 | mjordan_ | but can you specify an IPv6 address without the brackets? |
| 00:16.20 | file | there are no rules, IT'S A FREE FOR ALL |
| 00:16.20 | mjordan_ | i.e. |
| 00:16.26 | mjordan_ | ::1 == [::1]? |
| 00:16.36 | mjordan_ | e.g. |
| 00:16.37 | mjordan_ | c=IN IP6 ::1 |
| 00:16.49 | file | I don't... remember... |
| 00:17.07 | file | that's an RFC for that though! |
| 00:17.18 | mjordan_ | good point |
| 00:17.20 | mjordan_ | I shalt do my homework |
| 00:17.29 | file | apparently fine |
| 00:17.47 | file | yeah, cause the IP6 specifies it as IPv6 so it's fine |
| 00:18.06 | mjordan_ | The answer is open |
| 00:18.10 | mjordan_ | So. |
| 00:18.11 | mjordan_ | Yeah. |
| 00:18.22 | mjordan_ | At some point in time, PJSIP started using both [::1] and ::1 |
| 00:18.28 | file | imagines IPv6 being randomly enabled on DigiNet and the hilarity that would ensue |
| 00:18.34 | mjordan_ | It does not appear to be consistent. And could even be dependent on the version. |
| 00:18.42 | mjordan_ | file: Hilarity is a kind word. |
| 00:18.56 | mjordan_ | so my regexs in tests are now very wrong. |
| 00:19.00 | file | that should be in res_pjsip_sdp_rtp |
| 00:19.35 | file | takes a gander |
| 00:19.43 | file | er, well |
| 00:20.07 | file | maybe in our land... |
| 00:21.13 | file | got it |
| 00:21.28 | file | it was a result of the local host IP caching and consolidation |
| 00:22.20 | mjordan_ | ah |
| 00:22.28 | mjordan_ | so it should only affect the SDP connection address |
| 00:22.35 | file | yes |
| 00:22.45 | mjordan_ | nifty |
| 00:22.45 | file | we can make it so it doesn't put [] in |
| 00:22.48 | mjordan_ | nah |
| 00:22.54 | mjordan_ | Easier to just fix the regex |
| 00:23.20 | file | I'm not sure those words have ever been said |
| 00:26.33 | mjordan_ | I know, right? |
| 00:27.23 | file | and just like that in it goes |
| 00:28.51 | file | my kingdom for audio normalization across all media in the universe |
| 00:35.16 | file | huh |
| 00:35.36 | file | sipp is being weird in the pjsip directmedia_reinvite_t38 test |
| 00:35.45 | mjordan_ | hm. |
| 00:35.51 | file | it's not doing what it's told to do? |
| 00:35.52 | mjordan_ | the RTCP stuff is actually disconcerting. |
| 00:35.59 | mjordan_ | weird. |
| 00:36.46 | file | it's not sending a re-invite.. |
| 00:37.50 | mjordan_ | er |
| 00:37.52 | mjordan_ | rut roh |
| 00:39.27 | mjordan_ | want to read something slightly terrifying regarding thread safety? |
| 00:39.43 | mjordan_ | http://pastebin.com/KMuHp5qS |
| 00:39.43 | file | is that a trick question? |
| 00:40.15 | file | I've read that 3 times and don't get it |
| 00:40.42 | mjordan_ | well |
| 00:40.47 | mjordan_ | using ast_json_pack |
| 00:40.59 | mjordan_ | we are ref bumping an item implicitly using the pack parameters s: O |
| 00:41.05 | mjordan_ | that ref bump is not thread safe. |
| 00:41.30 | file | ah |
| 00:41.31 | mjordan_ | so if that item happens to be used in multiple locations by multiple consumers, the ref counting is not atomic |
| 00:41.41 | mjordan_ | in reality |
| 00:41.42 | file | well CRAP |
| 00:41.44 | mjordan_ | not sure it will happen |
| 00:41.53 | mjordan_ | since we don't share objects typically when adding them to messages |
| 00:42.00 | mjordan_ | well |
| 00:42.05 | mjordan_ | typically we don't. |
| 00:42.16 | mjordan_ | But we should probably replace em all with s: o and an explicit ast_json_ref |
| 00:44.00 | file | erm |
| 00:44.35 | file | the add_log and rotate_log Asterisk logs do not exist |
| 00:45.23 | file | I mildly disapprove of this, but I see what's happening - Asterisk is shutting down before StasisEnd is sent out and received |
| 00:46.29 | mjordan_ | er |
| 00:46.42 | mjordan_ | yeah, we can not rely on stasisend |
| 00:46.48 | mjordan_ | but it shouldn't be doing that anyway. |
| 00:47.14 | mjordan_ | this doesn't look right - http://pastebin.com/j3GENaLu |
| 00:48.08 | file | maybe? |
| 00:50.39 | mjordan_ | well, that test is sending RTCPReceiver reports when it should only send RTCPSender |
| 00:50.55 | mjordan_ | that means it would have one way audio - it is not sending RTP |
| 00:55.48 | file | and on that bombshell - bed |
| 00:59.06 | mjordan_ | nope, red herring. Nuts. |
| 00:59.09 | mjordan_ | g'night! |
| 01:07.37 | leifmadsen | pffft |
| 01:12.55 | mjordan_ | git bisect to the rescue |
| 01:41.09 | mjordan_ | hm |
| 01:41.13 | mjordan_ | twas the scheduler patch - 5c713fdf18ffa934e0cac8ddb29e4ad95a68200b |
| 01:42.01 | mjordan_ | that's ... ungood. |
| 05:04.45 | *** join/#asterisk-dev seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 05:04.45 | *** mode/#asterisk-dev [+o seanbright] by ChanServ |
| 05:05.27 | *** join/#asterisk-dev opticron (~opticron@75.76.201.152) |
| 05:05.28 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 06:58.58 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:00.25 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:10.44 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:16.46 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:16.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:21.11 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:21.11 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:44.04 | *** join/#asterisk-dev infobot (ibot@69-58-76-73.ut.vivintwireless.net) |
| 11:44.04 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Hell hath frozen over: Asterisk is moving to Git -=- Follow on Twitter at @AsteriskDev |
| 12:03.37 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 12:03.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 12:31.22 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:03.10 | jsmith | file: I hear congratulations are in order... |
| 13:03.42 | file | sure |
| 13:04.01 | file | although it would be nice if my email stopped exploding and my phone stopped vibrating |
| 13:12.06 | seanbright | file: congrats! |
| 13:12.19 | seanbright | not sure what for, but it's well deserved i'm sure |
| 13:13.51 | file | it is! I'm now the boss of mjordan! |
| 13:13.58 | Marquis42 | waaaaat |
| 13:13.58 | seanbright | finally! |
| 13:14.08 | Marquis42 | I thought you already told him what to do. ;) |
| 13:14.14 | file | I'm taking engineering in a new direction |
| 13:14.22 | Marquis42 | orly |
| 13:14.24 | file | I call it: cloud synergistic REST APIs |
| 13:14.30 | seanbright | written in go |
| 13:14.32 | Marquis42 | haha |
| 13:14.34 | seanbright | (... fuck yourself) |
| 13:14.36 | file | seanbright, what? no |
| 13:14.36 | file | java |
| 13:14.38 | zerohalo | ha |
| 13:14.39 | Marquis42 | lolz |
| 13:14.41 | seanbright | file: thank you |
| 13:14.44 | file | for maximum platform support |
| 13:15.15 | seanbright | java's support for realtime media is second to none |
| 13:15.27 | file | who said anything about realtime media? store and forward! |
| 13:15.49 | seanbright | revolutionary! |
| 13:20.58 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 13:20.58 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:50.02 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-jujqcsimwgflnift) |
| 13:50.02 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:54.23 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-lvoaijzkzaoenxch) |
| 13:57.07 | stefan27 | thanks for your answers yesterday coreyfarrell and rmudgett - they helped |
| 13:58.07 | file | stefan27, did you get to the bottom of it? |
| 14:11.21 | stefan27 | Not quite, but I'm not the real "issue owner". In the case of the bad magic numbers, I was just asked to assist in testing an experimental ast module designed by a colleague. There's no error in the clean asterisk |
| 14:11.51 | file | ack |
| 14:54.40 | stefan27 | In ast_rtp_read in the case of video frame, we set rtp->f.subclass.frame_ending = mark; where mark seems to range from 0, 1 or 1^23 (if I traced it correctly). This is bad I think, because in ast_rtp_raw_write we fetch mark=frame->subclass.frame_ending and seem to assume that mark is 0 or 1 because we do a (mark << 23) |
| 14:55.57 | file | marker bit should be on or off |
| 14:56.12 | stefan27 | ast_rtp_read does mark = seqno & (1 << 23); |
| 14:56.41 | stefan27 | then stores it as rtp->f.subclass.frame_ending = mark; |
| 15:00.19 | stefan27 | I'm guessing it should be converted to a 1 before stored in rtp->f.subclass.frame_ending ? |
| 15:00.51 | stefan27 | converted to a 1 if it's value was 1^23 |
| 15:05.29 | stefan27 | the struct member frame_ending should only take on values 0 or 1? |
| 15:13.38 | stefan27 | a colleague noticed that for a test case with video passthrough rtp marker bits are always set to 0 on the outgoing packets |
| 15:14.46 | stefan27 | The cause seems to be the above, but we only generated this issue on a non-clean asterisk. Can you reproduce this issue? |
| 15:19.18 | stefan27 | or alternatively analyze the code leading up to 'rtp->f.subclass.frame_ending = mark;'. I don't understand the comment /* Pass the RTP marker bit as bit */ |
| 15:25.39 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-jwytcxznnfyaescl) |
| 15:25.53 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-ucpybqmqymrcevpj) |
| 15:26.47 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-wbgzrhbgjnutgcns) |
| 15:29.34 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 15:29.35 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 15:31.32 | file | stefan27, seems like it |
| 15:32.47 | stefan27 | s/if it's value/if its value/ |
| 15:32.55 | stefan27 | my English skills really need to improve |
| 15:33.14 | stefan27 | even if much of it is just sloppyness |
| 15:41.30 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 16:13.11 | *** join/#asterisk-dev doome_ (~doome@77-234-67-65.pool.digikabel.hu) |
| 16:21.47 | stefan27 | If I create a review as draft can you people view it? https://gerrit.asterisk.org/#/c/1388 |
| 16:24.53 | stefan27 | maybe I should take the long route through JIRA, but it's just a one liner which seems to fix the issue |
| 16:26.04 | stefan27 | Though probably it should be rewritten |
| 16:28.45 | stefan27 | I gotta leave the office but I'll have irc logs tomorrow if anyone answers |
| 16:42.30 | *** join/#asterisk-dev spditner (~simon@23.91.132.109) |
| 16:57.51 | rmudgett | stefan27: Only you can see your draft reviews. |
| 17:01.35 | *** join/#asterisk-dev oej (~oej@185.76.74.37) |
| 17:01.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 17:30.20 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-ysrvrpoeeavjrram) |
| 17:30.21 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 17:47.38 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-enchmcrmfroxlyhn) |
| 17:49.02 | kharwell | About to make an rc2 for 11.20 and 13.6. I believe all changes that need to be included have been pushed in, but wanted to double check |
| 17:49.37 | kharwell | file^^^ |
| 17:49.39 | file | I think it's g2g |
| 17:50.09 | kharwell | alrighty thanks |
| 17:50.24 | file | did anyone do a further sched usage audit? |
| 17:51.44 | kharwell | dunno |
| 17:57.45 | file | core usage looks fine |
| 17:58.19 | file | yeah, I think it's fine |
| 17:59.58 | file | kharwell, g2g #2 |
| 18:00.39 | kharwell | file: thanks for taking a look |
| 18:01.12 | file | kharwell, of course! sacrificial lamb |
| 18:18.05 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 18:18.05 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:24.42 | *** join/#asterisk-dev Stefan26 (Stefan27@195-67-255-105-no207.tbcn.telia.com) |
| 20:48.35 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-cxdagendpfyluckv) |
| 20:48.35 | *** join/#asterisk-dev Stefan26 (Stefan27@195-67-255-105-no207.tbcn.telia.com) |
| 20:48.35 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 20:48.35 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-ysrvrpoeeavjrram) |
| 20:48.35 | *** join/#asterisk-dev spditner (~simon@23.91.132.109) |
| 20:48.35 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 20:48.35 | *** join/#asterisk-dev superscrat (asanders@nat/digium/x-wbgzrhbgjnutgcns) |
| 20:48.35 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-ucpybqmqymrcevpj) |
| 20:48.35 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-jujqcsimwgflnift) |
| 20:48.35 | *** join/#asterisk-dev opticron (~opticron@75.76.201.152) |
| 20:48.35 | *** mode/#asterisk-dev [+oooo tzafrir mjordan newtonr opticron] by leguin.freenode.net |
| 20:48.35 | *** join/#asterisk-dev seanbright (~sean@asterisk/contributor-and-bug-marshal/seanbright) |
| 20:48.35 | *** join/#asterisk-dev gtjoseph (~gtj0@unaffiliated/gtj) |
| 20:48.35 | *** join/#asterisk-dev Marquis42 (~mrbmw@d192-24-112-5.try.wideopenwest.com) |
| 20:48.35 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 20:48.35 | *** join/#asterisk-dev dustinm- (~dustinm@105.ip-167-114-152.net) |
| 20:48.35 | *** join/#asterisk-dev nbjoerg (~joerg@netbsd/developer/joerg) |
| 20:48.35 | *** join/#asterisk-dev danjenkins (firrre@gateway/shell/firrre/x-aiqwlmbiajylcytz) |
| 20:48.35 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 20:48.35 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-mbmyalncxsntvrji) |
| 20:48.35 | *** join/#asterisk-dev wedhorn (~wedhorn@110-175-181-222.static.tpgi.com.au) |
| 20:48.35 | *** join/#asterisk-dev WIMPy (~wimpy@e183095026.adsl.alicedsl.de) |
| 20:48.35 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 20:48.35 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 20:48.35 | *** join/#asterisk-dev jrrose (jon@nat/digium/x-kgwgajajrsfrvxgx) |
| 20:48.36 | *** join/#asterisk-dev leifmadsen (~leifmadse@asterisk/documenteur-extraordinaire/blitzrage) |
| 20:48.36 | *** mode/#asterisk-dev [+oooo seanbright ChanServ malcolmd leifmadsen] by leguin.freenode.net |
| 20:48.36 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-3-44.dhcp.nwtn.ct.charter.com) |
| 20:48.36 | *** join/#asterisk-dev JunK-Y (~junky@pdpc/supporter/active/junk-y) |
| 20:48.36 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 20:48.36 | *** join/#asterisk-dev kasanop (~kasanop@ivanpoddubny.com) |
| 20:48.36 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-oqehuxiuadlcnfkw) |
| 20:48.37 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-nrbynurcpibxprdg) |
| 20:48.37 | *** join/#asterisk-dev toresbe (~toresbe@158.36.191.230) |
| 20:48.37 | *** join/#asterisk-dev Jacke (jacke@valhalla.bofh.org) |
| 20:48.37 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 20:48.37 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-grbzttbtqoscllyk) |
| 20:48.37 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-vdaclqywtkpumirl) |
| 20:48.37 | *** join/#asterisk-dev _longines (~longines@static.95.25.4.46.clients.your-server.de) |
| 20:48.37 | *** join/#asterisk-dev dan_j (sid21651@gateway/web/irccloud.com/x-vexjteqbwdaopyth) |
| 20:48.37 | *** join/#asterisk-dev Qwell (north@asterisk/developer/Qwell) |
| 20:48.37 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 20:48.37 | *** join/#asterisk-dev X-Rob (X-Rob@gateway/web/irccloud.com/x-widwdohfrefjctzv) |
| 20:48.37 | *** join/#asterisk-dev Tim_Toady (~fuzzy@snf-33276.vm.okeanos.grnet.gr) |
| 20:48.37 | *** join/#asterisk-dev elguero (~miguel323@2001:470:1f06:12c4::2) |
| 20:48.37 | *** join/#asterisk-dev bklang (~bklang@coquette.alkaloid.net) |
| 20:48.44 | *** join/#asterisk-dev Gugge (gugge@92.246.2.105) |
| 20:48.44 | *** mode/#asterisk-dev [+oo Qwell jsmith] by leguin.freenode.net |
| 20:48.44 | *** join/#asterisk-dev russellb (~rustlebee@redhat/russellb) |
| 20:48.44 | *** join/#asterisk-dev philipp64 (~chatzilla@66-232-81-197.ctcweb.net) |
| 20:48.44 | *** mode/#asterisk-dev [+o russellb] by leguin.freenode.net |
| 20:49.56 | *** join/#asterisk-dev infobot (ibot@69-58-76-73.ut.vivintwireless.net) |
| 20:49.56 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Hell hath frozen over: Asterisk is moving to Git -=- Follow on Twitter at @AsteriskDev |
| 20:53.06 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 21:04.36 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 21:17.39 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 21:17.39 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:19.55 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 21:33.41 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 21:46.01 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 22:03.25 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 22:16.54 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 22:28.49 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-igefyqsluggqctww) |
| 22:38.27 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 22:57.26 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 23:01.00 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 23:04.50 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-cxdagendpfyluckv) |
| 23:07.53 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 23:07.53 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:22.30 | *** join/#asterisk-dev drmessano (~nonya@pdpc/supporter/active/drmessano) |
| 23:28.22 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-dvuuopdcsedsaepz) |
| 23:32.21 | *** join/#asterisk-dev mjordan (~mjordan@75.76.55.191) |
| 23:32.21 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 23:45.08 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-tolwuotczlggemkg) |