| 00:30.22 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-rjmwdvmwwvrpgzao) |
| 02:52.58 | *** join/#asterisk-dev dar123 (~bad53@107-203-254-117.lightspeed.sntcca.sbcglobal.net) |
| 02:56.09 | *** join/#asterisk-dev DivideBy0x0 (~DivideBy0@unaffiliated/divideby0x0) |
| 05:37.46 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 06:14.45 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:15.58 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:15.58 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:51.54 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.dynamic.se.alltele.net) |
| 07:51.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:53.54 | oej | Morning folks! |
| 08:04.49 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:08.26 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:24.27 | *** join/#asterisk-dev Bordr_ (~Bordr@23-24-156-49-static.hfc.comcastbusiness.net) |
| 11:40.24 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 12:57.22 | stefan27 | my sip.conf has udpbindaddr=0.0.0.0:8060 and when asterisk sends sip notifys initiated from cli i get Contact header with asterisk@192.168.1.227:8060 and when i send sip notifys with AMI i get contact header with asterisk@127.0.0.1:8060 . It seems sip_cli_notify calls ast_sip_ouraddrfor(&p->sa, &p->ourip, p); build_via(p); before calling transmit_invite(p, SIP_NOTIFY, 0, 2, NULL); , but |
| 12:57.22 | stefan27 | manager_sipnotify does not. is this a bug? manager_sipnotify and sip_cli_notify have a lot of code in common otherwise |
| 13:06.50 | *** join/#asterisk-dev [TK]D-Fender (~chatzilla@216-191-106-163.dedicated.allstream.net) |
| 13:25.04 | *** join/#asterisk-dev Demon_VoIP (~demon@eoks.ivanovo.ru) |
| 13:27.47 | Demon_VoIP | Hello. gtjoseph, Sorry. It's again me :) ASTERISK-25439 (segfaults in find_entry). Every day I have the segfaults 3-8 times in the same stack. Can you explain what's wrong with my server? What circumstances lead to this error? |
| 13:30.19 | Demon_VoIP | and other 1-2 times per day is deadlock: ASTERISK-25638 Where is no any progress in both :( |
| 13:50.13 | stefan27 | i made a gerrit review instead https://gerrit.asterisk.org/#/c/2126/ |
| 14:07.26 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-copojjbjrguogcqc) |
| 14:07.26 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 14:53.17 | stefan27 | what does Commit length validation failure mean |
| 14:53.54 | stefan27 | What are the rules? The summary line may not be longer than x characters? total length of message may not be longer than y? |
| 14:58.25 | file | 80 characters |
| 15:00.53 | stefan27 | aha |
| 15:01.03 | stefan27 | also what does "cherry pick" mean in the context of gerrit |
| 15:03.21 | file | every review is against a specific branch, in order to put a change into other branches you have to cherry pick, this can be done using the cherry pick button in gerrit which means "take this commit and put it into this branch" |
| 15:08.01 | stefan27 | aha but that's only relevant once the actual patch passes review? I noticed sip_cli_notify and manager_sipnotify had a lot of code in common so I guessed this was a bug, do you have a take on it yet? |
| 15:08.51 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-yidtxarktbzkwvqv) |
| 15:09.16 | stefan27 | i'll happily cherry pick it to the other branches once it's confirmed that it's not already working as intended :) |
| 15:09.35 | file | each patch is reviewed individually |
| 15:09.36 | stefan27 | Or should I cherry pick it straight away before any review? |
| 15:09.48 | file | if the code is the same, then it's easy |
| 15:10.22 | file | unless it's an absolutely huge change most people just cherry pick immediately, since you can cherry pick again if you have to fix anything |
| 15:11.07 | file | and I think? it's right |
| 15:17.34 | stefan27 | I should work on making better commit messages, but I only contribute a few times a year with mostly one-liners |
| 15:19.11 | *** join/#asterisk-dev Synthase_ (uid63346@gateway/web/irccloud.com/x-lizpzwnbajowgzyg) |
| 15:31.34 | gtjoseph | dan_j: are you around? |
| 15:32.40 | dan_j | Kinda. Just cooking |
| 15:33.01 | gtjoseph | Did I see a fix or workaround for this... op.alter_column('ps_aors', 'qualify_timeout', type_=sa.Decimal) |
| 15:33.01 | gtjoseph | AttributeError: 'module' object has no attribute 'Decimal' |
| 15:33.53 | dan_j | Yes. I need to use something else instead of Decimal. Was going to do it last Saturday night but was having git problems. |
| 15:34.20 | gtjoseph | Oh, I gotcha |
| 15:35.02 | gtjoseph | This is the first time I've actually tried to use alembic to create a database. :) |
| 15:35.50 | gtjoseph | I think it's Float |
| 15:49.04 | dan_j | Someone on here, cant remember who, suggested copying a different alembic script in the asterisk code. i think the type was numeric something. |
| 15:49.15 | dan_j | I'll check check tomorrow. |
| 15:49.19 | dan_j | Got irc history |
| 15:49.27 | dan_j | Sorry. gtg |
| 15:49.33 | gtjoseph | Float works. I just tried it. |
| 16:16.04 | *** join/#asterisk-dev leedm777 (leedm777@nat/digium/x-jixhyotoduydyfap) |
| 16:20.10 | gtjoseph | oh great... if you try to use realtime for transports it puts asterisk into infinite recursion. |
| 16:22.28 | file | ah yes I remember that now, fixing it requires state separation |
| 16:22.35 | gtjoseph | exactly |
| 16:23.14 | gtjoseph | should i roll that into my transport reload thing or do it separately? |
| 16:23.21 | file | separately |
| 16:23.29 | gtjoseph | yeah, ok |
| 16:25.53 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-siorqqewgzjugavq) |
| 16:34.09 | gtjoseph | file: / mjordan: so if i separate transport state, the current fields in ast_sip_transport are going to go away, or at least be no longer used. This means no 13, correct? |
| 16:35.08 | gtjoseph | Ok, if I populate them for legacy purposes then? |
| 16:36.06 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 16:36.58 | file | populating them is fine |
| 16:37.09 | gtjoseph | ok |
| 17:09.32 | *** join/#asterisk-dev Demon_VoIP (~demon@ip253.net222.n37.ru) |
| 18:43.47 | *** join/#asterisk-dev putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
| 18:43.47 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 22:00.23 | *** join/#asterisk-dev tzafrir (~tzafrir@91.183.149.90) |
| 22:00.23 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 22:34.30 | *** join/#asterisk-dev [TK]D-Fender (~joe@64.235.216.2) |
| 23:57.17 | *** join/#asterisk-dev jameswf_ (uid27319@gateway/web/irccloud.com/x-izyitfqiajjwdmmz) |
| 23:57.50 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-yidtxarktbzkwvqv) |