| 00:56.43 | *** join/#asterisk-dev klow (~textual@c-67-161-106-89.hsd1.wa.comcast.net) |
| 01:59.41 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 01:59.41 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 02:21.03 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 02:24.39 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 02:26.30 | cresl1n | wibbles |
| 02:27.49 | snuff-work | also noticed u fixed the return values from 0 to 1 in some cases in original patch.. i did think it was odd that everywhere it returned 0 from dtmf_info.c |
| 02:37.59 | *** join/#asterisk-dev F2Knight_ (~F2Knight@wsip-70-169-224-223.oc.oc.cox.net) |
| 02:44.45 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 03:02.55 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 03:04.04 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 03:06.34 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 04:02.52 | *** join/#asterisk-dev klow (~textual@c-98-247-49-57.hsd1.wa.comcast.net) |
| 04:12.33 | *** join/#asterisk-dev snuff-work (~blatus@203.87.61.22) |
| 04:12.33 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 05:53.42 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 06:13.43 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:14.38 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 06:14.38 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 06:37.53 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 06:44.18 | *** join/#asterisk-dev jkroon (~jkroon@154.73.35.201) |
| 07:15.52 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 07:15.52 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 07:18.36 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:18.36 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:10.44 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 12:51.15 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 12:51.16 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:04.09 | cresl1n | Hello world! |
| 13:06.09 | file | moo |
| 13:06.30 | cresl1n | Cows go moo? |
| 13:08.40 | file | generally yes |
| 13:42.05 | cresl1n | What are you up to this morning Mr. file? |
| 13:42.29 | file | making Jenkins happier! which with this recent merge, has been done |
| 13:42.44 | file | well - has been improved! |
| 13:43.02 | file | cresl1n, what are YOU up to? |
| 13:43.18 | cresl1n | trying to get IMAP working with app_voicemail :-) |
| 13:43.28 | file | backs away |
| 13:43.41 | cresl1n | as you should. |
| 13:43.48 | cresl1n | it's been lovely so far |
| 13:46.51 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-ivuhstcuirbhsikx) |
| 13:46.51 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:47.02 | cresl1n | Hey, it's newtonr! |
| 13:47.12 | cresl1n | Morning |
| 13:47.24 | newtonr | Mooooooorning |
| 13:47.27 | file | newtonr, helllllllllllo |
| 13:47.44 | cresl1n | file we've gotta fix this donut problem next time you're in town |
| 13:47.52 | file | cresl1n, oic |
| 13:47.58 | file | Taco Bell and Krispy Kreme? |
| 13:48.17 | cresl1n | You won't touch Taco Bell, no? |
| 13:48.35 | file | who said I'd touch Krispy Kreme? |
| 13:48.48 | cresl1n | darn |
| 13:48.48 | file | :P |
| 13:48.50 | cresl1n | is that off the list? |
| 13:48.54 | file | maybe, maybe not |
| 13:48.56 | file | undecided |
| 13:49.05 | cresl1n | They're pretty awesome |
| 13:53.52 | newtonr | mmm cruller |
| 13:54.51 | newtonr | I found out that my favorit Krispy Kreme doughnut, the cruller, is not a real cruller. Apparently I'd have to find a Tim Hortons |
| 13:55.01 | cresl1n | file, do you have an abstract opposition to Krispy Kreme? |
| 13:55.13 | file | cresl1n, no |
| 13:55.24 | cresl1n | cool |
| 13:55.32 | file | newtonr, how is it not a real cruller? |
| 13:55.37 | cresl1n | it's a distinct donut style worth trying in its own right |
| 13:59.05 | newtonr | people on the internet in food forums say it doesn't taste like home made crullers, or more traditional ones made at a few other doughtnut shops and chains |
| 13:59.13 | file | ah |
| 14:00.14 | newtonr | i think it is supposed to be denser and fattier |
| 14:00.38 | newtonr | at krispy kreme i almost like the sour cream dooughnut better than the cruller |
| 14:00.39 | newtonr | https://www.krispykreme.com/menu/Doughnuts/Glazed-Sour-Cream |
| 14:19.37 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:19.37 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:19.56 | file | A wild putnopvut appears. |
| 14:20.04 | putnopvut | I'm not wild, dangit |
| 14:20.19 | cresl1n | Sweet! I got app_voicemail IMAP connected to my gmail account |
| 14:20.20 | cresl1n | :-) |
| 14:20.26 | file | cresl1n, oh |
| 14:20.28 | file | cresl1n, um |
| 14:20.29 | cresl1n | Now gotta try this patch out |
| 14:20.35 | file | be careful |
| 14:20.38 | cresl1n | thumps file |
| 14:20.46 | file | is this a throw away or your actual account? |
| 14:20.57 | cresl1n | file have you tried this before? |
| 14:21.07 | cresl1n | it doesn't matter |
| 14:21.11 | cresl1n | I don't use my gmail account for anything |
| 14:21.18 | file | no, but I'm aware of how absurd the gmail IMAP server can be |
| 14:22.45 | cresl1n | stupid gerrit |
| 14:22.50 | cresl1n | forgets me every. single. day. |
| 14:23.15 | file | cresl1n, #firstworldproblem |
| 14:24.03 | cresl1n | Yes. Yes it is. |
| 14:25.58 | pnlarsson | hm, howto do the git rebase -i thing, i get a text with a lot of options... |
| 14:26.22 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-juegalqczeasoeag) |
| 14:26.39 | pnlarsson | Opened a gerrit thing and have some changes to push |
| 14:26.46 | cresl1n | Good mornings kharwell |
| 14:27.01 | kharwell | cresl1n: greetings |
| 14:30.28 | file | pnlarsson, are the changes the progression of working on something you want to push up for review? |
| 14:33.58 | pnlarsson | file: it's on review and I think I got it now |
| 14:34.19 | file | kk |
| 14:34.48 | pnlarsson | https://gerrit.asterisk.org/#/c/2904 |
| 14:35.18 | file | yup! went up fine |
| 14:47.06 | cresl1n | Hey, this whole IMAP voicemail things is a pretty sweet idea |
| 14:47.07 | cresl1n | IMHO :-) |
| 14:50.33 | file | yes. |
| 14:52.45 | tzafrir | file, sorry, I didn't realise I have commit access. Do I? |
| 14:52.59 | file | you have the ability to update the review |
| 14:53.04 | file | anyone does |
| 14:53.25 | tzafrir | err... sorry, wrong review. Yes, I'll update it. |
| 14:54.10 | file | systemd I'm not touching with a ten foot pole unless I have to :D |
| 14:54.21 | cresl1n | yeah, that's got trap written all over it |
| 14:54.40 | file | voluntells gtjoseph |
| 14:54.56 | gtjoseph | eh, what? |
| 14:55.06 | file | gtjoseph, oh nothing! just the systemd review |
| 14:55.12 | cresl1n | More like voluntrap |
| 14:55.16 | gtjoseph | oh, THAT. :) |
| 14:57.25 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qtkbayhbmnurzjjm) |
| 14:57.37 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-goerovsnwcvikavd) |
| 15:17.11 | leifmadsen | delegation! you will love it! |
| 15:20.59 | cresl1n | The delegator or the delegatee? |
| 15:21.00 | cresl1n | :-P |
| 15:21.04 | file | delegates the loving of it to leifmadsen |
| 15:21.09 | cresl1n | hi, btw, leifmadsen |
| 15:21.22 | cresl1n | I see you on facebook every so often |
| 15:21.25 | cresl1n | did you finish your basement? |
| 15:24.36 | cresl1n | ponders what to do with the 6 minutes before the next meeting |
| 15:24.48 | cresl1n | MORE IMAP! |
| 15:27.30 | file | cresl1n, the small slices of freedom between meetings |
| 15:38.32 | leifmadsen | cresl1n: ohai! |
| 15:38.41 | leifmadsen | cresl1n: basement finished, I am in it :) |
| 15:38.53 | leifmadsen | I have no windows, so I have no idea what it's like outside |
| 15:45.52 | file | leifmadsen, are there bars on the windows? |
| 15:46.15 | leifmadsen | there are no windows to provide bars for :) |
| 15:46.20 | leifmadsen | but my office has a bar... does that count? |
| 15:48.42 | file | no. |
| 16:12.31 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 16:13.18 | cresl1n | So⦠|
| 16:13.22 | cresl1n | last question I think |
| 16:13.27 | cresl1n | For the IMAP voicemail review |
| 16:15.20 | cresl1n | Alexei wants to remove the X-Asterisk-VM-Caller-channel flag from the IMAP message metadata |
| 16:15.30 | cresl1n | on the one hand, who uses it, right? |
| 16:15.32 | cresl1n | don't know |
| 16:16.07 | cresl1n | on the other hand, this is a release branch, and I'd rather not remove something of that nature particularly on a release branch |
| 16:16.19 | file | yeah - same |
| 16:16.24 | cresl1n | Ok |
| 16:16.33 | cresl1n | He claims security reasons |
| 16:16.55 | cresl1n | I can see his point, in a sense, but someone put it there in the first place, so presumably someone is using it |
| 16:17.07 | file | nods |
| 16:17.13 | cresl1n | accepts the nod |
| 16:18.08 | file | accepts the acceptance |
| 16:18.33 | cresl1n | Wendy's? |
| 16:18.50 | file | Toy Box |
| 16:32.43 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-iigggahglaykwzpd) |
| 16:32.43 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 16:35.00 | gtjoseph | continuation of ast_format_cap_append_by_type discussion... |
| 16:35.32 | gtjoseph | for slin and speex, the codec names are 'slin' and 'speex' but the formats have the rate/1000 appended. |
| 16:35.56 | gtjoseph | so slin12, slin16, etc. |
| 16:36.29 | gtjoseph | when ast_format_cap_append_by_type looks up the format in the cache by codec name, it misses on slin and speex and creates a new format. |
| 16:37.19 | gtjoseph | so... |
| 16:38.30 | gtjoseph | we could append the rate to slin and speex codec named before checking the cache... |
| 16:38.37 | gtjoseph | s/named/names/ |
| 16:39.09 | gtjoseph | or append the rate to all codec names and also populate the cache with name and rate for all codecs |
| 16:39.29 | cresl1n | what is it trying to use as the desired lookup value in the problem case? |
| 16:39.34 | file | the name of the codec |
| 16:39.41 | gtjoseph | not sure what ripple effects appending the rate to all format names will have though |
| 16:39.47 | cresl1n | without the sample rate? |
| 16:39.51 | file | yes |
| 16:39.54 | cresl1n | why? |
| 16:40.14 | file | because for most codecs the format cache does not include the sample rate in the name |
| 16:40.15 | cresl1n | oh yeah |
| 16:40.18 | cresl1n | slin is 8khz |
| 16:40.18 | gtjoseph | because we're iterating over all codecs |
| 16:40.29 | cresl1n | slin16 is the weird slin |
| 16:40.31 | file | I'd just add an API call to search based on codec |
| 16:40.32 | gtjoseph | and the codec names are only 'name' |
| 16:40.36 | cresl1n | 16 kHz slin |
| 16:40.37 | cresl1n | yeah |
| 16:40.50 | file | less ripples and will work for anything |
| 16:41.52 | cresl1n | my hunger is activating |
| 16:43.43 | gtjoseph | hmmm. will require a bit of work in the cache |
| 16:43.52 | gtjoseph | but ok |
| 16:43.55 | file | why? |
| 16:44.25 | *** join/#asterisk-dev F2Knight (~F2Knight@c-50-139-85-237.hsd1.or.comcast.net) |
| 16:44.28 | gtjoseph | 2 different search criteria. name and name/rate |
| 16:45.06 | file | an ao2_callback with a codec passed in and a strict pointer comparison of the codec on the format |
| 16:45.18 | file | yolo |
| 16:45.27 | putnopvut | Review 2790 is failing to build right now. Jenkins reports the error as "2016-05-25 11:35:04 ari/resource_channels.c:1509: error: 'ast_free' undeclared here (not in a function) |
| 16:45.27 | putnopvut | " |
| 16:45.46 | putnopvut | It builds fine for me, though. What is the proper fix for that? |
| 16:45.51 | file | uhhh |
| 16:45.59 | gtjoseph | i didn't want to have to iterate over the formats every time |
| 16:45.59 | cresl1n | food? |
| 16:46.43 | file | then you can add another container, but do the first way first or it may be premature optimization |
| 16:48.16 | gtjoseph | i'll try some things. |
| 17:03.20 | file | putnopvut, hum |
| 17:16.45 | *** join/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 17:54.39 | coreyfarrell | putnopvut: did you try building with MALLOC_DEBUG on and off? that build option has caused that problem for me many times in the past. |
| 17:55.36 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-14.wall.uls.co.za) |
| 17:56.25 | file | yeah, I think it needs a utils.h include |
| 17:59.34 | coreyfarrell | file: that is weird since resource_channels.c includes pbx.h, that includes channel.h which includes utils.h |
| 17:59.46 | file | yeah... dunno... 'tis weird |
| 18:01.09 | file | MALLOC_DEBUG does indeed show it though |
| 18:01.49 | *** join/#asterisk-dev libardi (~kvirc@187.64.229.94) |
| 18:03.41 | coreyfarrell | at some point I want to take another stab at moving those defines to astmm.h so MALLOC_DEBUG doesn't effect the required includes |
| 18:30.24 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-wozyxoflforjiupk) |
| 18:30.25 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 18:39.25 | putnopvut | I figured out the problem from earlier. Apparently, with MALLOC_DEBUG, ast_free() is a macro rather than a void (*func)(void*) function. So using ast_free_ptr is the way to go. |
| 18:39.39 | cresl1n | Ah |
| 18:41.00 | file | putnopvut, #TheMoreYouKnow |
| 19:35.12 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 19:36.33 | file | spins cresl1n |
| 19:37.26 | cresl1n | file.... |
| 19:37.43 | cresl1n | Do asterisk channels dream of electric RTP? |
| 19:37.47 | file | yes |
| 19:37.59 | file | cresl1n, cheap lunch tomorrow? |
| 19:38.10 | cresl1n | where? |
| 19:38.17 | file | Wendy's! |
| 19:38.36 | cresl1n | always. |
| 19:43.48 | gtjoseph | need some understanding on format translation path.... |
| 19:44.21 | gtjoseph | i short circuited ast_format_cap_append_by_type to only add ulaw and slin192... |
| 19:44.39 | gtjoseph | the test forces ulaw on both legs of the call... |
| 19:44.53 | gtjoseph | the test calls playback |
| 19:44.54 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-172.cust.bezeqint.net) |
| 19:44.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:45.19 | gtjoseph | there are no sln16 sound files |
| 19:45.23 | gtjoseph | but I get Playing 'demo-congrats.slin' |
| 19:46.01 | gtjoseph | If I set append_by_type to ulaw and slin, I get Playing 'demo-congrats.ulaw' |
| 19:46.07 | gtjoseph | which I believe to be correct. |
| 19:46.20 | gtjoseph | so why dod I get a transcode through slin the first time? |
| 19:46.37 | file | dunno! |
| 19:47.07 | gtjoseph | well, on that note. i'm OTL. |
| 19:50.37 | cresl1n | Out To Liberate? |
| 19:55.45 | *** join/#asterisk-dev acidfoo_ (~acidfoo@198-48-218-90.cpe.pppoe.ca) |
| 20:00.39 | rmudgett | gtjoseph: Do you have transcode_via_sln=yes in your asterisk.conf file? |
| 20:01.08 | file | it also may be that it decides that slin192 is "best" somehow |
| 20:02.19 | cresl1n | oh no.... |
| 20:04.04 | gtjoseph | ill have to check in the option when I get back. or one of you could check the "samples" default real quick. :) |
| 20:05.40 | gtjoseph | I *think* that if it does it uses the lay one |
| 20:05.47 | gtjoseph | last |
| 20:06.06 | gtjoseph | which would be 192 |
| 20:34.27 | gtjoseph | transcode_via_sln = no didn't help at all. |
| 22:54.33 | *** join/#asterisk-dev opticron (~opticron@75.76.51.46) |
| 22:54.33 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 22:55.14 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-juegalqczeasoeag) |