| 00:51.46 | file | coreyfarrell, interestingly the "asterisk -r" behavior on 14/master now is so different that it's causing an old test to fail a lot it seems |
| 00:52.12 | coreyfarrell | ugh |
| 00:52.36 | file | https://jenkins.asterisk.org/jenkins/job/periodic-asterisk-14/77/testReport/junit/(root)/AsteriskTestSuite/tests_channels_SIP_no_ack_dialog_cleanup/ |
| 00:52.49 | file | test probably just needs to be tweaked |
| 00:53.35 | coreyfarrell | is that 'asterisk -rx' behavior maybe? |
| 00:53.44 | file | methinks so, aye |
| 00:54.04 | coreyfarrell | like it shouldn't be printing "Asterisk cleanly ending (0).\nExecuting last minute cleanups\n" |
| 00:57.36 | file | the test took the cleanly ending into account it seems |
| 01:05.55 | coreyfarrell | file: in really_quit we've got: ast_verb(0, "Executing last minute cleanups\n"); |
| 01:07.54 | coreyfarrell | I think that is being run by the rasterisk process and it's printing directly to stdout. |
| 01:08.31 | file | ah |
| 01:08.35 | coreyfarrell | do we even need to run 'really_quit' from 'asterisk -r' processes? |
| 01:08.54 | coreyfarrell | really what happened is we fixed a bug (ast_verb not printing before init_logger is run) |
| 01:08.58 | file | does not know |
| 01:09.11 | coreyfarrell | init_logger is never run in the 'asterisk -r' process |
| 01:12.45 | coreyfarrell | I'm thinking of adding to the very beginning of ast_log_full: if (level == __LOG_VERBOSE && ast_opt_remote) { return; } |
| 01:13.57 | file | I'm off to bed! eyes on 4040 would also be nice, it's a straight up revert |
| 01:13.57 | coreyfarrell | that way if the rasterisk process logs an error/warning/notice it will show but ignore verbose messages created by rasterisk (not effecting those sent by the daemon over the socket) |
| 01:16.35 | coreyfarrell | file: you're probably gone already but if you're still there, only reverting master? |
| 01:24.13 | file | it only landed in master |
| 01:24.38 | file | there were subsequent reviews to put it elsewhere but I -1ed them when the master tests failed |
| 01:25.01 | file | and abandoned them earlier today as they were old and it had not yet been fixed |
| 01:30.11 | *** join/#asterisk-dev opticron (~opticron@75.76.59.35) |
| 01:30.11 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 01:46.59 | coreyfarrell | got it.. +1'd |
| 05:57.03 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:42.54 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 06:52.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:11.52 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:18.05 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:19.06 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:19.06 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:10.45 | *** join/#asterisk-dev matsk (~matsk@vpnbl.borderlight.net) |
| 08:57.06 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 09:04.23 | *** join/#asterisk-dev oej (~oej@88.214.184.160) |
| 09:04.23 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:25.48 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 09:54.20 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 10:21.36 | *** join/#asterisk-dev matsk (~matsk@217.142.152.44) |
| 11:07.39 | file | whistles |
| 12:57.29 | *** join/#asterisk-dev NirS_ (~Nir_S@185.6.64.162) |
| 12:58.25 | *** join/#asterisk-dev NirS_ (~Nir_S@185.6.64.162) |
| 12:58.31 | NirS_ | Good morning all |
| 13:00.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0098a3fed0ccc6d5aa.ipv6.abo.wanadoo.fr) |
| 13:16.43 | NirS_ | wonders where is everybody? it can't be this early in the US, or is it? |
| 13:18.00 | file | few are around |
| 13:18.07 | opticron | depends on the person |
| 13:18.29 | NirS_ | good one |
| 14:13.58 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:13.58 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:15.47 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:15.47 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:16.27 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-jsfsjyuqlehqsowl) |
| 14:34.59 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-igyxclflmplaypmr) |
| 14:38.31 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 15:24.53 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/session) |
| 15:51.13 | file | rmudgett, I purposely didn't fix that just to see how long it would take you :P |
| 15:52.10 | rmudgett | file: Really? You left something for me to change! |
| 15:54.15 | file | :D |
| 15:55.23 | kharwell | if anyone feels like a testsuite review the codec_opus tests could use some eyes: https://gerrit.asterisk.org/#/c/4010/ |
| 16:16.46 | gtjoseph | file: you were too quick. i had to add a doc note to the Q reviews. |
| 16:17.17 | file | gtjoseph, the horror! |
| 16:17.28 | gtjoseph | i know, really! |
| 16:18.21 | file | has a day of code reviews |
| 16:18.35 | file | come one, come all, to Gerrit! |
| 16:18.39 | file | where dreams come alive |
| 16:18.56 | file | and where I should schedule an upgrade time with newtonr |
| 16:20.31 | *** join/#asterisk-dev elguero (~miguel323@74-95-21-41-Connecticut.hfc.comcastbusiness.net) |
| 16:20.56 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 16:21.45 | gtjoseph | what goodies are in the new version? |
| 16:22.33 | file | gtjoseph, https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.13.html#_release_highlights |
| 16:23.11 | gtjoseph | Nice: File annotations (blame) in side-by-side diff |
| 16:23.14 | file | yes |
| 16:23.41 | file | I'm looking forward to that |
| 16:25.01 | file | this one also |
| 16:25.06 | file | "Issue 3035: Allow to remove specific votes from a change, while leaving the reviewer on the change." |
| 16:25.27 | gtjoseph | yeah, just saw that one |
| 17:23.29 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-khhcioftsprxwdlm) |
| 18:38.48 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 18:38.48 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:42.18 | *** join/#asterisk-dev ipengineer (~zconkle@71.252.134.63) |
| 19:45.50 | *** join/#asterisk-dev NirS (~Nir_s@87.69.126.26) |
| 19:46.21 | NirS | Hey guys, anyone can help me a second with Gerrit ? |
| 19:55.39 | NirS | Open question: when I submit a draft to Gerrit review board, to I need to publish it afterwards? |
| 19:56.00 | gtjoseph | if it's in draft, yes |
| 19:56.01 | file | yes, a draft is just that - a draft, it's not yet ready to be reviewed so it is not visible |
| 19:56.09 | file | it is only once published that it is available for review |
| 19:56.25 | NirS | ok, thanks |
| 19:56.34 | NirS | then I need to publish two drafts :-) |
| 19:56.52 | NirS | well, I'll publish 1 for now, the other is still under discussion |
| 19:56.53 | NirS | :) |
| 20:02.59 | NirS | Done |
| 20:03.00 | NirS | :-) |
| 20:28.35 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 20:38.53 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-mvipmwyuskrmssgo) |
| 21:27.54 | *** join/#asterisk-dev ipengineer (~zconkle@71.252.134.63) |
| 21:37.19 | ipengineer | Is anyone familiar with issues using periodic-announce-frequency and announce-frequency for the same queue? When using both of these methods only the position announcements work. The periodic announcement either does not play or if it does, does so right after the position announcement. Was tested in Asterisk 13 and may be something we need to open a bug for⦠Just wanted to check here first |
| 22:23.46 | *** join/#asterisk-dev snuff-work (~snuff-wor@203.87.61.22) |
| 22:23.46 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:41.09 | rmudgett | gtjoseph: The only quibble I have remaining on the answered elsewhere patch is that the other OPT_HANGUPCAUSE flag definitions are using spaces for alignment instead of tabs. I can +1 it anyway. |
| 22:41.37 | gtjoseph | i did spaces |
| 22:41.51 | gtjoseph | did it get converted back to tabs? |
| 22:42.32 | gtjoseph | DAMMIT I took that tab out. |
| 22:43.49 | gtjoseph | rmudgett: fixed for what seems like the 3rd time. |
| 22:44.04 | gtjoseph | sorry about that |
| 22:50.35 | rmudgett | gtjoseph: I think you need to hit save after making changes :P |
| 22:50.59 | gtjoseph | maybe that's it |
| 22:51.08 | file | save a tree! |
| 23:30.04 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-jsfsjyuqlehqsowl) |