| 00:22.34 | file | rmudgett, I'll take a review of my one line change :P |
| 00:32.41 | file | coreyfarrell, I just filed ASTERISK-26513, you may be interested in it |
| 00:34.45 | rmudgett | file: The patch to make codecs match the received codec may have a flip flop type problem if both sides attempt to match each other. |
| 00:37.29 | file | we can see if that happens in practice... |
| 01:08.18 | coreyfarrell | file: still around? |
| 01:08.54 | file | Yes |
| 01:09.33 | coreyfarrell | so I have an idea.. looks like res_pjsip and possibly more modules are refusing to unload, still have active tasks going on. |
| 01:09.46 | coreyfarrell | but we ran 'core stop gracefully'. |
| 01:10.18 | coreyfarrell | I'm thinking in that situation where some modules are not shutdown we should 'downgrade' to 'core stop now' .. not run the ast_register_cleanup |
| 01:10.35 | file | Ah |
| 01:10.46 | coreyfarrell | it'll clear the crash |
| 01:10.53 | file | Yeah, if we can't safely... |
| 01:12.22 | file | Go go testing |
| 01:14.11 | coreyfarrell | I don't know PJSIP enough to know how to make it shutdown properly... we'll need to disable building res_pjsip for the jenkins REF_DEBUG job |
| 01:15.05 | coreyfarrell | either way this is how asterisk should handle shutdown, when any module stays loaded we can't assume it's safe to run ast_register_cleanup's. |
| 01:15.14 | file | Aye |
| 01:17.24 | coreyfarrell | you think it's ok to change 'void ast_module_shutdown(void)' to 'int ast_module_shutdown(void)'? or even rename the symbol? it's declared in module.h but really belongs in _private.h. |
| 01:17.40 | coreyfarrell | only run by main/asterisk.c |
| 01:18.07 | file | Hum |
| 01:18.27 | file | Dunno, I'm in bed half asleep |
| 01:20.54 | rmudgett | No cherry-picks for https://gerrit.asterisk.org/#/c/4171/ ? |
| 01:23.48 | file | It didn't appear to be applicable to newer versions |
| 04:59.06 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 05:05.13 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 05:36.40 | *** join/#asterisk-dev matsk (~matsk@vpnbl.borderlight.net) |
| 05:51.00 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 06:00.41 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 06:33.47 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:11.40 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:56.00 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 09:10.03 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 09:10.03 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:15.38 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 11:31.02 | *** join/#asterisk-dev matsk (~matsk@vpnbl.borderlight.net) |
| 11:52.27 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-gzqdbhzovtwjyiyc) |
| 11:52.27 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 12:00.26 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 12:09.14 | *** join/#asterisk-dev Gugge_ (gugge@92.246.2.105) |
| 12:18.47 | *** join/#asterisk-dev opticron (~opticron@75.76.59.35) |
| 12:18.47 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 12:36.36 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 12:41.22 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 13:10.54 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 13:10.54 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:34.11 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 13:38.52 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:38.52 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:44.15 | file | cresl1n, !!? |
| 13:48.54 | cresl1n | file~!!111 |
| 13:49.18 | file | cresl1n, welcome to Friday! |
| 13:49.51 | cresl1n | merci, monsieur colp |
| 13:50.25 | file | cresl1n, lunch? |
| 13:57.37 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-jfqjjdbrhdcidcij) |
| 13:57.37 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:06.54 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 14:06.54 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:08.48 | *** join/#asterisk-dev chazzam (~chazz@vps.roguewerks.com) |
| 14:22.29 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:22.29 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:55.44 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 14:58.52 | coreyfarrell | file: now that you're not half asleep any thoughts about unpublishing 'ast_module_shutdown'? |
| 14:59.00 | file | not yet, in meeting |
| 15:00.05 | file | I think I'm fine with it though |
| 15:02.54 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 15:12.07 | file | coreyfarrell, btw you didn't crash Gerrit - it was me |
| 15:12.17 | file | the reload of the JIRA plugin somehow caused it to explode a bit |
| 15:13.21 | coreyfarrell | ha, I was half joking because the failure came at the exact same time as an error message I never saw about not having ASTERISK-[0-9]* in the commit msg. |
| 15:25.46 | file | coreyfarrell, deployed |
| 15:26.22 | coreyfarrell | that was too fast, I was looking at the 'status:open' and didn't see it, thought something went wrong :) |
| 15:26.48 | file | for that sort of stuff if it's simple and fine, I just put it into infrastructure and do it |
| 15:54.52 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-xnnbuonopxeepgvy) |
| 15:54.52 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:03.49 | *** join/#asterisk-dev JunK-Y (~junky@pdpc/supporter/active/junk-y) |
| 16:43.47 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-utxtixzmzajdvbmj) |
| 16:46.02 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 17:13.33 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 17:15.51 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 17:20.38 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-84-109-18-138.red.bezeqint.net) |
| 17:20.38 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 17:30.00 | rmudgett | gtjoseph: Are bundled pjproject patches are applied in alpha sorted order? |
| 17:30.29 | gtjoseph | yes |
| 17:30.41 | rmudgett | wasn't sure |
| 17:35.06 | gtjoseph | don't forget that the patch must apply with -p1 |
| 17:35.34 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 17:37.49 | *** join/#asterisk-dev dandann00dle (uid120491@gateway/web/irccloud.com/x-wefrwfosyumgyzlg) |
| 17:49.23 | jsmith | Wait -- are there bundled patches that aren't in upstream pjproject? |
| 17:54.20 | file | no |
| 17:54.23 | gtjoseph | jsmith: only patches that pertain to the actual build of pjproject. |
| 17:54.32 | gtjoseph | I.E. makefile fixup |
| 17:54.58 | file | doesn't count those |
| 17:55.46 | gtjoseph | me neither but i did just add one |
| 18:55.44 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-84-109-18-138.cablep.bezeqint.net) |
| 18:55.45 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:19.57 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 19:19.58 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 20:17.59 | rmudgett | gtjoseph: Looks like 61a5c3460ec23a623ac62633d055b34d4dded682 The --strip-components option patch broke building bundled on my dev machine. Make is trying to include /version.mak because $(PJDIR) is empty. |
| 20:18.20 | gtjoseph | sighs |
| 20:19.11 | gtjoseph | can you do the noisy build thing and see the error? |
| 20:20.25 | rmudgett | nothing really interesting is showing up because this is trying to include a file from the wrong location. |
| 20:20.59 | gtjoseph | can you do a 'make distclean' and try again |
| 20:21.18 | rmudgett | k |
| 20:22.09 | gtjoseph | i tested that back to centos6, debian6, ubuntu14, openbsd5.9 |
| 20:23.12 | gtjoseph | this is your new kubuntu16 machine right? |
| 20:26.04 | rmudgett | no. and distclean didn't work |
| 20:26.59 | rmudgett | still trying to include /version.mak |
| 20:27.22 | gtjoseph | what does "pwd -P" give you (from any working directory) |
| 20:28.07 | rmudgett | Gives me the current directory from root |
| 20:28.27 | gtjoseph | ok, that's what it should give you |
| 20:29.40 | gtjoseph | cd third-party/pjproject ; rm -rf source build.mak ; make configure NOISY_BUILD=yes |
| 20:33.56 | rmudgett | That seems to have done it. build.mak in thrird-party/pjproject didn't get deleted |
| 20:34.37 | gtjoseph | probably because the distclean didn't work |
| 20:35.02 | gtjoseph | if you wouldn't mind, try a few distcleans and configures to make sure the issue doesnt re-appear |
| 20:35.08 | rmudgett | arg still there |
| 20:35.39 | gtjoseph | what is? |
| 20:35.49 | rmudgett | build.mak got recreated |
| 20:35.54 | gtjoseph | yeah is should |
| 20:36.02 | gtjoseph | but it should work now |
| 20:36.50 | rmudgett | from a distclean? make stopped because of the invalid /version.mak reference |
| 20:37.07 | gtjoseph | you're killing me |
| 20:37.22 | rmudgett | :) |
| 20:37.28 | gtjoseph | are you doing this from the top-level directory or third-party/pjproject? |
| 20:37.49 | rmudgett | The make was the top level |
| 20:38.05 | gtjoseph | ok, let's try this... |
| 20:38.32 | gtjoseph | cd third-party/pjproject ; rm -rf source build.mak ; cd - |
| 20:38.44 | gtjoseph | make distclean |
| 20:38.54 | gtjoseph | ./configure <no other options> |
| 20:39.08 | gtjoseph | cd third-party/pjproject |
| 20:39.11 | gtjoseph | make configure |
| 20:40.32 | *** join/#asterisk-dev klow (~textual@96-81-150-137-static.hfc.comcastbusiness.net) |
| 20:41.58 | rmudgett | done |
| 20:42.06 | gtjoseph | did it work? |
| 20:42.17 | rmudgett | yes |
| 20:42.26 | gtjoseph | ok... |
| 20:42.28 | gtjoseph | cd - |
| 20:42.36 | gtjoseph | ./configure --with-pjproject-bundles |
| 20:42.40 | gtjoseph | ./configure --with-pjproject-bundled |
| 20:45.18 | rmudgett | ok |
| 20:45.25 | gtjoseph | did it work? |
| 20:45.39 | rmudgett | configure did I'll start make |
| 20:45.43 | gtjoseph | not yet |
| 20:45.54 | rmudgett | k |
| 20:45.56 | gtjoseph | cd third-party/pjproject |
| 20:46.00 | gtjoseph | make |
| 20:46.37 | rmudgett | that didn't work menuselect hasn't been run yet |
| 20:46.49 | gtjoseph | oh, duh |
| 20:47.04 | rmudgett | I'll just make menuselect |
| 20:47.16 | gtjoseph | yeah, you have to run menuselect at least once in the top level directory to generate menuselect.makeopts |
| 20:47.49 | rmudgett | now doing third-party/pjproject make |
| 20:48.38 | rmudgett | done |
| 20:48.45 | gtjoseph | did it work? |
| 20:48.54 | rmudgett | no errors reported |
| 20:49.08 | gtjoseph | cool, now try a complete make from the top-level |
| 20:49.43 | rmudgett | still trying to find /version.mak |
| 20:50.08 | rmudgett | should eventually fail |
| 20:50.31 | gtjoseph | WTF? |
| 20:52.39 | rmudgett | and there it went |
| 20:54.26 | gtjoseph | i don't understand why PJDIR isn't getting set when you run it form the top-level |
| 20:54.33 | gtjoseph | make cmenuselect |
| 20:54.41 | gtjoseph | wrong window. |
| 20:55.29 | gtjoseph | WHOA! It just failed for me |
| 20:57.02 | rmudgett | Just your friendly neighborhood canary :) |
| 20:57.22 | rmudgett | And Fiendish Automation is spaming the issues... |
| 21:06.36 | rmudgett | Is it possible make doesn't like doing the shell command with the export? |
| 21:06.56 | gtjoseph | that's what i'm thinking but it only seems to fail when from from top-level |
| 21:07.04 | gtjoseph | run from |
| 21:07.33 | file | rmudgett, I'm okay with his spamming |
| 21:07.36 | file | :P |
| 21:12.15 | putnopvut | btw, gonna chime in with a "fails for me, too bruh" |
| 21:12.34 | gtjoseph | am I the "bruh"? |
| 21:13.09 | putnopvut | whoever's reading it is |
| 21:13.30 | file | I'm not reading. |
| 21:17.29 | rmudgett | you're file |
| 21:17.35 | file | hi |
| 21:19.46 | coreyfarrell | gtjoseph: I just hit the error as well, I think it's failing while trying to 'make .lastclean' |
| 21:20.02 | gtjoseph | yteah it's bizarre |
| 21:24.08 | coreyfarrell | gtjoseph: main/Makefile has '-include $(ASTTOPDIR)/$(PJPROJECT_DIR)/build.mak' |
| 21:24.12 | coreyfarrell | I bet that's the problem |
| 21:24.21 | gtjoseph | possibly |
| 21:24.30 | gtjoseph | ah, probably |
| 21:24.55 | coreyfarrell | well I have to run be back in like an hour if you still need help |
| 21:25.07 | gtjoseph | nah, thanks |
| 21:25.14 | gtjoseph | i'm pretty sure that's it |
| 21:26.38 | file | if you're going to break something, make it BOLD, that's what I say |
| 21:28.16 | gtjoseph | rmudgett: add "PJDIR=$(ASTTOPDIR)/$(PJPROJECT_DIR)/source" to main/Makefile just before line 257 and see if it works. |
| 21:29.31 | gtjoseph | oops, actually line 256 |
| 21:29.46 | gtjoseph | just before "-include $(ASTTOPDIR)/$(PJPROJECT_DIR)/build.mak" |
| 21:32.17 | rmudgett | building... |
| 21:35.00 | coreyfarrell | gtjoseph: back for a bit.. is that include from main/Makefile just for getting the filenames of libpj*.a for linking? if so maybe the '-include' should be excluded for 'make clean'? |
| 21:35.56 | gtjoseph | well, regardless, PJDIP still has to be sed befor eincluding it |
| 21:36.00 | gtjoseph | PJDIR |
| 21:36.26 | gtjoseph | jeez... PJSIP still has to be set before including it |
| 21:36.46 | gtjoseph | s/PJSIP/PJDIR |
| 21:39.26 | rmudgett | quick build worked. Restarted from a distclean and building everyting... |
| 21:39.56 | gtjoseph | ok, thanks |
| 21:40.11 | rmudgett | Didn't see the error at the start of the build like before |
| 21:48.51 | rmudgett | build completed successfully |
| 21:49.37 | gtjoseph | ok, good |
| 22:04.19 | gtjoseph | patches up for bundled fix |
| 22:10.00 | *** join/#asterisk-dev klow (~textual@96-81-150-137-static.hfc.comcastbusiness.net) |
| 22:38.31 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-jfqjjdbrhdcidcij) |
| 22:43.04 | *** join/#asterisk-dev WIMPy (~wimpy@85.183.95.26) |
| 22:43.51 | *** join/#asterisk-dev klow (~textual@96-81-150-137-static.hfc.comcastbusiness.net) |
| 23:36.51 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 23:52.11 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |