| 00:23.19 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-ylkqbuppxnohefbr) |
| 00:42.29 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 00:42.29 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 01:47.21 | *** join/#asterisk-dev cresl1n (~Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 01:47.21 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 04:22.55 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 04:22.55 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:28.24 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 04:28.24 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 05:01.47 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 06:11.30 | *** join/#asterisk-dev bof22 (~Thunderbi@ARennes-650-1-165-208.w92-135.abo.wanadoo.fr) |
| 06:29.23 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-86-98.dhcp.nwtn.ct.charter.com) |
| 06:29.23 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 06:39.15 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 06:54.43 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:05.09 | *** join/#asterisk-dev snuff-work (~snuff-wor@203.87.61.22) |
| 07:05.09 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 07:44.25 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:03.23 | *** join/#asterisk-dev jkroon (~jkroon@dustpuppy.is.co.za) |
| 08:05.40 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:05.40 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:15.25 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:21.46 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-86-98.dhcp.nwtn.ct.charter.com) |
| 08:21.46 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 09:49.33 | *** join/#asterisk-dev ixyd (~denzs@carbon.gonicus.de) |
| 10:03.27 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lcy44-2-88-161-121-174.fbx.proxad.net) |
| 13:11.27 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 13:11.27 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:06.03 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-arccoytsedlbojdd) |
| 14:06.03 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:15.27 | gtjoseph | file: can you explain in english the logic change in sip_resolve_handle_naptr for review 4358 |
| 14:15.36 | file | no. |
| 14:15.38 | file | :D |
| 14:15.49 | file | as a comment in the code? |
| 14:15.56 | gtjoseph | no just here |
| 14:16.13 | gtjoseph | it's too early for me to follow the negatives |
| 14:16.33 | file | transport may already be an IPv6 transport |
| 14:16.39 | gtjoseph | the caffeine hasn't permeated my brain yet |
| 14:17.07 | file | the second part only checks for an IPv6 transport if it's not already one |
| 14:17.46 | gtjoseph | but if it's not available why check for ipv6? |
| 14:18.18 | file | because when you request a non-IPv6 transport you have to check for both IPv4 and IPv6 transports |
| 14:18.44 | file | ie: sip:test.com;transport=udp |
| 14:18.47 | gtjoseph | digesting |
| 14:18.53 | file | you'd want to check for both IPv4 and IPv6 addresses and transports |
| 14:19.30 | file | however if you explicitly set on an endpoint a transport that is IPv6 only, that information is given to the resolver and it can look for only IPv6 |
| 14:19.57 | file | if you explicitly set on an endpoint an IPv4 only transport, that information IS NOT given to the resolver in a way that you can only look for IPv4 |
| 14:20.21 | file | because it can't differentiate between you asking for udp in a SIP URI and having a transport set on an endpoint |
| 14:20.43 | file | so if it's not IPv6... it looks for both |
| 14:21.21 | gtjoseph | i take back what i said about "no only here" :) |
| 14:21.29 | file | :D |
| 14:22.58 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 14:22.58 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 14:25.43 | file | there is now a comment in the sip_resolve function explaining things |
| 14:52.24 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 15:07.49 | gtjoseph | yeah but it's not where that logic is :) |
| 15:08.45 | file | the logic is in multiple places |
| 15:09.04 | file | there's some of it in the SRV code too :P |
| 15:09.26 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-dzquehfgltcfamfq) |
| 15:09.26 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:09.31 | gtjoseph | yes but that "if" statement in naptr is the one that triggered my question |
| 15:10.17 | gtjoseph | having to read 300 lines down for the explanation isn't obvious. :) |
| 15:10.34 | file | 'll add another |
| 15:10.52 | gtjoseph | thanks |
| 15:19.59 | gtjoseph | file: are the tests going to pass without the resolver patch? |
| 15:20.07 | file | no |
| 15:33.09 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 15:58.40 | *** join/#asterisk-dev newtonr (RustyNewto@nat/digium/x-nlrkeftwcbubypsg) |
| 15:58.40 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:58.41 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-vsnbzgxdhteilyob) |
| 15:58.41 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:42.20 | file | oh now that is interesting |
| 16:42.35 | file | huh |
| 16:43.38 | file | if res_srtp is not loaded and we get an offer with required crypto we sent back a declined audio stream |
| 16:43.40 | file | we don't 488 |
| 16:44.53 | file | that's not very nice |
| 16:50.50 | file | ah |
| 17:58.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00e04ee8aa85912832.ipv6.abo.wanadoo.fr) |
| 18:29.56 | *** join/#asterisk-dev jkroon (~jkroon@105.11.225.226) |
| 19:24.23 | *** join/#asterisk-dev tuxian_ (~tuxian@194.12.3.78) |
| 19:36.32 | *** join/#asterisk-dev tuxian_ (~tuxian@igilmour.plus.com) |
| 19:40.21 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 19:40.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:46.37 | cj | hurm |
| 19:47.10 | cj | what should I use for my gerrit repo in asterisk/.git/config ? |
| 19:48.24 | file | the git review tool will automatically take care of that |
| 19:49.17 | file | it is highly suggested that you use it as it makes it vastly easily |
| 19:49.19 | file | er easier |
| 19:51.40 | cj | We don't know where your gerrit is. Please manually create a remote |
| 19:51.45 | cj | named "gerrit" and try again. |
| 19:51.58 | cj | sorry, I meant to use the word "remote" and not "repo" |
| 19:52.10 | file | how did you clone the repo and from where? |
| 19:52.34 | cj | I think I initially cloned from github, then I changed the origin line and did a fetch |
| 19:52.49 | file | interesting... |
| 19:53.10 | file | is there a .gitreview file? |
| 19:53.33 | file | and the gerrit remote is ssh://<username>@gerrit.asterisk.org:29418/asterisk.git |
| 19:53.36 | cj | yes. looks right to me |
| 19:53.37 | file | where <username> is your gerrit username |
| 19:55.06 | cj | ah, looks like I missed the .git suffix |
| 19:56.33 | cj | also looks like I needed to set a username |
| 19:57.08 | file | indeed |
| 19:57.56 | cj | $ gitdir=$(git rev-parse --git-dir); scp -p -P 29418 cjac@gerrit.asterisk.org:hooks/commit-msg ${gitdir}/hooks/ |
| 19:57.59 | cj | .git/hooks//commit-msg: Permission denied |
| 19:58.36 | file | that would be on your local system |
| 19:59.25 | cj | oh, I see. tee hee. |
| 20:03.09 | cj | *whew* I guess the prereqs are now complete: |
| 20:03.10 | cj | https://gerrit.asterisk.org/4380 |
| 20:03.21 | file | yup |
| 20:03.34 | file | the commit message doesn't fit standards, but we can fix that |
| 20:04.46 | cj | ok. I'll look at that link Thanh keeps pointing me at... |
| 20:05.05 | cj | http://chris.beams.io/posts/git-commit/ <- is this your standard? |
| 20:05.22 | file | https://wiki.asterisk.org/wiki/display/AST/Commit+Messages |
| 20:09.38 | cj | the "subsystem" referred to in that wiki page... does that directly map to what JIRA calls "Component/s"? |
| 20:10.49 | file | yes, you can also use something reasonable |
| 20:10.53 | file | in this case chan_sip |
| 20:12.08 | kharwell | k |
| 20:12.24 | kharwell | whoops that's not emacs |
| 20:12.56 | rmudgett | kharwell: I thought you were acknowledging for cj :) |
| 20:13.50 | cj | alright. I'm ready for a +2 and merge :-) |
| 20:17.14 | file | it has to verify before it can |
| 20:23.27 | cj | ah. what does the verify check? Jenkins? |
| 20:25.23 | cj | thanks for the help with the commit message, file. And for the +1, rmudgett |
| 20:29.47 | file | yup yup! |
| 20:29.58 | file | and yes, Jenkins does a verify check which is just build/unit tests |
| 20:30.08 | cj | crossgrades sip0.colliertech.org from i386 to amd64 |
| 20:30.10 | file | then when +2 is done it'll do more tests and auto-merge |
| 20:30.23 | cj | cool, that's how we do it, too. |
| 20:30.49 | cj | the jenkins verify seems a lot slower with gerrit.asterisk.org, though... |
| 20:31.13 | cj | are you starved for jenkins executor nodes? |
| 20:31.14 | file | there's lots of stuff already in progress running tests to merge earlier changes |
| 20:31.25 | file | we have 9 |
| 20:31.47 | cj | that seems like it should be sufficient. do you have pipelining with task dependencies maybe? |
| 20:31.59 | file | it's that it takes a long time to run Asterisk tests |
| 20:32.32 | file | some tests are fast, some tests are slower because it actually does calls/transfers/etc |
| 20:34.57 | cj | ah, using zuul even, eh? I think maybe Gerrit should put a message in the history log when it gets confirmation that the job has been submitted. |
| 20:35.19 | cj | but I don't really want to write any java, so I might just deal with it the way that it is :-) |
| 20:35.29 | file | noone wants to write any Java. |
| 20:36.02 | file | anyone who does is mad, MAD I SAY! |
| 20:36.06 | file | eyes leedm777 |
| 20:38.18 | leedm777 | throws a RuntimeException |
| 20:39.00 | file | what are you - an Atlassian product now? |
| 20:39.53 | leedm777 | file: Then I would have thrown an OutOfMemory exception. |
| 20:40.00 | file | good point |
| 21:50.19 | jameswf | its 2016, who talks on the phone longer than 2 minutes.... if it involves that much talking send me an email |
| 21:50.46 | jameswf | or a fax |
| 22:06.21 | cj | furrfu. i386 -> amd64 crossgrade complete. |
| 22:08.42 | cj | now building the sid package on jessie (fingers crossed) |
| 23:02.48 | *** join/#asterisk-dev snuff-work (~snuff-wor@203.87.61.22) |
| 23:02.48 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 23:54.04 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 23:54.04 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:55.53 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 23:55.53 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |