| 00:10.22 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-dzquehfgltcfamfq) |
| 00:24.01 | newtonr | @gtjoseph, you around? |
| 00:24.11 | newtonr | gtjoseph, I mean you |
| 00:27.01 | newtonr | nevermind! |
| 06:06.21 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 06:37.13 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 06:37.13 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 06:40.51 | *** join/#asterisk-dev ixyd (~denzs@b2b-46-252-133-250.unitymedia.biz) |
| 06:46.27 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 07:05.59 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 07:58.41 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 08:08.56 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 09:02.48 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 09:32.20 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 09:32.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:05.12 | *** join/#asterisk-dev jay89234 (596922e2@gateway/web/freenode/ip.89.105.34.226) |
| 10:06.12 | jay89234 | Hello, I have a segfault in asterisk 14.1.1 res/res_format_attr_opus.c line 120. The file is un-changed in 14.1.2. |
| 10:06.13 | jay89234 | #0 0x00007ff5071dc944 in sdp_fmtp_get (attr=<optimized out>, name=<optimized out>, attributes=<optimized out>) at res_format_attr_opus.c:120 #1 sdp_fmtp_get (attributes=<optimized out>, name=0x7ff5071de32c "ptime", attr=0x7ff4fc0548f8) at res_format_attr_opus.c:120 |
| 10:06.51 | jay89234 | Extremely hairy code around that line btw :) |
| 10:08.18 | jay89234 | It stack overflows due to recursive call |
| 10:15.28 | file | Please file an issue on issues.asterisk.org with console output including SIP trace and back trace with DONT_OPTIMIZE set in menuselect for compiler flags |
| 10:16.24 | jay89234 | How do you become a member there? |
| 10:19.05 | file | There's a large link on the left hand side that goes to signup.asterisk.org |
| 10:20.40 | jay89234 | thanks :) |
| 11:45.35 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 13:14.48 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 13:18.38 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 13:18.38 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:49.03 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 14:20.09 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 14:25.34 | file | anyone have suggestions on https://issues.asterisk.org/jira/browse/ASTERISK-26551 ? |
| 14:58.46 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 15:01.50 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 15:06.30 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-qbxebawbdywpcrud) |
| 15:06.30 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:07.36 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 15:07.36 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:09.03 | *** join/#asterisk-dev sgriepentrog (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:52.23 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qmydheftzqrmzgia) |
| 15:52.23 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:56.03 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 16:03.28 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 16:14.13 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-xlzuwpwynvgbmlij) |
| 16:14.13 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:44.26 | *** join/#asterisk-dev mjordan (mjordan@nat/digium/x-logkpciymivljnvw) |
| 16:44.26 | *** mode/#asterisk-dev [+o mjordan] by ChanServ |
| 16:46.05 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-dnsjbotxquiaasrj) |
| 16:46.05 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:58.07 | rmudgett | gtjoseph: ping |
| 16:59.29 | gtjoseph | in the send_request review for 13 line 3451... |
| 16:59.31 | gtjoseph | Just calling init doesn't put the timer in the correct state. You have to set TIMER_INACTIVE before calling schedule and at the time I wrote this, there was no other way to do it. If pjproject changed since then, that's great but I don't think so. |
| 17:00.20 | rmudgett | I'll look at that again. |
| 17:01.15 | gtjoseph | i was a while ago but at the time it was stupid pretty stupid. i couldn't figure out why the timer wasn't working. IIRC it was expiring immediately. |
| 17:02.37 | rmudgett | It is the TIMER_INACTIVE parameter value that doesn't get set? |
| 17:02.38 | *** part/#asterisk-dev hexanol (~bibi@modemcable094.94-70-69.static.videotron.ca) |
| 17:03.01 | gtjoseph | i _think_ so but like i said, it was a while ago. |
| 17:04.08 | gtjoseph | the only thing i can remember clearly about it was that i had to put it there and it was stupid that i had to. :) |
| 17:04.27 | rmudgett | I think I may be to blame for that. |
| 17:04.41 | gtjoseph | i don't think so |
| 17:04.52 | rmudgett | Need to look at the original review that put it in. |
| 17:07.51 | gtjoseph | was commit 60e2fbfe6 |
| 17:09.10 | gtjoseph | at least that's the last time it was touched |
| 17:12.30 | rmudgett | I still think I was to blame for that. |
| 17:13.00 | gtjoseph | bf46799f0e9836fc6c84b9c814faef4156e625d9 |
| 17:13.08 | gtjoseph | ther original commit: |
| 17:49.03 | rmudgett | gtjoseph: The pjproject timer code has not changed for any version used by Asterisk for pjsip. |
| 17:49.23 | gtjoseph | yeah that's what I thought. |
| 17:50.20 | gtjoseph | it's still possible that I got it wrong initially and the TIMER_INACTIVE isn't needed |
| 17:50.22 | rmudgett | And thus I'm likely to blame for that sillyness of canceling a timer right after we created it. |
| 17:50.50 | gtjoseph | well, we can certainly test it |
| 17:50.53 | rmudgett | The TIMER_INACTIVE is used as a flag in the callbacks to see if the timer is running. |
| 18:21.01 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 18:27.01 | kharwell | according to this page: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=5243109 in order for packet loss to be propagated to a codec the codec itself needs to have nativeplc=1 and jitterbuffers have to be in use. |
| 18:27.19 | kharwell | At that point from within the codec one could check for an interpolation frame. |
| 18:27.42 | kharwell | Is this still the way it works? If so what on the frame needs to be checked? datalen? seq? |
| 18:28.08 | file | I doubt it's been changed, an interop frame would have a datalen of 0 and a samples greater than 0 |
| 18:29.18 | file | but you should still be able to detect the situation by keeping track of the seqno of incoming frames |
| 18:29.36 | file | from within a codec |
| 18:30.01 | kharwell | hrm I am not seeing any frames come across with a datalen=0. I might not be setting up the jitterbuffer correctly though |
| 18:30.26 | kharwell | to check the out of order seqno do you still have to have the jitterbuffer enabled? |
| 18:30.43 | file | no |
| 18:31.31 | kharwell | I'm guessing it will be out of order? So I should be able to keep track of the last seqno and if the next one in is not seqno+1 I can assume a lost packet? |
| 18:31.53 | file | it won't be out of order, but there will be a gap |
| 18:32.18 | kharwell | okay cool. I'll give that a shot |
| 20:06.20 | *** join/#asterisk-dev philipp64|macmin (~chatzilla@66-232-81-197.ctcweb.net) |
| 20:16.39 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-jicbyvfbnzfvozwg) |
| 20:16.39 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 23:43.49 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-jicbyvfbnzfvozwg) |