| 00:24.46 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-bjvvclbenxmzfwzi) |
| 00:54.42 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 01:31.31 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 02:03.15 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 02:03.15 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 02:16.07 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 02:16.07 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 02:16.41 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 02:31.18 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 02:31.18 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 03:30.20 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 03:30.35 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:801b:381f:59f8:773a:feef) |
| 03:30.35 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:21.32 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 05:02.51 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:801b:657f:b2cd:55c4:103e) |
| 05:02.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 05:39.15 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:801b:3d47:4828:9dc2:ecd3) |
| 05:39.15 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 06:30.18 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.222.253) |
| 06:40.59 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 06:47.54 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 07:49.41 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:52.59 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:01.43 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:10.53 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:10.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:20.35 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 08:20.35 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:38.51 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 08:38.51 | *** mode/#asterisk-dev [+o wdoekes] by ChanServ |
| 08:41.06 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 08:41.06 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 08:43.54 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::10de) |
| 08:54.54 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 08:54.54 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 09:05.26 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 09:08.04 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:18.56 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 09:18.56 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 10:13.39 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 10:22.32 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 10:22.32 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:41.39 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 11:41.39 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 12:29.06 | tsearle | dpkg-shlibdeps: error: couldn't find library libcurl.so.4 needed by debian/asterisk-core/usr/lib/asterisk/modules/codec_opus.so (ELF format: 'elf64-x86-64'; RPATH: '') |
| 12:29.20 | tsearle | what does opus codec need libcurl for? |
| 12:32.10 | file | it uses it for reporting the usage information to us |
| 12:32.29 | tsearle | also, shouldn't configure check for the dependency if codec_opus is enabled? |
| 12:32.38 | tsearle | ok |
| 12:33.00 | tsearle | so if the traffic is blocked by a firewall, the codec will work ok? |
| 12:33.04 | file | yes |
| 12:33.36 | tsearle | cool, our network guys get pretty strict these days |
| 12:39.09 | tsearle | and the xml documentation that comes with the codecs, does that get fed somewhere to generate config files? |
| 12:39.33 | file | no, it's there for the CLI inspection stuff for documentation |
| 12:40.50 | tsearle | you mean the asterisk cli? |
| 12:46.28 | gtjoseph | yes, he means the asterisk cli. :) |
| 12:47.07 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 12:58.47 | file | The one CLI to rule it all |
| 13:02.38 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:801b:347d:7f3d:2617:62c3) |
| 13:02.38 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:30.40 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 13:30.40 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 13:36.27 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 13:36.28 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:41.16 | *** join/#asterisk-dev Northcode_ (55c3fff2@gateway/web/freenode/ip.85.195.255.242) |
| 13:43.46 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-dcblvaidgmssfxyy) |
| 13:43.47 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:44.03 | tsearle | is digium down? |
| 13:44.19 | tsearle | can reach downloads.digum.com nor wiki.asterisk.org |
| 13:44.25 | tsearle | (can't) |
| 13:44.54 | gtjoseph | working for me (colorado) |
| 13:45.05 | file | same here, working for me |
| 13:45.29 | tsearle | ok, so must be a belgian issue then... |
| 13:46.20 | file | what's a traceroute look like? |
| 13:47.34 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 13:47.34 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:47.49 | file | seems to be a bit wonky... |
| 13:48.02 | tsearle | <PROTECTED> |
| 13:48.03 | tsearle | <PROTECTED> |
| 13:48.03 | tsearle | <PROTECTED> |
| 13:48.03 | tsearle | <PROTECTED> |
| 13:48.03 | tsearle | <PROTECTED> |
| 13:48.03 | tsearle | <PROTECTED> |
| 13:48.05 | tsearle | <PROTECTED> |
| 13:48.07 | tsearle | <PROTECTED> |
| 13:48.09 | tsearle | <PROTECTED> |
| 13:48.11 | tsearle | 10 * * * |
| 13:48.13 | tsearle | 11 * 10ge14-7.core1.ash1.he.net (72.52.92.137) 583.077 ms * |
| 13:48.15 | tsearle | 12 * * * |
| 13:48.17 | tsearle | 13 * * * |
| 13:48.19 | tsearle | 14 * static-76-164-170-41.apid.com (76.164.170.41) 277.131 ms * |
| 13:48.21 | tsearle | 15 dsl2-67-58-77-186.apid.com (67.58.77.186) 173.964 ms * * |
| 13:48.23 | tsearle | 16 * * * |
| 13:48.25 | tsearle | 17 * * * |
| 13:48.27 | tsearle | 18 * * * |
| 13:48.31 | tsearle | 19 * * * |
| 13:48.33 | tsearle | 20 * * * |
| 13:48.35 | tsearle | 21 * * * |
| 13:48.37 | tsearle | 22 * * * |
| 13:48.39 | tsearle | 23 * * * |
| 13:48.41 | tsearle | 24 * * * |
| 13:48.43 | tsearle | 25 * * * |
| 13:48.45 | tsearle | 26 * * * |
| 13:48.47 | tsearle | 27 * shooty.asterisk.org (76.164.171.238) 289.116 ms * |
| 13:48.49 | tsearle | sometimes can't connect, sometimes connects at sub-dialup speeds |
| 13:48.53 | tsearle | eta 4h do d/l opus, heh |
| 13:49.00 | file | yeah, just noticing that |
| 13:49.20 | gtjoseph | digium had an outage last night |
| 13:49.27 | gtjoseph | i wonder if there are still issues |
| 13:50.04 | tsearle | was working earlier today, was able to d/l the 64 bit binary, then the world froze when I started to d/l i386 |
| 13:50.32 | file | gtjoseph: yeah Mark hasn't done a follow-up so it wouldn't surprise me if API is still wonky |
| 13:50.42 | gtjoseph | yep |
| 14:08.45 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 14:31.18 | seanbright | file: in https://gerrit.asterisk.org/#/c/4854/ (the master branch patch), i removed the bit fields and just used ints for the two fields. just want to make sure you noticed that when you were reviewing. |
| 14:31.32 | file | I did |
| 14:31.34 | seanbright | k |
| 14:31.51 | gtjoseph | so it's not the same for 13, 14 and master? |
| 14:31.58 | seanbright | its the same for 13 & 14 |
| 14:32.01 | seanbright | different for master |
| 14:32.26 | gtjoseph | the problem is that the next time someone makes a change that's near the code you changed, a cherry-pick to master will fail |
| 14:32.33 | seanbright | i mean... there's no reason that 'smooth' has to be 4 bytes |
| 14:33.00 | seanbright | the surface area of the relevant change is 2 lines in codec.h |
| 14:33.15 | seanbright | smooth:1, smoother_flags:3 -> smooth, smoother_flags |
| 14:33.16 | gtjoseph | i realize that but git doesn't care. :) |
| 14:33.25 | seanbright | ok |
| 14:33.43 | seanbright | so help me understand |
| 14:33.48 | gtjoseph | file: opinion? |
| 14:33.52 | seanbright | how does one "break" master in the right way |
| 14:34.00 | seanbright | otherwise no progress can be made |
| 14:34.08 | file | I don't think it's that important, the likelihood of someone changing codec.h is minimal |
| 14:34.21 | file | or the smoother stuff either |
| 14:34.39 | gtjoseph | ok. |
| 14:34.42 | file | big changes are likely to come to that in the future anyway which will make cherry picks problematic |
| 14:35.42 | seanbright | i don't care one way or the other. having the smoother_flags be a bitfield just makes adding flags in the future problematic because you have to know it's only 3 bits wide |
| 14:36.15 | gtjoseph | is there an enum value that defines a 3 bit mask? |
| 14:36.23 | gtjoseph | that's usually how we do it |
| 14:36.34 | seanbright | https://gerrit.asterisk.org/#/c/4853/1/include/asterisk/smoother.h |
| 14:36.53 | seanbright | just added to what was already there |
| 14:37.14 | gtjoseph | ah it wasn't an enum to begin with |
| 14:37.20 | seanbright | right |
| 14:37.42 | gtjoseph | ok, no worries then |
| 14:40.11 | file | worry pas |
| 14:41.40 | seanbright | what does it need to merge? another code review? |
| 14:42.27 | file | I don't understand the question |
| 14:42.39 | seanbright | in order for my code to be merged, what is required within gerrit? |
| 14:42.44 | seanbright | another +1? |
| 14:42.53 | file | someone else to +1 and then someone to +2 |
| 14:42.58 | seanbright | got it |
| 14:43.01 | file | that could be the same person |
| 14:43.14 | gtjoseph | i'll look in a bit |
| 14:43.22 | seanbright | no rush. was just curious. |
| 14:43.38 | seanbright | i have another patch that is quasi-related i'd like to put up afterwards. |
| 14:59.08 | *** join/#asterisk-dev oej (~oej@194.15.212.5) |
| 14:59.08 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 15:04.37 | file | Actually... |
| 15:05.23 | file | Can we enforce it based on the format in the smoother usage and not have to change stuff elsewhere? |
| 15:05.49 | file | George brought up that it still breaks ABI |
| 15:08.16 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-oqldwtoxbjbufkdu) |
| 15:08.16 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:10.37 | seanbright | hmm, let me take a look |
| 15:11.02 | seanbright | can you explain how it breaks ABI? |
| 15:12.13 | file | points at gtjoseph |
| 15:12.28 | file | you two hash it out, my brain is currently holding a threading race condition |
| 15:12.31 | seanbright | ok |
| 15:13.54 | gtjoseph | i just commented... basically you split an int into 2 unsigned int bitfields |
| 15:14.06 | seanbright | its the same int |
| 15:14.14 | seanbright | it's just split into two |
| 15:14.18 | gtjoseph | there's no guarantee that the compiler will combine the storage to be the same size as the originbal int |
| 15:14.38 | seanbright | there isn't? |
| 15:14.46 | seanbright | where is the abi reference? |
| 15:15.13 | gtjoseph | the abi reference is "you can't add things in the middle of a structure" |
| 15:15.24 | seanbright | right, and i'm not |
| 15:15.36 | gtjoseph | in this case, it MAY pushes mod down by the size of an int |
| 15:15.49 | seanbright | if i changed it to two shorts would that worok? |
| 15:15.53 | gtjoseph | nope |
| 15:16.04 | gtjoseph | you have to use a union, __padding, and a struct |
| 15:16.10 | gtjoseph | look in indications.h |
| 15:16.11 | seanbright | interesting |
| 15:16.14 | gtjoseph | there are examples |
| 15:16.23 | gtjoseph | why split it in the first place? |
| 15:16.23 | seanbright | is that specified somewhere? |
| 15:16.33 | gtjoseph | is what specified? |
| 15:16.41 | seanbright | like... what can i read that backs up what you are saying? |
| 15:16.49 | gtjoseph | gcc manual |
| 15:16.52 | seanbright | ok, thanks |
| 15:17.47 | gtjoseph | it's not that it won't work, it's that whether it works or not may depend on optimization and 64/32 bit |
| 15:18.08 | gtjoseph | why split the field anyway? |
| 15:18.17 | seanbright | because it is cleaner |
| 15:18.21 | seanbright | and i'm pretty sure it's valid |
| 15:18.28 | seanbright | i just need to find out how things are laid out |
| 15:18.35 | seanbright | still searching the gcc manual |
| 15:18.56 | gtjoseph | sure it is, just need to maintain the compatibility |
| 15:19.05 | seanbright | right |
| 15:19.07 | seanbright | and i think it is |
| 15:19.12 | seanbright | that's what i'm trying to confirm :-) |
| 15:19.32 | seanbright | i gotta think this is c standard info and not gcc manual |
| 15:19.34 | gtjoseph | you could also leave smooth defined exactly as it is and add smooth flags to the end of the structure |
| 15:19.38 | seanbright | but i don't have the c standard in front of me |
| 15:20.23 | seanbright | ok, implementation defined |
| 15:21.20 | gtjoseph | since you added a completely new int in master anyway, just do the same in 13/14 |
| 15:21.28 | seanbright | meh |
| 15:21.30 | file | grumbles as his idea does not pan out |
| 15:21.31 | seanbright | ugly |
| 15:21.36 | seanbright | i'll do what file suggested |
| 15:21.45 | gtjoseph | what did he suggest? |
| 15:21.55 | seanbright | just hard-code a check for slin in res_rtp_asterisk |
| 15:22.01 | seanbright | will do that in 13 & 14 |
| 15:22.03 | file | slin is the only special thing really |
| 15:22.11 | file | (for that) |
| 15:22.21 | gtjoseph | but again, we're doing the same thing 2 different ways |
| 15:22.32 | seanbright | no |
| 15:22.34 | seanbright | i don't think so |
| 15:22.40 | seanbright | we're hacking in a fix for release versions |
| 15:22.40 | gtjoseph | if adding a separate field worked in master, do the same in 13/14 |
| 15:22.45 | seanbright | doing it right for unreleased versions |
| 15:22.52 | seanbright | i don't want to add a field to the end of the structure |
| 15:22.55 | seanbright | that is ugly |
| 15:22.56 | gtjoseph | why? |
| 15:23.01 | seanbright | because it's ugly |
| 15:23.06 | seanbright | inelegant |
| 15:23.22 | gtjoseph | it's better than 2 implementations that someone else will have to figure out later |
| 15:23.36 | seanbright | ok |
| 15:23.42 | seanbright | will you -1 if i do it the way i want to? |
| 15:23.45 | seanbright | if so i won't bother |
| 15:23.50 | gtjoseph | yeah, sorry. |
| 15:23.53 | seanbright | no sweat |
| 15:30.55 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-dqqegdtkkjpzzuth) |
| 15:30.55 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:44.29 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 15:44.30 | file | gtjoseph: there's now a change which minimally alters things to fix the specific issue and doesn't change ABI |
| 15:45.25 | seanbright | i guess i should actually test this change... |
| 15:45.28 | seanbright | one moment |
| 15:45.57 | file | if your previous change worked, that one should too |
| 15:46.17 | seanbright | agreed, but it can't hurt to test (or... you know... compile) |
| 15:46.44 | file | minor detail |
| 15:54.22 | seanbright | i think this version of the patch would have been fine: https://gerrit.asterisk.org/#/c/4843/4 |
| 15:55.16 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 15:55.16 | *** mode/#asterisk-dev [+o DivideBy0] by ChanServ |
| 15:55.25 | seanbright | ok, it compiles. |
| 15:58.58 | seanbright | and works. |
| 15:59.00 | seanbright | hurrah. |
| 15:59.27 | file | cookies for all |
| 15:59.50 | tsearle | yay! cookies! |
| 16:24.10 | *** join/#asterisk-dev anonymouz666 (bd191ff7@gateway/web/freenode/ip.189.25.31.247) |
| 18:44.37 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 19:08.37 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 19:08.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:17.45 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 19:17.45 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 19:28.35 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 19:42.59 | *** join/#asterisk-dev tzafrir (~tzafrir@82.81.175.197) |
| 19:42.59 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:58.02 | seanbright | file: gtjoseph: thanks! |
| 19:58.09 | gtjoseph | no prob |
| 19:58.49 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 19:58.49 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 20:03.18 | file | moo |
| 20:04.37 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 20:18.17 | *** join/#asterisk-dev WIMPy (~wimpy@85.183.149.50) |
| 20:22.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0008c923479f703e3b.ipv6.abo.wanadoo.fr) |
| 20:37.38 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 20:53.05 | *** join/#asterisk-dev oej (~oej@h87-96-134-129.cust.se.alltele.net) |
| 20:53.05 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 21:00.59 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 22:16.18 | seanbright | can someone tell me the license # for this gentleman: |
| 22:16.19 | seanbright | https://issues.asterisk.org/jira/secure/ViewProfile.jspa?name=davidw |
| 22:19.32 | file | what's an issue where they have a patch? |
| 22:19.48 | seanbright | ASTERISK-21094 |
| 22:20.32 | file | 5737 |
| 22:20.56 | file | if you click the Dropdown on the far right of Attachments do you not have a "Manage Attachments" option? |
| 22:21.22 | seanbright | file: aha. |
| 22:21.24 | seanbright | thanks |
| 23:41.05 | *** join/#asterisk-dev yorick (~yorick@oftn/oswg-member/yorick) |
| 23:54.33 | *** join/#asterisk-dev tuxd00d (~tuxd00d@172.56.17.128) |