| 00:13.05 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-mhjlynvgjukjwkhy) |
| 00:53.01 | leifmadsen | Someone tell Mark Michelson thanks for his blog post about pjsip push config |
| 00:55.54 | file | leifmadsen: maybe I will maybe I won't |
| 00:56.19 | leifmadsen | file: OK! |
| 00:56.29 | leifmadsen | all I ask is that you maybe sometimes try to try |
| 00:56.38 | file | you could just Facebook him |
| 00:56.43 | leifmadsen | that reeks of effort |
| 00:56.51 | file | I know, I know |
| 00:56.53 | leifmadsen | I also don't really go on the FB any more |
| 00:56.54 | file | you're allergic to effort |
| 00:56.59 | leifmadsen | very much so |
| 00:57.12 | leifmadsen | although I'm kinda putting in some effort around documenting and testing things so that I can make an Asterisk VNF |
| 00:58.03 | file | oic |
| 00:58.32 | leifmadsen | https://github.com/redhat-nfvpe/vnf-asterisk |
| 01:01.40 | file | oic |
| 01:02.18 | leifmadsen | hoping to have something for OPNFV Summit in June |
| 01:02.47 | leifmadsen | should be fun |
| 01:03.12 | file | fun fun fun |
| 01:03.35 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-ejmtevguqbrezego) |
| 02:53.47 | *** join/#asterisk-dev libardi (~libardi@189.61.226.79) |
| 04:17.39 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-24.ph.ph.cox.net) |
| 06:24.13 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.42) |
| 06:57.00 | *** join/#asterisk-dev bof22 (~Thunderbi@185.13.183.107) |
| 07:54.53 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:09.37 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::152e) |
| 08:10.55 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 08:21.01 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:09.50 | *** join/#asterisk-dev jkroon_ (~jkroon@165.16.204.43) |
| 10:11.50 | *** join/#asterisk-dev jkroon__ (~jkroon@165.16.204.44) |
| 10:18.23 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 10:18.23 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 10:26.31 | *** join/#asterisk-dev tuxian (~tuxian@194.12.3.78) |
| 10:30.06 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.135.186) |
| 11:20.04 | *** join/#asterisk-dev bof23 (~Thunderbi@185.13.183.107) |
| 12:03.38 | *** join/#asterisk-dev pchero_work (~pchero@2a00:c80:1072::152e) |
| 13:19.20 | *** join/#asterisk-dev oej (~oej@81-235-187-59-no207.business.telia.com) |
| 13:19.20 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 13:25.01 | file | gtjoseph: how'd the test run go? |
| 13:25.31 | gtjoseph | More builtin_function_or_method' object has no attribute 'iteritems' |
| 13:25.43 | file | yeah... |
| 13:25.51 | gtjoseph | sifting through the results now |
| 13:26.27 | gtjoseph | ImportError: No module named sipp |
| 13:26.31 | gtjoseph | a few times |
| 13:27.03 | file | yeah, importing seems to be broken for some stuff |
| 13:27.28 | gtjoseph | ari seems to have taken the brunt of the issues |
| 13:27.46 | file | what was your total test failure count? |
| 13:28.15 | gtjoseph | <PROTECTED> |
| 13:28.18 | gtjoseph | BUT... |
| 13:28.33 | gtjoseph | i may have messed up while i was trying python3 |
| 13:28.44 | gtjoseph | i deleted pjsua :) |
| 13:28.49 | file | still, quite a few |
| 13:29.43 | gtjoseph | yeah. i'm gonna run a few of the failures on stock master to double check |
| 14:11.29 | gtjoseph | file: confirmed... rest_api in stock master = no failures. py3 = still running but 35% failure rate |
| 14:13.52 | file | gtjoseph: yeah... |
| 14:17.48 | gtjoseph | final for rest_api: Tests: 122 Passed: 65 Failed: 57 TimedOut: 0 Time: 8m 40sLongest test: 79s |
| 14:18.38 | file | ouchy |
| 14:19.57 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-tyxgrnthvfvrbgzp) |
| 14:27.26 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 14:27.26 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:37.21 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:37.22 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:37.48 | cresl1n | oh gerrit, you've forgotten me again |
| 14:54.19 | leifmadsen | maybe someone "fixed the glitch" |
| 14:57.50 | cresl1n | onsp |
| 14:58.05 | cresl1n | so witty... |
| 15:07.17 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-zqcgorwzjpyljnao) |
| 15:07.17 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:12.38 | seanbright | cresl1n: i have to log in to gerrit and jira a lot |
| 15:12.55 | seanbright | it's almost like they don't want me to participate. |
| 15:12.59 | seanbright | it's a conspiracy. |
| 15:51.59 | *** join/#asterisk-dev oej (~oej@host-95-195-194-100.mobileonline.telia.com) |
| 15:51.59 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 16:14.54 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-sriaahvzpdtnxerz) |
| 16:14.54 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:47.22 | *** join/#asterisk-dev newtonr (~newtonr@173-17-133-211.client.mchsi.com) |
| 16:47.22 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 16:53.42 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-32-13.wall.uls.co.za) |
| 17:41.37 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d001c85ca8ef8f18081.ipv6.abo.wanadoo.fr) |
| 18:32.09 | gtjoseph | file: in ast_read_stream, when reading from the read_stream callback, there's no check that AST_CHAN_TP_MULTISTREAM is actually set |
| 18:32.26 | gtjoseph | should there be? |
| 18:32.43 | file | I didn't do one because if you implement read_stream then support for multiple streams support is implied in my mind |
| 18:33.04 | gtjoseph | then do we need the property? |
| 18:33.20 | file | at all? yes, it's used for the automatic stream creation stuff |
| 18:33.31 | file | unless you mean we'd just check for the callback as indication of that |
| 18:33.33 | gtjoseph | it doesn't have to be |
| 18:33.52 | gtjoseph | we could check that write_stream and read_stream are not nulkl |
| 18:34.17 | gtjoseph | yeah |
| 18:34.25 | gtjoseph | we're doing it 2 ways |
| 18:34.32 | file | yeah |
| 18:34.38 | file | I'd be fine with that |
| 18:34.43 | gtjoseph | kk |
| 18:34.48 | gtjoseph | i'm making a list. |
| 18:34.55 | gtjoseph | bu tnot making the changes in this patch |
| 18:37.38 | seanbright | can someone just write a script to close all pre-13 issues with "Please re-open if you can reproduce with Asterisk 13 or higher" |
| 18:38.09 | file | seanbright: I tried crafting a query for automation to not allow issues to be opened against older versions, and that did not go well... |
| 18:39.01 | seanbright | meaning you broke something or people got pissed off? |
| 18:40.44 | file | it was not able to reliably determine the version |
| 18:42.24 | file | lemme go see what it did |
| 18:42.53 | file | project = ASTERISK AND affectedVersion < 11.0.0 |
| 18:43.23 | file | I disabled it when it auto-closed a valid issue |
| 18:43.42 | file | and now dog walk time |
| 19:06.37 | *** join/#asterisk-dev X-Rob (sid14615@gateway/web/irccloud.com/x-lrkbevkoariwzeex) |
| 19:09.29 | cresl1n | seanbirght, that's a great idea regardless |
| 19:09.37 | cresl1n | *seanbright rather |
| 19:19.18 | seanbright | it's a bit of a cop out |
| 19:19.29 | seanbright | but if we have no intention of fixing pre-13 bugs, why leave them open? |
| 19:31.24 | gtjoseph | file: if a format_cap has 2 audio entries and 2 video entrieswhat should the topology created by ast_stream_topology_create_from_format_cap look like? |
| 19:31.47 | file | 1 audio, 1 video |
| 19:32.57 | gtjoseph | ok. the capo on each stream would have 2 entries then |
| 19:33.09 | file | yes |
| 19:33.35 | gtjoseph | that's what it does. i was just double checking that that was the expected behavior |
| 19:49.29 | gtjoseph | file: ast_read is allowing frames with non default streams through when it pulls from the queue |
| 19:49.57 | file | k? |
| 19:50.28 | gtjoseph | it shouldn't be correct? |
| 19:50.34 | gtjoseph | should be null frame |
| 19:50.51 | file | yes |
| 19:51.55 | rmudgett | seanbright: "stale of cache" s/of/if |
| 19:53.04 | seanbright | UGHHH |
| 19:53.52 | seanbright | rmudgett: do you forsee having additional comments? if so i'll wait to revise. |
| 19:54.17 | rmudgett | Was just reading the review notice email. |
| 19:54.28 | seanbright | also: what do the coding guidelines say about indenting line continuations? |
| 19:54.40 | seanbright | 1 additional tab or 2? |
| 19:55.26 | rmudgett | I prefer only adding one indention level. Also with the binary operator at the beginning so it isn't lost at the end of the line. But that's me. |
| 19:55.43 | rmudgett | file seems to do the other way with binary operators |
| 19:55.53 | seanbright | binary operators go in front |
| 19:55.55 | seanbright | everyone knows that |
| 19:56.02 | file | I'm awful. |
| 19:56.03 | gtjoseph | YES!! |
| 19:56.11 | seanbright | YOU'RE AWFUL |
| 19:56.15 | *** join/#asterisk-dev tuxian (~tuxian@igilmour.plus.com) |
| 19:56.50 | rmudgett | Does that patch not apply to 13? |
| 19:57.08 | seanbright | does 13 have media cache? |
| 19:57.11 | seanbright | looks |
| 19:57.22 | gtjoseph | file: when reading from the queue, the stream and default stream don't get set for multichannel streams |
| 19:57.39 | seanbright | rmudgett: no media_cache in 13 |
| 19:57.45 | gtjoseph | i guess i will be fixing things in the test review |
| 19:57.54 | file | go go tests |
| 19:58.12 | rmudgett | Speaking of tests. I'm getting nowhere with that restart test. |
| 19:58.44 | rmudgett | I cannot find who is responsible for shutting down the AMI factory. Looks to be in twisted. |
| 21:02.40 | kharwell | gtjoseph: looks like https://gerrit.asterisk.org/#/c/5108/ failed on a "symbol lookup error: /lib/libasteriskssl.so.1: undefined symbol: ast_register_file_version" |
| 21:02.52 | gtjoseph | looks |
| 21:03.13 | kharwell | when trying to start asterisk |
| 21:04.10 | gtjoseph | it's because the fix hasn't been merged yet |
| 21:04.52 | kharwell | aah |
| 21:05.07 | gtjoseph | but it was tested on those machines |
| 21:05.15 | gtjoseph | so it's half and half right now |
| 21:05.42 | gtjoseph | after the fixes merge, existing reviews will need tobe rebased |
| 21:07.11 | kharwell | too late I already +1 them so no rebase allowed :-P |
| 21:29.53 | *** join/#asterisk-dev putnopvut (putnopvut@asterisk/master-of-queues/mmichelson) |
| 21:29.53 | *** mode/#asterisk-dev [+o putnopvut] by ChanServ |
| 21:30.07 | seanbright | a wild putnopvut appears |
| 21:30.29 | seanbright | your ears must have been burning... file was just talking mad smack about you, dawg. |
| 21:30.39 | file | brb :P |
| 21:30.55 | putnopvut | par for the course |
| 21:34.31 | file | and back |
| 21:35.00 | cresl1n | packets restored? |
| 21:36.21 | file | yes |
| 21:36.23 | file | and firewall restored |
| 21:36.28 | cresl1n | sighs |
| 21:36.41 | file | I managed to get the Vyatta firewall into such a state that it forgot to put rulesets into the INPUT chain |
| 21:36.45 | cresl1n | I'm glad you *think* that your firewall is restored. |
| 21:37.00 | cresl1n | goes to install backdoors |
| 21:38.24 | seanbright | i tell ya |
| 21:38.35 | seanbright | it's a good thing a large part of my infrastructure isn't in aws... |
| 21:38.49 | cresl1n | :) |
| 21:38.57 | seanbright | i have about 60 tickets sitting here and i don't know what to tell people |
| 21:39.03 | cresl1n | I think everybody says that whenever there's an AWS outage |
| 21:42.42 | file | seanbright: "Go out, take a walk, breath some fresh air." |
| 21:44.05 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-82-81-175-197.red.bezeqint.net) |
| 21:44.05 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:19.36 | gtjoseph | file: assert(tech->read_stream && tech->write_stream) |
| 23:19.57 | file | your statement has no context |
| 23:20.10 | gtjoseph | should it always be true? |
| 23:20.49 | file | if a channel supports streams, both have to be implemented |
| 23:20.54 | gtjoseph | kk |
| 23:20.55 | file | if a channel does not, then they don't |
| 23:21.38 | gtjoseph | we don't check anywhere |
| 23:32.21 | file | gtjoseph: have you fixed the crashes in https://jenkins.asterisk.org/jenkins/job/gate-asterisk-ari/3767/ by chance as a result of this? |
| 23:32.43 | gtjoseph | looks |
| 23:33.23 | gtjoseph | doesn't look related to channels |
| 23:33.32 | gtjoseph | or do you mean something else for "this" |
| 23:33.35 | file | f is NULL |
| 23:33.48 | file | in __ast_read |
| 23:33.53 | file | which was discussed earlier |
| 23:34.03 | gtjoseph | oh that. yes |
| 23:34.09 | file | kk |
| 23:34.15 | file | thought so |
| 23:49.11 | gtjoseph | file: is there any value in testing read_stream returning multiple frames? At that point in the code, a frame is a frame. |
| 23:49.40 | file | read_stream mirrors that of read, where you can return a chain of frames |
| 23:50.03 | gtjoseph | yes but the code path after the frame is read is the same |
| 23:50.25 | gtjoseph | i.e it doesn't matter whether the frame was read with read or read_Sstream |
| 23:50.31 | file | yes |
| 23:50.39 | file | so I don't understand your question? |
| 23:51.00 | leifmadsen | oh neat, I just crashed Asterisk via ARI |
| 23:51.08 | gtjoseph | is it worth testing read_stream returning multiple frames |
| 23:51.16 | file | ah |
| 23:51.19 | file | hrm |
| 23:51.21 | file | not really? |
| 23:51.24 | gtjoseph | good |
| 23:51.26 | file | leifmadsen: cool |
| 23:52.18 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 23:52.18 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 23:53.32 | file | leifmadsen: plz2fileissuewithdeetzbye |
| 23:56.08 | leifmadsen | indeed |
| 23:56.13 | leifmadsen | let me make sure I have a core file |
| 23:57.06 | leifmadsen | oh I bet I don't have DONT_OPTIMIZE enabled... |
| 23:57.11 | leifmadsen | so likely useless |
| 23:57.14 | leifmadsen | let me see if I can reproduce |
| 23:57.45 | leifmadsen | yep |
| 23:57.58 | leifmadsen | asterisk: ../src/pj/os_core_unix.c:674: pj_thread_this: Assertion `!"Calling pjlib from unknown/external thread. You must " "register external threads with pj_thread_register() " "before calling any pjlib functions."' failed. |
| 23:58.00 | leifmadsen | Aborted (core dumped) |
| 23:58.13 | leifmadsen | let me recompile asterisk with DONT_OPTIMIZE and see if I can get something better |