| 00:19.17 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 00:19.17 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 01:38.25 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:49ca:3059:333e:604c) |
| 01:38.25 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 06:43.48 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:44.42 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 06:46.11 | oej | Hello folks! |
| 06:49.56 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.34) |
| 06:53.14 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:03.53 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a06:a402:100:0:762f:68ff:fedf:4a19) |
| 07:07.46 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:07.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:33.14 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:20.53 | tsearle | gerrit 5913 (increment of media_count) had the fastest response time I've ever seen! :-P |
| 13:14.43 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-tlgouftjlygmfpog) |
| 13:14.44 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:25.22 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:25.22 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:26.28 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 13:36.51 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 14:02.44 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-dtyuiqhprdqqlbva) |
| 14:02.44 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:23.32 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-hwkqbizjyuihahiv) |
| 14:23.32 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:00.09 | kharwell | thinking of going ahead and pushing in https://gerrit.asterisk.org/#/c/5876/ anyone want to take a last look before doing that? |
| 16:00.23 | kharwell | cresl1n rmudgett ^^^ |
| 16:00.33 | cresl1n | I'm good with it |
| 16:02.35 | file | I like stuff |
| 16:03.01 | cresl1n | I just +1'd it again |
| 16:03.25 | kharwell | cresl1n: thanks! |
| 16:06.15 | file | will tests pass? I hope so! |
| 16:08.49 | rmudgett | kharwell: +1'ed it after a look at the recent changes |
| 16:20.02 | *** join/#asterisk-dev bford_ (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 16:32.51 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-aymbzvnvdstzpuxk) |
| 16:32.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:36.09 | *** join/#asterisk-dev elguero (~miguel323@74.95.21.41) |
| 17:00.34 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.174) |
| 17:02.43 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00b50b59ee85da133d.ipv6.abo.wanadoo.fr) |
| 18:05.45 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 18:05.46 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:53.52 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.174) |
| 19:13.55 | kharwell | file: raising an event when dtls is finished. thinking stasis event? |
| 19:14.07 | file | kharwell: pfft nah |
| 19:14.15 | file | you can just return a frame up |
| 19:17.18 | kharwell | so like what return a non zero value from recvfrom and then have rtp_read return a control frame? |
| 19:17.42 | file | yes |
| 19:58.39 | *** join/#asterisk-dev slaz_phonism (~slaz_phon@97-96-229-77.res.bhn.net) |
| 20:23.17 | cresl1n | kharwell: file: rmudgett |
| 20:23.41 | cresl1n | If we're thinking of adding a webrtc option for enabling all the webrtc related attributes in pjsip.conf |
| 20:23.53 | cresl1n | like webrtc=yes |
| 20:24.09 | cresl1n | shouldn't that also imply rtcp_mux=yes? |
| 20:24.17 | file | yes |
| 20:24.23 | file | and others |
| 20:24.25 | cresl1n | I'm guessing the only place rtcp_mux is used is in that context |
| 20:24.39 | cresl1n | maybe we should deprecate the option in favor of webrtc=yes |
| 20:24.47 | cresl1n | well |
| 20:24.52 | cresl1n | maybe deprecate is too soon |
| 20:24.55 | file | having it exist doesn't harm the world |
| 20:24.59 | cresl1n | yeah |
| 20:25.13 | cresl1n | that's the thought that immediately came to me after typing that |
| 20:25.22 | file | and tests are written strictly for RTCP-MUX testing, if we hide it behind webrtc=yes then we also have to bring ICE/DTLS into the mix for those too |
| 20:25.46 | cresl1n | I love the idea of an umbrella option that takes care of all those things |
| 20:25.50 | cresl1n | just for webrtc operation |
| 20:25.54 | file | yes |
| 20:26.05 | cresl1n | it would simplify configs for that case |
| 20:26.08 | kharwell | okay ya I'll keep it around. If you know of any others let me know as I'll be doing that work |
| 20:26.37 | file | cresl1n: the only thing that requires manual stuffage is DTLS certs for 'dat |
| 20:27.00 | cresl1n | it'd be neat if we could automatically generate those too, if needed |
| 20:27.04 | cresl1n | but yeah |
| 20:27.11 | file | future, future |
| 20:27.12 | cresl1n | dream the dream, and all that |
| 20:27.12 | rmudgett | Documentation for the new option should say it is a macro option that sets the other options. |
| 20:27.36 | cresl1n | that seems like a good idea |
| 20:27.49 | cresl1n | including some things that aren't going to be options |
| 20:30.06 | rmudgett | Though this webrtc=yes option could be a horrible thing to maintain. Reminds me of users.conf... |
| 20:32.07 | file | in what way? |
| 20:35.55 | rmudgett | What if we have webrtc=yes and rtcp_mux=no? Which takes precedence? Do we get webrtc but without rtcp_mux? Or if when we apply the webrtc=yes option it overrides rtcp_mux and forces it to yes. |
| 20:36.21 | file | webrtc enables all functionality required to achieve WebRTC |
| 20:36.55 | rmudgett | But it is also supposed to set rtcp_mux=yes implicitly. |
| 20:37.01 | file | yes, it would |
| 20:37.08 | file | if you do rtcp_mux=no then you aren't doing WebRTC according to spec |
| 20:37.38 | rmudgett | Someone is going to try that combination. |
| 20:37.49 | file | then too bad? |
| 20:37.58 | rmudgett | How should we handle the situation? |
| 20:38.05 | file | it would be enabled. |
| 20:39.13 | cresl1n | that'd be my preference too |
| 20:39.18 | cresl1n | webrtc=yes overrides |
| 20:39.42 | cresl1n | or maybe natural parse order wins? |
| 20:39.53 | file | ugh |
| 20:39.56 | file | :P |
| 20:39.59 | cresl1n | yeah |
| 20:40.02 | seanbright | i was thinking the same thing... ugh |
| 20:40.07 | cresl1n | I don't want to add code ride now with parse order preference |
| 20:40.27 | cresl1n | I'd rather say "shame on you, don't put rtcp_mux=x settings in when you webrtc=yes" |
| 20:40.45 | seanbright | can you post process the config and issue an error? |
| 20:40.46 | file | I think it is reasonable that the option force on the required options for WebRTC as part of its existence |
| 20:41.03 | file | seanbright: hum |
| 20:41.13 | cresl1n | <ââ Matt the lazy developer talking, not Matt the project lead |
| 20:41.20 | file | probably |
| 20:41.34 | cresl1n | also, hi seanbright :-) |
| 20:41.36 | seanbright | hi. |
| 20:41.47 | seanbright | "you specified webrtc = yes, so i'm ignoring your other bullshit" |
| 20:42.01 | cresl1n | that'd be fine too |
| 20:42.25 | cresl1n | make_webrtc_just_work=yes |
| 20:42.31 | file | yes. |
| 20:42.32 | rmudgett | I was thinking when we call the framework's apply callback we'd set the other options if webrtc=yes |
| 20:42.43 | file | we're in impl territory, too soon for that :P |
| 20:42.48 | cresl1n | make_webrtc_just_work_even_if_I_set_stupid_options=yes |
| 20:42.49 | file | bad rmudgett bad |
| 20:42.57 | seanbright | how would the cert be managed? |
| 20:43.06 | cresl1n | still has to be manual right now |
| 20:43.07 | rmudgett | :D rmudgett :D |
| 20:43.12 | file | seanbright: currently it'd still be manual |
| 20:43.21 | cresl1n | it'd be nice to have that automatic at some point |
| 20:43.23 | file | but the option could say "You've enabled WebRTC but haven't provided a certificate, etc" |
| 20:43.28 | seanbright | gotcha |
| 20:43.29 | cresl1n | yeah |
| 20:47.10 | *** join/#asterisk-dev angler- (angler@pdpc/sponsor/digium/angler) |
| 21:16.21 | rmudgett | file: What's up with https://gerrit.asterisk.org/#/c/5914/ It's just hanging around and not merging. |
| 21:16.45 | file | I don't... know |
| 21:16.59 | file | does it manually because life |
| 21:39.02 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 22:13.04 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 22:19.47 | *** join/#asterisk-dev leedm777 (~textual@173-16-52-28.client.mchsi.com) |
| 22:19.47 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 22:44.53 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:7448:7ac7:18da:42a5) |
| 22:44.53 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 22:55.43 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-hwkqbizjyuihahiv) |
| 23:01.20 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 23:01.20 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |