| 00:10.46 | *** join/#asterisk-dev joshelson (~joshelson@73.95.133.15) |
| 00:19.04 | *** join/#asterisk-dev infobot (~infobot@rikers.org) |
| 00:19.04 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 01:00.55 | *** join/#asterisk-dev sh_smith (foobar@cpe-76-174-26-91.socal.res.rr.com) |
| 01:58.24 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 03:22.06 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-86-98.dhcp.nwtn.ct.charter.com) |
| 03:22.06 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 06:38.46 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 06:44.58 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:44.58 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:48.07 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 06:51.36 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:51.36 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:04.01 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:13.54 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 07:31.34 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:31.34 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:02.19 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:17.32 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-240-195.try.wideopenwest.com) |
| 08:17.32 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 09:09.28 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 09:09.28 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 10:16.18 | *** join/#asterisk-dev oej (~oej@h-205-12.A165.corp.bahnhof.se) |
| 10:16.18 | *** mode/#asterisk-dev [+o oej] by ChanServ |
| 11:31.12 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 12:07.04 | *** join/#asterisk-dev post-factum (~post-fact@vulcan.natalenko.name) |
| 12:08.39 | *** part/#asterisk-dev post-factum (~post-fact@vulcan.natalenko.name) |
| 12:55.25 | *** join/#asterisk-dev jgowdy (uid239878@gateway/web/irccloud.com/x-fvamdkeqkhqrgdhq) |
| 13:09.45 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-buqexsmhjujdjqht) |
| 13:09.46 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:13.58 | tsearle | good monday everybody! |
| 13:14.14 | file | moo |
| 13:14.37 | seanbright | i don't think i like your tone of voice |
| 13:15.15 | file | seanbright: meep |
| 13:17.24 | gtjoseph | file: with 6030, what tells the remaining clients that a participant left the sfu bridge? |
| 13:17.50 | file | gtjoseph: nothing outright tells them, the stream just gets removed so they no longer receive video |
| 13:18.14 | file | turns into an m line with zero port and minimal contents |
| 13:18.19 | gtjoseph | so how would they know to remove a player? |
| 13:18.26 | gtjoseph | ah |
| 13:18.35 | file | it gets raised up in le browser |
| 13:18.40 | gtjoseph | ok |
| 13:19.04 | gtjoseph | just didn't want blank players to keep accumulating as folks came and went |
| 13:19.18 | file | yeah in the browser the video element goes away |
| 13:19.25 | file | it remains in the SDP though... because SDP. |
| 13:19.46 | file | with the changes I have up the addition of streams is minimized as best as we can do, though |
| 13:19.58 | gtjoseph | hopefully all clients behave the same way |
| 13:20.01 | gtjoseph | :) |
| 13:20.16 | tsearle | get up, get out, you lazy lout, get into your working clothes, up to your knees, with oil and grease, with a grindstone to your nose! |
| 13:20.18 | file | a client is what you write |
| 13:21.15 | gtjoseph | it's the "you" that's the issue :) |
| 13:21.44 | gtjoseph | tsearle: :) |
| 13:40.17 | tsearle | actually have that song stuck in my head, playing it in a loop atm, heh |
| 13:42.14 | tsearle | https://www.youtube.com/watch?v=Ih7gRsjS_Qo |
| 13:42.29 | tsearle | have to set the speed to 1.5x if you want to keep sane though, heh |
| 13:45.59 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-ukqbdqbdaguqxmrs) |
| 13:45.59 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:56.38 | gtjoseph | file: 6030 again. remove_destination_streams is a little.....confusing. |
| 13:56.49 | gtjoseph | basically it just marks all video streams as removed? |
| 13:57.23 | file | so the way putnopvut wrote it, each stream outgoing streamed is named based on the participant channel whose video it is forwarding |
| 13:57.49 | file | remove_destination_streams finds the stream that matches a name and marks it as removed |
| 13:58.10 | file | every other stream is untouched |
| 13:58.29 | gtjoseph | ok, not enough context in gerrit to see what is_video_dest does. |
| 13:58.52 | file | makes sure it's a video stream and compares the name |
| 13:58.55 | gtjoseph | could have just cloned the topology though then run the test on each |
| 13:59.26 | gtjoseph | but i get it now |
| 14:00.20 | gtjoseph | oops...and valid test failure |
| 14:00.50 | file | neat |
| 14:06.34 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:06.34 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:07.31 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-dubwulrlndjpirds) |
| 14:07.31 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:21.17 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:21.17 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:52.36 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-tftsivuvctyvnojr) |
| 14:52.36 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:37.58 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 16:07.13 | *** join/#asterisk-dev joshelson (~joshelson@64.55.128.243) |
| 16:10.08 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 16:10.08 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 16:21.25 | *** join/#asterisk-dev Marquis42 (~Marquis42@d14-69-240-195.try.wideopenwest.com) |
| 16:21.25 | *** mode/#asterisk-dev [+o Marquis42] by ChanServ |
| 16:53.37 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-86-98.dhcp.nwtn.ct.charter.com) |
| 16:53.37 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 17:34.22 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LFbn-1-5197-25.w90-105.abo.wanadoo.fr) |
| 18:28.53 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 18:28.53 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:04.56 | cresl1n | kharwell, file, et al - do you guys mind if I +2 https://gerrit.asterisk.org/#/c/5988/ |
| 19:05.08 | file | no |
| 19:05.32 | kharwell | sounds good to me |
| 19:05.50 | cresl1n | alright - it's happening.... |
| 19:05.56 | cresl1n | queues the ron paul gif |
| 21:17.18 | *** join/#asterisk-dev elguero (~miguel323@74-95-21-41-Connecticut.hfc.comcastbusiness.net) |
| 21:58.06 | cresl1n | Anybody care if I +2 https://gerrit.asterisk.org/#/c/5994/ |
| 21:58.27 | cresl1n | kharwell: â¦. |
| 21:58.29 | cresl1n | rmudgett: |
| 21:58.31 | cresl1n | others? |
| 22:01.21 | kharwell | I'm fine with that |
| 22:01.22 | gtjoseph | mee too |
| 22:01.22 | file | me three |
| 22:01.22 | file | >_> |
| 22:01.22 | cresl1n | closes his eyes and hits the '+2' button |
| 22:01.22 | cresl1n | runs |
| 22:19.35 | dan_j | Regarding 5750, the test fails due to a memory leak but it's fine for 5749. Is it something I should worry about, or is it because I may have selected different options in menuselect ? |
| 22:20.39 | dan_j | If someone gets a few minutes to re-run the tests on your side so i can see whats still failing? The old test results are no longer available on gerrit. |
| 22:21.04 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 22:21.04 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 22:25.13 | rmudgett | Gerrit has a pass on those reviews. |
| 22:26.28 | rmudgett | If you would like gerrit to retest the patch, just add a "recheck" comment to the review. |
| 22:27.28 | rmudgett | Though that isn't normally done unless the gerrit check failed. |
| 22:38.55 | dan_j | I meant the testsuite test |
| 22:39.33 | dan_j | 5756 |
| 23:18.56 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-dubwulrlndjpirds) |