| 00:20.23 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-gskcbmyqttttpjcn) |
| 01:05.55 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:4513:9a29:a854:36db) |
| 01:54.52 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:828e:d125:c1f7:da2e:c686) |
| 01:54.52 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:04.06 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:1d6e:7c36:8ae5:a6a7) |
| 07:57.30 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:57.31 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:58.35 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 08:00.34 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:00.34 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 08:15.54 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:26.47 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:35.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 12:48.53 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:828e:2101:261c:4958:f97f) |
| 12:48.53 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:30.31 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:50.22 | seanbright | coreyfarrell: when i created that API (https://gerrit.asterisk.org/#/c/5499/), i copied the behavior of ast_channel_alert_write() and erroneously added the comment about write(2). so the docs probably just need updating. |
| 13:50.51 | seanbright | the previous implementation just used a pipe and wrote a char |
| 13:51.07 | seanbright | eventfd requires an int64 (if i remember correctly) |
| 14:07.21 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-xlbkgxqailteohbw) |
| 14:07.21 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:29.30 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.163) |
| 15:12.03 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:12.03 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:12.35 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-isiumxcmtxqgovjh) |
| 15:12.35 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:12.38 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:12.38 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:23.13 | cresl1n | waves |
| 15:58.21 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-mfnwbuedwpcbxwmz) |
| 15:58.21 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:00.43 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:54d8:4125:1cb7:e130) |
| 16:06.54 | coreyfarrell | hopefully someone else can figure out that subscription tree leak, I failed. |
| 16:50.58 | seanbright | well if you can't figure it out, there is no way that i can |
| 16:51.47 | file | harsh |
| 16:51.58 | seanbright | i only speak the truth |
| 17:01.46 | coreyfarrell | unfortunately the ownership of parts of the subscription tree are very unclear. ast_sip_subscription_destroy has to be called on every subscription in the tree but this is not always done, especially for the "root" subscription of the tree. |
| 17:02.01 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-ahiurhvngvtdfmrr) |
| 17:02.01 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:02.32 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:e45d:d118:cd0e:7c69) |
| 17:03.36 | coreyfarrell | ast_sip_subscription_destroy does ao2_cleanup(sub->tree) but does not NULL sub->tree and doesn't actually free sub (it's still listed in the tree). so calling ast_sip_subscription_destroy too many times is crashy. |
| 17:08.32 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 17:08.32 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 17:10.46 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 17:33.57 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:9483:d9f7:50a0:712f) |
| 17:50.31 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d004c2e50dec7b6e89f.ipv6.abo.wanadoo.fr) |
| 17:50.41 | *** join/#asterisk-dev DivideBy0x0 (~DivideBy0@unaffiliated/divideby0x0) |
| 17:50.41 | *** mode/#asterisk-dev [+o DivideBy0x0] by ChanServ |
| 19:21.49 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 19:21.49 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 19:25.29 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 19:48.14 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 19:48.14 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 20:00.13 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-170.barak.net.il) |
| 20:00.13 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:01.30 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-yatqqcxqcreluyua) |
| 20:01.30 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 20:32.19 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:50be:1ed5:1a8d:796c) |
| 21:01.27 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-edolcapifbaixyyl) |
| 21:01.27 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:49.18 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:50be:1ed5:1a8d:796c) |
| 22:20.17 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:50be:1ed5:1a8d:796c) |
| 22:29.42 | *** join/#asterisk-dev skrusty (~skrusty@88.150.145.104) |
| 22:29.42 | *** mode/#asterisk-dev [+o skrusty] by ChanServ |
| 22:54.00 | X-Rob | file: coreyfarrell seanbright - can one of you guys add me to https://issues.asterisk.org/jira/browse/ASTERISK-27155 please? |
| 22:59.10 | file | hold. |
| 23:00.00 | file | it's unrestricted now |
| 23:01.57 | X-Rob | file: thanks |
| 23:02.02 | X-Rob | and yeah, looks like it needs an upgrade. |
| 23:02.39 | X-Rob | I'll link that ticket to fedora, so they upgrade libstrp, and I'll get it done on sng7. Thanks! |
| 23:03.27 | file | the minimum we support really is 1.5.4 |
| 23:03.40 | file | the old stuff can just implode depending on the other endpoint |
| 23:03.57 | X-Rob | https://bugzilla.redhat.com/show_bug.cgi?id=1301202 |
| 23:04.06 | X-Rob | Reported 2017-01-22 |
| 23:04.09 | X-Rob | 2016-01-22 |
| 23:04.13 | X-Rob | so.. 2 years. |
| 23:04.15 | X-Rob | GG, RHEL. |
| 23:08.43 | coreyfarrell | file: if the older versions blow up do you think they should be rejected by ./configure? |
| 23:08.53 | X-Rob | +1 to that idea. |
| 23:08.55 | file | normally they're fine |
| 23:09.02 | file | it depends on the endpoint, it's obscure stuff |
| 23:10.12 | file | enforcing it means that everyone who doesn't have 1.5.4 and has had zero problems suddenly has to do extra work |
| 23:10.38 | X-Rob | Well I've updated that RHEL ticket pointing them to the asterisk and freepbx ticket |
| 23:10.43 | X-Rob | I assume nothing will happen |
| 23:10.45 | coreyfarrell | ./configure --allow-broken-libs :) |
| 23:10.53 | file | coreyfarrell: that's still extra work on them |
| 23:11.06 | file | if it were overwhelmingly causing problems I'd tend to agree |
| 23:11.38 | X-Rob | I like the extra work of --allow-broken rather than them spending hours investigating backtraces and finally getting to someone who goes 'oh yeah, vtech phones crash asterisk with libsrtp 1.4.4' |
| 23:12.15 | file | you don't have to deal with the repercussions of changing such a thing in mid releases :P |
| 23:12.25 | X-Rob | I know, it's great for me! 8) |
| 23:12.53 | X-Rob | Is there anything ELSE you shoudl be warning me about? |
| 23:13.03 | file | if we see more issues about it then I think we can consider it, but until then it would be causing hardship on the vast majority of the user base who don't have such problems |
| 23:13.36 | file | knows nothing |
| 23:13.54 | coreyfarrell | file: how would you feel about ./configure --enable-strict-dep-checks or something opt-in that could enable stricter checks? |
| 23:14.19 | file | opt-in is fine |
| 23:22.22 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:7843:ec5b:513b:daa2) |
| 23:23.40 | rmudgett | Or how about master checking that libsrtp is 1.5.4 or greater? That way it is only on new branches that it requires a safer version. |
| 23:44.35 | coreyfarrell | hmm, EL backporting could be a problem. when Redhat backports the fix to 1.4.5 our configure script would do the wrong thing if it went by version. |