| 00:15.04 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 00:22.44 | coreyfarrell | does anyone here work on the digium binary modules? I'm wondering if I should add '#define AST_ABI_VERSION 16' to include/asterisk.h (and backport) to make it easier for modules to use conditionals to deal with asterisk branches. |
| 00:47.52 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-oktzrizbjhbmpgao) |
| 01:03.53 | gtjoseph | coreyfarrell: right now it's not an issue. we maintain branches parallel to asterisk branches and use submodules to keep the two in sync. |
| 01:08.34 | coreyfarrell | thanks |
| 01:16.40 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 01:20.46 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:20.46 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:08.01 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 02:26.21 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 04:28.38 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 07:28.54 | *** join/#asterisk-dev hehol (~Adium@109.90.164.163) |
| 07:51.56 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:41e5:18de:c50:7374) |
| 08:28.49 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 08:36.14 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 09:28.54 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 09:28.54 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 10:16.51 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:56.40 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:e851:d18:91fc:5c1c) |
| 13:56.40 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 15:06.13 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-ighhdjnaavudgpdu) |
| 15:06.13 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:09.09 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:09.09 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:09.29 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:09.29 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:11.33 | *** join/#asterisk-dev GameGamer43 (sid5533@gateway/web/irccloud.com/x-dfnbabcmcdenhkum) |
| 15:11.44 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 15:40.41 | coreyfarrell | gtjoseph / file: I'd rather mention here than contradict you on gerrit, but for the pbx reload messages I prefer the first patch: no config option, just reduce or remove the verbose messages. |
| 15:41.59 | gtjoseph | so 7896 instead of 7938? |
| 15:42.40 | file | I'm still torn, it's one of those things where I can see issue reports/community posts about |
| 15:43.39 | coreyfarrell | yes. personally I'm +1 on 7896 (once mentioned in CHANGES), -1 on 7938. |
| 15:44.11 | gtjoseph | hmmm. i'm torn as well. |
| 15:44.39 | gtjoseph | although i hate those messages, making them disappear suddenly could cause confusion. |
| 15:44.45 | kharwell | coreyfarrell: +1 I think removing them is fine. A mention in the CHANGES should be sufficient and if people want those messages they can fall back to the debug (for me they seem more like debug messages anyway) |
| 15:44.53 | gtjoseph | i'll think further though |
| 15:45.09 | file | I wish people read CHANGES |
| 15:45.11 | file | :D |
| 15:45.14 | cresl1n | Ha! |
| 15:45.42 | file | if the majority decide to change it so be it, but any resulting confusion is dealt with by you :D |
| 15:46.08 | coreyfarrell | knows how to mark a JIRA ticket as not a bug :) |
| 15:46.12 | cresl1n | First rule of reading CHANGES: Don't read CHANGES until after it's broken. |
| 15:51.57 | coreyfarrell | what if the reload ended with: ast_verb(3, "Successfully loaded %d extensions in %d contexts (enable debug for details).\n", ext_count, ctx_count)? |
| 15:53.07 | coreyfarrell | a single line at the original verbose level to 1) tell how many of the most important things were loaded and 2) tell people to enable debug if they want the messages they didn't see. |
| 15:53.47 | gtjoseph | that's be ok |
| 15:55.12 | file | I'm fine with that |
| 16:06.43 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:41e5:18de:c50:7374) |
| 16:13.30 | coreyfarrell | file / gtjoseph: instead of or in addition to the CHANGES entry? |
| 16:13.43 | file | I'd do both |
| 16:13.43 | gtjoseph | in addition |
| 16:40.27 | *** join/#asterisk-dev mvanbaak (~mvanbaak@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 16:40.27 | *** mode/#asterisk-dev [+o mvanbaak] by ChanServ |
| 16:55.53 | coreyfarrell | looks like we don't have an ast_context_extensions_count(), the only way to get the count would be to iterate the linked list. just saying how many contexts we loaded good enough? |
| 16:56.48 | gtjoseph | i think that's ok |
| 17:02.32 | coreyfarrell | file / gtjoseph: after adding the message telling people to enable debug should we follow kharwell's suggestion to remove the existing verbose messages instead of changing the level (including for 13/15)? |
| 17:03.03 | gtjoseph | what was the level change from/to, i forgot |
| 17:03.15 | *** join/#asterisk-dev Worldexe_ (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 17:05.43 | gtjoseph | oh, 2 to 4. no i'd just remove them |
| 17:05.48 | coreyfarrell | ugh looks like only some of the messages are printed to debug. pbx.c messages are being changed from 3 to 6. https://gerrit.asterisk.org/#/c/7896/1/main/pbx.c |
| 17:06.18 | gtjoseph | i was looking in config.c |
| 17:06.33 | gtjoseph | yeah no need to keep verbosing them |
| 17:32.52 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 17:40.57 | stefan27 | sounds great, dialplan reload always prints like 5000 lines with our default verbose level |
| 17:44.07 | coreyfarrell | got busy with something else for a bit.. just posted my comments. |
| 17:54.45 | stefan27 | and now that I read this conversation I'm not gonna panic after we upgraded again and "core reload" seemingly doesnt work because there's no wall of text. It always pays off to eavesdrop on asterisk-dev :) |
| 18:13.52 | coreyfarrell | gtjoseph: about ast_vector_string_split, currently if it has an allocation failure it does not clear the list (items already added are left in the vector). should that be changed? |
| 18:17.19 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.172) |
| 18:37.32 | *** join/#asterisk-dev fblackburn (~fblackbur@modemcable094.94-70-69.static.videotron.ca) |
| 18:41.56 | *** join/#asterisk-dev bford (442392a1@gateway/web/freenode/ip.68.35.146.161) |
| 18:41.56 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 18:45.24 | gtjoseph | coreyfarrell: i don't think it's worth it to check. if you have an alloc failure you're already screwed. |
| 18:49.28 | coreyfarrell | gtjoseph: also I'm adding the comment about \arg input not being modified, but it is declared const so I'm not sure it's needed to say that we don't modify a const? |
| 18:50.04 | gtjoseph | yeah i missed the const. i'm ok without the comment then |
| 19:36.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00c907be2c459998e9.ipv6.abo.wanadoo.fr) |
| 20:36.22 | coreyfarrell | anyone have an idea what would cause testsuite tests/rest_api/recording/stored/file to fail? I'm getting the failure locally with or without REF_DEBUG on all 3 in tests/rest_api/recording/stored. |
| 20:37.31 | coreyfarrell | for all 3 tests asterisk is responding with 404 error to http://127.0.0.1:8088/ari/recordings/stored/superfly |
| 20:52.33 | coreyfarrell | just found it. res_ari_recording doesn't work if recordings are stored in a symlinked folder, thus the test fails under ./run-local. is this a security feature or a bug in asterisk? |
| 21:44.40 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-ighhdjnaavudgpdu) |
| 22:08.44 | *** join/#asterisk-dev kharwell (~kharwell@user-24-214-15-130.knology.net) |
| 22:08.44 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 22:33.35 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 22:33.35 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:42.33 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LFbn-1-11898-226.w90-93.abo.wanadoo.fr) |
| 23:40.41 | *** part/#asterisk-dev kharwell (~kharwell@user-24-214-15-130.knology.net) |