| 00:19.22 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:19.22 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:46.40 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:f199:bad2:f676:a181) |
| 02:46.40 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:58.13 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:d004:ea85:6670:a48) |
| 03:58.13 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 07:25.04 | *** join/#asterisk-dev jkroon (~jkroon@vc-nat-gp-s-41-13-4-69.umts.vodacom.co.za) |
| 07:33.03 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:33.03 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 08:00.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:ccf6:acab:488e:ee0b) |
| 08:07.30 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:11.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:56ee:75ff:fed4:f268) |
| 08:18.40 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 08:18.40 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:13.22 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:56ee:75ff:fed4:f268) |
| 10:04.56 | tzafrir | I've been testing a potential issue with the manager command VoicemailUsersList . I noticed that it needs the manager reporting permissions, |
| 10:05.08 | tzafrir | both read and write. Is that a bug? |
| 10:16.33 | coreyfarrell | tzafrir: based purely on descriptions in include/asterisk/manager.h it seems like EVENT_FLAG_USER would be more appropriate than EVENT_FLAG_REPORTING. |
| 10:17.50 | coreyfarrell | I think it should require 'write' access only. it's a bit of a misnomer, 'write' permission should be called 'execute' permission, 'read' permission is for AMI events. |
| 10:18.39 | tzafrir | What do you mean by "execute"? I thought that "read" is for those that would not change the state. |
| 10:19.46 | coreyfarrell | when the AMI client sends "Action: VoicemailUsersList\n" it is asking Asterisk to execute that action. that requires "write" access, AMI doesn't know if the action is readonly or not. |
| 10:20.37 | coreyfarrell | "read" permission is for AMI events.. for example if you don't have EVENT_FLAG_DIALPLAN then you will not receive "VarSet" events. |
| 10:36.06 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:56ee:75ff:fed4:f268) |
| 10:36.59 | *** join/#asterisk-dev pchero (~pchero@x1-6-d8-d7-75-5e-99-79.cpe.webspeed.dk) |
| 10:47.51 | *** join/#asterisk-dev jkroon (~jkroon@vc-nat-gp-s-41-13-2-41.umts.vodacom.co.za) |
| 10:52.26 | coreyfarrell | file: you should remove the +2 from one set of install_prereq patches or the other. they conflict with each-other so you don't want SUSE merging to some branches / arch to other branches. |
| 10:52.48 | file | I want to see what happens :P |
| 10:53.12 | coreyfarrell | I tried cherry-picking one on top of the other locally, it failed. |
| 10:56.14 | file | sorts it |
| 11:23.44 | *** join/#asterisk-dev kados__ (~dakudos@c-73-203-6-107.hsd1.co.comcast.net) |
| 11:46.02 | coreyfarrell | my malloc-no-inline patch adds utils/astmm.c to .gitignore in master (it's copied from main/). should I add that file for 13/15 as well? |
| 11:47.02 | coreyfarrell | by that I mean add it to .gitignore |
| 12:30.06 | gtjoseph | coreyfarrell: i'd say yes |
| 12:55.51 | coreyfarrell | got an actual failure on unit tests from https://jenkins2.asterisk.org/job/check-ast-master-64/1754/ |
| 12:56.41 | gtjoseph | that's odd |
| 12:56.41 | coreyfarrell | recheck had no issue. is this worth investigating further or do we ignore this as "it happens"? |
| 12:57.47 | coreyfarrell | that run was initiated by a change to CLI completion for AO2_DEBUG so definitely not caused by my change. |
| 12:57.49 | gtjoseph | i'll take a look. i've never seen that test fail before |
| 12:58.00 | gtjoseph | yeah agreed |
| 14:05.34 | coreyfarrell | anyone have thoughts about https://issues.asterisk.org/jira/browse/ASTERISK-27742 (adding stereo recording to res_monitor)? I don't want to discourage contribution of a nifty feature, but I do want to see res_monitor eventually go away which would be harder if it supports something app_mixmonitor cannot do. |
| 14:12.44 | file | you could inquire as to why they did Monitor and didn't go for MixMonitor |
| 14:13.07 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-fgokzsqqnfhvtqjb) |
| 14:13.07 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:33.11 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-kohiznqzaotvmquk) |
| 14:33.11 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:38.36 | coreyfarrell | kharwell: just saw `git fetch --prune`.. thanks! want to do the same to 11.x as well? |
| 14:45.15 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-50-171-205.dialup.adsl.anteldata.net.uy) |
| 14:46.32 | kharwell | gonna leave them for now. I'm fine doing that, but others wanted to not touch anything prior to 13. Unless people have since changed their minds or care? |
| 14:47.16 | file | I didn't want to sink yet more time into stuff personally |
| 14:47.27 | file | for branches we no longer care about |
| 14:47.59 | *** join/#asterisk-dev LkBurn (~quassel@pool-108-34-210-109.prvdri.fios.verizon.net) |
| 14:50.01 | coreyfarrell | my reason for wanting the minor branches gone is so the gerrit UI stops trying to get me to cherry-pick to 13.15 all the time. not an issue right now, in a couple years gerrit will try getting me to cherry-pick to 11.18. |
| 14:50.08 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-kbinxxdjqxsysoli) |
| 14:50.08 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:03.19 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 15:03.19 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 15:21.26 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 15:21.26 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 15:35.26 | kharwell | coreyfarrell: 11 branches now deleted as well |
| 15:50.34 | coreyfarrell | :) |
| 16:00.00 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 16:41.53 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-133-136.dialup.adsl.anteldata.net.uy) |
| 17:18.33 | coreyfarrell | rmudgett: sorry I thought I had removed that! |
| 17:52.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d009cbf5b5b0fda4e2f.ipv6.abo.wanadoo.fr) |
| 18:56.15 | seanbright | so i'm looking for the rationale for a change that was made 7 years ago |
| 18:56.18 | seanbright | https://github.com/asterisk/asterisk/commit/6e36042f64f54785afa4815f262c1e0e08ce596f |
| 18:56.40 | seanbright | or phrased another way: why would one want to use this over just a Monitor()? |
| 18:59.20 | file | I don't understand the question |
| 19:01.20 | seanbright | doesn't Monitor() split into two files already? |
| 19:01.27 | seanbright | doesn't mixmonitor exist because of that very fact? |
| 19:02.22 | file | yes, kinda yes? |
| 19:02.53 | seanbright | ok... so i guess i don't see the point in the change and want someone to tell me what that missing point would be |
| 19:02.58 | seanbright | a gut check, as it were |
| 19:03.21 | file | people sometimes like their media differently, and Monitor and MixMonitor operate differently in how they internally work |
| 19:03.30 | file | Monitor writes in the media path, which has implications |
| 19:03.39 | file | MixMonitor tries to minimally do that |
| 19:05.14 | file | I don't have any info from internal as to why explicitly the change was done |
| 19:07.26 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 19:07.26 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:07.55 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LFbn-1-5297-89.w90-105.abo.wanadoo.fr) |
| 19:12.31 | scgm11_ | seanbright I was pointed to this issue https://issues.asterisk.org/jira/browse/ASTERISK-23657 |
| 19:12.47 | scgm11_ | when I open https://issues.asterisk.org/jira/browse/ASTERISK-27742?filter=11341 |
| 19:13.42 | scgm11_ | as Monitor is going to be deprecated maybe those changes make sense |
| 19:17.05 | scgm11_ | maybe using t and r I can mix in stereo mode, Im trying to understand mixmonitor right now to see If its possible |
| 20:58.08 | seanbright | coreyfarrell: one thing that might be helpful for 8521 is an explanation of what that change is buying us (for those of us that haven't been following along at home) |
| 21:02.58 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 21:02.58 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:06.08 | rmudgett | That review is getting Asterisk ready for swimsuit season. It is quite slimming. :) |
| 21:24.25 | *** join/#asterisk-dev Oooohboy (~Oooohboy@2605:6000:1711:c1ff:707f:befe:122b:7907) |
| 21:34.52 | coreyfarrell | rmudgett: do you think this will actually decrease binary size? I had thought of it largely as improving the organization of memory management code by getting everything into one header + source. plus simplifying utils.h by not using the logger from inline functions. |
| 21:35.52 | coreyfarrell | seanbright: I'll try to get some coherent thoughts together & expand the commit msg. |
| 21:36.24 | rmudgett | I expect it to reduce code size. Every inlined function bloats code. We do allocate memory in a lot of places. |
| 22:00.50 | coreyfarrell | rmudgett: when you get a chance 8525 / 8526 are related, the tiny parts of 8521 that can go in 13/15. |
| 23:51.52 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-fgokzsqqnfhvtqjb) |