| 02:15.57 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:61d3:ed5b:9c5d:4bc1) |
| 02:15.57 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:53.16 | *** join/#asterisk-dev tm1000 (sid6728@gateway/web/irccloud.com/x-gdldutrmvdbmuqjl) |
| 05:20.48 | *** join/#asterisk-dev Oooohboy (~Oooohboy@2605:6000:1711:c1ff:40ff:2349:eb42:5235) |
| 06:51.55 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:51.55 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:17.56 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 07:49.23 | *** join/#asterisk-dev CELYA_ (~Thunderbi@46.218.88.74) |
| 08:57.02 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 08:57.02 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 09:00.59 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 09:00.59 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 09:01.25 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 12:18.19 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:c87d:2097:3149:68cc) |
| 12:18.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:36.46 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:fdb1:747a:d02a:42b3) |
| 12:36.46 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:48.34 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:75d4:b81:63b8:72b1) |
| 12:48.34 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:52.12 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 12:56.29 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 13:45.07 | tsearle | hey all, it seems I'm having an issue with stuck channels |
| 13:45.33 | tsearle | I see channels in the hangup extension appearing to be stuck in invoking agi |
| 13:45.42 | tsearle | they appear in core show channels concise |
| 13:46.07 | tsearle | but they are reported as unkown when trying to query via "core show channel PJSIP/xxxx" |
| 13:46.23 | tsearle | the issue seems to resemble |
| 13:46.28 | tsearle | https://community.asterisk.org/t/cannot-hangup-channel-with-command/68341 |
| 13:46.36 | tsearle | but I can't see any conclusion ref that |
| 13:46.44 | tsearle | does this ring any bells with anybody? |
| 14:11.37 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-vxccdiuiqwchihsp) |
| 14:11.37 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:15.33 | *** join/#asterisk-dev hehol (~Adium@ip-178-200-61-160.hsi07.unitymediagroup.de) |
| 14:28.33 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-awwkjctqpqndiqcv) |
| 14:28.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:45.04 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-vbiehsebkbidpggv) |
| 14:45.04 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:47.01 | *** join/#asterisk-dev scgm11_ (~scgm11@r190-134-148-118.dialup.adsl.anteldata.net.uy) |
| 14:48.01 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:48.01 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:52.35 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-hgywbfejaaiseqmu) |
| 14:52.35 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:56.53 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-bsbqqbhxvwwwlrvo) |
| 14:56.53 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:06.04 | *** join/#asterisk-dev jkroon (~jkroon@105.8.6.80) |
| 16:00.41 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-shgenhssfusrrpzl) |
| 16:00.42 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:01.51 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 16:01.51 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 16:12.59 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-tjukcnhmvbavmmtv) |
| 16:12.59 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:38.06 | rmudgett | kharwell: Is there a known problem with tests/fax/pjsip/t38_fast_reject on v13? |
| 16:46.11 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 16:51.08 | kharwell | not to my knowledge, but I just ran it locally and it failed for me too |
| 16:52.10 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00380ebfa413f5dd52.ipv6.abo.wanadoo.fr) |
| 17:05.31 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 17:27.18 | coreyfarrell | looks like jenkins never tried running anything for https://gerrit.asterisk.org/8655 (check or gate). am I not supposed to post changes to the 14 branch of the testsuite? |
| 17:31.26 | kharwell | looks like nothing has been run for the 14 gates in a while. Guessing they were disabled since 14 is security only. So I lean toward no except for a couple of things. A test specifically for a security fix and I'm fine with stuff going into it related to the branching stuff |
| 17:32.29 | kharwell | that way there are little or no potential conflicts just in case a test or something has to be cherry picked into it |
| 17:33.10 | kharwell | although if the gates aren't running I'm not sure the point. Maybe if we have a security issue someone was planning on manually running them? dunno |
| 17:46.05 | coreyfarrell | so another patch I have strips Asterisk version detection from the testsuite (across the board). it cleanly cherry-picks to all versions, deletes ~2200 lines. I was planning on putting into 14 just to keep the branches closer? |
| 17:46.45 | coreyfarrell | I'm just reviewing the diff now before I post. |
| 17:50.23 | kharwell | that's fine by me |
| 17:55.00 | rmudgett | I really don't think we should be removing the versioning stuff from the testsuite code itself. |
| 17:56.26 | coreyfarrell | why not? not trying to be difficult just like to understand why we'd want to keep it. |
| 18:00.11 | rmudgett | We seem to be heading in the direction where the testsuite can *only* run on the current branch tips. Running it on an older version (even if only slightly older) would then fail on newer tests. |
| 18:01.05 | rmudgett | The minversion values also help document when something the test checks went into asterisk. |
| 18:01.44 | kharwell | don't tags solve the first problem and logs the second? |
| 18:02.23 | rmudgett | Finding something in the logs is a lot more work. |
| 18:03.25 | coreyfarrell | rmudgett: so I've already removed all the minversion: specifiers from all test-config.yaml files. are you saying you want that reverted? |
| 18:03.32 | rmudgett | Though I suppose the testsuite is only useful for the branch tips anyway. |
| 18:03.39 | kharwell | sure but it shouldn't happen often. What does happen often is people having to update reviews to align the version(s) |
| 18:05.08 | rmudgett | Updating reviews to align versions doesn't happen often either because we get so many testsuite tests to review. :) |
| 18:06.16 | kharwell | heh true that |
| 18:06.52 | file | wonders if this will ever be over |
| 18:07.37 | kharwell | offers file a train full of tacos |
| 18:08.02 | rmudgett | wonders if file could handle that many |
| 18:08.56 | file | declines |
| 18:09.36 | rmudgett | If we consider the testsuite only useful for the branch tips then versioning really isn't necessary. |
| 18:13.04 | rmudgett | file: The OPTIONS patch doesn't generate the ContactStatus events anymore. The generation of those events was integral to how the endpoint status was determined. We have two testsuite tests that fail because we no longer generate them. |
| 18:13.31 | file | it did last I touched it at least |
| 18:13.37 | rmudgett | Its going to take some thought to figure out how to get those events generated again. |
| 18:14.22 | rmudgett | While on the OPTIONS patch... |
| 18:15.32 | rmudgett | I've been thinking of restoring the contact status sorcery objects. It would make merging into master a bit easier because of the recent addition of the contact status list AMI action. |
| 18:16.08 | file | provided it doesn't hurt the design much |
| 18:18.01 | rmudgett | I don't think it would affect the design much. We won't have the observers that generate the endpoint status anymore. We'll just be updating the records for other modules. |
| 18:18.13 | rmudgett | Though sorcery does impose its own CPU burden. |
| 18:20.13 | file | aye |
| 18:33.49 | coreyfarrell | kharwell: I broke the testsuite in 14/15/master, 8700/8701/8702 fixes it. I caused one test to have nothing in the properties: which makes it it a NoneType instead of an object. |
| 18:36.56 | kharwell | oh interesting. Didn't even think about that breaking stuff. I'm surprised that was the only one |
| 18:38.12 | coreyfarrell | I'm double-checking 15 right now. |
| 18:39.34 | coreyfarrell | yeah that was the only test. |
| 18:40.35 | kharwell | makes sense I guess since most, if not all, should have deps at the very least |
| 18:41.19 | coreyfarrell | yeah well that test should have had deps too. I just added twisted / starpy since it uses AMI. I know it requires other stuff but for now just want to unbreak the testsuite. |
| 18:43.39 | kharwell | heh yeah I'm sure there are a slew of tests missing appropriate deps |
| 18:45.09 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |
| 19:10.00 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 19:10.08 | cresl1n | waves to jkroon |
| 19:12.08 | jkroon | evening cresl1n |
| 19:15.15 | cresl1n | It was neat to meet you in person |
| 19:15.42 | jkroon | indeed it was. glad to see you travelled savely back home. |
| 19:18.59 | jkroon | waves good bye ... long weekend beckons |
| 19:19.06 | cresl1n | farewell! |
| 20:02.53 | coreyfarrell | kharwell: I think you mean to 'regate' |
| 20:03.01 | kharwell | dang it yes |
| 20:06.09 | coreyfarrell | kharwell: fwiw the cli completion reviews don't get any coverage from jenkins. those were manually tested before being submitted. |
| 20:07.10 | kharwell | true |
| 20:07.15 | kharwell | no reason to tax jenkins then |
| 20:09.40 | kharwell | when regating do you have to remove the -1 from jenkins for it to retrigger? Or will it overwrite it later? |
| 20:10.30 | coreyfarrell | I've regated stuff in the middle of the night and it merged fine (I don't have access to remove jenkins votes) |
| 20:11.31 | coreyfarrell | not sure if maybe digium folks remove the -1 so others can see in the list that it's already being regated? |
| 20:12.14 | file | it used to be that it wouldn't work quite right if it was still -1 |
| 20:12.18 | file | I don't recall if that was changed |
| 20:12.22 | file | I just mostly do it out of habit too |
| 20:15.37 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 20:15.37 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 20:21.37 | kharwell | almost all those failures will hopefully be fixed with the patches I have up. Except for the two crashes on shutdown |
| 20:21.57 | coreyfarrell | two crashes on shutdown? |
| 20:23.11 | kharwell | quickly glancing at it it appeared asterisk was shutting down at the time |
| 20:23.36 | coreyfarrell | CDR record still being processed during shutdown? |
| 20:24.59 | kharwell | you mean where it crashed? doesn't appear to be involving CDRs |
| 20:25.31 | coreyfarrell | have a link to the backtrace? |
| 20:26.13 | kharwell | Here is one. I'll see if I can find the other again too: https://jenkins2.asterisk.org/job/gate-ast-master-sip/504/artifact/logs/channels/SIP/message_unauth/backtrace_15964.txt |
| 20:27.21 | file | https://jenkins2.asterisk.org/job/gate-ast-15-pjsip/464/artifact/logs/channels/pjsip/publish/asterisk_event_devicestate/backtrace_3678.txt |
| 20:27.49 | kharwell | coreyfarrell: ya that's the other one ^^ |
| 20:29.02 | coreyfarrell | the message_unauthed crash is cel using a function that is being unloaded.. ASTERISK-27410 is open for that issue. |
| 20:30.41 | kharwell | hrm odd https://gerrit.asterisk.org/#/c/8605/ was verified but jenkins didn't submt it. Cause it needs rebasing maybe? |
| 20:30.53 | coreyfarrell | the asterisk_event_devicestate is a new one I haven't seen before. |
| 20:31.31 | coreyfarrell | normally it would rebase on automatically or mark it as "merge conflict" if it can't. |
| 20:33.00 | kharwell | the orange dot over by "Parent(s)" was the only thing that stuck out to me as to why it might not have gone in. hrm odd then |
| 20:33.24 | kharwell | oh well allowed me to do it manually |
| 20:33.57 | kharwell | coreyfarrell: want me to create an issue then for that other crash? |
| 20:34.41 | coreyfarrell | kharwell: might as well otherwise we'll lose the backtrace. |
| 20:35.25 | kharwell | alrighty. Do you know if there is a general "problems on shutdown" issue I should link it to? |
| 20:35.44 | coreyfarrell | probably needs something similar to the fix I put into res_pjsip_session which ignores certain callbacks during shutdown. |
| 20:36.03 | coreyfarrell | I'm not aware of a general shutdown tracker issue |
| 21:33.39 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |
| 21:55.29 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |
| 22:39.53 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |
| 22:44.44 | *** join/#asterisk-dev leedm777 (~textual@50-81-28-132.client.mchsi.com) |
| 22:44.44 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:04.31 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |
| 23:11.17 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-vxccdiuiqwchihsp) |
| 23:26.14 | *** join/#asterisk-dev joshelson (~joshelson@c-73-181-14-245.hsd1.co.comcast.net) |