| 00:05.53 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-mvulqoeqvdkgvnai) |
| 06:49.29 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 09:26.27 | AsteriskRoss | ASTERISK-27792 - PJProject 2.7.2 has a fix commited 5727 but isn't in 2.7.2 even though the commit was before the release of 2.7.2. What is the best way to fix this, for me I've just included the patch '0060-sip_msg-Prevent-crash-on-header-without-vptr' from the previous release. Should we contact the PJSIP team or should I submit a new patch to include the correct file? |
| 09:31.03 | file | 2.7.2 was a security release, not a normal release |
| 09:31.18 | file | It only in included changes to fix security issues |
| 09:32.04 | file | So there is nothing to fix. The next normal release will include the latest batch of upstreamed fixes. |
| 09:37.06 | AsteriskRoss | Ok in that case we still need to include the original patch |
| 09:40.25 | AsteriskRoss | This was original committed under https://gerrit.asterisk.org/#/c/7975/ |
| 09:42.51 | AsteriskRoss | I can't find the commit where it was removed though |
| 09:50.42 | file | it, uh, wasn't |
| 09:50.45 | file | it's still in there. |
| 09:56.23 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 10:10.02 | AsteriskRoss | Ok, I've just pulled 13 from GIT and its there! I'm looking into why I don't have that file! Sorry! |
| 10:49.07 | AsteriskRoss | The upstream patch differs from the current one which has PJ_ASSERT_RETURN(hdr->vptr, -2); as apposed to if (!hdr->vptr) { return 0; } I'm getting a crash when processing the header Content-Length: 239rn would the upstream patch work correctly where the vptr has extra space at the beginning of the string? |
| 11:47.59 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:1754:7500:b1e8:995f:f0e7:3dec) |
| 11:58.48 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:32.45 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:32.45 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:05.47 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-hfaesdllogpjdzph) |
| 14:05.47 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:16.29 | cresl1n | https://gerrit.asterisk.org/#/c/8683/1/channels/chan_pjsip.c |
| 14:17.24 | cresl1n | file: if REMB is scoped to all N video streams within the session, how does properly that fit with the chan_pjsip write_stream function code? |
| 14:17.53 | file | you still send it out each individual stream |
| 14:17.57 | cresl1n | Oooooooh |
| 14:17.59 | cresl1n | cool |
| 14:18.02 | cresl1n | thanks :-) |
| 14:18.35 | file | it's a bit silly, which is why they made transport-cc which is transport level |
| 14:18.43 | cresl1n | gotcha |
| 14:31.09 | *** join/#asterisk-dev elguero (~miguel323@74-95-21-41-Connecticut.hfc.comcastbusiness.net) |
| 14:33.59 | *** join/#asterisk-dev anthm (~anthm@freeswitch/developer/anthm) |
| 14:38.53 | cresl1n | file: does https://gerrit.asterisk.org/#/c/8717/2/apps/confbridge/conf_config_parser.c work with ARI created bridges too? |
| 14:39.19 | file | no, there is no interface provided by ARI to control settings like those |
| 14:39.23 | cresl1n | Gotcha |
| 14:39.28 | cresl1n | so we rely on defaults in that case |
| 14:39.34 | file | yes |
| 14:39.41 | cresl1n | I guess that's fair |
| 14:39.45 | file | none of the video stuff is configurable over ARI |
| 14:40.09 | cresl1n | I guess if it becomes important at some point we can re-address it |
| 14:40.12 | file | wonders |
| 14:40.54 | file | yeah, has to be defined |
| 14:46.36 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-dljioxtmpnftpswo) |
| 14:46.36 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:16.27 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-109-191.dialup.adsl.anteldata.net.uy) |
| 15:43.54 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-zazqcfwtfkykkuai) |
| 15:43.54 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 17:21.34 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-115-246.dialup.adsl.anteldata.net.uy) |
| 17:34.55 | scgm11_ | Hello, wich is the correct way to add a new log channel ? |
| 17:41.42 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-djxqnxyhmqvbqfda) |
| 17:45.35 | seanbright | https://github.com/asterisk/asterisk/blob/f03b984724b31ffe097158cb34bf075341fe2cca/include/asterisk/logger.h#L122 |
| 17:45.57 | seanbright | sorry, shorter link: |
| 17:45.58 | seanbright | https://github.com/asterisk/asterisk/blob/master/include/asterisk/logger.h#L122 |
| 17:49.29 | scgm11_ | thanks!! |
| 18:06.28 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 18:06.28 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 18:13.35 | scgm11_ | mmm I dont think this is what I need, what I want is to create a new sink for the log, insted of writing to console or file or syslog add a new option |
| 18:23.24 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00e50bdbebf018081e.ipv6.abo.wanadoo.fr) |
| 18:38.31 | seanbright | k |
| 18:42.48 | seanbright | as far as i am aware, that is not something that can be registered/unregistered at runtime |
| 18:42.55 | seanbright | you'd have to modify main/logger.c directly |
| 18:53.48 | coreyfarrell | scgm11_: at one point I had looked into enabling the ability to register/unregister logger destination types, it wasn't simple. |
| 20:02.20 | seanbright | and no one wants that |
| 20:02.30 | seanbright | except for scgm11_ and coreyfarrell |
| 20:14.10 | scgm11_ | I miss some messages... what no one wants? |
| 20:20.34 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 20:22.18 | *** join/#asterisk-dev jkroon_ (~jkroon@165.16.204.169) |
| 20:41.56 | *** join/#asterisk-dev Oooohboy (~Oooohboy@2605:6000:1711:c1ff:d1a9:7286:c207:b4c0) |
| 20:43.06 | *** join/#asterisk-dev jkroon__ (~jkroon@165.16.204.170) |
| 22:08.50 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LFbn-1-5297-89.w90-105.abo.wanadoo.fr) |
| 22:44.06 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-hfaesdllogpjdzph) |
| 23:10.05 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:1615:3e00:64a0:7e4a:b4da:d72b) |